)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"99009c384e587666c33a1b30156066a760dd3e1b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a7e91ece_77e3d924","updated":"2023-06-07 13:11:17.000000000","message":"I did not create an Alembic revision for this yet, as apparently support for autogenerating is not yet wired at https://opendev.org/openstack/keystone/src/commit/a7ba534f3d61d04e835fb3c578d9eee43de87d78/keystone/common/sql/migrations/env.py#L32.\n\nAnd while after adding:\n\n\u003e target_metadata \u003d AccessRuleModel.metadata\n\nand the required imports autogenerate worked, it created a huge change dropping everthing.","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"576cb3b8074be544d2087c680b9d7dec486df547","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56eee72c_b71c20dd","updated":"2023-06-27 15:44:27.000000000","message":"Wait, you don\u0027t want to merge this. It\u0027s not complete. See my prior comments.","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"7de67a47fcbff4f1a373c4bc7561da3d956ed34b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df86878d_5cf57637","updated":"2023-07-05 08:28:11.000000000","message":"recheck grenade","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"4ec75daf553982884947e52a4f0cb51fd0d5fba1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32197041_7de3407b","in_reply_to":"000f6f03_6aa382a9","updated":"2023-06-28 04:58:12.000000000","message":"Do you mind updating https://docs.openstack.org/keystone/latest/contributor/database-migrations.html then with the instructions on how to create revisions and all? I bluntly point at another project, check out https://docs.openstack.org/nova/latest/reference/database-migrations.html which has commands and code examples an all ;-)","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"75660d47c742612bb113aa381164ea201703aa91","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b8ed0ee9_4577382e","in_reply_to":"17d179a7_479f5b45","updated":"2023-06-26 12:45:12.000000000","message":"So with above autogen the migration that Stephen linked would be solved automatically but otherwise shouldn\u0027t this patch contain a migration that removes the index?","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"90adecf183c1bfc885f0b36400d7551c93608e82","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"584ad435_113388aa","in_reply_to":"32197041_7de3407b","updated":"2023-06-28 07:42:23.000000000","message":"I now saw https://review.opendev.org/c/openstack/keystone/+/887035 which apparently does just that.","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"4ec75daf553982884947e52a4f0cb51fd0d5fba1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"59b73007_a773a1e9","in_reply_to":"56eee72c_b71c20dd","updated":"2023-06-28 04:58:12.000000000","message":"\u003e Wait, you don\u0027t want to merge this. It\u0027s not complete. See my prior comments.\n\nGood catch. I was just about to write this when I saw the Workflow+1.\nDo you mind just creating the migration and adding it to this change to have this complete and ready to merge?","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"b0b8876f248781725f8f3715816b6cdf55a6bd9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"17d179a7_479f5b45","in_reply_to":"6457197d_fa981bf0","updated":"2023-06-13 15:01:39.000000000","message":"Sure. There seems to be (a little) merge conflict, but I was able to work around that.\n\nCan you then please give me the commands you expect to work?\n\nI did try:\n\n  tox --notest -r -e py38\n  source .tox/py38/bin/activate\n  alembic -c keystone/common/sql/alembic.ini upgrade heads\n  alembic -c keystone/common/sql/alembic.ini revision --autogenerate\n\n\nwhich causes alembic trying to create a huge changeset dropping (almost) everything but failing with:\n\n\nINFO  [alembic.runtime.migration] Context impl SQLiteImpl.\nINFO  [alembic.runtime.migration] Will assume non-transactional DDL.\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027password\u0027\nINFO  [alembic.autogenerate.compare] Detected removed index \u0027ix_request_token_consumer_id\u0027 on \u0027request_token\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027request_token\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027config_register\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027project_tag\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027role\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027mapping\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027policy_association\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027idp_remote_ids\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027id_mapping\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027project_option\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027role_option\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027application_credential_access_rule\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027consumer\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027sensitive_config\u0027\nINFO  [alembic.autogenerate.compare] Detected removed index \u0027ix_revocation_event_audit_id_issued_before\u0027 on \u0027revocation_event\u0027\nINFO  [alembic.autogenerate.compare] Detected removed index \u0027ix_revocation_event_issued_before\u0027 on \u0027revocation_event\u0027\nINFO  [alembic.autogenerate.compare] Detected removed index \u0027ix_revocation_event_project_id_issued_before\u0027 on \u0027revocation_event\u0027\nINFO  [alembic.autogenerate.compare] Detected removed index \u0027ix_revocation_event_user_id_issued_before\u0027 on \u0027revocation_event\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027revocation_event\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027trust\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027user\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027expiring_user_group_membership\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027federation_protocol\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027nonlocal_user\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027service_provider\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027local_user\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027implied_role\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027federated_user\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027endpoint_group\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027identity_provider\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027application_credential\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027trust_role\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027group\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027application_credential_role\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027user_group_membership\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027service\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027project\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027access_rule\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027endpoint\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027registered_limit\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027project_endpoint\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027user_option\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027policy\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027limit\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027project_endpoint_group\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027whitelisted_config\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027credential\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027region\u0027\nINFO  [alembic.autogenerate.compare] Detected removed index \u0027ix_access_token_authorizing_user_id\u0027 on \u0027access_token\u0027\nINFO  [alembic.autogenerate.compare] Detected removed table \u0027access_token\u0027\nERROR [alembic.util.messaging] Can\u0027t locate revision identified by \u0027contract\u0027\n  FAILED: Can\u0027t locate revision identified by \u0027contract\u0027","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc67930c8e5645a01a327201ba5514d38c6a7576","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6457197d_fa981bf0","in_reply_to":"a7e91ece_77e3d924","updated":"2023-06-07 13:51:00.000000000","message":"Can you try with [1] applied first?\n\n[1] https://review.opendev.org/c/openstack/keystone/+/826147","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bb32d4c887f6c6fd4d60658a2eef98a58fed3af2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"000f6f03_6aa382a9","in_reply_to":"b8ed0ee9_4577382e","updated":"2023-06-27 12:35:18.000000000","message":"Sorry, I missed this. I replied on my patch but tl;dr: you need to use\n\n```\npython -m keystone.common.sql.migrations.manage revision --autogenerate\n```\n\ninstead","commit_id":"4c54243a989d68bd624cac2a2cc1c934ed8d0c76"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"d2baa473539c71d6da816ead3bd20a32b504836d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70c03e34_03cd267c","updated":"2024-02-19 14:50:11.000000000","message":"I just wanted to rebase this older change of mine real quick when I noticed something strange. Running the Alembic autogeneration added this:\n\n--- cut ---\n\ndef upgrade():\n    # ### commands auto generated by Alembic - please adjust! ###\n    with op.batch_alter_table(\u0027access_rule\u0027, schema\u003dNone) as batch_op:\n        batch_op.create_unique_constraint(None, [\u0027external_id\u0027])\n\n--- cut ---\n\n\nDiving deeper into the changes that went to the DB schemas as Alembic revisions caused me to spot a likely missed piece of schema definition.\n\n\nPTAL.","commit_id":"2a0d76ee1eda64c01fae750b2df787ae2585d6a9"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"a0c8229005e9d02e17b4b51f9f12fd124b583032","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8807f12a_961d9e13","updated":"2024-03-06 13:38:48.000000000","message":"Could you kindly take a look at this one?\nIt\u0027s a cleanup / fixup that best be merged before more changes come on top :-)","commit_id":"90dcff07c03ee60227b01f47d67fe9e5b1629593"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"7b161bc3281e3d56041964c2323e5dfae0e18a5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"556ded27_dafc213b","updated":"2024-03-27 08:06:40.000000000","message":"Could you please kindly take a look at this?!\n\nIt fixes an inconsistency in the Alembic database schema management and certainly is of value to have fixed before any new changes are introduced.","commit_id":"90dcff07c03ee60227b01f47d67fe9e5b1629593"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"eb2b13d5d7358af65330741a3fd7af62ea7e5900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9d95ae93_f32c85a6","updated":"2024-03-19 20:41:21.000000000","message":"Elod could you kindly take a look at this one.","commit_id":"90dcff07c03ee60227b01f47d67fe9e5b1629593"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"fba3143a89c455b7346b9ad148c57e2a434dbed5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5880f05f_a9bbeb10","updated":"2024-02-23 08:32:46.000000000","message":"I quickly fixed the commit message regarding the references commit containing the Alembic update - sorry David that reset you +2 :-(\n\n\nWill this require some sort of backporting or cleanup? I suppose not, as the issue would only have appeared on the next Alembic autocreate (which I ran for my intended change).","commit_id":"90dcff07c03ee60227b01f47d67fe9e5b1629593"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0dbe1925cf47a8da4a172b05cad9e51d09220816","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"753b0b92_68c98b68","updated":"2024-02-23 08:49:22.000000000","message":"this looks ok to me but I\u0027m not deep enough into keystone db code to actually vote on it","commit_id":"90dcff07c03ee60227b01f47d67fe9e5b1629593"}]}