)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"ff6f3bd6812ceb16bd24755cf124257818619409","unresolved":true,"context_lines":[{"line_number":10,"context_line":"keystone-tempest-plugin RBAC tests job was added."},{"line_number":11,"context_line":"- https://review.opendev.org/c/openstack/keystone/+/760478"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But we need to run both test tox and tempest plugin for RBAC."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change also fixes many test cases which were not updated after"},{"line_number":16,"context_line":"the manager role was added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"4f8da223_a4cd24df","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":61},"updated":"2026-04-23 19:10:35.000000000","message":"Why exactly do we need this?  It does not make sense to me to have essentially two identical test suites.\n\nThe test being run by `tox` in `keystone.tests.protection.v3.*` cover the same use cases as the test run by tempest in `keystone_tempest_plugin.tests.rbac.v3.*`.\n\nIIRC, the reason the tox job was removed is because the tempest tests are comprehensive and supersede the tests being updated here.\n\nIf we were to re-enable the tox job we would be committing to maintaining duplicate test suites for no apparent benefit.  The tempest job is run in both `keystone` and `keystone-tempest-plugin` gates so I see no point in also running this suite in tox.\n\nIMO, testing the default policy is a functional test, not a unit test, and tempest is the right place to execute policy testing.\n\nTo me, the correct path forward is to fix the tempest protection gate job and make it voting because it is currently non-voting.  The tempest job should be the source-of-truth for test validation of policies and we should deprecate and remove the tests in the `keystone` repository.\n\nI am a hard -2 on re-enabling tox unless someone can make a strong case on why we should duplicate test efforts for SRBAC and commit to maintaining the duplicates across two repositories.","commit_id":"7b1ce51f9e9f04b7f5761b012477e0d71c20963f"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"ff6f3bd6812ceb16bd24755cf124257818619409","unresolved":true,"context_lines":[{"line_number":10,"context_line":"keystone-tempest-plugin RBAC tests job was added."},{"line_number":11,"context_line":"- https://review.opendev.org/c/openstack/keystone/+/760478"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But we need to run both test tox and tempest plugin for RBAC."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change also fixes many test cases which were not updated after"},{"line_number":16,"context_line":"the manager role was added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ac21f366_0cd47977","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"updated":"2026-04-23 19:10:35.000000000","message":"Why exactly do we need two sets of what seems like identical tests?","commit_id":"7b1ce51f9e9f04b7f5761b012477e0d71c20963f"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"5fa3bd95c1c8eaf7600453cf6d108a81d9c7d721","unresolved":true,"context_lines":[{"line_number":10,"context_line":"keystone-tempest-plugin RBAC tests job was added."},{"line_number":11,"context_line":"- https://review.opendev.org/c/openstack/keystone/+/760478"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But we need to run both test tox and tempest plugin for RBAC."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change also fixes many test cases which were not updated after"},{"line_number":16,"context_line":"the manager role was added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"8bb3fb3f_c7cee788","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":61},"in_reply_to":"4f8da223_a4cd24df","updated":"2026-04-24 06:05:03.000000000","message":"This is the job we should fix instead of adding a tox job: https://review.opendev.org/c/openstack/keystone-tempest-plugin/+/986031","commit_id":"7b1ce51f9e9f04b7f5761b012477e0d71c20963f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"63fced1c2b4cbac9265d7e622491772630b4d730","unresolved":true,"context_lines":[{"line_number":10,"context_line":"keystone-tempest-plugin RBAC tests job was added."},{"line_number":11,"context_line":"- https://review.opendev.org/c/openstack/keystone/+/760478"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But we need to run both test tox and tempest plugin for RBAC."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change also fixes many test cases which were not updated after"},{"line_number":16,"context_line":"the manager role was added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"d2a16486_f6fd1ad4","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":61},"in_reply_to":"8bb3fb3f_c7cee788","updated":"2026-04-24 17:25:50.000000000","message":"Its been a very long time and i almost lost the context on this. \n\nI have not compared the exact test coverage between keystone_tempest_plugin/tests/rbac/v3 and keystone/tests/protection/v3, but if you are saying those are duplicates, then I agree with you. In that case, /keystone/tests/protection/v3 tests are dead code as we are not running them anywhere, so we should remove them in favour of keystone_tempest_plugin/tests/rbac/v3.\n\nanyways leaving the decision of removing the non-running/duplicate tests to you guys. I am good to abandon it after the response.","commit_id":"7b1ce51f9e9f04b7f5761b012477e0d71c20963f"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"5fa3bd95c1c8eaf7600453cf6d108a81d9c7d721","unresolved":false,"context_lines":[{"line_number":10,"context_line":"keystone-tempest-plugin RBAC tests job was added."},{"line_number":11,"context_line":"- https://review.opendev.org/c/openstack/keystone/+/760478"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But we need to run both test tox and tempest plugin for RBAC."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change also fixes many test cases which were not updated after"},{"line_number":16,"context_line":"the manager role was added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"91f9b72d_2085e5f6","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"in_reply_to":"ac21f366_0cd47977","updated":"2026-04-24 06:05:03.000000000","message":"I\u0027m not sure why this draft of my comment posted along with my full comment. ¯\\_(ツ)_/¯","commit_id":"7b1ce51f9e9f04b7f5761b012477e0d71c20963f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"26782e717cb128da3fd09f7a8409faa4b1f55474","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32266fa3_4b71d305","updated":"2023-06-20 01:14:17.000000000","message":"all protection test run successfully https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9bf/886434/1/check/keystone-tox-protection/9bf520f/testr_results.html","commit_id":"d8f2961d128f2c5523111e9d304a74bca7a6e602"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0ae8c652d8ce6e77e41b09e337681ac0b07c2f87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d57cef9d_60d08558","updated":"2023-12-02 16:08:29.000000000","message":"recheck CI has been fixed.","commit_id":"d8f2961d128f2c5523111e9d304a74bca7a6e602"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4fc15d6990b57d255778b7f4b62a3fac129d7b9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f97606de_14145e6a","updated":"2023-12-14 20:44:34.000000000","message":"recheck trying again to see what exact failure it has","commit_id":"d8f2961d128f2c5523111e9d304a74bca7a6e602"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a47536d6e7afa23df97e494f770f3eed881f381","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"20b8cd66_20a5c4ce","in_reply_to":"f97606de_14145e6a","updated":"2023-12-15 04:04:58.000000000","message":"It seems https://review.opendev.org/c/openstack/keystone/+/822601 did not update the appropriate test cases.","commit_id":"d8f2961d128f2c5523111e9d304a74bca7a6e602"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"b4b9798d1f710317ac8c3804656a6fb1967e5984","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b239e63_28ce0d2f","updated":"2024-02-19 12:42:26.000000000","message":"recheck","commit_id":"90a4336aad8cea9caaff45693209fd084483d5f4"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"66217df156ec5135cea0ba38912fb9fadd14fb41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"36d62d2e_0604b8ee","updated":"2026-02-19 13:59:55.000000000","message":"recheck","commit_id":"39fe6f5e291fca9d0ac214aa51ad4f241d9e490f"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"f9473fa0d4eaea2888b9bc76663f9cd33e1ee76c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c05433da_2a542718","updated":"2026-02-20 14:39:38.000000000","message":"recheck","commit_id":"39fe6f5e291fca9d0ac214aa51ad4f241d9e490f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"866abb0cc2e962b1c6e0a238801af3038f63543a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4f6de919_95bbf28f","updated":"2026-04-27 10:37:19.000000000","message":"My \"idea\" was that having local tests it is possible to comparably easy run the tests locally without relying on the CI. We have a bunch of changes pending that try to verify we are actually closing vulnerabilities with the unittests. I strongly disagree it is a right approach and wanted that we move them to protection tests so that we can do this easily. When you move things like that to the remote project you increase the brain context (AI may be ok with it, human barely). There is a big chance we start forgetting where the things should be tested.\nWhat do you think, @dmendiza@redhat.com","commit_id":"7b1ce51f9e9f04b7f5761b012477e0d71c20963f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"0598d30816293315b6f49ca8c7db92cf6df2fc02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"31afa62e_4bc7ecfb","updated":"2026-04-22 17:13:32.000000000","message":"uff, a long one ;-)","commit_id":"7b1ce51f9e9f04b7f5761b012477e0d71c20963f"}]}