)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"2723d163bca618ee7ab47a745023c24701d0d310","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Closes-Bug: #2028809"},{"line_number":25,"context_line":"Related-Bug: #1901891"},{"line_number":26,"context_line":"Change-Id: Iea95a3c2df041a0046647b3d3dadead1a6d054d1"},{"line_number":27,"context_line":"(cherry picked from commit 6730c761d18aa547998f2add833c13f45f257fe7)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"afb4257f_71411168","line":27,"updated":"2023-08-15 15:14:10.000000000","message":"nit: missing \u0027cherry picked from...\u0027 line. should be cherry picked from stable/2023.1","commit_id":"65f1fb6b4a54386f473369b05c8d10d77fb6710c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"ad368cd672af91867c1ce12025bd233a6cdb4507","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Closes-Bug: #2028809"},{"line_number":25,"context_line":"Related-Bug: #1901891"},{"line_number":26,"context_line":"Change-Id: Iea95a3c2df041a0046647b3d3dadead1a6d054d1"},{"line_number":27,"context_line":"(cherry picked from commit 6730c761d18aa547998f2add833c13f45f257fe7)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5dc7f776_9faeaa07","line":27,"in_reply_to":"39b504fa_ce7fe66e","updated":"2023-08-16 15:29:40.000000000","message":"In general in OpenStack, as described in the stable policy [1], patches should be backported branch by branch. To make the reviewing of backports easier it is recommended, to use \u0027git cherry-pick -x \u003cpatch_from_n+1_branch\u003e\u0027 command, so that this would look like:\n\n    [..]\n    Change-Id: Iea95a3c2df041a0046647b3d3dadead1a6d054d1\n    (cherry picked from commit 6730c761d18aa547998f2add833c13f45f257fe7)\n    (cherry picked from commit df54af90d03b14ebcd6e662bc8ece1fc52ea7c1d)\n\n(note, that gerrit can be also used, but the ui only puts the proper cherry-picked-from lines IFF the patch on N+1 branch has already merged)\n\n[1] https://docs.openstack.org/project-team-guide/stable-branches.html#processes","commit_id":"65f1fb6b4a54386f473369b05c8d10d77fb6710c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5b8e0ee236121946d716fe020f7ec590ffb64a9b","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Closes-Bug: #2028809"},{"line_number":25,"context_line":"Related-Bug: #1901891"},{"line_number":26,"context_line":"Change-Id: Iea95a3c2df041a0046647b3d3dadead1a6d054d1"},{"line_number":27,"context_line":"(cherry picked from commit 6730c761d18aa547998f2add833c13f45f257fe7)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"73ed0b87_17a582f5","line":27,"in_reply_to":"5dc7f776_9faeaa07","updated":"2023-08-16 15:58:23.000000000","message":"What I read in the process - `To do so, you may try to use the “Cherry Pick To” button in the Gerrit UI for the original patch in master`; `The backport must match the master commit` - so all tells, that you need to ensure that backport is a clean cherry-pick from the master, rather then from the previous cherry-pick.\nAlso, frankly speaking, I see no difference in that as long as cherry-picks are clean from master both to N-1 and N-2. Difference would be if cherry-pick to N-1 is not clean, then backport to N-2 indeed worth to be done from N-1, as it might be a clean one.\n\nBackport examples tell only, that N-1 branch backport should be merged before N-2. but it doesn\u0027t say that N-2 should be made from N-1 rather then master, IMO.\n\nIt could be that I just don\u0027t see what you\u0027re referring to in the doc (I did that twice today already - apparently I\u0027m getting blind)...","commit_id":"65f1fb6b4a54386f473369b05c8d10d77fb6710c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"8b7a19bd5ff77f1337ee9ce61c390d27e4ed915f","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Closes-Bug: #2028809"},{"line_number":25,"context_line":"Related-Bug: #1901891"},{"line_number":26,"context_line":"Change-Id: Iea95a3c2df041a0046647b3d3dadead1a6d054d1"},{"line_number":27,"context_line":"(cherry picked from commit 6730c761d18aa547998f2add833c13f45f257fe7)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e7c9190c_774e9d74","line":27,"in_reply_to":"73ed0b87_17a582f5","updated":"2023-08-17 09:00:24.000000000","message":"no, you are not blind, thanks for reading it so thoroughly! :)\nWithout over-explaining it: for reviewers it is good to see that the backports were cherry picked branch by branch, seeing all the previous cherry picks (random example [1]). You are right, in this case, as there is no difference in the patch against zed compared to master version, it is not a big deal. Also, I\u0027m aware that not all project requires to strictly do the cherry picks branch by branch, hence it is just a nit. Sorry for wasting your time.\n\n[1] https://review.opendev.org/c/openstack/nova/+/882920/1//COMMIT_MSG","commit_id":"65f1fb6b4a54386f473369b05c8d10d77fb6710c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1c5aecbcbcf43dc02574d797dac7d4737c3fd1f6","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Closes-Bug: #2028809"},{"line_number":25,"context_line":"Related-Bug: #1901891"},{"line_number":26,"context_line":"Change-Id: Iea95a3c2df041a0046647b3d3dadead1a6d054d1"},{"line_number":27,"context_line":"(cherry picked from commit 6730c761d18aa547998f2add833c13f45f257fe7)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"39b504fa_ce7fe66e","line":27,"in_reply_to":"afb4257f_71411168","updated":"2023-08-15 16:13:08.000000000","message":"I was cherry-picking from master - not from 2023.1, as this was also a clean cherry-pick.\n\nNot sure what you\u0027ve meant about missing line. You\u0027ve commented on it?","commit_id":"65f1fb6b4a54386f473369b05c8d10d77fb6710c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bf275c4cf59a818077c9a87266d0715a374b6ccc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5786e126_bd649ada","updated":"2023-08-14 08:44:09.000000000","message":"Thanks","commit_id":"65f1fb6b4a54386f473369b05c8d10d77fb6710c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"8b7a19bd5ff77f1337ee9ce61c390d27e4ed915f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cd83d4e2_02efeac9","updated":"2023-08-17 09:00:24.000000000","message":"Thanks for the backport Dmitriy, LGTM! (Clean cherry pick, already backported \u0026 merged to stable/2023.1, considering these I\u0027m approving the patch here as well)","commit_id":"65f1fb6b4a54386f473369b05c8d10d77fb6710c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"2723d163bca618ee7ab47a745023c24701d0d310","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"687d48da_aa40c5a9","updated":"2023-08-15 15:14:10.000000000","message":"clean cherry pick. since the patch, that is causing the new bug, was cherry picked \u0026 merged to stable/zed, too, this makes sense.\n(not yet merged in stable/2023.1, though)","commit_id":"65f1fb6b4a54386f473369b05c8d10d77fb6710c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1643297192842d0f339f8f0c1c2fb39651bba822","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d67bbe4e_75598319","updated":"2023-08-21 14:08:23.000000000","message":"recheck tempest failed on unrelated test: tempest.api.network.test_dhcp_ipv6.NetworksTestDHCPv6.test_dhcpv6_64_subnets","commit_id":"65f1fb6b4a54386f473369b05c8d10d77fb6710c"}]}
