)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"96027f4e28ac410066b53c3d2cd3796e67e8cd58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"23c12a05_0d74c234","updated":"2023-08-15 17:43:58.000000000","message":"I didn\u0027t added any test here, as not really sure how to test that specific usecase.\nAs it should be upgrade job, and we need to ensure that services did some action (like server create) prior to upgrade and then same action fail after the keystone upgrade.\n\nAnd I\u0027m not sure on how to achieve that with devstack..","commit_id":"61a6ae32579ae0392e31bef61653625537e61e31"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3204e6e1b5bc7d7488c5126110313f3aefa0f42e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"03a06fcc_c80a7791","updated":"2023-08-16 17:15:12.000000000","message":"Thank you for the patch.\n\nI wondered why ``oauth2_thumbprint`` is missing instead of being ``None``. In [1], where the token obj is generated from the token_Id, the token obj has an ``oauth2_thumbprint`` attr. Thus, it should be ``None``.\n\nThe root cause of this bug is the caching [2][3]. The tokens are cached by oslo in the form of the old token model.\n\nWhen I turn off the caching as follows, the error doesn\u0027t happen.\n\n```\n/etc/keystone/keystone.conf:\n\n[cache]\nmemcache_servers \u003d localhost:11211\nbackend \u003d dogpile.cache.memcached\nenabled \u003d False\n# enabled \u003d True\n```\n\nIMO, this patch can be merged as it\u0027s more user-friendly compared to forcing users to reset their cache.\n\n[1] https://opendev.org/openstack/keystone/src/branch/master/keystone/token/provider.py#L172\n[2] https://opendev.org/openstack/keystone/src/branch/master/keystone/token/provider.py#L153\n[3] https://docs.openstack.org/oslo.cache/train/reference/api/oslo_cache.html","commit_id":"3aa35ed73188a27efa5f4fd1b091b66e75131cec"}],"keystone/common/render_token.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3204e6e1b5bc7d7488c5126110313f3aefa0f42e","unresolved":true,"context_lines":[{"line_number":142,"context_line":"            token_reference[\u0027token\u0027][key][\u0027access_rules\u0027] \u003d ("},{"line_number":143,"context_line":"                token.application_credential[\u0027access_rules\u0027]"},{"line_number":144,"context_line":"            )"},{"line_number":145,"context_line":"    token_oauth2_thumbprint \u003d getattr(token, \u0027oauth2_thumbprint\u0027, None)"},{"line_number":146,"context_line":"    if token_oauth2_thumbprint:"},{"line_number":147,"context_line":"        token_reference[\u0027token\u0027][\u0027oauth2_credential\u0027] \u003d {"},{"line_number":148,"context_line":"            \u0027x5t#S256\u0027: token.oauth2_thumbprint"}],"source_content_type":"text/x-python","patch_set":3,"id":"cd7ab3bc_2575ce94","line":145,"updated":"2023-08-16 17:15:12.000000000","message":"I suggest adding NOTE to describe this is for backward compatibility if this patch is going to be merged.","commit_id":"3aa35ed73188a27efa5f4fd1b091b66e75131cec"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c6925aeff37001c0077c5ae15304e1b795dc4a21","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            token_reference[\u0027token\u0027][key][\u0027access_rules\u0027] \u003d ("},{"line_number":143,"context_line":"                token.application_credential[\u0027access_rules\u0027]"},{"line_number":144,"context_line":"            )"},{"line_number":145,"context_line":"    token_oauth2_thumbprint \u003d getattr(token, \u0027oauth2_thumbprint\u0027, None)"},{"line_number":146,"context_line":"    if token_oauth2_thumbprint:"},{"line_number":147,"context_line":"        token_reference[\u0027token\u0027][\u0027oauth2_credential\u0027] \u003d {"},{"line_number":148,"context_line":"            \u0027x5t#S256\u0027: token.oauth2_thumbprint"}],"source_content_type":"text/x-python","patch_set":3,"id":"bc0b6e02_5ab85452","line":145,"in_reply_to":"cd7ab3bc_2575ce94","updated":"2023-08-17 08:24:44.000000000","message":"Done","commit_id":"3aa35ed73188a27efa5f4fd1b091b66e75131cec"}]}