)]}'
{"id":"openstack%2Fkeystone~892865","triplet_id":"openstack%2Fkeystone~stable%2Fxena~I8d0bb2438b23227b5a66b94af6f8e198084fcd8d","project":"openstack/keystone","branch":"stable/xena","topic":"bug/1901891","attention_set":{},"removed_from_attention_set":{"8313":{"account":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"last_update":"2023-09-01 13:19:11.000000000","reason":"Change was submitted"},"14250":{"account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"last_update":"2023-09-01 12:00:15.000000000","reason":"\u003cGERRIT_ACCOUNT_14250\u003e replied on the change","reason_account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}},"28619":{"account":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"last_update":"2023-09-01 13:19:11.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8d0bb2438b23227b5a66b94af6f8e198084fcd8d","subject":"Force algo specific maximum length \u0026 Properly trimm bcrypt hashed passwords","status":"MERGED","created":"2023-08-28 09:06:08.000000000","updated":"2023-09-01 13:20:45.000000000","submitted":"2023-09-01 13:19:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"892865-bug/1901891","cherry_pick_of_change":890661,"cherry_pick_of_patch_set":2,"meta_rev_id":"cf903f55bbe6f1c4c271d5b9d22599050e28bb35","_number":892865,"virtual_id_number":892865,"owner":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-09-01 13:19:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2023-08-28 09:50:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2023-09-01 12:00:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":1,"date":"2023-09-01 12:00:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}],"reviewers":{"CC":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"REVIEWER":[{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-28 09:06:08.000000000","updated_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"CC"},{"updated":"2023-08-28 09:23:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-08-28 09:50:36.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2023-08-28 10:52:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-08-31 07:32:04.000000000","updated_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"reviewer":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"state":"REVIEWER"},{"updated":"2023-08-31 07:32:04.000000000","updated_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"}],"messages":[{"id":"23f115771dd79d9a10c1c07f7f7fedfd28e25ce9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2023-08-28 09:06:08.000000000","message":"Patch Set 1: Cherry Picked from branch stable/yoga.","accounts_in_message":[],"_revision_number":1},{"id":"4cf460fec7a6e1bf97cfd8155cc1fe8546468ae0","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-28 09:23:19.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ac7446f66bcf4d50b1ad6d3285c1b5e5\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/7c278a5d50e244a0bb4f808a512c9dd2 : SUCCESS in 15m 30s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/3be0568df38a4b93a0b567619c91ae05 : SUCCESS in 16m 12s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ae611c8964d19eabc52d49b9296d7c7f03b59841","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-08-28 09:50:36.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ab6ca093f9551af5f1e0e26ddb4fbcf8baadc5ea","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-08-28 09:50:48.000000000","message":"Topic bug/1901891-stable/xena removed","accounts_in_message":[],"_revision_number":1},{"id":"2d484df425232a85070da0978b0b45850b3f91c7","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-08-28 09:50:54.000000000","message":"Topic set to bug/1901891","accounts_in_message":[],"_revision_number":1},{"id":"2fa39e2eb47b4314a15eda1fa4917493b77ca9a7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-28 10:52:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7b2b58ddabae42b79ddec4275e50b14c\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9d17fcb78b3141da9447358529d9a13e : SUCCESS in 15m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/11eaf1403d1b4ac79273578e23d8fb65 : SUCCESS in 4m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3c66f9c8f62a45dcbfe2206925508351 : SUCCESS in 14m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0d22c315ba2a4c529b3a7bfdd9e4036e : SUCCESS in 12m 34s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ca9540bb0f574af1967c94695f96500a : SUCCESS in 15m 03s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b28ff70076b84fae9fdcd478b5b5672b : SUCCESS in 11m 03s\n- grenade https://zuul.opendev.org/t/openstack/build/e31b7a4709384480b7b0b3b75d09e5ac : SUCCESS in 1h 13m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1e8d4a8429144753904aa2f06338aff5 : SUCCESS in 1h 11m 44s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ac1e86dce7e8451e8818abaee05ab511 : SUCCESS in 9m 19s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/01e2e491a3414feca9ad72bd69551797 : SUCCESS in 38m 46s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/312117f090e54ce096cd9436c5b7fc85 : FAILURE in 21m 44s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7aa18d357e2b4b91acbe9b24da33b994 : FAILURE in 37m 45s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/17f6ad619b934e90878cae759215131f : SUCCESS in 33m 35s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/613ddad798614b9eae746a0bbe05041a : FAILURE in 24m 13s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/caab95b1fbab47d1b03abc213e3df759 : FAILURE in 21m 34s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a1374c7eede947f2b2460e000563b983 : SUCCESS in 54m 53s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/461c94ce366e4be2aef0e14453efd46b : SUCCESS in 38m 42s","accounts_in_message":[],"_revision_number":1},{"id":"c8861d3c3bde63f8261bd1d0f266ab5b1c0d912d","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-09-01 12:00:15.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"21cf13d1afe7d2b676f7ada1520c4bb2511a9558","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-01 12:00:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"47cb46bf7906e44334871d14e0040b43ec702b7d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-01 13:19:11.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a05217fc1a41480e862309dc3d6b5dba\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3042749747b0479e954c9c262bcbb6bc : SUCCESS in 5m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d7512ed0ba784459ae4f10a1c3709d71 : SUCCESS in 16m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/db8547394d474d42899855c073ed033b : SUCCESS in 13m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/80af94797ef84cdd833643319fb13695 : SUCCESS in 13m 48s\n- grenade https://zuul.opendev.org/t/openstack/build/7cf0cecd2b7b4988b0a851709763f875 : SUCCESS in 1h 03m 40s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/167d8976a5b044b6928e720410db88e9 : SUCCESS in 1h 12m 04s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/588e5779f7de46bfb57fe0ad177a06f7 : SUCCESS in 9m 06s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/296217fdc6584042804a02e92cf1d552 : SUCCESS in 34m 57s\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/2d17e15c453c49eaac2b151b6f15735a : SUCCESS in 35m 12s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8e2791606ec24f9f98b70a5f26f88c32 : SUCCESS in 50m 16s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/d89a463a711e4f3cb947b14b552559ad : SUCCESS in 44m 08s","accounts_in_message":[],"_revision_number":1},{"id":"253fb77e035b167692c99f640cb23dca1e39117e","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-01 13:19:11.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"cf903f55bbe6f1c4c271d5b9d22599050e28bb35","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-01 13:20:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/80193626b45e40edaf7e9bae0559939f\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/50a708036f3a4d8c9e137d468c63f9b7 : SUCCESS in 1m 13s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/576227b2bf354a0cb0dda5ac4e5dd432 : SUCCESS in 46s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a38ba2a70cdf7e72c0f17bb80d895ccc1e39a010","revisions":{"a38ba2a70cdf7e72c0f17bb80d895ccc1e39a010":{"kind":"REWORK","_number":1,"created":"2023-08-28 09:06:08.000000000","uploader":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"ref":"refs/changes/65/892865/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/65/892865/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/65/892865/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/65/892865/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/65/892865/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/65/892865/1"}}},"commit":{"parents":[{"commit":"eff960e124e2f28922067800547e23f1931d3c4a","subject":"Merge \"[PooledLDAPHandler] Ensure result3() invokes message.clean()\" into stable/xena","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/eff960e124e2f28922067800547e23f1931d3c4a"}]}],"author":{"name":"Dave Wilde (d34dh0r53)","email":"dwilde@redhat.com","date":"2022-02-09 17:28:59.000000000","tz":-360},"committer":{"name":"Lajos Katona","email":"katonalala@gmail.com","date":"2023-08-28 09:06:08.000000000","tz":0},"subject":"Force algo specific maximum length \u0026 Properly trimm bcrypt hashed passwords","message":"Force algo specific maximum length \u0026 Properly trimm bcrypt hashed passwords\n\nThis is the squash of 2 patches related to bcrypt hashing settings.\n\n1.\nForce algo specific maximum length\n\nThe bcrypt algorithm that we use for password hashing silently\nlength limits the size of the password that is hashed giving the\nuser a false sense of security [0].  This patch adds a check\nin the verify_length_and_trunc_password function for the hash in\nuse and updates the max_length accordingly, this will override\nthe configured value and log a warning if the password is truncated.\n\nConflicts:\n* tox.ini\n\n[0]: https://passlib.readthedocs.io/en/stable/lib/passlib.hash.bcrypt.html#security-issues\n\n2.\nProperly trimm bcrypt hashed passwords\n\nbcrypt  hashing algorythm has a limitation on length of passwords it\ncan hash on 72 bytes. In [1] a password trimm to 54 symbols has been\nimplemented, which resulted in password being invalidated after the\nkeystone upgrade, since passwords are trimmed differently by bcrypt\nitself, as well as len(str()) is not always equal to\nlen(str().encode()) as trimming should be done based on bytes and not\nstring itself.\n\nWith the change we return a byte object from\n`verify_length_and_trunc_password`, so it does not need to\nbe encoded afterwards, since we need to strip based on bytes\nrather then on length of the string.\n\n[1] https://review.opendev.org/c/openstack/keystone/+/828595\n\nCloses-Bug: #2028809\nRelated-Bug: #1901891\noriginal change id: Iea95a3c2df041a0046647b3d3dadead1a6d054d1\n(cherry picked from commit 6730c761d18aa547998f2add833c13f45f257fe7)\n(cherry picked from commit 65f1fb6b4a54386f473369b05c8d10d77fb6710c)\n\nCloses-bug: #1901891\nChange-Id: I8d0bb2438b23227b5a66b94af6f8e198084fcd8d\n(cherry picked from commit 3288af579de8ee312c36fb78ac9309ce8c554827)\n(cherry picked from commit 1b3536a7a4d72e7f7b95cc1874a450accad3ec8d)\n(cherry picked from commit 7852ca24a4eb86cb271ef7ec5e07f8f9c97f926d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/a38ba2a70cdf7e72c0f17bb80d895ccc1e39a010"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/a38ba2a70cdf7e72c0f17bb80d895ccc1e39a010"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}