)]}'
{"id":"openstack%2Fkeystone~893944","triplet_id":"openstack%2Fkeystone~stable%2Fvictoria~I8d0bb2438b23227b5a66b94af6f8e198084fcd8d","project":"openstack/keystone","branch":"stable/victoria","topic":"bug/1901891","attention_set":{},"removed_from_attention_set":{"17685":{"account":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"last_update":"2023-09-07 08:58:00.000000000","reason":"\u003cGERRIT_ACCOUNT_17685\u003e replied on the change","reason_account":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},"8313":{"account":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"last_update":"2023-09-07 17:22:05.000000000","reason":"Change was submitted"},"28619":{"account":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"last_update":"2023-09-07 17:22:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8d0bb2438b23227b5a66b94af6f8e198084fcd8d","subject":"Force algo specific maximum length \u0026 Properly trimm bcrypt hashed passwords","status":"MERGED","created":"2023-09-06 17:01:26.000000000","updated":"2023-09-07 17:23:36.000000000","submitted":"2023-09-07 17:22:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"893944-bug/1901891","cherry_pick_of_change":893549,"cherry_pick_of_patch_set":1,"meta_rev_id":"4a9bcafe19c4222564286afb4f9fa086c1b84f88","_number":893944,"virtual_id_number":893944,"owner":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-09-07 17:22:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2023-09-07 08:58:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2023-09-07 13:44:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":1,"date":"2023-09-07 13:44:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-06 17:01:26.000000000","updated_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"CC"},{"updated":"2023-09-06 18:15:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-07 07:24:42.000000000","updated_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2023-09-07 07:24:42.000000000","updated_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2023-09-07 13:44:41.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"}],"messages":[{"id":"0172c2c33e63a447a5817e18f99e96d7ac122edd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2023-09-06 17:01:26.000000000","message":"Patch Set 1: Cherry Picked from branch stable/wallaby.","accounts_in_message":[],"_revision_number":1},{"id":"06e73ff9d1a3e25d1c3658d05e0a6a53b4d89399","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2023-09-06 17:01:32.000000000","message":"Topic bug/1901891-stable/victoria removed","accounts_in_message":[],"_revision_number":1},{"id":"3c397541913c6a38f303bc468d0fe12b533f2cfc","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2023-09-06 17:01:52.000000000","message":"Topic set to bug/1901891","accounts_in_message":[],"_revision_number":1},{"id":"8f4ac0857e8deccfe47853306f90c25c282da384","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-06 18:15:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7904e36220dc46909cb396451375680e\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/54f77326fc5c401094659e57825428e3 : SUCCESS in 25m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fd400a40953f45e7b9f915db6cb95602 : SUCCESS in 5m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/96ffa49be32f4ad3812220bbd52cc4b1 : SUCCESS in 23m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b5d8a20a13fa4d12a6b14b75459ba1ad : SUCCESS in 24m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b9c804f45667488fbbdbfbb0435af713 : SUCCESS in 14m 19s\n- grenade https://zuul.opendev.org/t/openstack/build/5d79b3c993f449169f19d0bb63caabfb : SUCCESS in 50m 40s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1ac03812c04b4363b665e8bed0a1b162 : SUCCESS in 1h 11m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c0ba349863fe48668d7edf599a30e216 : SUCCESS in 8m 56s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/da335ef3cf3343fd91bd11217cda5244 : SUCCESS in 42m 56s\n- keystone-dsvm-py3-functional-federation-ubuntu-focal https://zuul.opendev.org/t/openstack/build/540069c19bfd49fa946bd231fc827834 : FAILURE in 39m 26s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/5d5107d40f0540bbb7c3324e7d413ff7 : SUCCESS in 41m 13s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/ff83bd9f83504e14bdc881f5d4c99b2c : FAILURE in 20m 57s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/18315ab5e6544e17aa6f5147f9957c8b : FAILURE in 23m 27s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ceee9fdb53fd43ba9e8435d4021f64a7 : SUCCESS in 1h 07m 11s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/3caebb498cae47cdaf66746705de84be : SUCCESS in 42m 38s","accounts_in_message":[],"_revision_number":1},{"id":"c636e28bcae7d193eafd234010634d93a3940b1d","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-07 08:58:00.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"867efbf064d9492f206dd4a209e2049e74b054ac","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2023-09-07 13:44:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8b0d9bd0395a3530ccf8c91500d04101a3d751aa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-07 13:45:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"126ba44e924b0419f1a9fafe74e736f3c8f43331","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-07 17:22:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cf785350824948e0b2d2c317ddd4872c\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/82a159cc26dd487a89eb2beb553449a7 : SUCCESS in 7m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f73520f745dc4e21bfe4b07ffe1af8d4 : SUCCESS in 15m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e6c7aac82384435b9cf5b337f358c197 : SUCCESS in 14m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c8e46012c3054420a6067e08140a7d59 : SUCCESS in 14m 46s\n- grenade https://zuul.opendev.org/t/openstack/build/a9ab0bd6d38c4513a6e5500d751a9c93 : SUCCESS in 1h 20m 31s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e57d7e4c822a4694b6955d3dfc70ca0a : SUCCESS in 1h 50m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7ebc562b81814d3ea78dd7b61d3cee49 : SUCCESS in 9m 04s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/3fe90f13a2404423947c66c85e48979b : SUCCESS in 27m 01s\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/c58d68d397c343698ebdad9024dfe5e7 : SUCCESS in 39m 47s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/16e5b8657c0e471182cbae092bf3cb78 : SUCCESS in 46m 31s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/6cdc1c2982484e649db627fb006478d2 : SUCCESS in 37m 51s","accounts_in_message":[],"_revision_number":1},{"id":"9a1f32921afac640d3855ab2a7c38625e05ec877","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-07 17:22:05.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"4a9bcafe19c4222564286afb4f9fa086c1b84f88","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-07 17:23:36.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/651d262504a84779b853be085ee3d926\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9f601f9af4244e81812e0d1ddc9efa6b : SUCCESS in 1m 06s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f354d29bdd6448419a0a9efd812accf2 : SUCCESS in 1m 11s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0d5186cb49f452423240e8c6234ca2b753918fe7","revisions":{"0d5186cb49f452423240e8c6234ca2b753918fe7":{"kind":"REWORK","_number":1,"created":"2023-09-06 17:01:26.000000000","uploader":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"ref":"refs/changes/44/893944/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/44/893944/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/44/893944/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/44/893944/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/44/893944/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/44/893944/1"}}},"commit":{"parents":[{"commit":"5a3cc2382aaefc5e99a8ecca1d76e483a8a553d9","subject":"[stable-only] Cap virtualenv/setuptools","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/5a3cc2382aaefc5e99a8ecca1d76e483a8a553d9"}]}],"author":{"name":"Dave Wilde (d34dh0r53)","email":"dwilde@redhat.com","date":"2022-02-09 17:28:59.000000000","tz":-360},"committer":{"name":"Lajos Katona","email":"katonalala@gmail.com","date":"2023-09-06 17:01:26.000000000","tz":0},"subject":"Force algo specific maximum length \u0026 Properly trimm bcrypt hashed passwords","message":"Force algo specific maximum length \u0026 Properly trimm bcrypt hashed passwords\n\nThis is the squash of 2 patches related to bcrypt hashing settings.\n\n1.\nForce algo specific maximum length\n\nThe bcrypt algorithm that we use for password hashing silently\nlength limits the size of the password that is hashed giving the\nuser a false sense of security [0].  This patch adds a check\nin the verify_length_and_trunc_password function for the hash in\nuse and updates the max_length accordingly, this will override\nthe configured value and log a warning if the password is truncated.\n\nConflicts:\n* tox.ini\n\n[0]: https://passlib.readthedocs.io/en/stable/lib/passlib.hash.bcrypt.html#security-issues\n\n2.\nProperly trimm bcrypt hashed passwords\n\nbcrypt  hashing algorythm has a limitation on length of passwords it\ncan hash on 72 bytes. In [1] a password trimm to 54 symbols has been\nimplemented, which resulted in password being invalidated after the\nkeystone upgrade, since passwords are trimmed differently by bcrypt\nitself, as well as len(str()) is not always equal to\nlen(str().encode()) as trimming should be done based on bytes and not\nstring itself.\n\nWith the change we return a byte object from\n`verify_length_and_trunc_password`, so it does not need to\nbe encoded afterwards, since we need to strip based on bytes\nrather then on length of the string.\n\n[1] https://review.opendev.org/c/openstack/keystone/+/828595\n\nCloses-Bug: #2028809\nRelated-Bug: #1901891\noriginal change id: Iea95a3c2df041a0046647b3d3dadead1a6d054d1\n(cherry picked from commit 6730c761d18aa547998f2add833c13f45f257fe7)\n(cherry picked from commit 65f1fb6b4a54386f473369b05c8d10d77fb6710c)\n\nCloses-bug: #1901891\nChange-Id: I8d0bb2438b23227b5a66b94af6f8e198084fcd8d\n(cherry picked from commit 3288af579de8ee312c36fb78ac9309ce8c554827)\n(cherry picked from commit 1b3536a7a4d72e7f7b95cc1874a450accad3ec8d)\n(cherry picked from commit 7852ca24a4eb86cb271ef7ec5e07f8f9c97f926d)\n(cherry picked from commit a38ba2a70cdf7e72c0f17bb80d895ccc1e39a010)\n(cherry picked from commit 11e1258ccda688fd6f1414ac664c50df56ca2989)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/0d5186cb49f452423240e8c6234ca2b753918fe7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/0d5186cb49f452423240e8c6234ca2b753918fe7"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}