)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d1879a3b42981a4b5f98d1ad65e5a6241c5c2d2f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Assign roles in parent project for federated users"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a federated (auto-created) user belongs to a parent project, he should have appropriate roles in it."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1b981cc476022522573e11d1d6a322143370262b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"37a2aaa7_79d7ec5d","line":9,"range":{"start_line":9,"start_character":64,"end_line":9,"end_character":66},"updated":"2023-12-06 06:55:05.000000000","message":"Please use gender neutral terms, like \"they\" in this case. Also wrap long lines in the commit message at at most 72 chars.","commit_id":"d764812a4d0d60c2dd6334df84d1c1d5d49e68d9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"10ed9eb93c8a11cd5d92b7581ba8a9938214bcd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"13cfb9bd_57d2e76b","updated":"2023-11-29 09:36:54.000000000","message":"+1 if unit tests are implemented, this is something that as an operator is expected.","commit_id":"65a9a33c2d024552f6472cd29be43d136ca2204c"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"f44e7b41493b8e50dfb9f6dc5deeefbb0a0c0b34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3e4523c9_1d55e88c","updated":"2023-11-26 03:24:56.000000000","message":"Please create unit tests for the change","commit_id":"65a9a33c2d024552f6472cd29be43d136ca2204c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d1879a3b42981a4b5f98d1ad65e5a6241c5c2d2f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"008c601a_37170658","updated":"2023-12-06 06:55:05.000000000","message":"First of all welcome as a new contributor and thank you for your submission.\n\nLet me start with some general remarks: The usual path of a patch is that it should first get merged into the master branch of the repo. Only once that that has happened, backports into stable branches can happen. So you should re-target this patch against master first, unless the issue only affects the stable/yoga branch, but that doesn\u0027t seem to be the case.\n\nIn order to be able to do backports, it will also be necessary to have a bug report attached, so please create one on launchpad.net and link to it in the commit message by adding \"Closes-Bug: NNNNN\".\n\nPlease also note that I\u0027m not a regular keystone reviewer, so I cannot say anything about the actual functional part of your patch, but I hope others can pick that up.","commit_id":"d764812a4d0d60c2dd6334df84d1c1d5d49e68d9"}],"keystone/auth/plugins/mapped.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d1879a3b42981a4b5f98d1ad65e5a6241c5c2d2f","unresolved":true,"context_lines":[{"line_number":109,"context_line":"def handle_unscoped_token(auth_payload, resource_api, federation_api,"},{"line_number":110,"context_line":"                          identity_api, assignment_api, role_api):"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def validate_shadow_mapping(shadow_projects, existing_roles, idp_domain_id,"},{"line_number":113,"context_line":"                                idp_id):"},{"line_number":114,"context_line":"        # Validate that the roles in the shadow mapping actually exist. If"},{"line_number":115,"context_line":"        # they don\u0027t we should bail early before creating anything."}],"source_content_type":"text/x-python","patch_set":6,"id":"59f4a7e9_d54598a5","side":"PARENT","line":112,"updated":"2023-12-06 06:55:05.000000000","message":"What is the reason to move these functions to the top level? If that really is necessary, please do it in a dedicated commit, so that the changes that you are doing in this commit become more easily visible.","commit_id":"0a318bef48bc43b35f9fb1476af466382c0b76f9"}]}