)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"79795188b149c9d830023c4ee5c4801951e24573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1546ec75_90264ea4","updated":"2023-10-28 06:09:20.000000000","message":"@clark when i started adding logging to pbr it was not executing when i ran\npip install -e --verbose /opt/stack/keystone.\n\ni did notice some pbr messages but none form LocalinstallScripts.run\nhttps://github.com/openstack/pbr/blob/master/pbr/packaging.py#L474\n\nhttps://github.com/pypa/pip/issues/8368 deprecated calling setup.py install when building a wheel failed for source distributions without pyproject.toml\n\nthis fallback was deprecated in pip 20.2\nhttps://pip.pypa.io/en/stable/news/#v20-2\nand removed in 23.1\nhttps://pip.pypa.io/en/stable/news/#v23-1\n\nthat explains why clamping to pip\u003d\u003d21.1.3 worked in devstack\n\nthe correct fix is just to add the minimal pyproject.toml to force pbr to actully be used as the build systems so we coud basically copy this change to every repo.\n\nthat will future proof use to addtional changes like this.","commit_id":"ea3de49e8303faa96939487475aa9ff2c02de1e2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ec006563fbe402e307c5e0595fdf5c2c83b549b2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e7b0b2ba_b76fdbb1","updated":"2023-10-28 06:41:47.000000000","message":"context for keystone team\n\nIn the qa team etherpad there was a topic about possible removing centos 9 stream support form devstack  because GLOBAL_VENV\u003dtrue was not supprot amoung other reasosn\n\nat the end of the day it was decied not to do that but i was courious why so i started looking into that during the ptg.\n\nthe failure mode was that the keystone wsgi script were not being generated so keystone did not start properly and as a result everything else would fail.\n\nthis was just a symptom of a larger problem which is that the behavior of pip install -e changed as of pip 23.1\n\npreviously if there was no pyproject.toml pip would fall back to calling setup.py install which would execute pbr to generate the custom enteryproits for wsgi files\n\nunlike console scripts wsgi_scripts is not actull a standard thing\n\nconsole_script generation was actully done by setup tools but wsgi_script generation is done by pbr.\n\nin the new pip behalfor instead of doing a local install a temporary wheel is built\nand then and editable install from that wheel is done\n\nthat has the effect of runing some but not all of pbr to generate thigns like package metadta for source files but it does not result in the wsgi files form being generated in teh pip install -e case.\n\nyou can replicate this behavior pretty simplely on cenots by createing a venv and installing keystone without this patch\n```\ngit clone https://opendev.org/openstack/keystone\ncd keystone\npython3 -m venv .venv\n. .venv/bin/activate\npython3 -m pip install -U pip\npython3 -m pip install -e --verbose .\nls .venv/bin/keystone*\n```\n\nthis will not have .venv/bin/keystone-wsgi-admin  .venv/bin/keystone-wsgi-public\n\n\nif you downgrade pip or remove -e those files will be installed.\n\nthis might be a bug in how editable installs are done for weels in pip or in pbr\nbut a better long term solution is ot just start using pyproject.toml instead of\nrelying on the deprecated/removed fallback.\n\nthis change has the minium pyproject.toml form \n\nhttps://github.com/openstack/pbr/blob/d03d617c09e7ba8ddf62d1e53d71685cd708e2da/pbr/build.py#L19-L21\n\nto use pbr as a pep-517 build system backend\n\npbr will continue to read configuraiton form setup.cfg as it did when\ninvoked form setup.py install so adding this pyproject.toml does not requrie us to drop support for setup.py although we could also do that eventually in a seperate step.\n\nits a public holiday in ireland on monday so ill be back to work on tuesday and ill send a mail to the list about this then. assumign there are no objections im going to suggest we implemet this change on all openstack repo (or at least thos with wsgi_scripts)","commit_id":"ea3de49e8303faa96939487475aa9ff2c02de1e2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68fbf33a60dfbb0de07fc0cf03e0321a3b02fb02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ad30514_85f6eff5","in_reply_to":"e7b0b2ba_b76fdbb1","updated":"2025-05-12 12:03:10.000000000","message":"Done","commit_id":"ea3de49e8303faa96939487475aa9ff2c02de1e2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5501b5c2b10fa3bad34faa6572c9170c5e75202f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"34359d3c_5af0e4d4","updated":"2023-11-15 12:14:03.000000000","message":"setting -1 until we add supprot for wsgi_script in editable mode whne pyproject.toml is used.","commit_id":"32be36d2f3367cfb62747485692877495ce4390c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e3f880475f9482ba2375edea2c735b13bb280c38","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"358f39a6_206498a2","in_reply_to":"34359d3c_5af0e4d4","updated":"2024-03-05 14:39:49.000000000","message":"It looks like this will not happen, so what will be the next step ?","commit_id":"32be36d2f3367cfb62747485692877495ce4390c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d463cb804a95ecb6e118410a2823544f4595b928","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f6d346d4_d0a15407","in_reply_to":"358f39a6_206498a2","updated":"2024-03-05 15:28:16.000000000","message":"we need the wsgi part to proceed next cycle and then this can proceed\n\nwe have abandoned the idea of adding wsgi script generation to pbr for edtibale mode. while it would be possibel to do we do not have time to do it and done want to maintian it going forward.\n\ninstead we are removing the use of the PBR extetion form the existing projects\nfor nova we wanted to hold the wsgi prat till after FF and merge it this week and then we may also merge the pyporject.toml part this week too.\n\nstephen didnt propose wsgi pataches ot all affected repos as we would liek the core teams for each repo to really handel this but the pattern is pretty simple to follow\n\nhttps://review.opendev.org/q/topic:%22remove-wsgi_scripts%22\n\n\nkeystone does not have a toplevel wsgi moduel so you can follwo the cinder example\n\nfirst we need to statical add wsgi files in teh repo \n\n\nhttps://review.opendev.org/c/openstack/cinder/+/902876\n\nnova had to do dance of remvoign our old use of nova/wsgi\n\nhttps://review.opendev.org/c/openstack/nova/+/902686\n\nand then addign a new one\n\nhttps://review.opendev.org/c/openstack/nova/+/902687/4\n\noptionally the last step is to remove the supprot for the pbr extions\n\nhttps://review.opendev.org/c/openstack/nova/+/902688/5\n\nthe apprch we are takign is an additive one.\n\nwe are adding supprot for using wsgi via moduel paths without code generation for the scrit file\n\nwhile still keeping support for generating the script with pbr if you use setup.py directly instead of the pyproject.toml functionality.\n\nwe dont plan to drop the pbr supprot for generating the wsgi script until at least 2025.1 (E)","commit_id":"32be36d2f3367cfb62747485692877495ce4390c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68fbf33a60dfbb0de07fc0cf03e0321a3b02fb02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c13f4dc_ec195775","in_reply_to":"f6d346d4_d0a15407","updated":"2025-05-12 12:03:10.000000000","message":"Done","commit_id":"32be36d2f3367cfb62747485692877495ce4390c"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"01024a1ae7fc195fa1093a05a05fcf6f35666f06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"61ad288b_bbd9ca40","updated":"2025-05-09 13:09:52.000000000","message":"bad, I was like 1000% sure we have it already - too many projects to maintain :-(","commit_id":"ee437c72ca133b42e9abf37b155615888c6711e4"}],"pyproject.toml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"78f299ae71202a72b2217bb71f4c318b662a0395","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[build-system]"},{"line_number":2,"context_line":"requires \u003d [\"pbr\u003e\u003d5.7.0\", \"setuptools\u003e\u003d64.0.0\", \"wheel\"]"},{"line_number":3,"context_line":"build-backend \u003d \"pbr.build\""}],"source_content_type":"text/x-toml","patch_set":4,"id":"e49e2749_ac74f229","line":2,"range":{"start_line":2,"start_character":49,"end_line":2,"end_character":54},"updated":"2024-05-04 09:07:39.000000000","message":"Am I right, that `wheel` here always mean \u0027latest\u0027 without being unoverridable by constraints?\n\nI also do not see `wheel` in Nova for instance:\nhttps://review.opendev.org/c/openstack/nova/+/899753/11/pyproject.toml","commit_id":"32be36d2f3367cfb62747485692877495ce4390c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68fbf33a60dfbb0de07fc0cf03e0321a3b02fb02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[build-system]"},{"line_number":2,"context_line":"requires \u003d [\"pbr\u003e\u003d5.7.0\", \"setuptools\u003e\u003d64.0.0\", \"wheel\"]"},{"line_number":3,"context_line":"build-backend \u003d \"pbr.build\""}],"source_content_type":"text/x-toml","patch_set":4,"id":"882b416a_b7f6e335","line":2,"range":{"start_line":2,"start_character":49,"end_line":2,"end_character":54},"in_reply_to":"e49e2749_ac74f229","updated":"2025-05-12 12:03:10.000000000","message":"Done","commit_id":"32be36d2f3367cfb62747485692877495ce4390c"}]}