)]}'
{"id":"openstack%2Fkeystone~901926","triplet_id":"openstack%2Fkeystone~stable%2F2023.1~I4fd7bf6b194c38815c2a9cdbab92a07315397eab","project":"openstack/keystone","branch":"stable/2023.1","topic":"bug/1999068-stable/2023.1","attention_set":{},"removed_from_attention_set":{"14250":{"account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"last_update":"2024-01-26 17:37:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4fd7bf6b194c38815c2a9cdbab92a07315397eab","subject":"Don\u0027t forget to check if authorization fails","status":"MERGED","created":"2023-11-27 14:52:55.000000000","updated":"2024-01-26 17:38:57.000000000","submitted":"2024-01-26 17:37:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"901926-bug/1999068-stable/2023.1","cherry_pick_of_change":874346,"cherry_pick_of_patch_set":5,"meta_rev_id":"ef66c86630968ac8af1356fb207d0625680321cb","_number":901926,"virtual_id_number":901926,"owner":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-01-26 17:37:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"all":[{"value":2,"date":"2024-01-05 15:53:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":2,"date":"2024-01-26 14:55:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":1,"date":"2024-01-26 14:55:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-27 14:52:55.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"CC"},{"updated":"2023-11-27 15:29:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-11-27 16:43:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-05 15:53:59.000000000","updated_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"reviewer":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"state":"REVIEWER"},{"updated":"2024-01-26 14:55:02.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"}],"messages":[{"id":"93859960bfb3d5aa6a6c6fde60c42d6db57746f0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-11-27 14:52:55.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"8460cbf9a726ff3a3bd2546fb0e15ea874684545","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-27 15:29:34.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e9a895b5930546078050830c3f555fb5\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/e1d5c8686af3466f90ab8d7ecd39168b : SUCCESS in 34m 14s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/c0b603a1483944a9b980bd6ef556990d : SUCCESS in 9m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"178230805062adaf7d57b022038603f7b1fe86b7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-27 16:43:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2e79a02d7d9245b8bf32f4ab994129bb\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6188927d49874a18b59afbe753b97f18 : SUCCESS in 14m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/411ab64401724e5889b30f53db92c978 : SUCCESS in 5m 23s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a487d46aa2d14702bb7f8b06a1db1a56 : SUCCESS in 11m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a7fc0d3a4f4e4d48bf6de332719949bb : SUCCESS in 12m 24s\n- grenade https://zuul.opendev.org/t/openstack/build/9622dc04192a43649ccb8d1e42786e81 : SUCCESS in 1h 03m 08s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/8243869b579e48d88ac401200f02e828 : SUCCESS in 1h 41m 55s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/61c987b57a554b0ba35e03b030935f21 : SUCCESS in 34m 45s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/6d1eacc497fa4c0aacf9500d156e8ba9 : SUCCESS in 51m 24s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b0eab4451c584865b81e56991129a00f : SUCCESS in 41m 19s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/6aba512772904cab9224fd6d5bef62ae : SUCCESS in 41m 06s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/22e0c7b280b24584989e7b40f782bb76 : SUCCESS in 22m 00s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/91625755ddc2410ab65bd3f2cc7533e5 : FAILURE in 23m 53s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f03dda547c9d400fba71df37ccf4fb4f : SUCCESS in 52m 43s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/b9338a506fec4a4daf94177c0f465120 : SUCCESS in 50m 49s","accounts_in_message":[],"_revision_number":1},{"id":"0e389e70e9997f587031a26e9c87dde7313f3650","author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"date":"2024-01-05 15:53:59.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cbd4e336c830adfe1d1ec13195b28be42c5aeeb5","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2024-01-26 14:55:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7a8329858e012dbc9ff0b93d27b142db6730b685","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-26 14:55:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"58bb8b3749867ee7f59125417fd7985d54c92ac7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-26 17:37:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0dd50b72987e4f0385151b100da569c9\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f37b7b69a0104e42aa31fb776cb39efe : SUCCESS in 5m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2e283acf002a45b3a5b282d6509d5b99 : SUCCESS in 10m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a27baa8d863c4887aeaa9ee84e5e9a72 : SUCCESS in 14m 42s\n- grenade https://zuul.opendev.org/t/openstack/build/b904d1c719c049b681946a2625959797 : SUCCESS in 1h 12m 02s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/c5c3665aac2142eda0cbb164f3aa44f8 : SUCCESS in 1h 09m 07s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/24c13ee36ccf46e6bd80dc165d5b650c : SUCCESS in 39m 24s\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/fa9d732a3a424f5380ed3db2526c0106 : SUCCESS in 31m 29s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/aef169969b53414181e04b53d43564a3 : SUCCESS in 42m 00s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/6f57f76f2d7d490089d497315d191c2d : SUCCESS in 40m 59s","accounts_in_message":[],"_revision_number":1},{"id":"b1814f318b337ec9a3d3641e439b033a3dc8ec2b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-26 17:37:04.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"ef66c86630968ac8af1356fb207d0625680321cb","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-26 17:38:57.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ef8e190d221f48b7bc099616a0e1ecb3\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/238aa079bef942fd9ed7a068bde41cbc : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ea8c8aa982235240cf58bd561132aefe33439506","revisions":{"ea8c8aa982235240cf58bd561132aefe33439506":{"kind":"REWORK","_number":1,"created":"2023-11-27 14:52:55.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/26/901926/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/26/901926/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/26/901926/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/26/901926/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/26/901926/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/26/901926/1"}}},"commit":{"parents":[{"commit":"3bcd957d223c6cd7ecacb434725a4d7139acaadd","subject":"Merge \"Add an option to randomize LDAP urls list\" into stable/2023.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/3bcd957d223c6cd7ecacb434725a4d7139acaadd"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2023-02-18 08:09:39.000000000","tz":-360},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2023-11-27 14:52:55.000000000","tz":0},"subject":"Don\u0027t forget to check if authorization fails","message":"Don\u0027t forget to check if authorization fails\n\nThe fix is to copy the missing check from class AuthProtocol\nof keystonemiddleware.\n\nCloses-bug: 1999068\nChange-Id: I4fd7bf6b194c38815c2a9cdbab92a07315397eab\n(cherry picked from commit 1544c7fc0aca9638c7cd31742e778d9327d2a62c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/ea8c8aa982235240cf58bd561132aefe33439506"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/ea8c8aa982235240cf58bd561132aefe33439506"}]},"branch":"refs/heads/stable/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
