)]}'
{"id":"openstack%2Fkeystone~902029","triplet_id":"openstack%2Fkeystone~stable%2Fyoga~I4fd7bf6b194c38815c2a9cdbab92a07315397eab","project":"openstack/keystone","branch":"stable/yoga","topic":"bug/1999068-stable/yoga","attention_set":{},"removed_from_attention_set":{"14250":{"account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"last_update":"2024-02-07 09:42:08.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I4fd7bf6b194c38815c2a9cdbab92a07315397eab","subject":"Don\u0027t forget to check if authorization fails","status":"ABANDONED","created":"2023-11-28 08:42:21.000000000","updated":"2024-02-07 09:42:08.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":874346,"cherry_pick_of_patch_set":5,"meta_rev_id":"23811c5acbf72273332da943b09b3351755ca518","_number":902029,"virtual_id_number":902029,"owner":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-11-28 09:57:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-28 08:42:21.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"CC"},{"updated":"2023-11-28 09:35:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-11-28 09:57:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-07 09:42:08.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"501144019f8cabc87d224c34ba83d50faac2c12d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-11-28 08:42:21.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"5d28febc5fde0bc1fc5d5662eb549238281b2efc","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-28 09:35:01.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ea4a1dc31575424189aee8f0a98ff5f4\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/785192c6925841ba9fdedb82f1673115 : SUCCESS in 44m 42s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/f3ced3d3cf08458cb42ff9ee72709fc1 : SUCCESS in 13m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a9cff4edf4c1fb2066b69fac129ab208a226f0ad","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-28 09:57:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/aa9b8983845245269b72e191674f1406\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e6ef4baa9fc544a694141616809c15c7 : SUCCESS in 13m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a753b5d945124b2bbd179d0e6f0ed44d : SUCCESS in 5m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b04899a499f644dc83f0c42ff0b81acd : SUCCESS in 11m 28s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5d59b06294c34e8686b9b4649242d465 : SUCCESS in 14m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9a04134da5f943b693e1c8f22edbc539 : SUCCESS in 11m 31s\n- grenade https://zuul.opendev.org/t/openstack/build/216331d6d4dd495bba49d5601a7b4bcd : SUCCESS in 52m 49s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2d471e19600d46f6aedbbddc774839c6 : SUCCESS in 1h 14m 32s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/c662804997c5491880d26688617f7b47 : SUCCESS in 28m 07s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/5ca39513e70543cdb207392fd1305b72 : SUCCESS in 46m 56s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5cfc591d275747a18a0809f2e80f62ee : SUCCESS in 36m 40s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/0c7dea82563b4fcc954f50eef1a1c5e0 : SUCCESS in 27m 48s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/7131c8108d2f4fed8aa12da0594c2b19 : FAILURE in 23m 20s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/dd9a4213fee3437b8ff772a7a1403b35 : SUCCESS in 34m 53s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/de1580bb077d4baaa541c8d319e9e6de : SUCCESS in 57m 47s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/1683abc231c149c5afd9b547190ce8df : SUCCESS in 44m 42s","accounts_in_message":[],"_revision_number":1},{"id":"23811c5acbf72273332da943b09b3351755ca518","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-02-07 09:42:08.000000000","message":"Abandoned\n\nstable/yoga branch of openstack/keystone is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/yoga if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"747c7d9b95dd2ef8115c38c4b2b370d378081f71","revisions":{"747c7d9b95dd2ef8115c38c4b2b370d378081f71":{"kind":"REWORK","_number":1,"created":"2023-11-28 08:42:21.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/29/902029/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/29/902029/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/29/902029/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/29/902029/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/29/902029/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/29/902029/1"}}},"commit":{"parents":[{"commit":"0a318bef48bc43b35f9fb1476af466382c0b76f9","subject":"Add an option to randomize LDAP urls list","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/0a318bef48bc43b35f9fb1476af466382c0b76f9"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2023-02-18 08:09:39.000000000","tz":-360},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2023-11-28 08:42:21.000000000","tz":0},"subject":"Don\u0027t forget to check if authorization fails","message":"Don\u0027t forget to check if authorization fails\n\nThe fix is to copy the missing check from class AuthProtocol\nof keystonemiddleware.\n\nCloses-bug: 1999068\nChange-Id: I4fd7bf6b194c38815c2a9cdbab92a07315397eab\n(cherry picked from commit 1544c7fc0aca9638c7cd31742e778d9327d2a62c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/747c7d9b95dd2ef8115c38c4b2b370d378081f71"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/747c7d9b95dd2ef8115c38c4b2b370d378081f71"}]},"branch":"refs/heads/stable/yoga"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
