)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f18d4d9992e20eb2fe9a7b7dc53f56d94e21eb82","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\"datetime.datetime’s utcnow() and utcfromtimestamp() are deprecated\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This broke 2000+ unit tests when running them under Python 3.12."},{"line_number":15,"context_line":"This patch fixes all of this."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I5307464684c8e2e979248cb6cf9d3ada0257ad73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff823072_fc2a4a4f","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":27},"updated":"2024-01-23 08:35:02.000000000","message":"how does deprecation break unit tests ? Don\u0027t these cause just noisy warnings ?\n(this may be trivial but need to be updated to describe the problem properly)","commit_id":"e956a59f3e8be0fa5123cfc2b585f401856200d2"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"0ab6bf25430cb98d19a128b8d15dba73671663ca","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\"datetime.datetime’s utcnow() and utcfromtimestamp() are deprecated\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This broke 2000+ unit tests when running them under Python 3.12."},{"line_number":15,"context_line":"This patch fixes all of this."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I5307464684c8e2e979248cb6cf9d3ada0257ad73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9287e567_6d7726c6","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":27},"in_reply_to":"ff823072_fc2a4a4f","updated":"2024-02-05 10:23:23.000000000","message":"By default yes they would just cause noise during tests but I think the warnings fixture sets any DeprecationWarning in the keystone codebase to \"error\".\n\nhttps://opendev.org/openstack/keystone/src/branch/master/keystone/tests/unit/ksfixtures/warnings.py#L32\n\nIf I set that to \u0027ignore\u0027 they get logged, but the tests actually pass under py312 (with alot of noise!)","commit_id":"e956a59f3e8be0fa5123cfc2b585f401856200d2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"0ab6bf25430cb98d19a128b8d15dba73671663ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e5625335_bf0af545","updated":"2024-02-05 10:23:23.000000000","message":"I think moving to using oslo_utils.timeutils is probably preferable here as it will ensure that the returned objects are timezone naive, preserving existing behaviour.","commit_id":"fc8c61fc544f841dd835d11992861258a13a2f93"}]}