)]}'
{"id":"openstack%2Fkeystone~909260","triplet_id":"openstack%2Fkeystone~stable%2Fwallaby~I8c45131b298ceae7b43b42e2c5df167607d18c48","project":"openstack/keystone","branch":"stable/wallaby","topic":"appcred-validation-speed2-stable/wallaby","attention_set":{},"removed_from_attention_set":{"21107":{"account":{"_account_id":21107,"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","username":"lathiat"},"last_update":"2024-03-26 18:27:17.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I8c45131b298ceae7b43b42e2c5df167607d18c48","subject":"Improve application credential validation speed","status":"ABANDONED","created":"2024-02-20 04:59:08.000000000","updated":"2024-03-26 18:27:17.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":880456,"cherry_pick_of_patch_set":4,"meta_rev_id":"8a502fa9f8e7180dd6afe3ccfea71050c24969c6","_number":909260,"virtual_id_number":909260,"owner":{"_account_id":21107,"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","username":"lathiat"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2024-02-20 06:13:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-20 06:01:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-02-20 06:13:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-26 18:27:17.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"078dc6ddc8d9b17728de5572c1c61717601d995d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":21107,"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","username":"lathiat"},"date":"2024-02-20 04:59:08.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"ce6f2c46af3b945cdadbc203a6716efe1c14d251","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-20 06:01:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cc3ed5a3339e4861917eb0bb964146ed\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/3fce3ab9892841328bcdc2bd6a30a78e : TIMED_OUT in 1h 00m 59s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/f71423c55f09464aa14ca305d417f7be : SUCCESS in 12m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"493e36eeb0471f1adcca1852a91c87db63df7238","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-20 06:13:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3d043ac5b967433c88ccdab77d853bf5\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cb1e1db9e9b4481ca68fa9361825b864 : SUCCESS in 17m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5fbf71e20f8b40bdbc86f738df230867 : SUCCESS in 5m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/11b9be6c9cf0410397e16f3260531304 : SUCCESS in 14m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2f61f3a260914686a9c0006ea3048329 : SUCCESS in 19m 33s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/87af903e69d74acfb8a21f21518f3f17 : SUCCESS in 14m 25s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/171f66303e93427da0afefbdfca5ba7a : SUCCESS in 13m 33s\n- grenade https://zuul.opendev.org/t/openstack/build/8660f4ec19ce41b4bce223839a14d875 : SUCCESS in 1h 03m 08s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/adbcdfc19e044072b1946c20874dff02 : SUCCESS in 1h 13m 23s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/ef73d41e38674874936c084ce7edf9e3 : SUCCESS in 38m 17s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/41f5bcb9dbb24b4493abf6903ce0251a : SUCCESS in 38m 14s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f7eb87750c064b0db07f7f0a15d35125 : FAILURE in 27m 26s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/91691b47e01b434ba026e9fa5b880b64 : SUCCESS in 26m 24s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/cbfba0d08f764d1491275c1db1b9310f : FAILURE in 22m 48s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/1233e21602024850866f7fa9c3feb96f : FAILURE in 9m 25s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/27b6601d64e14ab2b309eafda91e72d0 : SUCCESS in 52m 49s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/22cd987ec83d44f585065b0581240976 : SUCCESS in 34m 58s","accounts_in_message":[],"_revision_number":1},{"id":"8a502fa9f8e7180dd6afe3ccfea71050c24969c6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-26 18:27:17.000000000","message":"Abandoned\n\nstable/wallaby branch of openstack/keystone is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/wallaby if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"55f98f126041b3ed6fe75b24fc2ed635eb89326f","revisions":{"55f98f126041b3ed6fe75b24fc2ed635eb89326f":{"kind":"REWORK","_number":1,"created":"2024-02-20 04:59:08.000000000","uploader":{"_account_id":21107,"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","username":"lathiat"},"ref":"refs/changes/60/909260/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/60/909260/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/60/909260/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/60/909260/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/60/909260/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/60/909260/1"}}},"commit":{"parents":[{"commit":"54dd95db47a9e1011a4bcd25a167769d7d9141e5","subject":"Merge \"Add an option to randomize LDAP urls list\" into stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/54dd95db47a9e1011a4bcd25a167769d7d9141e5"}]}],"author":{"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","date":"2024-01-02 08:46:24.000000000","tz":0},"committer":{"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","date":"2024-02-20 04:59:08.000000000","tz":0},"subject":"Improve application credential validation speed","message":"Improve application credential validation speed\n\nValidating an application credential token is very slow, taking at least\n400ms+ in a simple devstack environment, 5-10x longer than validating a\nuser/password project token.\n\nThe primary bottleneck during a token validation request\n(/v3/auth/tokens) is that token.roles is evaluated at least 5 times.\nvalidate_token is called twice, first during RBAC to populate the\nsubject token context and again to actually validate the token. Each\ncall to validate_token then called token.roles twice because it first\nchecks if it is None, before calling it again to use the result. Lastly\ntoken.roles is evaluated a fifth time during\nrender_token_response_from_model.\n\nEach evaluation of token.roles calls through\n_get_application_credential_roles into list_role_assignments which then\nmakes multiple round-trip SQL queries to the database.\n\nUnlike the related get_roles_for_user_and_project function, none of\nthese calls are currently cached/memoized. We memoize\nlist_role_assignments to get the same-speedup.\n\nReduce the number of token.roles calls to only 3 by storing and re-using\nthe token.roles result in validate_token, then memoize\nlist_role_assignments so the 2nd and 3rd call fetch from the cache\ninstead of repeating many SQL queries.\n\nThis provides a substantial performance improvement bringing validation\ntime in-line with user/password tokens.\n\nChange-Id: I8c45131b298ceae7b43b42e2c5df167607d18c48\n(cherry picked from commit 67b5cca032c36ef67a8aee9db6adada9b403dc5c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/55f98f126041b3ed6fe75b24fc2ed635eb89326f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/55f98f126041b3ed6fe75b24fc2ed635eb89326f"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}