)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7386a0da52d4649862a2720c70cc52420134625f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Stanek \u003cdstanek@dstanek.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-02 16:41:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cleanup of openstack-common.conf and sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An upcoming change[1] in oslo\u0027s update.py adds new warnings for"},{"line_number":10,"context_line":"style issues in the config. To compensate this commit:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_5db121e0","line":7,"updated":"2014-05-02 18:46:51.000000000","message":"put the hash of the commit so that it\u0027s easy to figure out which changes we\u0027re picking up with the next sync.","commit_id":"bf6eb9058f2a14d45a634e53cb1c16cacbab5075"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7386a0da52d4649862a2720c70cc52420134625f","unresolved":false,"context_lines":[{"line_number":13,"context_line":" - uses the script directive for scripts"},{"line_number":14,"context_line":" - explicitly lists modules copied as a dependency of other oslo modules"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"I also ran a full sync once the config changes were made."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"1. https://review.openstack.org/76901"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_1ddeb911","line":16,"updated":"2014-05-02 18:46:51.000000000","message":"should be able to list the changes that are being picked up in this sync. I do something like git log --oneline --no-merges (old commit).. -- (the parts that changed in the sync)","commit_id":"bf6eb9058f2a14d45a634e53cb1c16cacbab5075"}],"keystone/openstack/common/log.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a2d1d5b3f0f7d83446293307544169e5449d3301","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                default\u003dFalse,"},{"line_number":118,"context_line":"                help\u003d\u0027Use syslog for logging. \u0027"},{"line_number":119,"context_line":"                     \u0027Existing syslog format is DEPRECATED during I, \u0027"},{"line_number":120,"context_line":"                     \u0027and will chang in J to honor RFC5424.\u0027),"},{"line_number":121,"context_line":"    cfg.BoolOpt(\u0027use-syslog-rfc-format\u0027,"},{"line_number":122,"context_line":"                # TODO(bogdando) remove or use True after existing"},{"line_number":123,"context_line":"                #    syslog format deprecation in J"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_1e50825d","line":120,"updated":"2014-05-28 18:00:58.000000000","message":"change \"chang\" to \"change\"","commit_id":"f4275c508a6eb86c702af49c04283ba4e9801c1e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f72e9534b4e6d3db4ded740f931554619b2dc96f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                default\u003dFalse,"},{"line_number":118,"context_line":"                help\u003d\u0027Use syslog for logging. \u0027"},{"line_number":119,"context_line":"                     \u0027Existing syslog format is DEPRECATED during I, \u0027"},{"line_number":120,"context_line":"                     \u0027and will chang in J to honor RFC5424.\u0027),"},{"line_number":121,"context_line":"    cfg.BoolOpt(\u0027use-syslog-rfc-format\u0027,"},{"line_number":122,"context_line":"                # TODO(bogdando) remove or use True after existing"},{"line_number":123,"context_line":"                #    syslog format deprecation in J"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_87142c45","line":120,"in_reply_to":"3ae8d1ca_1e50825d","updated":"2014-05-29 11:39:37.000000000","message":"It\u0027s a sync from incubator. The fix belongs there, not to keystone.","commit_id":"f4275c508a6eb86c702af49c04283ba4e9801c1e"}],"openstack-common.conf":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0d829c3ea262fd4c4aae9590340634de12cd6b3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# The list of modules to copy from openstack-common"},{"line_number":4,"context_line":"module\u003ddb"},{"line_number":5,"context_line":"module\u003ddb.sqlalchemy"},{"line_number":6,"context_line":"module\u003dconfig"}],"source_content_type":"text/plain","patch_set":1,"id":"9ad9bd40_dd76113e","side":"PARENT","line":3,"updated":"2014-05-02 18:44:16.000000000","message":"this still seems a bit useful for new contributors","commit_id":"d006469d1f8357308087f3e37d4d70de3cdbba4a"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"48f50c6633cd2f33a33fb2e4d065498578834b75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# The list of modules to copy from openstack-common"},{"line_number":4,"context_line":"module\u003ddb"},{"line_number":5,"context_line":"module\u003ddb.sqlalchemy"},{"line_number":6,"context_line":"module\u003dconfig"}],"source_content_type":"text/plain","patch_set":1,"id":"9ad9bd40_6bbe1ad6","side":"PARENT","line":3,"in_reply_to":"9ad9bd40_dd76113e","updated":"2014-05-03 00:06:26.000000000","message":"Better change to # The list of modules to copy from oslo-incubator","commit_id":"d006469d1f8357308087f3e37d4d70de3cdbba4a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7386a0da52d4649862a2720c70cc52420134625f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# local is a dependency of oslo"},{"line_number":17,"context_line":"module\u003dlocal"},{"line_number":18,"context_line":"# lockutils is a dependency of oslo"},{"line_number":19,"context_line":"module\u003dlockutils"},{"line_number":20,"context_line":"module\u003dlog"},{"line_number":21,"context_line":"module\u003dpolicy"},{"line_number":22,"context_line":"module\u003dstrutils"}],"source_content_type":"text/plain","patch_set":1,"id":"9ad9bd40_9df8097e","line":19,"updated":"2014-05-02 18:46:51.000000000","message":"We need to add the dependencies ourselves? this is going to make things more difficult for us to know when we\u0027re not using something anymore. Currently we can just remove the one line when keystone isn\u0027t using the module anymore... now we\u0027ll have to figure out the dependencies.","commit_id":"bf6eb9058f2a14d45a634e53cb1c16cacbab5075"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"48f50c6633cd2f33a33fb2e4d065498578834b75","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# local is a dependency of oslo"},{"line_number":17,"context_line":"module\u003dlocal"},{"line_number":18,"context_line":"# lockutils is a dependency of oslo"},{"line_number":19,"context_line":"module\u003dlockutils"},{"line_number":20,"context_line":"module\u003dlog"},{"line_number":21,"context_line":"module\u003dpolicy"},{"line_number":22,"context_line":"module\u003dstrutils"}],"source_content_type":"text/plain","patch_set":1,"id":"9ad9bd40_8b36fe50","line":19,"in_reply_to":"9ad9bd40_23b7e0d9","updated":"2014-05-03 00:06:26.000000000","message":"As Brant pointed out, we don\u0027t need do this,  the purpose of  change in update.py is just warning the difference between actual copied module and module listed in  openstack-common.conf , I can add something to explain like \" If modules are used internally by oslo , please ignore the warning\".\nNot all developers remove all modules and do a full sync , There is the case ,some unused modules still exist in the consumer project, that\u0027s why I intend to keep the warning. \n\nI\u0027m open to discuss this more :), any suggestion ?","commit_id":"bf6eb9058f2a14d45a634e53cb1c16cacbab5075"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"477d5f6d9b4cda6b606cfa7f8083fd0505fd0adc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# local is a dependency of oslo"},{"line_number":17,"context_line":"module\u003dlocal"},{"line_number":18,"context_line":"# lockutils is a dependency of oslo"},{"line_number":19,"context_line":"module\u003dlockutils"},{"line_number":20,"context_line":"module\u003dlog"},{"line_number":21,"context_line":"module\u003dpolicy"},{"line_number":22,"context_line":"module\u003dstrutils"}],"source_content_type":"text/plain","patch_set":1,"id":"9ad9bd40_480b0f25","line":19,"in_reply_to":"9ad9bd40_36ad529d","updated":"2014-05-04 13:41:11.000000000","message":"I can change \"WARNING\" to \"INFO\" ;)","commit_id":"bf6eb9058f2a14d45a634e53cb1c16cacbab5075"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"1094b749adc6e6b1f53c6a0ea04220da37532edc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# local is a dependency of oslo"},{"line_number":17,"context_line":"module\u003dlocal"},{"line_number":18,"context_line":"# lockutils is a dependency of oslo"},{"line_number":19,"context_line":"module\u003dlockutils"},{"line_number":20,"context_line":"module\u003dlog"},{"line_number":21,"context_line":"module\u003dpolicy"},{"line_number":22,"context_line":"module\u003dstrutils"}],"source_content_type":"text/plain","patch_set":1,"id":"9ad9bd40_36ad529d","line":19,"in_reply_to":"9ad9bd40_8b36fe50","updated":"2014-05-04 00:24:08.000000000","message":"Perhaps \"WARNING\" is a bit strong then? Perhaps a  notice or INFO \"Module copied because internal dep\" (please use better words than this:P )","commit_id":"bf6eb9058f2a14d45a634e53cb1c16cacbab5075"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0690ce2b60c3883899528487f1a0e264fbfeb1ce","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# local is a dependency of oslo"},{"line_number":17,"context_line":"module\u003dlocal"},{"line_number":18,"context_line":"# lockutils is a dependency of oslo"},{"line_number":19,"context_line":"module\u003dlockutils"},{"line_number":20,"context_line":"module\u003dlog"},{"line_number":21,"context_line":"module\u003dpolicy"},{"line_number":22,"context_line":"module\u003dstrutils"}],"source_content_type":"text/plain","patch_set":1,"id":"9ad9bd40_23b7e0d9","line":19,"in_reply_to":"9ad9bd40_98c49793","updated":"2014-05-02 19:51:19.000000000","message":"Done","commit_id":"bf6eb9058f2a14d45a634e53cb1c16cacbab5075"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"6d8941ff8b84b02c6c5244a768b5cb6e1f700f5f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# local is a dependency of oslo"},{"line_number":17,"context_line":"module\u003dlocal"},{"line_number":18,"context_line":"# lockutils is a dependency of oslo"},{"line_number":19,"context_line":"module\u003dlockutils"},{"line_number":20,"context_line":"module\u003dlog"},{"line_number":21,"context_line":"module\u003dpolicy"},{"line_number":22,"context_line":"module\u003dstrutils"}],"source_content_type":"text/plain","patch_set":1,"id":"9ad9bd40_98c49793","line":19,"in_reply_to":"9ad9bd40_9df8097e","updated":"2014-05-02 19:09:38.000000000","message":"complain in the upstream patch ASAP :)","commit_id":"bf6eb9058f2a14d45a634e53cb1c16cacbab5075"}]}