)]}'
{"id":"openstack%2Fkeystone~918697","triplet_id":"openstack%2Fkeystone~master~I350a68eab15276809b3ae040dfb656d2d5a77278","project":"openstack/keystone","branch":"master","attention_set":{"7973":{"account":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"last_update":"2024-05-14 16:43:31.000000000","reason":"\u003cGERRIT_ACCOUNT_12932\u003e replied on the change","reason_account":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"}},"13478":{"account":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"last_update":"2024-06-04 00:04:21.000000000","reason":"\u003cGERRIT_ACCOUNT_12932\u003e replied on the change","reason_account":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"}},"5046":{"account":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"last_update":"2024-05-10 15:07:07.000000000","reason":"\u003cGERRIT_ACCOUNT_12932\u003e replied on the change","reason_account":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"}},"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2024-05-14 16:43:31.000000000","reason":"\u003cGERRIT_ACCOUNT_12932\u003e replied on the change","reason_account":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"}}},"removed_from_attention_set":{"12932":{"account":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"last_update":"2024-06-04 00:04:21.000000000","reason":"\u003cGERRIT_ACCOUNT_12932\u003e replied on the change","reason_account":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"}}},"hashtags":[],"change_id":"I350a68eab15276809b3ae040dfb656d2d5a77278","subject":"UserAppCredListCreateResource: remove check for third-part app cred creation","status":"NEW","created":"2024-05-08 20:03:33.000000000","updated":"2024-06-04 00:04:21.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"34749338840489e34ba463526dd6fe7128df907e","_number":918697,"virtual_id_number":918697,"owner":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"tag":"autogenerated:zuul:check","value":1,"date":"2024-05-08 21:42:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":-1,"date":"2024-05-15 20:17:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-08 20:51:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-05-08 21:42:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-10 15:07:07.000000000","updated_by":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2024-05-14 16:43:31.000000000","updated_by":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"reviewer":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"state":"REVIEWER"},{"updated":"2024-05-14 16:43:31.000000000","updated_by":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2024-05-15 20:17:53.000000000","updated_by":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"reviewer":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"state":"REVIEWER"}],"messages":[{"id":"ed975fbd81c2fb7900c3d2090419928f67b1be48","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"date":"2024-05-08 20:03:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"13efdb5f328811f5e4cc9f9b070b6c632dca8feb","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-05-08 20:51:26.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5b5b0b48d3f44fd08e1b1c61331cae19\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/a6bac3c20e1a4638b0effca34dc974ef : SUCCESS in 10m 34s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/6501892b60bb429cb1ad50733d5f8aeb : SUCCESS in 45m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0d1e6994a4f2d33b1cb0ee61a7ecb99c2d5ea6b1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-05-08 21:42:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5d37737ec7e4438cb65deb08e2ada19b\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/75e2c956e7d54eacaaa542f4e8b289aa : SUCCESS in 12m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dffd2d09c6a84ad79098048a43914a04 : SUCCESS in 4m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f919ae63a18a41feb168e0432461956c : SUCCESS in 11m 26s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/670a43479f0844b9841293a0d11ee654 : SUCCESS in 12m 08s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/92140fb703994c098c40bae8ba064ca3 : FAILURE in 13m 40s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5d88c885cc4a414887aecfe560f0b66d : SUCCESS in 9m 17s\n- grenade https://zuul.opendev.org/t/openstack/build/a83cdc5bfc494f919213075f6d64440d : SUCCESS in 1h 08m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e999719178ca40af9a41341a4e217e54 : SUCCESS in 1h 32m 43s\n- keystone-tox-py310-with-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/86d61cdce5e648778e7c8b7a6231291f : SUCCESS in 12m 10s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/cfd18747fdb345fd968cba654f84138f : SUCCESS in 21m 22s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/97655f250c5442f18ba34eb061edee4b : FAILURE in 21m 41s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/4a50014808f546e4b50d8555944e30e0 : FAILURE in 26m 55s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/337be5ff284b4ef6be11524422c299e6 : SUCCESS in 32m 33s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/4ab48c52e97148928f2a27e89fb0d2d0 : SUCCESS in 20m 12s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/da97717423474388ba4d305b0c5054a4 : FAILURE in 11m 47s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a2ee9198896b4a0f87d1eab2edd4af1c : SUCCESS in 39m 27s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/34116c89340c4d2e8f363435f3265f01 : FAILURE in 28m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a966fc5a87f3e322d5da0a05117f4a48e1af6076","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2024-05-15 20:17:53.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"34749338840489e34ba463526dd6fe7128df907e","author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"date":"2024-06-04 00:04:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"afa02cc22c03335c090f0d62daad3a7338d2b020","revisions":{"afa02cc22c03335c090f0d62daad3a7338d2b020":{"kind":"REWORK","_number":1,"created":"2024-05-08 20:03:33.000000000","uploader":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"ref":"refs/changes/97/918697/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/97/918697/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/97/918697/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/97/918697/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/97/918697/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/97/918697/1"}}},"commit":{"parents":[{"commit":"522627de3c66113d03019122735cdfc3e0d245c8","subject":"Allow domain admin to view roles","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/522627de3c66113d03019122735cdfc3e0d245c8"}]}],"author":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2024-05-08 19:59:52.000000000","tz":-300},"committer":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2024-05-08 20:00:32.000000000","tz":-300},"subject":"UserAppCredListCreateResource: remove check for third-part app cred creation","message":"UserAppCredListCreateResource: remove check for third-part app cred creation\n\nThis is already prevented by the identity:create_application_credential\npolicy, so the in-code check is redundant. Including the explicit check\nmeans that the apparently-customizable policy can\u0027t actually be customized,\nand that the \u003cuser\u003e arg supported by the application credential API can\nnever be used.\n\nBug: 2065212\nChange-Id: I350a68eab15276809b3ae040dfb656d2d5a77278\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/afa02cc22c03335c090f0d62daad3a7338d2b020"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/afa02cc22c03335c090f0d62daad3a7338d2b020"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
