)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"3c3fe064cd66e2fa31a821887462575d6c13ada6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b5769aa2_2951d168","updated":"2024-07-19 13:29:15.000000000","message":"This is looking good. Do you plan adding unit tests for output validation? I remember the spec proposes adding an option for disabling output validation, but I wonder how this would look in practice, enabling us to catch issues in CI","commit_id":"e3973b5e3e0c485af855d0658944b972679a840f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"7d1d04bd96bc9ed0f286216385ffdd13073a6ced","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1918ca45_9db201dd","in_reply_to":"b5769aa2_2951d168","updated":"2024-07-24 15:41:52.000000000","message":"missed to post a formal response since it was immediately discussed online. output validation is already in place and it caught few cases where schema was incomplete. It just having good unittests we do not need anything extra.","commit_id":"e3973b5e3e0c485af855d0658944b972679a840f"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"658da727f6d831b1e10c04c06cf6d7a8e3082274","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9a2d94b7_99710798","updated":"2024-08-01 15:46:16.000000000","message":"Noticed a comment inaccuracy","commit_id":"be8b79327def5d5844dcae7b1d3517dd7202e5f4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"027210f687c6a14e445b0a324dfe05628a9f9e99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"24c2d7c9_fb2974a1","updated":"2024-09-27 16:02:25.000000000","message":"thks","commit_id":"076409f18eb3ac3d85efe284ecc3c5c2624dfcf9"}],"keystone/api/credentials.py":[{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"658da727f6d831b1e10c04c06cf6d7a8e3082274","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @validation.response_body_schema(schema.credential_response_body)"},{"line_number":231,"context_line":"    def get(self, credential_id: str):"},{"line_number":232,"context_line":"        \"\"\"Create new credentials."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        POST /v3/credentials"},{"line_number":235,"context_line":"        \"\"\""},{"line_number":236,"context_line":"        # Get Credential."},{"line_number":237,"context_line":"        ENFORCER.enforce_call("},{"line_number":238,"context_line":"            action\u003d\u0027identity:get_credential\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"07b2d01a_1bc3944b","line":235,"range":{"start_line":232,"start_character":8,"end_line":235,"end_character":11},"updated":"2024-08-01 15:46:16.000000000","message":"This comment header is for POST, but the function is for showing a single credential.","commit_id":"be8b79327def5d5844dcae7b1d3517dd7202e5f4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"40ef0784bfa7ce6de7cb0fb9fa641237df093e0a","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @validation.response_body_schema(schema.credential_response_body)"},{"line_number":231,"context_line":"    def get(self, credential_id: str):"},{"line_number":232,"context_line":"        \"\"\"Create new credentials."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        POST /v3/credentials"},{"line_number":235,"context_line":"        \"\"\""},{"line_number":236,"context_line":"        # Get Credential."},{"line_number":237,"context_line":"        ENFORCER.enforce_call("},{"line_number":238,"context_line":"            action\u003d\u0027identity:get_credential\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ef9f046d_cd342dfe","line":235,"range":{"start_line":232,"start_character":8,"end_line":235,"end_character":11},"in_reply_to":"07b2d01a_1bc3944b","updated":"2024-08-01 15:48:46.000000000","message":"Done","commit_id":"be8b79327def5d5844dcae7b1d3517dd7202e5f4"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"8997a00815bb99aa6a771fc1fb1f548169191716","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @validation.response_body_schema(schema.credential_response_body)"},{"line_number":231,"context_line":"    def get(self, credential_id: str):"},{"line_number":232,"context_line":"        \"\"\"Create new credentials."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        GET /v3/credentials/{credential_id}"},{"line_number":235,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7db2969e_84113d17","line":232,"range":{"start_line":232,"start_character":11,"end_line":232,"end_character":21},"updated":"2024-09-27 14:29:20.000000000","message":"s/Create new/Retrieve existing/","commit_id":"5e7ef45106c96cc046138b88f6c61d2754f5977d"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"027210f687c6a14e445b0a324dfe05628a9f9e99","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @validation.response_body_schema(schema.credential_response_body)"},{"line_number":231,"context_line":"    def get(self, credential_id: str):"},{"line_number":232,"context_line":"        \"\"\"Create new credentials."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        GET /v3/credentials/{credential_id}"},{"line_number":235,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"05c1db30_7f4e66f3","line":232,"range":{"start_line":232,"start_character":11,"end_line":232,"end_character":21},"in_reply_to":"7db2969e_84113d17","updated":"2024-09-27 16:02:25.000000000","message":"Done","commit_id":"5e7ef45106c96cc046138b88f6c61d2754f5977d"}]}