)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"1a41109ad21380e883571f0b8c915a5199a2ca7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ac0ec7d_6a56ec72","updated":"2024-10-01 09:23:08.000000000","message":"There should be unit tests for this. Without unit tests it will get broken again and nobody will notice until the next upgrade.","commit_id":"2b8e1175e5535a11a420b9285fc9fc281a1ce362"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"57bc0c177cf1c3858d5b7e3011824cc98557d965","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6670d559_e1b7dda5","in_reply_to":"0ac0ec7d_6a56ec72","updated":"2024-10-02 16:51:11.000000000","message":"While I do agree, at the moment there\u0027re just no tests around upgrades at all. So I\u0027m kind of on the fence time wise, since it\u0027s not actually about adding a specific test case, but covering whole migrations with tests kinda.\n\nAnd I\u0027m not able to justify spent time on that activity right now.","commit_id":"2b8e1175e5535a11a420b9285fc9fc281a1ce362"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2ded8415539ca561463c597fb88906e848a9f9ba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85e94a61_d1eb119d","in_reply_to":"6670d559_e1b7dda5","updated":"2024-10-04 22:01:03.000000000","message":"I\u0027d suggest adding a tests with a follow-up, as Keystone DB sync check is pretty much broken for a while, which is nasty...\n\nWith that I will try to find some time soonish for creating some testing around this as a follow-up.","commit_id":"2b8e1175e5535a11a420b9285fc9fc281a1ce362"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"66596f9187cc614c8ede9f8fdbbaf3e389e13cfa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6e24d86_0013ee7c","in_reply_to":"85e94a61_d1eb119d","updated":"2025-04-30 12:56:49.000000000","message":"Since upgrades are essentially broken without this I\u0027m in favor of merging without the unit tests and adding them as a follow-up.","commit_id":"2b8e1175e5535a11a420b9285fc9fc281a1ce362"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"55b10f5740bc2f032070719e1d30bcd9c0362bc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57f7c24b_0f1b5616","updated":"2025-05-01 10:39:00.000000000","message":"I think I\u0027ll go ahead and propose backports to 2024.1 at the same time... To save a bit review time","commit_id":"5125d9feed8dc8f9f0ad01f4c042594475f5fb84"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f53e6a3067c1c47657adf9aa9245d7174577d90f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2da70997_ca249c27","updated":"2025-04-30 08:18:36.000000000","message":"So pretty much keystone upgrades are still pretty much borked. Just got https://bugs.launchpad.net/openstack-ansible/+bug/2109672 related to this.","commit_id":"5125d9feed8dc8f9f0ad01f4c042594475f5fb84"}]}