)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"57baf55777597ea3d6ec563d82754d0bb3a3ee4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"534fa752_e834c1d8","updated":"2025-01-09 13:40:59.000000000","message":"recheck codegenerator adapted","commit_id":"055492f6eb4eca5c387609d8547117c1d15707cd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"90977421a32048fdda699a78ffbe2c5193828bb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"23de5b32_fa0473a4","updated":"2025-01-08 08:13:35.000000000","message":"recheck expired logs","commit_id":"055492f6eb4eca5c387609d8547117c1d15707cd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"266c489cd782419955c48fb718b960fc6028a6ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"948f8389_87efd094","updated":"2025-02-05 14:32:21.000000000","message":"recheck the openapi job","commit_id":"5ec777fa37dc7acc7736afafa3e9aad95529a090"}],"keystone/api/os_federation.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"1cc5ee9a72cdded244d250d7ed05b1c0469b4726","unresolved":true,"context_lines":[{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    _id_path_param_name_override \u003d \u0027idp_id\u0027"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @validation.request_query_schema("},{"line_number":151,"context_line":"        schema.identity_provider_index_request_query"},{"line_number":152,"context_line":"    )"},{"line_number":153,"context_line":"    @validation.response_body_schema("}],"source_content_type":"text/x-python","patch_set":7,"id":"6b5da4c6_f16ae63c","line":150,"updated":"2024-11-15 13:51:08.000000000","message":"here you still use index query parameters for show operation","commit_id":"380c34fa66110295df2c9e56b0a213aa7e92d38a"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"877562fb6ae07dc379464b60000760dc11d7f669","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    )"},{"line_number":148,"context_line":"    _id_path_param_name_override \u003d \u0027idp_id\u0027"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @validation.request_query_schema("},{"line_number":151,"context_line":"        schema.identity_provider_index_request_query"},{"line_number":152,"context_line":"    )"},{"line_number":153,"context_line":"    @validation.response_body_schema("}],"source_content_type":"text/x-python","patch_set":7,"id":"31ee808b_cfd6a82d","line":150,"in_reply_to":"6b5da4c6_f16ae63c","updated":"2024-12-05 21:10:06.000000000","message":"Done","commit_id":"380c34fa66110295df2c9e56b0a213aa7e92d38a"}],"keystone/federation/schema.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fa888e709b7f86df412e37ced0a8abf0db4ce7bf","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        \"type\": \"string\","},{"line_number":82,"context_line":"        \"description\": \"The identity provider description\","},{"line_number":83,"context_line":"    },"},{"line_number":84,"context_line":"    \"authorization_ttl\": {"},{"line_number":85,"context_line":"        \"type\": \"integer\","},{"line_number":86,"context_line":"        \"description\": ("},{"line_number":87,"context_line":"            \"The length of validity in minutes for group memberships \""}],"source_content_type":"text/x-python","patch_set":1,"id":"062f5de8_a70f1d87","line":84,"updated":"2024-10-04 15:36:26.000000000","message":"after you fix the links you\u0027ll see this one starting to fail. Reason is that it is an optional parameter which may be included in the output being \"null\" - known stuff as with some other params.","commit_id":"ce1d149695027ac1ea9fad611e9598823bae39af"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"9c093a0e8b0732c76bce2629b54fe35fa59e67f0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        \"type\": \"string\","},{"line_number":82,"context_line":"        \"description\": \"The identity provider description\","},{"line_number":83,"context_line":"    },"},{"line_number":84,"context_line":"    \"authorization_ttl\": {"},{"line_number":85,"context_line":"        \"type\": \"integer\","},{"line_number":86,"context_line":"        \"description\": ("},{"line_number":87,"context_line":"            \"The length of validity in minutes for group memberships \""}],"source_content_type":"text/x-python","patch_set":1,"id":"8a24981e_05378740","line":84,"in_reply_to":"062f5de8_a70f1d87","updated":"2024-10-23 19:02:11.000000000","message":"Done","commit_id":"ce1d149695027ac1ea9fad611e9598823bae39af"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fa888e709b7f86df412e37ced0a8abf0db4ce7bf","unresolved":true,"context_lines":[{"line_number":127,"context_line":"            \"items\": identity_provider_schema,"},{"line_number":128,"context_line":"            \"description\": \"A list of identity provider objects\","},{"line_number":129,"context_line":"        },"},{"line_number":130,"context_line":"        \"links\": response_types.links,"},{"line_number":131,"context_line":"    },"},{"line_number":132,"context_line":"    \"additionalProperties\": True,"},{"line_number":133,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"81734093_0d884c7d","line":130,"updated":"2024-10-04 15:36:26.000000000","message":"links of the IDP return additional field \"protocols\" - see example under https://docs.openstack.org/api-ref/identity/v3-ext/#list-identity-providers I suggest you create here a local param_type links which extends the `{**response_types.links, \"protocols\": {\"type\":\"string\"}`","commit_id":"ce1d149695027ac1ea9fad611e9598823bae39af"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"9c093a0e8b0732c76bce2629b54fe35fa59e67f0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            \"items\": identity_provider_schema,"},{"line_number":128,"context_line":"            \"description\": \"A list of identity provider objects\","},{"line_number":129,"context_line":"        },"},{"line_number":130,"context_line":"        \"links\": response_types.links,"},{"line_number":131,"context_line":"    },"},{"line_number":132,"context_line":"    \"additionalProperties\": True,"},{"line_number":133,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"2b1cc627_274666a9","line":130,"in_reply_to":"81734093_0d884c7d","updated":"2024-10-23 19:02:11.000000000","message":"Done","commit_id":"ce1d149695027ac1ea9fad611e9598823bae39af"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"552124e4ed05839168a0065b30c4abc9a3580e67","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"_identity_provider_properties \u003d {"},{"line_number":86,"context_line":"    \"enabled\": {"},{"line_number":87,"context_line":"        \"type\": parameter_types.boolean,"},{"line_number":88,"context_line":"        \"description\": \"Whether the identity provider is enabled or not\","},{"line_number":89,"context_line":"    },"},{"line_number":90,"context_line":"    \"description\": {"}],"source_content_type":"text/x-python","patch_set":6,"id":"c7f513a3_bb19fb0f","line":87,"updated":"2024-10-25 20:28:22.000000000","message":"I realize I placed all of the parameter_types wrong, I will be fixing this. Right now it would be `\"type\": {\"type\": ...}`","commit_id":"3cb43bcbae02ef031e14b8718526eb6047696a89"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"52c6927bda6698a62e5a196c66cef6534ff0708a","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"_identity_provider_properties \u003d {"},{"line_number":86,"context_line":"    \"enabled\": {"},{"line_number":87,"context_line":"        \"type\": parameter_types.boolean,"},{"line_number":88,"context_line":"        \"description\": \"Whether the identity provider is enabled or not\","},{"line_number":89,"context_line":"    },"},{"line_number":90,"context_line":"    \"description\": {"}],"source_content_type":"text/x-python","patch_set":6,"id":"5dec6fb2_46dbaf98","line":87,"in_reply_to":"c7f513a3_bb19fb0f","updated":"2024-10-31 17:45:44.000000000","message":"Done","commit_id":"3cb43bcbae02ef031e14b8718526eb6047696a89"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"1cc5ee9a72cdded244d250d7ed05b1c0469b4726","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"identity_provider_index_request_query: dict[str, Any] \u003d {"},{"line_number":128,"context_line":"    \"type\": \"object\","},{"line_number":129,"context_line":"    \"properties\": {},"},{"line_number":130,"context_line":"    \"additionalProperties\": True,"},{"line_number":131,"context_line":"}"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dae72be1_0e92eb9b","line":129,"updated":"2024-11-15 13:51:08.000000000","message":"it is possible to filter IDPs by `id` and `enabled` flag (https://docs.openstack.org/api-ref/identity/v3-ext/#id281)","commit_id":"380c34fa66110295df2c9e56b0a213aa7e92d38a"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"877562fb6ae07dc379464b60000760dc11d7f669","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"identity_provider_index_request_query: dict[str, Any] \u003d {"},{"line_number":128,"context_line":"    \"type\": \"object\","},{"line_number":129,"context_line":"    \"properties\": {},"},{"line_number":130,"context_line":"    \"additionalProperties\": True,"},{"line_number":131,"context_line":"}"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"08220333_67890ef9","line":129,"in_reply_to":"dae72be1_0e92eb9b","updated":"2024-12-05 21:10:06.000000000","message":"Done","commit_id":"380c34fa66110295df2c9e56b0a213aa7e92d38a"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"1cc5ee9a72cdded244d250d7ed05b1c0469b4726","unresolved":true,"context_lines":[{"line_number":172,"context_line":"                },"},{"line_number":173,"context_line":"            },"},{"line_number":174,"context_line":"            \"additionalProperties\": False,"},{"line_number":175,"context_line":"        },"},{"line_number":176,"context_line":"    },"},{"line_number":177,"context_line":"    \"additionalProperties\": False,"},{"line_number":178,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"f8874238_e448f275","line":175,"updated":"2024-11-15 13:51:08.000000000","message":"please mark required properties","commit_id":"380c34fa66110295df2c9e56b0a213aa7e92d38a"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"877562fb6ae07dc379464b60000760dc11d7f669","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                },"},{"line_number":173,"context_line":"            },"},{"line_number":174,"context_line":"            \"additionalProperties\": False,"},{"line_number":175,"context_line":"        },"},{"line_number":176,"context_line":"    },"},{"line_number":177,"context_line":"    \"additionalProperties\": False,"},{"line_number":178,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"93399fee_06253023","line":175,"in_reply_to":"f8874238_e448f275","updated":"2024-12-05 21:10:06.000000000","message":"Confirmed with osc api that no required properties exist (all get default values):\n```\n❯ osc api identity OS-FEDERATION/identity_providers/test_idp -m put --os-cloud local\n{\"identity_provider\":{\"authorization_ttl\":null,\"description\":null,\"domain_id\":\"bad9607fc3e64b74af985629b2537178\",\"enabled\":false,\"id\":\"test_idp\",\"links\":{\"self\":\"http://localhost:5000/v3/OS-FEDERATION/identity_providers/test_idp\"},\"remote_ids\":[]}}\n```","commit_id":"380c34fa66110295df2c9e56b0a213aa7e92d38a"}]}