)]}'
{"id":"openstack%2Fkeystone~934727","triplet_id":"openstack%2Fkeystone~master~I0ffeaf032ccdfcd99da27719cf90451a5855af81","project":"openstack/keystone","branch":"master","attention_set":{},"removed_from_attention_set":{"16137":{"account":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"last_update":"2025-02-14 16:25:24.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0ffeaf032ccdfcd99da27719cf90451a5855af81","subject":"Unify response code for EC2_S3_Resource","status":"MERGED","created":"2024-11-12 08:51:54.000000000","updated":"2025-02-14 16:26:55.000000000","submitted":"2025-02-14 16:25:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"934727","meta_rev_id":"d31b1719f6a16ec5732534b752770fa1b83f7ffb","_number":934727,"virtual_id_number":934727,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-02-14 16:25:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"all":[{"value":2,"date":"2025-02-14 14:26:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":2,"date":"2025-02-11 13:30:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"all":[{"value":1,"date":"2025-02-14 14:26:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-12 09:45:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-11-12 10:14:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-11 13:30:55.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2025-02-14 14:26:37.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"}],"messages":[{"id":"5aa9d7aa17635d678b6b9e60c6d99d3742599daa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2024-11-12 08:51:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dc47c36e3b50b2fa0de786b26089dfca5629a2b1","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-12 09:45:01.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fdcf06943ea24a4f96de95ae2c02c92a\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/92d174d89dcb42a6aac4a390ceb37b14 : SUCCESS in 43m 08s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/d9d33189f46a4566bf4480b7103daed2 : SUCCESS in 50m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5cc6c893b98d3986e8701d18a54208583667babc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-12 10:14:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bd94051314bd4248b07e8732449f715e\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2cd62595ab5b4009af02c13a74d5b274 : SUCCESS in 13m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cc0c812e32d84b7499eab498b813973c : SUCCESS in 5m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/be7483d434d949aabb5bbd912147ba9b : SUCCESS in 11m 02s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/afbf43cdaa354e6abec72227ac2ecd16 : SUCCESS in 13m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5023e191eb0c45a591ca82860d658b15 : SUCCESS in 10m 49s\n- grenade https://zuul.opendev.org/t/openstack/build/e68ddc57f67843deac6d4fce2a2e49d6 : SUCCESS in 35m 37s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/62e986d1bd5246d6bc3752fda4c61f81 : SUCCESS in 1h 22m 03s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/3b2fec2073c04a66b1f57286c02a5340 : SUCCESS in 16m 15s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/5ac0693be3534959b8b091ef44941f82 : SUCCESS in 29m 52s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/c1c31ab8136d4c9d81933d5bf07c348a : FAILURE in 30m 20s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/b82bf7b7bc754998ba8482c69b3d2ecf : SUCCESS in 34m 15s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/91240f324b694cde938187505b510c7d : SUCCESS in 10m 56s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/88b943fa888f4d66ad20841f2bb7587c : FAILURE in 11m 36s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d837bd91b59a49a5ac1a78474d7f4e1c : SUCCESS in 37m 49s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/77126d621eca492bb6285a8e27051dca : FAILURE in 29m 37s (non-voting)\n- codegenerator-openapi-identity-tips-with-api-ref https://zuul.opendev.org/t/openstack/build/8fa1280889854cbbb1c1bd1f963953ea : SUCCESS in 3m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f9d74aff8f7e0fc174af3598667392c1cd190f8d","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2025-02-11 13:30:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a5f2a19454587b446b55f824bfbc79e0c0cacbd6","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2025-02-14 14:26:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"47500d054c42ed5cfbcbb1b259aaf417f5038f9b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-14 14:27:09.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"856ce2b08722eea8912971075ceeb47e2df1b305","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-14 16:25:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8651c5282d8f458fa4d42b572c17370d\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ad441d8939a844c5ad7f47d38fec6191 : SUCCESS in 6m 27s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/1edd24b93f0b451da3a6df8b581646fe : SUCCESS in 12m 34s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/23ac6fca155f459ab0f510bf072c54a5 : SUCCESS in 10m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0c9d0d017dc9423ba81b466ccc559d33 : SUCCESS in 11m 42s\n- grenade https://zuul.opendev.org/t/openstack/build/38b9a8866aa44a6eb2a067435a6b4614 : SUCCESS in 47m 57s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/16b4f25602264d5f897209f7ee6165d1 : SUCCESS in 1h 52m 50s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/79710f0471ec414fb8a89f86806245a6 : SUCCESS in 41m 32s\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/15d45e84546a4d1187b70d687ef26e17 : SUCCESS in 24m 51s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/74878d18b7284511a20fdcce42e26878 : SUCCESS in 56m 56s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/e1645c8f44e84e2784de20246ea89999 : FAILURE in 40m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9351aeb8a289f15da11924fa3b702c45ad047990","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-14 16:25:24.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"d31b1719f6a16ec5732534b752770fa1b83f7ffb","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-14 16:26:55.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f52c59bd49cd4338b2eb8d28a09d3e3e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4e28c8203ccc4a4283c4a743a7f61cb4 : SUCCESS in 1m 13s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ae4e54148a2b3594c7cb246c50ba956dce52fdc3","revisions":{"ae4e54148a2b3594c7cb246c50ba956dce52fdc3":{"kind":"REWORK","_number":1,"created":"2024-11-12 08:51:54.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/27/934727/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/27/934727/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/27/934727/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/27/934727/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/27/934727/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/27/934727/1"}}},"commit":{"parents":[{"commit":"6433f1ae1c094e58216360d191a21d956a80f658","subject":"Merge \"Complete getting rid of passlib\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/6433f1ae1c094e58216360d191a21d956a80f658"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.com","date":"2024-11-12 08:51:24.000000000","tz":60},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.com","date":"2024-11-12 08:51:39.000000000","tz":60},"subject":"Unify response code for EC2_S3_Resource","message":"Unify response code for EC2_S3_Resource\n\nWhen looking up the credential we dont catch the\nCredentialNotFound exception which causes us to\nreturn a 404 Not Found response code to the client\nwhich is fine, but since we dont catch it we also\noutput the entire exception to stderr.\n\nThis changes so that we instead catch the\nCredentialNotFound exception and raise a\nNotFound exception which retains the behaviour\nbut does not pollute the logs with long tracebacks.\n\nThis also addresses a security concern if the\ncredential is found but is of the wrong type we\nthrow an Unauthorized response code but say in\nthe message that the \"EC2 access key is not found\",\nthis could potentially be used for doing a enumeration\nattack trying to figure out if a credential exists\nor not.\n\nTo fix this we change the response code from\nUnauthorized to Not Found which makes it impossible\nto know which part of the code raised the error\nfrom the outside.\n\nCloses-Bug: #2077541\nChange-Id: I0ffeaf032ccdfcd99da27719cf90451a5855af81\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/ae4e54148a2b3594c7cb246c50ba956dce52fdc3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/ae4e54148a2b3594c7cb246c50ba956dce52fdc3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}