)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"4f5ff2fcc2b66d732ba512e27fb7245ccd5605b3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to appropriately set what attributes should be used depending upon what"},{"line_number":12,"context_line":"the \u0027query_scope\u0027 configuration setting"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I68eb741874990d8a67493224c81901b17727db44"},{"line_number":15,"context_line":"Closes-Bug: #1210141"},{"line_number":16,"context_line":"Partial-Bug: #1231488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_d1425667","line":14,"updated":"2014-05-15 05:05:27.000000000","message":"-1 for this one. The convention is to have the change-id as the last line of the commit. This is probably because a change id was generated after you made changes, since this is your first commit. Will be ok from next time. Please change the commit message,, putting this line at the very end, and resubmit. \ndescription: https://git.eclipse.org/r/Documentation/user-changeid.html#_description","commit_id":"3ba80b28937e26fa44ff55a64f5efdb3a0d7575f"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"bf86d72a6586a62c7073fa6b33e824660c17576b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to appropriately set what attributes should be used depending upon what"},{"line_number":12,"context_line":"the \u0027query_scope\u0027 configuration setting"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I68eb741874990d8a67493224c81901b17727db44"},{"line_number":15,"context_line":"Closes-Bug: #1210141"},{"line_number":16,"context_line":"Partial-Bug: #1231488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_b11f8a6b","line":14,"in_reply_to":"7adec928_d1425667","updated":"2014-05-15 05:17:52.000000000","message":"Sorry, seems like I was wrong. We need change-id to be in the footer, as it is here, so removing the -1.","commit_id":"3ba80b28937e26fa44ff55a64f5efdb3a0d7575f"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"4f5ff2fcc2b66d732ba512e27fb7245ccd5605b3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I68eb741874990d8a67493224c81901b17727db44"},{"line_number":15,"context_line":"Closes-Bug: #1210141"},{"line_number":16,"context_line":"Partial-Bug: #1231488"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_717c22b6","line":16,"updated":"2014-05-15 05:05:27.000000000","message":"Not sure if you should mention the partial bug here, this commit does not address that. But it is probably ok, Im not -1 ing for this.","commit_id":"3ba80b28937e26fa44ff55a64f5efdb3a0d7575f"}],"keystone/common/config.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"66aaa777de1d27698d183b0733b272ea12b4d31a","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        cfg.StrOpt(\u0027user_id_attribute\u0027, default\u003d\u0027cn\u0027,"},{"line_number":453,"context_line":"                   help\u003d\u0027LDAP attribute mapped to user id.  If \"query_scope\" \u0027"},{"line_number":454,"context_line":"                        \u0027is set to \"one\", then this attribute must be set to \u0027"},{"line_number":455,"context_line":"                        \u0027the LDAP attribute that is the left-most relative \u0027"},{"line_number":456,"context_line":"                        \u0027distinguished name (RDN) of the distinguished name \u0027"},{"line_number":457,"context_line":"                        \u0027(DN).  If \"query_scope\" is set to \"sub\", then this \u0027"},{"line_number":458,"context_line":"                        \u0027attribute may be set to any LDAP attribute; however  \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_9c035e41","line":455,"updated":"2014-05-18 16:36:56.000000000","message":"Suggest change \"that is\" to \"that is used as\"\n\nCould change \"LDAP attribute\" to \"attribute\" since the doc already used LDAP attribute.","commit_id":"d5feadd95f2c078a085aa7429739051e745f31a2"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"66aaa777de1d27698d183b0733b272ea12b4d31a","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                   help\u003d\u0027LDAP attribute mapped to user id.  If \"query_scope\" \u0027"},{"line_number":454,"context_line":"                        \u0027is set to \"one\", then this attribute must be set to \u0027"},{"line_number":455,"context_line":"                        \u0027the LDAP attribute that is the left-most relative \u0027"},{"line_number":456,"context_line":"                        \u0027distinguished name (RDN) of the distinguished name \u0027"},{"line_number":457,"context_line":"                        \u0027(DN).  If \"query_scope\" is set to \"sub\", then this \u0027"},{"line_number":458,"context_line":"                        \u0027attribute may be set to any LDAP attribute; however  \u0027"},{"line_number":459,"context_line":"                        \u0027listing user information will still result in \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_fc8d42d4","line":456,"updated":"2014-05-18 16:36:56.000000000","message":"suggest change \"distinguished name\" to \"user entry\u0027s distinguished name\"\n\nor even \"user entry\" since what else would the RDN be for?","commit_id":"d5feadd95f2c078a085aa7429739051e745f31a2"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"66aaa777de1d27698d183b0733b272ea12b4d31a","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                        \u0027the LDAP attribute that is the left-most relative \u0027"},{"line_number":456,"context_line":"                        \u0027distinguished name (RDN) of the distinguished name \u0027"},{"line_number":457,"context_line":"                        \u0027(DN).  If \"query_scope\" is set to \"sub\", then this \u0027"},{"line_number":458,"context_line":"                        \u0027attribute may be set to any LDAP attribute; however  \u0027"},{"line_number":459,"context_line":"                        \u0027listing user information will still result in \u0027"},{"line_number":460,"context_line":"                        \u0027displaying user id as the left-most RDN of the DN.\u0027),"},{"line_number":461,"context_line":"        cfg.StrOpt(\u0027user_name_attribute\u0027, default\u003d\u0027sn\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_bc873ab4","line":458,"updated":"2014-05-18 16:36:56.000000000","message":"Is this just saying that this configuration option is ignored if query_scope is sub?","commit_id":"d5feadd95f2c078a085aa7429739051e745f31a2"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"66aaa777de1d27698d183b0733b272ea12b4d31a","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                        \u0027(DN).  If \"query_scope\" is set to \"sub\", then this \u0027"},{"line_number":458,"context_line":"                        \u0027attribute may be set to any LDAP attribute; however  \u0027"},{"line_number":459,"context_line":"                        \u0027listing user information will still result in \u0027"},{"line_number":460,"context_line":"                        \u0027displaying user id as the left-most RDN of the DN.\u0027),"},{"line_number":461,"context_line":"        cfg.StrOpt(\u0027user_name_attribute\u0027, default\u003d\u0027sn\u0027,"},{"line_number":462,"context_line":"                   help\u003d\u0027LDAP attribute mapped to user name.\u0027),"},{"line_number":463,"context_line":"        cfg.StrOpt(\u0027user_mail_attribute\u0027, default\u003d\u0027email\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_7cb93278","line":460,"updated":"2014-05-18 16:36:56.000000000","message":"suggest change this line to\n\n displaying the user\u0027s id as the user entry\u0027s left-most RDN value.","commit_id":"d5feadd95f2c078a085aa7429739051e745f31a2"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"fcd7e631b7dd3c20c781059e969c80b406ead8ef","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                   help\u003d\u0027LDAP objectclass for users.\u0027),"},{"line_number":463,"context_line":"        cfg.StrOpt(\u0027user_id_attribute\u0027, default\u003d\u0027cn\u0027,"},{"line_number":464,"context_line":"                   help\u003d\u0027LDAP attribute mapped to user id.  If \"query_scope\" \u0027"},{"line_number":465,"context_line":"                        \u0027is set to \"one\", then this attribute must be set to \u0027"},{"line_number":466,"context_line":"                        \u0027the attribute that is used as the left-most relative \u0027"},{"line_number":467,"context_line":"                        \u0027distinguished name (RDN) of the user entry.  If \u0027"},{"line_number":468,"context_line":"                        \u0027\"query_scope\" is set to \"sub\", then this attribute \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_20604dce","line":465,"updated":"2014-06-04 18:29:15.000000000","message":"suggest changing \"attribute\" to \"option\": \u0027this attribute must be set to the attribute that is\u0027 is difficult to read/understand.","commit_id":"62e3912e6ded52d4997dac3e90c7418d1de43189"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"cba9030f75e62df98addafaed70b2c48992983b3","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                   help\u003d\u0027LDAP objectclass for users.\u0027),"},{"line_number":463,"context_line":"        cfg.StrOpt(\u0027user_id_attribute\u0027, default\u003d\u0027cn\u0027,"},{"line_number":464,"context_line":"                   help\u003d\u0027LDAP attribute mapped to user id.  If \"query_scope\" \u0027"},{"line_number":465,"context_line":"                        \u0027is set to \"one\", then this attribute must be set to \u0027"},{"line_number":466,"context_line":"                        \u0027the attribute that is used as the left-most relative \u0027"},{"line_number":467,"context_line":"                        \u0027distinguished name (RDN) of the user entry.  If \u0027"},{"line_number":468,"context_line":"                        \u0027\"query_scope\" is set to \"sub\", then this attribute \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_e7521035","line":465,"in_reply_to":"1ae5cdf2_20604dce","updated":"2014-07-25 09:10:11.000000000","message":"+1","commit_id":"62e3912e6ded52d4997dac3e90c7418d1de43189"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"91cce0f2884212698b360d92b3cb432b2ca0e597","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                   help\u003d\u0027LDAP objectclass for users.\u0027),"},{"line_number":463,"context_line":"        cfg.StrOpt(\u0027user_id_attribute\u0027, default\u003d\u0027cn\u0027,"},{"line_number":464,"context_line":"                   help\u003d\u0027LDAP attribute mapped to user id.  If \"query_scope\" \u0027"},{"line_number":465,"context_line":"                        \u0027is set to \"one\", then this attribute must be set to \u0027"},{"line_number":466,"context_line":"                        \u0027the attribute that is used as the left-most relative \u0027"},{"line_number":467,"context_line":"                        \u0027distinguished name (RDN) of the user entry.  If \u0027"},{"line_number":468,"context_line":"                        \u0027\"query_scope\" is set to \"sub\", then this attribute \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_143c05c0","line":465,"in_reply_to":"1ae5cdf2_20604dce","updated":"2014-08-06 07:50:26.000000000","message":"Done","commit_id":"62e3912e6ded52d4997dac3e90c7418d1de43189"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"fcd7e631b7dd3c20c781059e969c80b406ead8ef","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                        \u0027the attribute that is used as the left-most relative \u0027"},{"line_number":467,"context_line":"                        \u0027distinguished name (RDN) of the user entry.  If \u0027"},{"line_number":468,"context_line":"                        \u0027\"query_scope\" is set to \"sub\", then this attribute \u0027"},{"line_number":469,"context_line":"                        \u0027may be set to any LDAP attribute; however, listing \u0027"},{"line_number":470,"context_line":"                        \u0027user information will still result in displaying the \u0027"},{"line_number":471,"context_line":"                        \u0027user\\\u0027s id as the user entry\\\u0027s left-most RDN \u0027"},{"line_number":472,"context_line":"                        \u0027value.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_40b47934","line":469,"updated":"2014-06-04 18:29:15.000000000","message":"\"Any\" attribute? Are there any restrictions? Is this option just ignored if query_scope is set to \u0027sub\u0027?","commit_id":"62e3912e6ded52d4997dac3e90c7418d1de43189"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"cba9030f75e62df98addafaed70b2c48992983b3","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                        \u0027the attribute that is used as the left-most relative \u0027"},{"line_number":467,"context_line":"                        \u0027distinguished name (RDN) of the user entry.  If \u0027"},{"line_number":468,"context_line":"                        \u0027\"query_scope\" is set to \"sub\", then this attribute \u0027"},{"line_number":469,"context_line":"                        \u0027may be set to any LDAP attribute; however, listing \u0027"},{"line_number":470,"context_line":"                        \u0027user information will still result in displaying the \u0027"},{"line_number":471,"context_line":"                        \u0027user\\\u0027s id as the user entry\\\u0027s left-most RDN \u0027"},{"line_number":472,"context_line":"                        \u0027value.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_0750e42a","line":469,"in_reply_to":"1ae5cdf2_40b47934","updated":"2014-07-25 09:10:11.000000000","message":"+1","commit_id":"62e3912e6ded52d4997dac3e90c7418d1de43189"}]}
