)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"d96b43926b8ac657a4f7263fd39334d4cd845f3d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We need to use only creation from `metadata` for several reasons:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* `create_all` have better performance than migrations usage. This is"},{"line_number":12,"context_line":"important because Keystone has critical low tests performance."},{"line_number":13,"context_line":"* We prepare to use Alembic to migrations applying. Alembic doesn\u0027t"},{"line_number":14,"context_line":"support SQLite."},{"line_number":15,"context_line":"* With implementation of I47444c4944f08535227718e368a1950c45c6cb32 we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"baada198_aa2598ae","line":12,"updated":"2014-08-06 21:33:18.000000000","message":"I tried this and didn\u0027t see any improvement in performance.","commit_id":"82e565f0d7f6160751764ffa7b457ef922e897cf"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"c53031fa248666e678ca4eb47fe0a1ffd9a0426b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We need to use only creation from `metadata` for several reasons:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* `create_all` have better performance than migrations usage. This is"},{"line_number":12,"context_line":"important because Keystone has critical low tests performance."},{"line_number":13,"context_line":"* We prepare to use Alembic to migrations applying. Alembic doesn\u0027t"},{"line_number":14,"context_line":"support SQLite."},{"line_number":15,"context_line":"* With implementation of I47444c4944f08535227718e368a1950c45c6cb32 we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"baada198_41d21634","line":12,"in_reply_to":"baada198_aa2598ae","updated":"2014-08-07 08:22:40.000000000","message":"Thanks. Ok, this topic is not necessarily must be here.","commit_id":"82e565f0d7f6160751764ffa7b457ef922e897cf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"d96b43926b8ac657a4f7263fd39334d4cd845f3d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"* `create_all` have better performance than migrations usage. This is"},{"line_number":12,"context_line":"important because Keystone has critical low tests performance."},{"line_number":13,"context_line":"* We prepare to use Alembic to migrations applying. Alembic doesn\u0027t"},{"line_number":14,"context_line":"support SQLite."},{"line_number":15,"context_line":"* With implementation of I47444c4944f08535227718e368a1950c45c6cb32 we"},{"line_number":16,"context_line":"guarantee identity of models and migrations, so `create_all` will be"},{"line_number":17,"context_line":"totally safe."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"baada198_ea1f9058","line":14,"updated":"2014-08-06 21:33:18.000000000","message":"This seems like a blocker for switching to alembic.","commit_id":"82e565f0d7f6160751764ffa7b457ef922e897cf"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"c53031fa248666e678ca4eb47fe0a1ffd9a0426b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"* `create_all` have better performance than migrations usage. This is"},{"line_number":12,"context_line":"important because Keystone has critical low tests performance."},{"line_number":13,"context_line":"* We prepare to use Alembic to migrations applying. Alembic doesn\u0027t"},{"line_number":14,"context_line":"support SQLite."},{"line_number":15,"context_line":"* With implementation of I47444c4944f08535227718e368a1950c45c6cb32 we"},{"line_number":16,"context_line":"guarantee identity of models and migrations, so `create_all` will be"},{"line_number":17,"context_line":"totally safe."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"baada198_ac0e8931","line":14,"in_reply_to":"baada198_ea1f9058","updated":"2014-08-07 08:22:40.000000000","message":"I have tried to run \"Models comparison\" without this patch in dependencies, it runs well, so it seems to be not a blocker. Maybe it was, but now it is ok to be separated.","commit_id":"82e565f0d7f6160751764ffa7b457ef922e897cf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5cf629002664afca9adc317234b299fadb5c7938","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use metadata.create_all() to fill a test database"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need to use only creation from `metadata` for several reasons:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"With implementation of I47444c4944f08535227718e368a1950c45c6cb32 we"},{"line_number":12,"context_line":"guarantee identity of models and migrations, so `create_all` will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1abeadc6_b41e87b9","line":9,"updated":"2014-08-21 01:30:44.000000000","message":"No reason is given.","commit_id":"e323e2e7475b9206987123d58b3abf0ee6453da7"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"3d4e9e44506ed5a0820290d58d89b8372bee4498","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use metadata.create_all() to fill a test database"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need to use only creation from `metadata` for several reasons:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"With implementation of I47444c4944f08535227718e368a1950c45c6cb32 we"},{"line_number":12,"context_line":"guarantee identity of models and migrations, so `create_all` will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1abeadc6_8177e69e","line":9,"in_reply_to":"1abeadc6_b41e87b9","updated":"2014-08-26 13:14:07.000000000","message":"Sorry. I have rephrased the message.","commit_id":"e323e2e7475b9206987123d58b3abf0ee6453da7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5cf629002664afca9adc317234b299fadb5c7938","unresolved":false,"context_lines":[{"line_number":13,"context_line":"totally safe."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ief6a4c5fec8143a4b9698e215b091ebbac880fb7"},{"line_number":16,"context_line":"Closes-Bug: #1319370"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1abeadc6_d41b03c8","line":16,"updated":"2014-08-21 01:30:44.000000000","message":"How does this fix the bug?","commit_id":"e323e2e7475b9206987123d58b3abf0ee6453da7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"33310838d595d0fb878557913d9dc3ca5f4fd28c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use metadata.create_all() to fill a test database"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since implementation of I47444c4944f08535227718e368a1950c45c6cb32 we"},{"line_number":10,"context_line":"guarantee identity of models and migrations, so `create_all` will be"},{"line_number":11,"context_line":"totally safe. So we don\u0027t need to synchronize migrations before tests"},{"line_number":12,"context_line":"start."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"baa201ad_87dce674","line":9,"updated":"2014-10-05 13:42:38.000000000","message":"https://review.openstack.org/#/c/80630/ isn\u0027t merged yet.","commit_id":"c84d5630afd77def5c649136a9a7988a5d46582f"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"465696c6e0d0db0a3a77431626ef27a87e2fcbb0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use metadata.create_all() to fill a test database"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since implementation of I47444c4944f08535227718e368a1950c45c6cb32 we"},{"line_number":10,"context_line":"guarantee identity of models and migrations, so `create_all` will be"},{"line_number":11,"context_line":"totally safe. So we don\u0027t need to synchronize migrations before tests"},{"line_number":12,"context_line":"start."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"baa201ad_6b9decbb","line":9,"in_reply_to":"baa201ad_87dce674","updated":"2014-10-07 08:03:20.000000000","message":"Good point, these patches should be dependent. Thank you!","commit_id":"c84d5630afd77def5c649136a9a7988a5d46582f"}],"keystone/tests/ksfixtures/database.py":[{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"dbe217aa7db751ed5e898f8a947ca91fae5ab843","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    return wrapper"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _setup_database(extensions\u003dNone):"},{"line_number":46,"context_line":"    if CONF.database.connection !\u003d tests.IN_MEM_DB_CONN_STRING:"},{"line_number":47,"context_line":"        db \u003d tests.dirs.tmp(\u0027test.db\u0027)"},{"line_number":48,"context_line":"        pristine \u003d tests.dirs.tmp(\u0027test.db.pristine\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_5a855805","side":"PARENT","line":45,"updated":"2014-07-11 18:55:05.000000000","message":"The commit message did not mention about the removal of this function.","commit_id":"ed9838c64117ffece5a35ce2bca89507dcf25128"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"9c3508666abfd8afff2ca0aacab87030859bbbfd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    return wrapper"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _setup_database(extensions\u003dNone):"},{"line_number":46,"context_line":"    if CONF.database.connection !\u003d tests.IN_MEM_DB_CONN_STRING:"},{"line_number":47,"context_line":"        db \u003d tests.dirs.tmp(\u0027test.db\u0027)"},{"line_number":48,"context_line":"        pristine \u003d tests.dirs.tmp(\u0027test.db.pristine\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_16a47406","side":"PARENT","line":45,"in_reply_to":"baada198_5a855805","updated":"2014-07-14 10:17:07.000000000","message":"Done","commit_id":"ed9838c64117ffece5a35ce2bca89507dcf25128"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"dbe217aa7db751ed5e898f8a947ca91fae5ab843","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def setUp(self):"},{"line_number":118,"context_line":"        super(Database, self).setUp()"},{"line_number":119,"context_line":"        _setup_database(extensions\u003dself._extensions)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        self.engine \u003d sql.get_engine()"},{"line_number":122,"context_line":"        sql.ModelBase.metadata.create_all(bind\u003dself.engine)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_3a97c43b","side":"PARENT","line":119,"updated":"2014-07-11 18:55:05.000000000","message":"Same comment as above","commit_id":"ed9838c64117ffece5a35ce2bca89507dcf25128"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"9c3508666abfd8afff2ca0aacab87030859bbbfd","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def setUp(self):"},{"line_number":118,"context_line":"        super(Database, self).setUp()"},{"line_number":119,"context_line":"        _setup_database(extensions\u003dself._extensions)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        self.engine \u003d sql.get_engine()"},{"line_number":122,"context_line":"        sql.ModelBase.metadata.create_all(bind\u003dself.engine)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_d69d9cbd","side":"PARENT","line":119,"in_reply_to":"baada198_3a97c43b","updated":"2014-07-14 10:17:07.000000000","message":"Done","commit_id":"ed9838c64117ffece5a35ce2bca89507dcf25128"}]}