)]}'
{"keystone/auth/controllers.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"75ff58cf84419f7d63f6cd30d90b02efa7b8281f","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            msg \u003d _(\u0027User not found\u0027)"},{"line_number":434,"context_line":"            raise exception.Unauthorized(msg)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        # TODO(nkinder) emit a CADF notification in addition to logging"},{"line_number":437,"context_line":"        # successful token issuance.  We should probably emit a notification"},{"line_number":438,"context_line":"        # for failed authentication as well."},{"line_number":439,"context_line":"        msg \u003d _(\u0027Issued token for user %(u_id)s\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_e7d9d023","line":436,"updated":"2014-05-20 17:33:12.000000000","message":"really should change \"in addition to \"  to \"in place of\"  as logging is not the right approach for audit.","commit_id":"22bae42b5897440de12a5340ce32b8a2770bda9f"}],"keystone/token/controllers.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"23273828048db8790ff4773adedd87eb097b9647","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            auth_token_data, roles_ref\u003droles_ref, catalog_ref\u003dcatalog_ref)"},{"line_number":132,"context_line":"        msg \u003d _(\u0027Issued token for user %(u_id)s\u0027)"},{"line_number":133,"context_line":"        msg \u003d msg % {\u0027u_id\u0027: user_ref[\u0027id\u0027]}"},{"line_number":134,"context_line":"        LOG.info(msg)"},{"line_number":135,"context_line":"        return token_data"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _authenticate_token(self, context, auth):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_3f8f5f76","line":134,"updated":"2014-05-19 19:09:07.000000000","message":"If we do this I think it should be done for v2 and v3 consistently. Also, I think this is something that can be done with the cadf notifications framework: \n\nhttps://github.com/openstack/keystone/blob/master/keystone/notifications.py#L228-L232","commit_id":"1fc9311cc0a729b3ff35c5c3ee3bc02bd2e687f1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6742f7b77dfcc9035175b8bb9e714912d3168b15","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        (token_id, token_data) \u003d self.token_provider_api.issue_v2_token("},{"line_number":131,"context_line":"            auth_token_data, roles_ref\u003droles_ref, catalog_ref\u003dcatalog_ref)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        msg \u003d _(\u0027Issued token for user %(u_id)s\u0027)"},{"line_number":134,"context_line":"        msg \u003d msg % {\u0027u_id\u0027: user_ref[\u0027id\u0027]}"},{"line_number":135,"context_line":"        LOG.info(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_1eb52dd0","line":132,"updated":"2014-05-20 16:04:54.000000000","message":"So, maybe we should add a note here saying that we should also handle this with cadf notifications? I think that sending a formal notification following the cadf convention here would be useful. http://www.dmtf.org/standards/cadf\n\nIn both cases, when authentication fails and when it\u0027s successful, that could be important auditing information.","commit_id":"e8b17192ec88fd55e8014723affec401bf17887e"}]}