)]}'
{"keystone/auth/controllers.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"87420d0d43e6c086a834a33a372ddd7bc4179545","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # ensure the project domain is enabled"},{"line_number":120,"context_line":"        domain_ref \u003d self.assignment_api.get_domain(project_ref[\u0027domain_id\u0027])"},{"line_number":121,"context_line":"        self._assert_domain_is_enabled(domain_ref)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def _assert_domain_is_enabled(self, domain_ref):"},{"line_number":124,"context_line":"        if not domain_ref.get(\u0027enabled\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_f41ddc74","line":121,"updated":"2014-05-27 21:47:56.000000000","message":"This should only be done if the user\u0027s domain !\u003d the project domain.  If the user domain and project domain are the same this is a superfluous check (and round trip) to the backend.","commit_id":"211018243ff46e81e96c6e4b1fecc496fe76dbb0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c1f893559f1a199a3e5a27aeabb8adfe31b8353a","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            LOG.exception(e)"},{"line_number":166,"context_line":"            raise exception.Unauthorized(e)"},{"line_number":167,"context_line":"        self._assert_project_is_enabled(project_ref)"},{"line_number":168,"context_line":"        self._assert_domain_is_enabled(domain_ref)"},{"line_number":169,"context_line":"        return project_ref"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _lookup_trust(self, trust_info):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_64cf1380","line":168,"updated":"2014-05-29 16:08:57.000000000","message":"if project_name was specified \u003e lookup_domain already calls assert_domain_is_enabled.\n\nso this line should only go in the else block.\n\nBut I suggest adding a comment or todo explaining why it\u0027s only needed there.","commit_id":"943e26516e60740bac346e655da42096095f4261"}]}
