)]}'
{"keystone/assignment/backends/ldap.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8adabbaef0eead4a5b0cfa732cbfe12925b3dab1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      domain_id\u003dNone, group_id\u003dNone):"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        def _get_roles_for_just_user_and_project(user_id, tenant_id):"},{"line_number":90,"context_line":"            self.get_project(tenant_id)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"            proj_dn \u003d self.project._id_to_dn(tenant_id)"},{"line_number":93,"context_line":"            assignments \u003d self.role.get_role_assignments(proj_dn)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_0466bd29","line":90,"updated":"2014-05-20 15:45:53.000000000","message":"Looking at this it could probably be refactored from \u0027tenant_id\u0027 to \u0027project_id\u0027 like _get_roles_for_group_and_project below. Doesn\u0027t have to be done now, just noticing it.","commit_id":"a41bf2098895a4a3ec98f7ca45f10fea8df48b56"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8adabbaef0eead4a5b0cfa732cbfe12925b3dab1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                    continue"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"                role_id \u003d self.role._dn_to_id(assignment.role_dn)"},{"line_number":112,"context_line":"                roles.append(role_id)"},{"line_number":113,"context_line":"            return roles"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        def _get_roles_for_group_and_project(group_id, project_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_e47ab1b8","line":112,"updated":"2014-05-20 15:45:53.000000000","message":"Could make this like the one below for consistency. \n\n    roles.append(self.role._dn_to_id(assignment.role_dn))","commit_id":"a41bf2098895a4a3ec98f7ca45f10fea8df48b56"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8adabbaef0eead4a5b0cfa732cbfe12925b3dab1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                    continue"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"                roles.append(self.role._dn_to_id(assignment.role_dn))"},{"line_number":138,"context_line":"            return roles"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        if domain_id is not None:"},{"line_number":141,"context_line":"            msg \u003d _(\u0027Domain metadata not supported by LDAP\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_c4569529","line":138,"updated":"2014-05-20 15:45:53.000000000","message":"These two methods are pretty similar but not sure what would be the best way to combine them it we did. It would be cool to have one method that handed the logic for both cases.","commit_id":"a41bf2098895a4a3ec98f7ca45f10fea8df48b56"}]}