)]}'
{"keystone/catalog/controllers.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"25934eabd32a646c10a5c16616034dd3af02efe6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            ref \u003d self._assign_unique_id(ref)"},{"line_number":167,"context_line":"        if ref[\u0027id\u0027] \u003d\u003d \u0027\u0027:"},{"line_number":168,"context_line":"            raise exception.ValidationError("},{"line_number":169,"context_line":"                _(\u0027region ID must not be empty\u0027))"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        ref \u003d self.catalog_api.create_region(ref)"},{"line_number":172,"context_line":"        return wsgi.render_response("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_6b2b6d30","line":169,"updated":"2014-06-02 18:35:39.000000000","message":"Suggest combining this with line 164 to be something like:\n\n    if not ref.get(\u0027id\u0027):\n\nThis will catch situations where id is None, etc.","commit_id":"26724e5e85050e146fbe5796b2ba926b585c16ad"},{"author":{"_account_id":11425,"name":"Kévin Bernard-Allies","email":"kbernard-allies@bajoo.fr","username":"BAK"},"change_message_id":"7d554e52c87adff610386cb148a25f6e2ad50703","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            ref \u003d self._assign_unique_id(ref)"},{"line_number":167,"context_line":"        if ref[\u0027id\u0027] \u003d\u003d \u0027\u0027:"},{"line_number":168,"context_line":"            raise exception.ValidationError("},{"line_number":169,"context_line":"                _(\u0027region ID must not be empty\u0027))"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        ref \u003d self.catalog_api.create_region(ref)"},{"line_number":172,"context_line":"        return wsgi.render_response("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_78fdef39","line":169,"in_reply_to":"1ae5cdf2_6b2b6d30","updated":"2014-06-03 07:57:34.000000000","message":"In the second case, id is explicitly set to an empty value, so we can think it\u0027s desired.\nShould we assign a new id, or return an error ?","commit_id":"26724e5e85050e146fbe5796b2ba926b585c16ad"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b8fd0dde595682709ee2de9a3ade71d36e5d7457","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            ref \u003d self._assign_unique_id(ref)"},{"line_number":167,"context_line":"        if ref[\u0027id\u0027] \u003d\u003d \u0027\u0027:"},{"line_number":168,"context_line":"            raise exception.ValidationError("},{"line_number":169,"context_line":"                _(\u0027region ID must not be empty\u0027))"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        ref \u003d self.catalog_api.create_region(ref)"},{"line_number":172,"context_line":"        return wsgi.render_response("}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0eff1802","line":169,"in_reply_to":"1ae5cdf2_78fdef39","updated":"2014-07-19 15:08:08.000000000","message":"I\u0027d suggest the change Morgan proposes would work well, let\u0027s assign an ID if is missing or an  empty string","commit_id":"26724e5e85050e146fbe5796b2ba926b585c16ad"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d77cbdcbdc690716daadcac5d700a6dbcd225b96","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            ref \u003d self._assign_unique_id(ref)"},{"line_number":167,"context_line":"        if ref[\u0027id\u0027] \u003d\u003d \u0027\u0027:"},{"line_number":168,"context_line":"            raise exception.ValidationError("},{"line_number":169,"context_line":"                _(\u0027region ID must not be empty\u0027))"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        ref \u003d self.catalog_api.create_region(ref)"},{"line_number":172,"context_line":"        return wsgi.render_response("}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_014d2972","line":169,"in_reply_to":"baada198_0eff1802","updated":"2014-07-19 17:23:44.000000000","message":"I agree with Morgan and Henry.","commit_id":"26724e5e85050e146fbe5796b2ba926b585c16ad"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"31936358baec8631f2a174b4507d74e0576b10b4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        ref \u003d self._normalize_dict(region)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if not ref.get(\u0027id\u0027):"},{"line_number":166,"context_line":"            ref \u003d self._assign_unique_id(ref)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        ref \u003d self.catalog_api.create_region(ref)"},{"line_number":169,"context_line":"        return wsgi.render_response("}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_4269bc23","line":166,"updated":"2014-07-21 16:15:38.000000000","message":"Does the input always\u0027t have  \"id\"  ?","commit_id":"f9b5eb6e7b9a1bc9cabb5a82d7e7095b15d1585e"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7553b5d3fc0e71d1b2dc30b3560741d57c6bb6ae","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        ref \u003d self._normalize_dict(region)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if not ref.get(\u0027id\u0027):"},{"line_number":166,"context_line":"            ref \u003d self._assign_unique_id(ref)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        ref \u003d self.catalog_api.create_region(ref)"},{"line_number":169,"context_line":"        return wsgi.render_response("}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_e5065a1b","line":166,"in_reply_to":"baada198_4269bc23","updated":"2014-07-21 16:21:34.000000000","message":"No...and if it\u0027s missing, we still assign a new id.....","commit_id":"f9b5eb6e7b9a1bc9cabb5a82d7e7095b15d1585e"}],"keystone/tests/test_v3_catalog.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"fd1066cb369deea6a2bcf21d405b8e6425a490a4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \"\"\"Call ``POST /regions`` with an empty ID in the request body.\"\"\""},{"line_number":83,"context_line":"        ref \u003d self.new_region_ref()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # set empty region ID"},{"line_number":86,"context_line":"        ref[\u0027id\u0027] \u003d \u0027\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.post("}],"source_content_type":"text/x-python","patch_set":1,"id":"5adbc538_32821653","line":85,"updated":"2014-05-25 01:30:21.000000000","message":"the comment is rather obvious and can be removed","commit_id":"44ead3abf55b8656cf69bc02a2b04864520b7ed1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"fd1066cb369deea6a2bcf21d405b8e6425a490a4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # set empty region ID"},{"line_number":86,"context_line":"        ref[\u0027id\u0027] \u003d \u0027\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.post("},{"line_number":89,"context_line":"            \u0027/regions\u0027,"},{"line_number":90,"context_line":"            body\u003d{\u0027region\u0027: ref},"},{"line_number":91,"context_line":"            expected_status\u003d400)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5adbc538_5287a261","line":88,"updated":"2014-05-25 01:30:21.000000000","message":"try to maximize the number of characters per line. \n\ncan do this in 2 lines instead of 4.","commit_id":"44ead3abf55b8656cf69bc02a2b04864520b7ed1"}]}