)]}'
{"id":"openstack%2Fkeystone~961903","triplet_id":"openstack%2Fkeystone~stable%2F2024.1~I1a0ecd80a44eae6032e985091032aa91ee5c81a5","project":"openstack/keystone","branch":"stable/2024.1","topic":"use-secrets-library-in-oauth1-sql-backend","hashtags":[],"change_id":"I1a0ecd80a44eae6032e985091032aa91ee5c81a5","subject":"Replace the random library with secrets in oauth1","status":"ABANDONED","created":"2025-09-21 23:17:06.000000000","updated":"2025-10-31 13:45:24.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c7c756e1a23f2b9d431553c4c6fd91837ff2096e","_number":961903,"virtual_id_number":961903,"owner":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2025-09-22 00:57:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-21 23:40:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-09-22 00:57:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-10-31 13:45:24.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"c0c21a63182b26063cf4ea97340a9d3e90e84c5e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"date":"2025-09-21 23:17:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"33f79899564a44c3f4f06488946d2fb5cf2b1c20","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-21 23:40:35.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/856562b5b510450aa3396cbe54b289a8\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/787f92ca156c40d09d82f63cd3d9256c : SUCCESS in 22m 00s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/1e44743a6ff845c88f185c146ff24597 : SUCCESS in 19m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c90eb743e3a25b351e9ef0015060763f347999de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-22 00:57:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/817a899aba4c4f218e28f54848be3e48\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/27ccd3cff70e489bb5fa5a1714f6279d : SUCCESS in 13m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/90b4acbbc2704aeebc58ec929c045629 : SUCCESS in 3m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ad66be1ece4a4b798417cc1a5006c87e : SUCCESS in 11m 38s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/9353117735ed45ef938695b7212ba996 : SUCCESS in 9m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5cd42aa69070420a9a83335cb5d09d1c : SUCCESS in 8m 35s\n- grenade https://zuul.opendev.org/t/openstack/build/39114ed612374b13b36146b79e57f1e1 : SUCCESS in 54m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e5e59012adfe4118a41027796869eef3 : SUCCESS in 1h 32m 29s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/9ccc57f489ac464db9d5f779ce8b58b6 : SUCCESS in 25m 55s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/670cc4ae78084750a5b74d718716ef9d : FAILURE in 35m 45s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/9aee8acf62b0406d8384184a9b8e5e75 : FAILURE in 16m 32s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/024b564b3790437cbc167352a20ae29f : SUCCESS in 17m 49s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/cbd9212193de441aae5f1b4b80bff1e3 : SUCCESS in 15m 25s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/94662587a103402981d16e7e9f59339c : FAILURE in 17m 03s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e9a35c80cec449a490ecd107d015f41f : SUCCESS in 46m 00s\n- keystone-dsvm-functional-oidc-federation https://zuul.opendev.org/t/openstack/build/5b9170c2dea547399bd967718aaa24dd : SUCCESS in 27m 55s","accounts_in_message":[],"_revision_number":1},{"id":"c7c756e1a23f2b9d431553c4c6fd91837ff2096e","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-10-31 13:45:24.000000000","message":"Abandoned\n\nstable/2024.1 branch of openstack/keystone is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/2024.1 if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e732d2d765e6e8f213d6c5a6f1b5e34e37d1468b","revisions":{"e732d2d765e6e8f213d6c5a6f1b5e34e37d1468b":{"kind":"REWORK","_number":1,"created":"2025-09-21 23:17:06.000000000","uploader":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"ref":"refs/changes/03/961903/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/03/961903/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/03/961903/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/03/961903/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/03/961903/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/03/961903/1"}}},"commit":{"parents":[{"commit":"4e2e36ad7767a459277987d21f748cec54ac09e0","subject":"Fix DB migrations after alembic integration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/4e2e36ad7767a459277987d21f748cec54ac09e0"}]}],"author":{"name":"Adrian Jarvis","email":"adrian.jarvis@catalystcloud.nz","date":"2025-09-18 04:39:16.000000000","tz":720},"committer":{"name":"Adrian Jarvis","email":"adrian.jarvis@catalystcloud.nz","date":"2025-09-21 23:16:13.000000000","tz":720},"subject":"Replace the random library with secrets in oauth1","message":"Replace the random library with secrets in oauth1\n\nThe module keystone.oauth1.backends.sql was using the random library to\ngenerate the verifier of a request token.  The bandit security scanner\ntool from version 1.8.4 onwards identifies the use random.sample as a\nlow security issue, despite random actually being an alias to\nrandom.SystemRandom(). This change replaces the use of random library\nwith the secrets library and avoids the use of shadowing random.\n\nChange-Id: I1a0ecd80a44eae6032e985091032aa91ee5c81a5\nSigned-off-by: Adrian Jarvis \u003cadrian.jarvis@catalystcloud.nz\u003e\n(cherry picked from commit 420503a3731fec618e4e8a83415e8ec416ca35da)\n(cherry picked from commit 0ade43a83c8c44034fbf962dd566670bb1f86fdb)\n(cherry picked from commit f1e80dd69c631cc8e1d4cc5412e103833ed92137)\n(cherry picked from commit 5a4c2582ba278954fd61586830b3be6cc349c194)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/e732d2d765e6e8f213d6c5a6f1b5e34e37d1468b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/e732d2d765e6e8f213d6c5a6f1b5e34e37d1468b"}]},"branch":"refs/heads/stable/2024.1"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}