)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"34ad2939ca459cb9b8dfc6772bc1c17e8f72a027","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d23528df_9809f1a7","updated":"2026-04-09 13:04:09.000000000","message":"There must be a unit test demonstrating how this works. I think it does not work now because of the problem with variable name mentioned in the review.\nIf this is changing a behavior visible to a API user, there must be a bugreport reference.","commit_id":"faeaa48d1eed7f8c39a846157164b0a178031ed7"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"ba2735ad369f2114a17dc3c955c8d7dd97e2cc12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1933c887_20775cbc","updated":"2025-12-18 16:39:43.000000000","message":"recheck unrelated","commit_id":"faeaa48d1eed7f8c39a846157164b0a178031ed7"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"966c6f6b54ffd6f1482bd1bd194664036616d7f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"945833c0_b8c34f53","in_reply_to":"3db544ed_7ae8209c","updated":"2026-04-20 10:35:50.000000000","message":"take a chance and start writing unittests able to test every single aspect of the jsonschema validation. I haven\u0027t managed this in 2 years (with jsonschema validator, openapi validator, custom parsing validator), but maybe you have more luck.","commit_id":"faeaa48d1eed7f8c39a846157164b0a178031ed7"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"0b27ec4399491a498af1fa6bddc169d4765e79ce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3db544ed_7ae8209c","in_reply_to":"722d813f_3da33ecb","updated":"2026-04-09 14:15:50.000000000","message":"How do i make sure that this works? The previous wrong key with underscore was not noticed by 4 reviewers (including one core reviewer) and by you, the patch author. Things like this should be caught by CI.","commit_id":"faeaa48d1eed7f8c39a846157164b0a178031ed7"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"0c407a7b7aade09bcf9d64da77c47f4040992402","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"722d813f_3da33ecb","in_reply_to":"d23528df_9809f1a7","updated":"2026-04-09 13:38:36.000000000","message":"this has nothing to do with changing the API behavior, but rather fixing a bug introduced with the schemas (due to the not sufficient coverage with existing tests that do not try to set additional attributes on the projects/domains). This is a followup fix to other places with similar behavior, I am not able to find the bug report for this, maybe someone just pinged in the IRC with it.","commit_id":"faeaa48d1eed7f8c39a846157164b0a178031ed7"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"966c6f6b54ffd6f1482bd1bd194664036616d7f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bcd36b37_13ec19b4","updated":"2026-04-20 10:35:50.000000000","message":"recheck flaky CI","commit_id":"9dd1b2e304f9eeafae6096ac8f9c98c50e7db91a"}],"keystone/resource/schema.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"34ad2939ca459cb9b8dfc6772bc1c17e8f72a027","unresolved":true,"context_lines":[{"line_number":278,"context_line":"                },"},{"line_number":279,"context_line":"                **_domain_properties,"},{"line_number":280,"context_line":"            },"},{"line_number":281,"context_line":"            \"additional_properties\": True,"},{"line_number":282,"context_line":"            \"required\": [\"name\"],"},{"line_number":283,"context_line":"        }"},{"line_number":284,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"24500ee7_23443269","line":281,"updated":"2026-04-09 13:04:09.000000000","message":"I am confused. Here additional_properties is used with an underscore. Below on line 286 and on line 210 additionalProperties with camelCase are used. Why the difference? How does it work?","commit_id":"faeaa48d1eed7f8c39a846157164b0a178031ed7"}]}