)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"cc3820a7abec24c32f947b2fe7bbced0a5a9eab1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TestAuthInfo class in test_v3_auth made more efficient."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The TestAuthInfo class inherited from class RestfulTestCase which is ineffcient because it cause backend databases and fixtures to be loaded unnecessarily."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Created a new class RestfulTestCaseHelper and moved auth building helper functions from RestfulTestCase to there."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_b888fb71","line":9,"updated":"2014-06-05 10:23:27.000000000","message":"Please follow the 80 character line limit for commit message text.","commit_id":"bcf6dd32700dd4f0aed74d7f7c6a93fd807934b1"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"8d50fa8b88511702325fa943adce278bb257eb04","unresolved":false,"context_lines":[{"line_number":7,"context_line":"TestAuthInfo class in test_v3_auth made more efficient."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The TestAuthInfo class inherited from class RestfulTestCase"},{"line_number":10,"context_line":"which is ineffcient because it cause backend databases and"},{"line_number":11,"context_line":"fixtures to be loaded unnecessarily."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Created a new class RestfulTestCaseHelper and moved auth building"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_6bb0fbf4","line":10,"updated":"2014-06-09 15:24:50.000000000","message":"- remove \u0027which\u0027\n- change \u0027cause\u0027 to \u0027causes the\u0027","commit_id":"856f20d0c6e15ff187514a8bf687f2a1e6307fd2"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"8d50fa8b88511702325fa943adce278bb257eb04","unresolved":false,"context_lines":[{"line_number":11,"context_line":"fixtures to be loaded unnecessarily."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Created a new class RestfulTestCaseHelper and moved auth building"},{"line_number":14,"context_line":"helper functions from RestfulTestCase to there."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If5c187e4f2a5871fd9ad41d90de4d5ddecd75153"},{"line_number":17,"context_line":"Closes-Bug: #1134836"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_6b5f1b73","line":14,"updated":"2014-06-09 15:24:50.000000000","message":"Rephrase to:\n\nMoved auth builder helper functions from RestfulTestCase to a new class called RestfulTestCaseHelper.","commit_id":"856f20d0c6e15ff187514a8bf687f2a1e6307fd2"}],"keystone/tests/test_v3.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"092215ec6c74b8c03aa20d8005a124d4e784be8b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"TIME_FORMAT \u003d \u0027%Y-%m-%dT%H:%M:%S.%fZ\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class RestfulTestCaseHelper(rest.RestfulTestCase):"},{"line_number":43,"context_line":"    def build_auth_scope(self, project_id\u003dNone, project_name\u003dNone,"},{"line_number":44,"context_line":"                         project_domain_id\u003dNone, project_domain_name\u003dNone,"},{"line_number":45,"context_line":"                         domain_id\u003dNone, domain_name\u003dNone, trust_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_94519532","line":42,"updated":"2014-06-18 14:46:17.000000000","message":"a docstr defining the limited scope of the new class would be appreciated","commit_id":"4c35c9b22182bf269823940b66129f88c4429322"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"a26fba59becea3b97d26c07c5749a3430b64be8b","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class RestfulTestCaseHelper(object):"},{"line_number":42,"context_line":"    \"\"\"To hold auth building functions.\"\"\""},{"line_number":43,"context_line":"    def build_auth_scope(self, project_id\u003dNone, project_name\u003dNone,"},{"line_number":44,"context_line":"                         project_domain_id\u003dNone, project_domain_name\u003dNone,"},{"line_number":45,"context_line":"                         domain_id\u003dNone, domain_name\u003dNone, trust_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_fb898bca","line":42,"updated":"2014-06-20 17:23:56.000000000","message":"Then this should be \"AuthHelper\"  but better to call it a Mixin:\n\n\"AuthTestMixin\"","commit_id":"813ce9f27ae0c1b7e60d1817b76a96d06ae12802"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"fdd4c257ba404c63d0f63b214daaab86b16e3d54","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class RestfulTestCaseHelper(object):"},{"line_number":42,"context_line":"    \"\"\"To hold auth building functions.\"\"\""},{"line_number":43,"context_line":"    def build_auth_scope(self, project_id\u003dNone, project_name\u003dNone,"},{"line_number":44,"context_line":"                         project_domain_id\u003dNone, project_domain_name\u003dNone,"},{"line_number":45,"context_line":"                         domain_id\u003dNone, domain_name\u003dNone, trust_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_1369bb8b","line":42,"in_reply_to":"1ae5cdf2_fb898bca","updated":"2014-06-20 19:52:29.000000000","message":"++ on the improved name","commit_id":"813ce9f27ae0c1b7e60d1817b76a96d06ae12802"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"fdd4c257ba404c63d0f63b214daaab86b16e3d54","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return {\u0027auth\u0027: auth_data}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class RestfulTestCase(tests.SQLDriverOverrides, RestfulTestCaseHelper):"},{"line_number":115,"context_line":"    def config_files(self):"},{"line_number":116,"context_line":"        config_files \u003d super(RestfulTestCase, self).config_files()"},{"line_number":117,"context_line":"        config_files.append(tests.dirs.tests_conf(\u0027backend_sql.conf\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_b3264765","line":114,"updated":"2014-06-20 19:52:29.000000000","message":"This still must subsclass rest.RestfulTestCase.  This is now skipping ~600 tests because testr isn\u0027t finding them.","commit_id":"813ce9f27ae0c1b7e60d1817b76a96d06ae12802"}],"keystone/tests/test_v3_auth.py":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"8d50fa8b88511702325fa943adce278bb257eb04","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    # using the test_v3.RestfulTestCase class to gain access to the auth"},{"line_number":36,"context_line":"    # building helper functions, they cause backend databases and fixtures"},{"line_number":37,"context_line":"    # to be loaded unnecessarily.  Separating out the helper functions from"},{"line_number":38,"context_line":"    # this base class would improve efficiency (Bug #1134836)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_missing_auth_methods(self):"},{"line_number":41,"context_line":"        auth_data \u003d {\u0027identity\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_0b95b7e3","line":38,"updated":"2014-06-09 15:24:50.000000000","message":"Do we still need this comment?","commit_id":"856f20d0c6e15ff187514a8bf687f2a1e6307fd2"}]}