)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"02cb8f24696160d131fdccdc260055e1ddb890d3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5b92dd4d_919aa4a1","updated":"2026-04-21 11:58:02.000000000","message":"Tests do not include domain mappings, which is potentially a problematic place in the patch logic.","commit_id":"112d2c3ff98e47eb307bf8b48b2d3be37fae369a"}],"keystone/federation/utils.py":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"02cb8f24696160d131fdccdc260055e1ddb890d3","unresolved":true,"context_lines":[{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        for project in projects:"},{"line_number":763,"context_line":"            domain \u003d project.get(\"domain\", {})"},{"line_number":764,"context_line":"            domain_key \u003d domain.get(\"id\") or domain.get(\"name\") or None"},{"line_number":765,"context_line":"            project_key \u003d (project[\"name\"], domain_key)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"            if project_key not in projects_by_key:"}],"source_content_type":"text/x-python","patch_set":4,"id":"74de387b_712f7f15","line":764,"range":{"start_line":764,"start_character":25,"end_line":764,"end_character":71},"updated":"2026-04-21 11:58:02.000000000","message":"is this right? As this kinda adds possibility to have same project/domain, just in one case it would be domain name, in other domain id?\n\nAnd also can we have None for the project domain? I think all projects should be part of the domain and if domain is not suplied, it\u0027s gonna be IdP default domain?\n\nIt feels like we should attempt to resolve to domain ID as a key here unless it\u0027s not possible for some reason.","commit_id":"112d2c3ff98e47eb307bf8b48b2d3be37fae369a"}]}
