)]}'
{"id":"openstack%2Fkeystone~984587","triplet_id":"openstack%2Fkeystone~unmaintained%2F2024.1~I7260bf46adf003aef7c7ac0d436c3758f658cb0c","project":"openstack/keystone","branch":"unmaintained/2024.1","topic":"fix_ldap_enabled_boolean","attention_set":{},"removed_from_attention_set":{"7888":{"account":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"last_update":"2026-04-14 19:05:20.000000000","reason":"\u003cGERRIT_ACCOUNT_7888\u003e replied on the change","reason_account":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"}},"17685":{"account":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"last_update":"2026-04-15 13:32:32.000000000","reason":"Change was submitted"},"8313":{"account":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"last_update":"2026-04-15 11:41:04.000000000","reason":"\u003cGERRIT_ACCOUNT_8313\u003e replied on the change","reason_account":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"}}},"hashtags":[],"change_id":"I7260bf46adf003aef7c7ac0d436c3758f658cb0c","subject":"fix ldap \u0027enabled\u0027 setting not interpreted as boolean","status":"MERGED","created":"2026-04-14 15:09:59.000000000","updated":"2026-04-15 13:34:05.000000000","submitted":"2026-04-15 13:32:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"984587-fix_ldap_enabled_boolean","meta_rev_id":"298558296ca227a40f2c0b7693cc79f7b8b9041d","_number":984587,"virtual_id_number":984587,"owner":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"value":0,"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-04-15 13:32:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"recommended":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"all":[{"value":1,"date":"2026-04-14 19:05:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"value":2,"date":"2026-04-15 11:41:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"all":[{"value":0,"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"value":1,"date":"2026-04-15 11:41:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-14 15:09:59.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"state":"REVIEWER"},{"updated":"2026-04-14 15:10:20.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"state":"REVIEWER"},{"updated":"2026-04-14 16:26:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"20013ad252b5f96c40fae6c4e455e838c4c782f2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2026-04-14 15:09:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2e71d6a5a6015e84630d213e5fd7bd1f6b50b4c9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-14 16:26:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/1c4195d6419049fea93996f08f8987d9\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cdd6b4714ff44010834a9e13aae5e00d : FAILURE in 14m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bafd2838b3064fde8ab4d73827ecc2e9 : SUCCESS in 5m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1c60f58692f9410cb3ed3942a75a1ec1 : SUCCESS in 15m 44s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/e0296d58f8184f01a33f5d348b90d81b : SUCCESS in 14m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1aa6600b9da1468c8a05f33d03c5c782 : SUCCESS in 14m 10s\n- grenade https://zuul.opendev.org/t/openstack/build/50b01cf8275e4f548729f36892bd50b5 : SUCCESS in 1h 03m 08s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b6dd96f42d424ac5a71662be51d37a15 : SUCCESS in 49m 29s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/fa3334df20ea483199bedcfad3c7e0ec : SUCCESS in 14m 25s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/cba84646129a48fa8de30c73b98db917 : SUCCESS in 28m 50s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/58741f136bb94b5685b7c829eaeeef2d : FAILURE in 22m 52s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/87d2d13a8fae4a0980bf9891b38f4745 : FAILURE in 17m 36s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/520d15820a8347f48d816b1de4608706 : SUCCESS in 31m 35s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/c2594b79b242438894e2b6f2a671a8f9 : FAILURE in 19m 03s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/d91b26fd0f54468d98b9d21beb3240be : FAILURE in 18m 46s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/4fc912526bc04472b815e5508617cd58 : SUCCESS in 31m 20s\n- keystone-dsvm-functional-oidc-federation https://zuul.opendev.org/t/openstack/build/5dbc3df56923411f9875b43f26d254fe : SUCCESS in 16m 15s","accounts_in_message":[],"_revision_number":1},{"id":"374dd16c3adfc19a3007815393daab81ae5cf952","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2026-04-14 17:10:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a182cc88422931c562c45d72b962f576e66dc8f5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-14 18:56:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5ec757b5372348558748608d0fe60074\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/39a20cf7716c41be880db86b4cc87798 : SUCCESS in 14m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6314e752f50640148dd1b4d7352f27a8 : SUCCESS in 3m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/328361ecafcf42198444f8c2416bb004 : SUCCESS in 9m 34s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/4e105675b36b4ad59caaa2ac8ed2cfd4 : SUCCESS in 9m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1df3551cdd58456daf3cc939bfb06513 : SUCCESS in 7m 29s\n- grenade https://zuul.opendev.org/t/openstack/build/f232399767704026a1c13615d6f13bcb : SUCCESS in 1h 02m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f2492adfc6bb4f5fab61bb6d3298e545 : SUCCESS in 1h 40m 23s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d5b84c1183c94a3a940067bb549ac221 : SUCCESS in 9m 45s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/c519ff36d14943b5970a401be4752ee9 : SUCCESS in 16m 24s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/385ea8a3a6224e0fb8eabdacfb6c0bb7 : FAILURE in 22m 51s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/e49e10d4360f416baa78b955323f3449 : FAILURE in 23m 00s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/29d940205a80409eb8d0c5c00ff9b7c8 : SUCCESS in 16m 31s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/eebcc7ab508742cc956ee636ceacae48 : FAILURE in 15m 10s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/2930d673771e49a58733dce73147cd38 : FAILURE in 21m 11s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a284aec624d6465a94c3b2ccb19f11be : SUCCESS in 1h 06m 07s\n- keystone-dsvm-functional-oidc-federation https://zuul.opendev.org/t/openstack/build/38458ea48bfd4c9ead4564da889f2c47 : SUCCESS in 30m 27s","accounts_in_message":[],"_revision_number":1},{"id":"f776575cdc2026c2a0d08513af72b97e84bd672b","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2026-04-14 19:05:20.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3aa681cc7a50a7e51b9ce7d5e971e11b77ac05e1","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2026-04-15 11:41:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7a99386e89816b38865fca59356557dc8077144e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-15 11:41:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9b9c4b1c008471af90200bcc6a05f49cd999e9c1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-15 13:32:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dd78d21a3c62433197877bf316411ffc\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8874c6756e7346a483ebea0cbba0f677 : SUCCESS in 3m 41s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b0ae4b2e1751453e9e2657698e4c7303 : SUCCESS in 21m 23s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/da4e0d33e5334759bc7bc019156ff8a9 : SUCCESS in 8m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/80108cd1e1104edd831c9bde59620288 : SUCCESS in 12m 02s\n- grenade https://zuul.opendev.org/t/openstack/build/4c8b6aff0e464e2da1033300b84ca191 : SUCCESS in 50m 11s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/16a9b36d815b42eabe7d3e7c0e001af4 : SUCCESS in 1h 33m 40s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3ac7607efd7c411188f3898e32419426 : SUCCESS in 11m 23s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/800146beecf74dd8bdfd48f97f772834 : SUCCESS in 14m 14s\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/cd2aa8011e084134bdef6aa629ca1ffe : SUCCESS in 15m 23s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/00dbb773ba554102bc263725d421e05e : SUCCESS in 28m 08s","accounts_in_message":[],"_revision_number":1},{"id":"b65b8c7ac9b4362b93f956499bf23fc45886d0a9","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-15 13:32:32.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"298558296ca227a40f2c0b7693cc79f7b8b9041d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-15 13:34:05.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3cc2e223c99c4746b1aca9149e722665\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f93d767d178342d78113cf20cbb08969 : SUCCESS in 58s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/dfaed8a8328d436d8f5db2fca6e438e1 : SUCCESS in 56s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dc8c24af85b36242f77791c8ac07ff69944ffd2c","revisions":{"dc8c24af85b36242f77791c8ac07ff69944ffd2c":{"kind":"REWORK","_number":1,"created":"2026-04-14 15:09:59.000000000","uploader":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"ref":"refs/changes/87/984587/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/87/984587/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/87/984587/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/87/984587/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/87/984587/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/87/984587/1"}}},"commit":{"parents":[{"commit":"adedc84594907824fcce34fe0617b8b03fbd576f","subject":"Prevent unauthorized EC2 credential creation and deletion","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/adedc84594907824fcce34fe0617b8b03fbd576f"}]}],"author":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2025-08-21 14:11:12.000000000","tz":120},"committer":{"name":"Elod Illes","email":"elod.illes@est.tech","date":"2026-04-14 15:07:59.000000000","tz":120},"subject":"fix ldap \u0027enabled\u0027 setting not interpreted as boolean","message":"fix ldap \u0027enabled\u0027 setting not interpreted as boolean\n\ninterpretation of the ldap enabled attribute as boolean\nis only done if enabled_invert setting is set to true.\n\nConflicts:\n  keystone/identity/backends/ldap/core.py\n\nNOTE(elod.illes): conflict is due to Blakify patch [1] that was added\nin 2024.2 Dalmatian release.\n\n[1] I832ec4c152fa58fb0088d9f880add86a20ec95fc\n\nCloses-Bug: #2121152\nChange-Id: I7260bf46adf003aef7c7ac0d436c3758f658cb0c\nSigned-off-by: Benedikt Trefzer \u003cbenedikt.trefzer@cirrax.com\u003e\n(cherry picked from commit 98e3e6bd847e94d856f3bac7eb23d1b3e9d4f89b)\n(cherry picked from commit 3cdfe147347d647dce4901d2e6beed794cc1618b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/dc8c24af85b36242f77791c8ac07ff69944ffd2c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/dc8c24af85b36242f77791c8ac07ff69944ffd2c"}]},"branch":"refs/heads/unmaintained/2024.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}