)]}'
{"id":"openstack%2Fkeystone~990615","triplet_id":"openstack%2Fkeystone~stable%2F2025.1~I31a1f11a181c11be7de631faf414bfdaf29dac42","project":"openstack/keystone","branch":"stable/2025.1","topic":"fix/project-policy-null-domain-match-stable/2025.2-stable/2025.1","attention_set":{},"removed_from_attention_set":{"14250":{"account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"last_update":"2026-06-17 21:20:55.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I31a1f11a181c11be7de631faf414bfdaf29dac42","subject":"Fix project policy allowing unauthorized access to root domains","status":"MERGED","created":"2026-05-29 08:55:52.000000000","updated":"2026-06-17 21:22:04.000000000","submitted":"2026-06-17 21:20:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"990615-fix/project-policy-null-domain-match-stable/2025.2-stable/2025.1","cherry_pick_of_change":990614,"cherry_pick_of_patch_set":1,"meta_rev_id":"4c904ac9b1805f6813d07d863a98e3282b07a8e8","_number":990615,"virtual_id_number":990615,"owner":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-06-17 21:20:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"all":[{"value":2,"date":"2026-06-17 19:01:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":2,"date":"2026-06-17 17:07:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"all":[{"value":1,"date":"2026-06-17 19:01:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-29 08:55:52.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"state":"CC"},{"updated":"2026-05-29 10:40:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-06-17 17:07:16.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"},{"updated":"2026-06-17 19:01:38.000000000","updated_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"reviewer":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"state":"REVIEWER"}],"messages":[{"id":"5ee9de0d6dae7b2936b0aaeb8b2d5c359c1f284d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2026-05-29 08:55:52.000000000","message":"Patch Set 1: Cherry Picked from branch stable/2025.2.","accounts_in_message":[],"_revision_number":1},{"id":"aaa25e3dceb767c027b3ad1145742dc284131f7a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-29 10:40:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fbcfb903d6c44a7cb4882064734c5cbe\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/124ba20f17304bff8c32da6d9d42b5c4 : SUCCESS in 15m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/95912851c17948e1abaab7357b3f72bb : SUCCESS in 5m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/284f3fc193bd49e3b89c6749f4f6d2f9 : SUCCESS in 12m 20s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/667304b5f37048d9b7e0dfbc7737ebb7 : SUCCESS in 12m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cd02b0b11d15424080aa2168dcab046a : SUCCESS in 12m 25s\n- grenade https://zuul.opendev.org/t/openstack/build/dbdd2fdc18a044fda8f2aed8a120fa39 : SUCCESS in 47m 56s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7803bba567784bc09d6ab6d3614c0ac7 : SUCCESS in 1h 42m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3ca0b90cad3e435aab2f86ef29098be8 : SUCCESS in 8m 18s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/2ac5a6e85d1046498724fd61eab04709 : SUCCESS in 24m 47s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/3ff38799a57b406ab5177ae6f7a4e6cf : FAILURE in 28m 16s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/e3f141f7ef184044bbfe81cb2334b933 : FAILURE in 22m 35s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/508e325176cb4630a627b848ba8edbda : FAILURE in 22m 23s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/2c1da4f9190c400ea938ee129e87cec6 : SUCCESS in 19m 20s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/482367493f804ed897e76ae0b934be06 : SUCCESS in 42m 08s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/537a1a3120eb45a5a992540a135f7fc8 : SUCCESS in 58m 26s\n- codegenerator-openapi-identity-tips-with-api-ref https://zuul.opendev.org/t/openstack/build/4a2ce41c883348f587d1b350b3a6183f : FAILURE in 6m 59s (non-voting)\n- keystone-dsvm-functional-oidc-federation https://zuul.opendev.org/t/openstack/build/5df9435144674eeda21d8349a7063a11 : FAILURE in 35m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b08b5e2c10f85e8f7c5704f7f510f3b91fdb9644","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2026-06-17 17:07:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"bb64a152b0717dda7259e74d67b39e5b3cee9728","author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"date":"2026-06-17 19:01:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a1c3e415757fd0e7a6cef913aa87f44165415169","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-17 19:02:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"782c9d1b4473cb8196d324a2bcb51edf2c6257f4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-17 21:20:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/52363edf987b4b808cb50494d3405f17\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3f41afc91818447d952bc0375557e562 : SUCCESS in 6m 50s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/40da8c4127fc4a46a5852c5ce4d7282e : SUCCESS in 8m 03s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/f3a0059319234b44bc7c1cc05f6fa0de : SUCCESS in 12m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c680948918d840e79388bc38db77dff3 : SUCCESS in 13m 39s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/06861b589cd640f98d1babe950c2893a : SUCCESS in 5m 07s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/8a68de2f4b224a9884c0c94599aa276f : SUCCESS in 13m 58s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/37520c2214b74acab834d4791dd9491d : SUCCESS in 1h 33m 24s\n- grenade https://zuul.opendev.org/t/openstack/build/c5033ab4160942119b40439c1655607a : FAILURE in 23m 23s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/cf9403082ef74f11a05bd8f5ded117b2 : SUCCESS in 42m 13s","accounts_in_message":[],"_revision_number":1},{"id":"5545094c89f8eda1ca27e422c7057e24c7c7f04e","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-17 21:20:55.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"4c904ac9b1805f6813d07d863a98e3282b07a8e8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-17 21:22:04.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/983099068f5c4ad6b4f137051156da74\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ceb6ae9ffbfd4737aead2f29f0d43a5a : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d8cdc340c49f142b0b1f7fdf61113b825ff4fa1c","revisions":{"d8cdc340c49f142b0b1f7fdf61113b825ff4fa1c":{"kind":"REWORK","_number":1,"created":"2026-05-29 08:55:52.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/15/990615/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/15/990615/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/15/990615/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/15/990615/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/15/990615/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/15/990615/1"}}},"commit":{"parents":[{"commit":"53af4f758e84a617d7a8522ebaf79937a67c5e4b","subject":"Merge \"Enforce app cred project boundary on EC2 credential paths\" into stable/2025.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/53af4f758e84a617d7a8522ebaf79937a67c5e4b"}]}],"author":{"name":"Dong Ma","email":"winterma.dong@gmail.com","date":"2026-01-13 12:19:42.000000000","tz":480},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-05-29 08:55:52.000000000","tz":0},"subject":"Fix project policy allowing unauthorized access to root domains","message":"Fix project policy allowing unauthorized access to root domains\n\nThe project policy rules using domain_id matching were vulnerable to\na None \u003d\u003d None match condition. When a user has a project-scoped token\n(domain_id \u003d None in credentials) and the target is a root domain\n(domain_id \u003d null), the policy check would incorrectly pass.\n\nThis allowed any user with a reader/admin/manager role on any project\nto access details of root domains (projects with is_domain\u003dtrue and\ndomain_id\u003dnull), such as the default domain.\n\nThe fix adds an explicit check to ensure the target project domain_id\nis not null, preventing the accidental None \u003d\u003d None match. This follows\nthe same pattern used in grant.py for handling null domain_id values.\n\nAffected policy rules:\n- SYSTEM_READER_OR_DOMAIN_READER_OR_PROJECT_USER\n- SYSTEM_ADMIN_OR_DOMAIN_ADMIN_OR_PROJECT_ADMIN\n- ADMIN_OR_DOMAIN_MANAGER\n\nCloses-Bug: #2138295\nChange-Id: I31a1f11a181c11be7de631faf414bfdaf29dac42\nSigned-off-by: Dong Ma \u003cwinterma.dong@gmail.com\u003e\n(cherry picked from commit 57a0a59cce0aad4fdd9d42390ee61c8c28f16590)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/d8cdc340c49f142b0b1f7fdf61113b825ff4fa1c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/d8cdc340c49f142b0b1f7fdf61113b825ff4fa1c"}]},"branch":"refs/heads/stable/2025.1","conflicts":{"ours":"53af4f758e84a617d7a8522ebaf79937a67c5e4b","theirs":"96466c2210f8ef01d126a0c3eb45cdf56c2263dc","contains_conflicts":false}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}