)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"9dd00a1f215f1c6e88ac17cb502e5fefadb5803d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"825a5cf9_0f343c0a","updated":"2026-06-11 14:08:25.000000000","message":"(i have no idea what i am asking) Are \nhttps://opendev.org/openstack/keystone/src/branch/master/keystone/limit/backends/sql.py#L167-L171\n and \nhttps://opendev.org/openstack/keystone/src/branch/master/keystone/limit/backends/sql.py#L249-L254\n similar to this? If yes, should they be fixed separately or in this change request?","commit_id":"8e78573a95426f194789f7a13e9f298f1133faf1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd4ca04f86a85a235311e95ceea0a727bc5fa7a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b5df2c04_08dbbf63","in_reply_to":"588f6c14_79564897","updated":"2026-06-11 16:11:25.000000000","message":"by the way im not claiming that i have fixed all of the issue with transaction but this is why using decorators on functions can be a safer pattehr as you are less likely to return a qry object form a decorated function by mistake then you are to use one outside of a with block.","commit_id":"8e78573a95426f194789f7a13e9f298f1133faf1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"879fe0e596c8fd386689b41bc93838574b7ec421","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5b57bee_7bf87516","in_reply_to":"825a5cf9_0f343c0a","updated":"2026-06-11 15:49:41.000000000","message":"similar yes the same no\n\nso the context manager while its deactvated when we dedent is not actully drop until the end fo the function and the grabage collector wotn clean it up until the fuction returns\n\nso those are not returning an lazy query obejct that is then evauated later but those ifs shoudl really be indented in the context manager so the query is run inside the read transaction.","commit_id":"8e78573a95426f194789f7a13e9f298f1133faf1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9c989c198f00372d80a264697ef632b628fbe7cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"588f6c14_79564897","in_reply_to":"f5b57bee_7bf87516","updated":"2026-06-11 16:09:00.000000000","message":"https://review.opendev.org/c/openstack/keystone/+/992974/1 should cover those\ni dont that hat is a conenction leak in the saem way as this patch  tires to resolve but it more correct form a generic cotnext manager point of view.","commit_id":"8e78573a95426f194789f7a13e9f298f1133faf1"}]}