)]}'
{"id":"openstack%2Fkeystone~993907","triplet_id":"openstack%2Fkeystone~master~Iae4c167213db7850eedea2def48987ed373c3515","project":"openstack/keystone","branch":"master","topic":"ec2-timestamp-fix-v2","attention_set":{},"removed_from_attention_set":{"14250":{"account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"last_update":"2026-06-24 12:30:06.000000000","reason":"Change was marked work in progress"}},"hashtags":[],"change_id":"Iae4c167213db7850eedea2def48987ed373c3515","subject":"ec2: enforce timestamp presence in _check_timestamp","status":"NEW","created":"2026-06-18 12:52:24.000000000","updated":"2026-06-24 13:55:17.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3c763ca4784336477d2e0b70edc46393129396fe","_number":993907,"virtual_id_number":993907,"owner":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-06-24 13:48:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-18 13:45:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-06-18 14:34:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f0be40f479c78e4af1838685f48c770a169ec8cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2026-06-18 12:52:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"96e51516621705a3879c199d0df9e905ca631eb1","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-18 13:45:25.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/153ee27ebc3640bd8e9ee13386bf4aa7\n\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/a829f71ccac64abfb823a102f8dafa70 : FAILURE in 16m 50s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/de727ab764804dc3bd484be890f4aa1d : FAILURE in 19m 31s (non-voting)\n- openstack-tox-py314-arm64 https://zuul.opendev.org/t/openstack/build/5d2a0b8a00e84ce1b4f51b8ae037074e : FAILURE in 29m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0726c6d74b26b08831c815de13d129c0afd514eb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-18 14:34:13.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/ff48f051a8654863a0672beb292075af\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5167f6cc972a486bb12ad8f1e96199c5 : FAILURE in 15m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4effe7ef624d4f518ce27cce0241301f : FAILURE in 7m 28s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/c268893fd4644451847e94488ba44d50 : FAILURE in 12m 30s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/1a2d0401794544e6a8197025fc19eddd : FAILURE in 10m 13s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/a703688c8953464ca0f5f44c5734cc11 : FAILURE in 15m 18s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/424ab344b1af464793de618d224ca66d : SUCCESS in 13m 31s\n- grenade https://zuul.opendev.org/t/openstack/build/5829a75465c840e187983c2962bdec4e : SUCCESS in 57m 08s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b5eea30a715d4fb0b7492b60412b27b8 : SUCCESS in 1h 38m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c10f9b9c1a2143f19024d81827d7e729 : SUCCESS in 12m 23s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/e4bfce62d56f43889a9bd1cb28eaa4f4 : SUCCESS in 14m 53s (non-voting)\n- keystone-tempest https://zuul.opendev.org/t/openstack/build/75f611129f83421595a889be831c6af0 : SUCCESS in 25m 42s\n- keystone-tempest-fips https://zuul.opendev.org/t/openstack/build/3178d8cf36f847fa9483bb0881253ff4 : FAILURE in 14m 09s (non-voting)\n- keystone-tempest-federation https://zuul.opendev.org/t/openstack/build/725341d5f9ca44308d8e93576645ad14 : FAILURE in 21m 25s (non-voting)\n- keystone-tempest-federation-k2k https://zuul.opendev.org/t/openstack/build/3b163392bd37407c9e9caa5c7b53c505 : SUCCESS in 31m 11s\n- keystone-tempest-oidc-federation https://zuul.opendev.org/t/openstack/build/b4769d4502194e62a1f5eaacf4984187 : SUCCESS in 24m 54s\n- keystone-tempest-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/bad275a35e64446c83273570dfe9ee63 : SUCCESS in 32m 18s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/61b8eb6b126e4fc7afd8d2889c4914b1 : SUCCESS in 52m 41s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/6216bb6f3e6d4b06af8ae667400a3ba5 : SUCCESS in 41m 20s\n- codegenerator-openapi-identity-tips-with-api-ref https://zuul.opendev.org/t/openstack/build/b526e182358948efa0049a1882bd0aad : SUCCESS in 9m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a7e11255929e6a3b40e68060914d7a76eb3fb94e","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2026-06-24 12:30:06.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"021ef574bdbc0378c978048875116df8656ccd13","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2026-06-24 12:30:46.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":2},{"id":"bcdd728d8a137fa5cf8509d56a1c5013f53c7107","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-24 13:48:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ff5b027f3e5d4ea28c770553483f6e1f\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/610dc598ad5d40e49e0dfee0c10a0dd6 : SUCCESS in 16m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/75c81e6fad3b40548fbd9e310d16fb07 : SUCCESS in 5m 33s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ce9111bbb8ea4a909d94464bbab12eb5 : SUCCESS in 11m 46s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/3cbf5a124ff44a0f8f6d6b51359c64f8 : SUCCESS in 10m 43s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/225906139a88408cab4647c0319e9150 : SUCCESS in 17m 23s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/72f5b66c141b4b728d77c8db53f3d800 : SUCCESS in 12m 10s\n- grenade https://zuul.opendev.org/t/openstack/build/0ce505c1c9c249b784d8fc86408d00ec : SUCCESS in 1h 12m 15s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6c903094ca7a4ae8aba1aed7d84d5110 : SUCCESS in 59m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8454c8eb84d5436c90aa816a44473dc6 : SUCCESS in 12m 03s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/45f1ecfbce9d4ca390dd6ad4827450b0 : SUCCESS in 10m 02s (non-voting)\n- keystone-tempest https://zuul.opendev.org/t/openstack/build/c7d41b7ab68245869acc1432dd03bcfc : SUCCESS in 32m 32s\n- keystone-tempest-fips https://zuul.opendev.org/t/openstack/build/c1b8b244a0d9431683fee29065793aa9 : FAILURE in 15m 05s (non-voting)\n- keystone-tempest-federation https://zuul.opendev.org/t/openstack/build/5b3afee3ab76476988e70f3d029f01c7 : FAILURE in 26m 50s (non-voting)\n- keystone-tempest-federation-k2k https://zuul.opendev.org/t/openstack/build/cba7c705b3e24c2f96673bfae9ce341c : SUCCESS in 31m 12s\n- keystone-tempest-oidc-federation https://zuul.opendev.org/t/openstack/build/a447ef5f5a354200935466ef3179e1ea : SUCCESS in 35m 29s\n- keystone-tempest-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/c1913b4d816a48668a8b410beaf21b75 : SUCCESS in 32m 16s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e9d9cecc99774c0488010e9e8fdeec18 : SUCCESS in 1h 03m 37s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/14d20616a70b494f9d3355effe236f4c : SUCCESS in 42m 37s\n- codegenerator-openapi-identity-tips-with-api-ref https://zuul.opendev.org/t/openstack/build/18b27c1ce5b84e828265c50dda237352 : SUCCESS in 6m 46s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"3c763ca4784336477d2e0b70edc46393129396fe","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-24 13:55:17.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6a6b465675c04c05a3f31a33791055a6\n\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/42ca36b8ad1b42d8b8d91e335f5f045c : SUCCESS in 18m 46s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/99ecf1f8987447bf890323347bf3d4d7 : SUCCESS in 21m 28s (non-voting)\n- openstack-tox-py314-arm64 https://zuul.opendev.org/t/openstack/build/485cb916241e4391b8c5a4da1af81d1d : SUCCESS in 35m 08s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b4649a6cb0c1583b741468dfb2fa1ffd3973e0b2","revisions":{"471e34b2422293a228942836d00977ddcd4cf1c0":{"kind":"REWORK","_number":1,"created":"2026-06-18 12:52:24.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/07/993907/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/07/993907/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/07/993907/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/07/993907/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/07/993907/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/07/993907/1"}}},"commit":{"parents":[{"commit":"4172e784581e71b468325c05f4e9023c0fefd9b5","subject":"Materialize limit backend queries in read sessions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/4172e784581e71b468325c05f4e9023c0fefd9b5"}]}],"author":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-06-18 12:34:26.000000000","tz":120},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-06-18 12:52:08.000000000","tz":120},"subject":"ec2: enforce timestamp presence in _check_timestamp","message":"ec2: enforce timestamp presence in _check_timestamp\n\nLP#1872737 introduced auth_ttl to limit the replay window for EC2/S3\nsigned requests. However, _check_timestamp() silently returned when the\nrequest contained no timestamp, allowing any request without a Timestamp\nor X-Amz-Date field to bypass auth_ttl entirely.\n\nThis closes the gap by:\n\n- Raising Unauthorized when neither a params/header timestamp nor a\n  token-embedded date is present, instead of returning silently.\n- Extracting the date from the base64 string-to-sign for token-based\n  callers (e.g. Swift\u0027s s3token middleware), so auth_ttl is enforced\n  consistently for all authentication paths.\n- Adding Timestamp to the params dict in the two credential test helpers\n  that were generating requests without one, so the unit tests continue\n  to pass under the stricter validation.\n\nCloses-Bug: #1872737\n\nAssisted-by: Claude Sonnet 4.6 \u003cnoreply@anthropic.com\u003e\nChange-Id: Iae4c167213db7850eedea2def48987ed373c3515\nSigned-off-by: Grzegorz Grasza \u003cxek@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/471e34b2422293a228942836d00977ddcd4cf1c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/471e34b2422293a228942836d00977ddcd4cf1c0"}]},"branch":"refs/heads/master"},"b4649a6cb0c1583b741468dfb2fa1ffd3973e0b2":{"kind":"REWORK","_number":2,"created":"2026-06-24 12:30:06.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/07/993907/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/07/993907/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/07/993907/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/07/993907/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/07/993907/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/07/993907/2"}}},"commit":{"parents":[{"commit":"4172e784581e71b468325c05f4e9023c0fefd9b5","subject":"Materialize limit backend queries in read sessions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/4172e784581e71b468325c05f4e9023c0fefd9b5"}]}],"author":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-06-18 12:34:26.000000000","tz":120},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-06-24 12:29:42.000000000","tz":120},"subject":"ec2: enforce timestamp presence in _check_timestamp","message":"ec2: enforce timestamp presence in _check_timestamp\n\nLP#1872737 introduced auth_ttl to limit the replay window for EC2/S3\nsigned requests. However, _check_timestamp() silently returned when the\nrequest contained no timestamp, allowing any request without a Timestamp\nor X-Amz-Date field to bypass auth_ttl entirely.\n\nThis closes the gap by:\n\n- Raising Unauthorized when neither a params/header timestamp nor a\n  token-embedded date is present, instead of returning silently.\n- Extracting the date from the base64 string-to-sign for token-based\n  callers (e.g. Swift\u0027s s3token middleware), so auth_ttl is enforced\n  consistently for all authentication paths.\n- Adding Timestamp to the params dict in the two credential test helpers\n  that were generating requests without one, so the unit tests continue\n  to pass under the stricter validation.\n\nCloses-Bug: #1872737\n\nAssisted-by: Claude Sonnet 4.6 \u003cnoreply@anthropic.com\u003e\nChange-Id: Iae4c167213db7850eedea2def48987ed373c3515\nSigned-off-by: Grzegorz Grasza \u003cxek@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/b4649a6cb0c1583b741468dfb2fa1ffd3973e0b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/b4649a6cb0c1583b741468dfb2fa1ffd3973e0b2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}