)]}'
{"id":"openstack%2Fkeystone~999082","triplet_id":"openstack%2Fkeystone~master~Ia75f347a6b205cbc4065f44c599918e5215511ea","project":"openstack/keystone","branch":"master","hashtags":[],"change_id":"Ia75f347a6b205cbc4065f44c599918e5215511ea","subject":"Use constant-time comparison for TOTP passcode validation","status":"NEW","created":"2026-07-29 11:12:13.000000000","updated":"2026-07-29 17:38:28.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"work_in_progress":true,"has_review_started":false,"meta_rev_id":"d1c60a83e27f0e8123903a48b86d0ba04572828a","_number":999082,"virtual_id_number":999082,"owner":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-07-29 12:28:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"reviewer_updates":[{"updated":"2026-07-29 12:28:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6e4435011db33174959d3ad2b085d9a9f4f4bd3f","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2026-07-29 11:12:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe61e46e62166f61e0a17851e4c6a7f61dfaab63","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-29 12:28:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9aa0c0a5b86f46308b12711088e38e2e\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ea826f0d70bf47aa93823b4286e54d92 : SUCCESS in 17m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ff6aeb5b8a114b80a975673f2ea07c4d : SUCCESS in 5m 49s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/935e51d1a9a14fdcb45808b5937db57d : SUCCESS in 12m 00s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/0f6e1828e25b48bca880238a409eca09 : SUCCESS in 10m 08s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/66d4be63043342b8b9c2b82236b98130 : SUCCESS in 14m 56s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8efec1cfde844272935d6d3ac527a561 : SUCCESS in 15m 47s\n- grenade https://zuul.opendev.org/t/openstack/build/030c9ef54e5545f38fc4b4fdd9bd3b71 : SUCCESS in 1h 05m 57s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/90988edd42494115b8f507303d17145b : SUCCESS in 1h 15m 01s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1b3b2aa39ad24c33a0f12a06c684d57a : SUCCESS in 10m 05s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/d6237cc2742b484ea11bee4af69baf7a : SUCCESS in 18m 57s (non-voting)\n- keystone-tempest https://zuul.opendev.org/t/openstack/build/5be81dadeb6149d2bb2f53187fe4c03c : SUCCESS in 51m 39s\n- keystone-tempest-fips https://zuul.opendev.org/t/openstack/build/02bcb9ec3241403a8a67d7c30af30fc8 : FAILURE in 19m 09s (non-voting)\n- keystone-tempest-federation https://zuul.opendev.org/t/openstack/build/da3f0d89ee354b46ab435b26d93d4f77 : FAILURE in 25m 56s (non-voting)\n- keystone-tempest-federation-k2k https://zuul.opendev.org/t/openstack/build/ff75d78272d14476b2e51ddc3bf231cb : SUCCESS in 47m 42s\n- keystone-tempest-oidc-federation https://zuul.opendev.org/t/openstack/build/9595d5bc0d894d18b112afa3491f7e39 : SUCCESS in 52m 16s\n- keystone-tempest-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/58598b1783404d5aa6f6f032ceb6359c : SUCCESS in 33m 56s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/35db3e3f7ab54cc29cbc756cabcf7237 : SUCCESS in 59m 30s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/93abdd08df1849fa9f136ce06f73e8cf : SUCCESS in 45m 34s\n- codegenerator-openapi-identity-tips-with-api-ref https://zuul.opendev.org/t/openstack/build/a67661fd3a914fae9e16e1a43c19219a : SUCCESS in 8m 26s (non-voting)\n\nWarning:\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job keystone-tempest-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job keystone-tempest-fips.  Add to preserve-home-paths if safe, or otherwise remove.","accounts_in_message":[],"_revision_number":1},{"id":"d1c60a83e27f0e8123903a48b86d0ba04572828a","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-29 17:38:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/249d724e7df142318aea74473c897f41\n\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/9fe54e3b879e46c683995d07e1417164 : SUCCESS in 20m 59s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/5cd8dcfb53d042ab9a32c5589770dc99 : SUCCESS in 46m 42s (non-voting)\n- openstack-tox-py314-arm64 https://zuul.opendev.org/t/openstack/build/1a4a70bc029344d984f84b0050e66b83 : SUCCESS in 36m 49s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ef273e58c88d31c53f0c67973bc704f171b77ed6","revisions":{"ef273e58c88d31c53f0c67973bc704f171b77ed6":{"kind":"REWORK","_number":1,"created":"2026-07-29 11:12:13.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/82/999082/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/82/999082/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/82/999082/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/82/999082/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/82/999082/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/82/999082/1"}}},"commit":{"parents":[{"commit":"30ef2ffa65a3486ef882f00538e20f2253c57d4c","subject":"Merge \"Make JWT token signing algorithm configurable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/30ef2ffa65a3486ef882f00538e20f2253c57d4c"}]}],"author":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-07-29 07:03:08.000000000","tz":120},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-07-29 11:12:03.000000000","tz":120},"subject":"Use constant-time comparison for TOTP passcode validation","message":"Use constant-time comparison for TOTP passcode validation\n\nThe TOTP auth plugin compared the user-supplied passcode against the\nlist of valid passcodes with the `in` operator, which performs\nsequential, early-exit string comparisons. This leaks timing\ninformation proportional to the number of matching leading\ncharacters (CWE-208), letting a network attacker who can measure\nresponse latency incrementally reconstruct a valid TOTP passcode and\nbypass multi-factor authentication.\n\nReplace it with hmac.compare_digest() against each candidate\npasscode, which does not leak per-character timing.\n\nAssisted-by: Claude Sonnet 5\nChange-Id: Ia75f347a6b205cbc4065f44c599918e5215511ea\nSigned-off-by: Grzegorz Grasza \u003cxek@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/ef273e58c88d31c53f0c67973bc704f171b77ed6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/ef273e58c88d31c53f0c67973bc704f171b77ed6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}