)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"983a371ae9042680b84d6f265d7ba22d161729a3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"Don\u0027t configure external bridge on computes if DVR is disabled\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Br-ex is needed if provider networks are used, using providers"},{"line_number":10,"context_line":"networks is something kolla can\u0027t control or add a logic on"},{"line_number":11,"context_line":"when are used or not, is under operators control."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Creating br-ex in compute nodes not cause any functional"},{"line_number":14,"context_line":"issue, only a error message \"could not open network device\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f201791_edcba9a2","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":49},"updated":"2017-06-21 12:43:21.000000000","message":"Hi Eduardo, I don\u0027t quite understand you here. Why is br-ex needed on computes if DVR is disabled?","commit_id":"aa1785f1973e4eee774f439f3c484b6dbed0780d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"dc4d62e3121099ed49b74543ba5c17ebb9bc76b5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"Don\u0027t configure external bridge on computes if DVR is disabled\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Br-ex is needed if provider networks are used, using providers"},{"line_number":10,"context_line":"networks is something kolla can\u0027t control or add a logic on"},{"line_number":11,"context_line":"when are used or not, is under operators control."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Creating br-ex in compute nodes not cause any functional"},{"line_number":14,"context_line":"issue, only a error message \"could not open network device\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f201791_adcff17d","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":49},"in_reply_to":"5f201791_edcba9a2","updated":"2017-06-21 12:47:19.000000000","message":"for using providers networks, atm there are users with providers in their deployment and have currently br-ex using in compute nodes for this case. If we remove this, will break their deployments while upgrading.\n\nBut I think the correct way to do it is with this change https://review.openstack.org/#/c/469529/\n\nWill abandon this once is merged the other, but the backport for ocata cannot be merged because will break current deployment just doing a simple config change","commit_id":"aa1785f1973e4eee774f439f3c484b6dbed0780d"}],"ansible/roles/openvswitch/handlers/main.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"6a6ac77208b29466ebbb221cdacffd2b9b220142","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  changed_when: status.stdout.find(\u0027changed\u0027) !\u003d -1"},{"line_number":37,"context_line":"  when:"},{"line_number":38,"context_line":"    - inventory_hostname in groups[\"network\"]"},{"line_number":39,"context_line":"      or (inventory_hostname in groups[\"compute\"] and enable_neutron_dvr | bool)"},{"line_number":40,"context_line":"  with_together:"},{"line_number":41,"context_line":"    - \"{{ neutron_bridge_name.split(\u0027,\u0027) }}\""},{"line_number":42,"context_line":"    - \"{{ neutron_external_interface.split(\u0027,\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_56087790","side":"PARENT","line":39,"updated":"2017-06-02 10:50:19.000000000","message":"While reverting this change the br-ex device will be created on the compute nodes even if it is not required there. The neutron_external_interface does not have to exist on the compute nodes if not using dvr. Creating the br-ex on the compute nodes on the neutron_external_interface could result in issues when the compute nodes are using the neutron_external_interface for something else.","commit_id":"841bc75ae21f1890d1397fe6db0a075030322046"}]}