)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"70900dfc49d3a73a3230ce52ee2646970c14501b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"kolla_dev_repos_pull: \"no\""},{"line_number":50,"context_line":"kolla_dev_mode: \"no\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Proxy settings for magnum containers that need internet access"},{"line_number":53,"context_line":"container_http_proxy: \"\""},{"line_number":54,"context_line":"container_https_proxy: \"\""},{"line_number":55,"context_line":"container_no_proxy: \"\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_29618c3a","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":27},"updated":"2017-10-05 09:26:46.000000000","message":"can you make this read, \"for containers such as magnum\"","commit_id":"40534c06bdd06a79a523a769627d00a20a044553"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"70900dfc49d3a73a3230ce52ee2646970c14501b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"# Proxy settings for magnum containers that need internet access"},{"line_number":53,"context_line":"container_http_proxy: \"\""},{"line_number":54,"context_line":"container_https_proxy: \"\""},{"line_number":55,"context_line":"container_no_proxy: \"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"container_proxy:"},{"line_number":58,"context_line":"  http_proxy: \"{{ container_http_proxy }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f515b1d_694e64c2","line":55,"updated":"2017-10-05 09:26:46.000000000","message":"Can we set this to something similar to the original patch (external vip and such)","commit_id":"40534c06bdd06a79a523a769627d00a20a044553"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"b5b6caae6e9594374b4704a81d423de5de34f186","unresolved":false,"context_lines":[{"line_number":49,"context_line":"kolla_dev_repos_pull: \"no\""},{"line_number":50,"context_line":"kolla_dev_mode: \"no\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Proxy settings for magnum containers that need internet access"},{"line_number":53,"context_line":"container_http_proxy: \"\""},{"line_number":54,"context_line":"container_https_proxy: \"\""},{"line_number":55,"context_line":"container_no_proxy: \"localhost,127.0.0.1\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_84f4e5d0","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":27},"updated":"2017-10-05 09:47:39.000000000","message":"See comment wrt this on ps 1","commit_id":"2a698c0a9c91a4ee7bd617a9b73cef8d63ade0b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"334a7906d7713789a9c4a30549c193b2590802d1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"kolla_dev_mode: \"no\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Proxy settings for magnum containers that need internet access"},{"line_number":53,"context_line":"container_http_proxy: \"\""},{"line_number":54,"context_line":"container_https_proxy: \"\""},{"line_number":55,"context_line":"container_no_proxy: \"localhost,127.0.0.1\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"container_proxy:"},{"line_number":58,"context_line":"  http_proxy: \"{{ container_http_proxy }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_046475b8","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":41},"updated":"2017-10-05 09:49:10.000000000","message":"why is this needed? could be filled in same container_proxy dict","commit_id":"2a698c0a9c91a4ee7bd617a9b73cef8d63ade0b9"}],"ansible/roles/magnum/defaults/main.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"504aa9bb5c1bc4378b724798a261124a936d1498","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    group: magnum-conductor"},{"line_number":19,"context_line":"    enabled: true"},{"line_number":20,"context_line":"    image: \"{{ magnum_conductor_image_full }}\""},{"line_number":21,"context_line":"    environment:"},{"line_number":22,"context_line":"      DUMMY_ENVIRONMENT: kolla_useless_env"},{"line_number":23,"context_line":"    volumes:"},{"line_number":24,"context_line":"      - \"{{ node_config_directory }}/magnum-conductor/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_d4704c0b","line":21,"updated":"2017-10-05 12:04:51.000000000","message":"in this line (probably)","commit_id":"1df6b0577054358fc2ddaea6644a8ae08e7262e9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"504aa9bb5c1bc4378b724798a261124a936d1498","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    group: magnum-conductor"},{"line_number":19,"context_line":"    enabled: true"},{"line_number":20,"context_line":"    image: \"{{ magnum_conductor_image_full }}\""},{"line_number":21,"context_line":"    environment:"},{"line_number":22,"context_line":"      DUMMY_ENVIRONMENT: kolla_useless_env"},{"line_number":23,"context_line":"    volumes:"},{"line_number":24,"context_line":"      - \"{{ node_config_directory }}/magnum-conductor/:{{ container_config_directory }}/:ro\""},{"line_number":25,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_7482b8ca","line":22,"range":{"start_line":21,"start_character":16,"end_line":22,"end_character":42},"updated":"2017-10-05 12:04:51.000000000","message":"here the real environment that is going to be used","commit_id":"1df6b0577054358fc2ddaea6644a8ae08e7262e9"}],"ansible/roles/magnum/handlers/main.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"334a7906d7713789a9c4a30549c193b2590802d1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      or policy_json.changed | bool"},{"line_number":23,"context_line":"      or magnum_api_container.changed | bool"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Restart magnum-conductor container"},{"line_number":26,"context_line":"  vars:"},{"line_number":27,"context_line":"    service_name: \"magnum-conductor\""},{"line_number":28,"context_line":"    service: \"{{ magnum_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_242d3146","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":32},"updated":"2017-10-05 09:49:10.000000000","message":"only conductor requires proxy?","commit_id":"2a698c0a9c91a4ee7bd617a9b73cef8d63ade0b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"334a7906d7713789a9c4a30549c193b2590802d1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":37,"context_line":"    image: \"{{ service.image }}\""},{"line_number":38,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":39,"context_line":"    environment: \"{{ container_proxy }}\""},{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - action !\u003d \"config\""},{"line_number":42,"context_line":"    - inventory_hostname in groups[service.group]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_44170def","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":15},"updated":"2017-10-05 09:49:10.000000000","message":"missing check in config.yml. containers will always be mark as changed and restarted even with no real change https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/common/tasks/config.yml#L217","commit_id":"2a698c0a9c91a4ee7bd617a9b73cef8d63ade0b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"334a7906d7713789a9c4a30549c193b2590802d1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":37,"context_line":"    image: \"{{ service.image }}\""},{"line_number":38,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":39,"context_line":"    environment: \"{{ container_proxy }}\""},{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - action !\u003d \"config\""},{"line_number":42,"context_line":"    - inventory_hostname in groups[service.group]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_043235a8","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":36},"updated":"2017-10-05 09:49:10.000000000","message":"this should come from role defaults, check `common`` role","commit_id":"2a698c0a9c91a4ee7bd617a9b73cef8d63ade0b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"504aa9bb5c1bc4378b724798a261124a936d1498","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":38,"context_line":"    image: \"{{ service.image }}\""},{"line_number":39,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":40,"context_line":"    environment: \"{{ container_proxy }}\""},{"line_number":41,"context_line":"  when:"},{"line_number":42,"context_line":"    - action !\u003d \"config\""},{"line_number":43,"context_line":"    - inventory_hostname in groups[service.group]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_745bd886","line":40,"range":{"start_line":40,"start_character":18,"end_line":40,"end_character":39},"updated":"2017-10-05 12:04:51.000000000","message":"same value as in api, in default sets real container_proxy env","commit_id":"1df6b0577054358fc2ddaea6644a8ae08e7262e9"}]}
