)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4a44d077060db8e7710058d3a73092a4b3eaf283","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Following deployment of Grafana, a check is made to ensure that the"},{"line_number":10,"context_line":"login page is accessible. If the Grafana container has been deployed"},{"line_number":11,"context_line":"to a remote host the check will fail because the task is set to run"},{"line_number":12,"context_line":"against the local controller. Further to this, because Grafana is not"},{"line_number":13,"context_line":"accessible the ansible uri module does not return a status field, so"},{"line_number":14,"context_line":"no retry attempts are made and the task fails with an obscure message:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_2da43908","line":12,"updated":"2018-01-10 18:48:09.000000000","message":"Needs updating based on my comment[1] in the bug.\n\n[1] https://bugs.launchpad.net/kolla-ansible/+bug/1742501/comments/2","commit_id":"d857142cdeefebc066a270fd9cf4f8fc1221010d"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"49d357ce0a22d8f88d9a9abba487401a2de7b457","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Following deployment of Grafana, a check is made to ensure that the"},{"line_number":10,"context_line":"login page is accessible. If the Grafana container has been deployed"},{"line_number":11,"context_line":"to a remote host the check will fail because the task is set to run"},{"line_number":12,"context_line":"against the local controller. Further to this, because Grafana is not"},{"line_number":13,"context_line":"accessible the ansible uri module does not return a status field, so"},{"line_number":14,"context_line":"no retry attempts are made and the task fails with an obscure message:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"TASK [grafana : Wait for grafana application ready] *****************"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_aa2fc4f4","line":13,"range":{"start_line":12,"start_character":30,"end_line":13,"end_character":65},"updated":"2018-01-11 03:58:58.000000000","message":"rephrase the statement for better understanding of change.","commit_id":"d857142cdeefebc066a270fd9cf4f8fc1221010d"}],"ansible/roles/grafana/tasks/post_config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4a44d077060db8e7710058d3a73092a4b3eaf283","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ grafana_server_port }}/login\""},{"line_number":5,"context_line":"    status_code: 200"},{"line_number":6,"context_line":"  register: result"},{"line_number":7,"context_line":"  until: result.status \u003d\u003d 200"},{"line_number":8,"context_line":"  retries: 10"},{"line_number":9,"context_line":"  delay: 2"},{"line_number":10,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_ed3ad1cb","line":7,"updated":"2018-01-10 18:48:09.000000000","message":"We can cope with a lower level network failure where status is not present like this:\n\n  until: result | failed or result.status \u003d\u003d 200","commit_id":"d857142cdeefebc066a270fd9cf4f8fc1221010d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4a44d077060db8e7710058d3a73092a4b3eaf283","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  until: result.status \u003d\u003d 200"},{"line_number":8,"context_line":"  retries: 10"},{"line_number":9,"context_line":"  delay: 2"},{"line_number":10,"context_line":"  run_once: true"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Enable grafana datasources"},{"line_number":13,"context_line":"  uri:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_4d5bc52d","line":10,"updated":"2018-01-10 18:48:09.000000000","message":"Presumably we also need to apply this change to the other two tasks in this file?","commit_id":"d857142cdeefebc066a270fd9cf4f8fc1221010d"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"d808086f0ca7cf8fbd9ddeda4067f7349d8d94a8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ grafana_server_port }}/login\""},{"line_number":5,"context_line":"    status_code: 200"},{"line_number":6,"context_line":"  register: result"},{"line_number":7,"context_line":"  until: result | failed or result.status \u003d\u003d 200"},{"line_number":8,"context_line":"  retries: 10"},{"line_number":9,"context_line":"  delay: 2"},{"line_number":10,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_578fa129","line":7,"updated":"2018-01-12 09:32:33.000000000","message":"This makes no sense to me. Why do we accept a failed?","commit_id":"2854671018dc0c908914c8b6fbd773e19eafa72f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7fe3b4630a0a0e8cdee1e4a7ed0fa3c30bafb8bc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ grafana_server_port }}/login\""},{"line_number":5,"context_line":"    status_code: 200"},{"line_number":6,"context_line":"  register: result"},{"line_number":7,"context_line":"  until: result | failed or result.status \u003d\u003d 200"},{"line_number":8,"context_line":"  retries: 10"},{"line_number":9,"context_line":"  delay: 2"},{"line_number":10,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_7a916499","line":7,"in_reply_to":"7f96bb07_37be9565","updated":"2018-01-12 09:57:45.000000000","message":"Agreed - I tested it and it behaves as Mark suggests. It\u0027s a shame the module doesn\u0027t set status \u003d \u0027None\u0027 or similar when it fails so we could still retry if it couldn\u0027t access the url. That wouldn\u0027t help for the case when the container isn\u0027t accessible because of the network topology, but it could be useful if it isn\u0027t returning a status code because it\u0027s still loading. Perhaps the wait_for module would be a better choice.","commit_id":"2854671018dc0c908914c8b6fbd773e19eafa72f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe8e4ff4419b6bb77338c255506286b2ade51cf4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ grafana_server_port }}/login\""},{"line_number":5,"context_line":"    status_code: 200"},{"line_number":6,"context_line":"  register: result"},{"line_number":7,"context_line":"  until: result | failed or result.status \u003d\u003d 200"},{"line_number":8,"context_line":"  retries: 10"},{"line_number":9,"context_line":"  delay: 2"},{"line_number":10,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_37be9565","line":7,"in_reply_to":"7f96bb07_578fa129","updated":"2018-01-12 09:46:18.000000000","message":"This just defines the criteria on which to stop the iteration. The task will still fail.","commit_id":"2854671018dc0c908914c8b6fbd773e19eafa72f"}]}