)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"ed0f0ea60c55e8983ce7b98a1a77ca14ec7f9964","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for deploying ZooKeeper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This picks up the abandoned review:"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/412423"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Sam Yaple \u003csam@yaple.net\u003e"},{"line_number":13,"context_line":"Partially-Implements: blueprint monasca-roles"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df7087c5_f076e606","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":39},"updated":"2018-03-09 11:59:21.000000000","message":"since zookeeper image is complecated in kolla, please add depend-on: xxxx","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6a33a347c568107bf6035b83c038bd9b206621b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for deploying ZooKeeper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This picks up the abandoned review:"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/412423"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Sam Yaple \u003csam@yaple.net\u003e"},{"line_number":13,"context_line":"Partially-Implements: blueprint monasca-roles"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df7087c5_42caf64d","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":39},"in_reply_to":"df7087c5_f076e606","updated":"2018-03-14 14:43:58.000000000","message":"Good point, although now that the Zookeeper image is merged in Kolla I don\u0027t think we need it.","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"9eb198fde8d4f35c854f60a725e7aae626665fa4","unresolved":false,"context_lines":[{"line_number":222,"context_line":"[bifrost:children]"},{"line_number":223,"context_line":"deployment"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"[zookeeper:children]"},{"line_number":226,"context_line":"monitoring"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"[zun:children]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"df7087c5_4ad11afb","line":225,"updated":"2018-03-09 14:15:58.000000000","message":"As zk/kafka will also be used for messaging, should this point to group control?","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"6fbb9c175e301ec74580ef52c1aa2aa4135f8b94","unresolved":false,"context_lines":[{"line_number":222,"context_line":"[bifrost:children]"},{"line_number":223,"context_line":"deployment"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"[zookeeper:children]"},{"line_number":226,"context_line":"monitoring"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"[zun:children]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"df7087c5_ffea0eaa","line":225,"in_reply_to":"df7087c5_4ad11afb","updated":"2018-03-12 09:56:42.000000000","message":"gree smith, zookerper be uesed for messaging, we should move to control group","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":589,"context_line":""},{"line_number":590,"context_line":"# Zookeeper"},{"line_number":591,"context_line":"[zookeeper:children]"},{"line_number":592,"context_line":"zookeeper"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"# Zun"},{"line_number":595,"context_line":"[zun-api:children]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"df7087c5_e37ab422","line":592,"updated":"2018-03-08 16:55:30.000000000","message":"I don\u0027t think we need this second level for zookeeper as it is.\n\nWould it make sense to make kafka a child of zookeeper (or vice versa), so that zk runs wherever kafka is? Or should the two be decoupled?","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"}],"ansible/inventory/multinode":[{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"9eb198fde8d4f35c854f60a725e7aae626665fa4","unresolved":false,"context_lines":[{"line_number":241,"context_line":"[bifrost:children]"},{"line_number":242,"context_line":"deployment"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"[zookeeper:children]"},{"line_number":245,"context_line":"monitoring"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"[zun:children]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"df7087c5_2ad626f3","line":244,"updated":"2018-03-09 14:15:58.000000000","message":"group control","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"}],"ansible/roles/common/templates/cron.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    ( \u0027trove\u0027, enable_trove ),"},{"line_number":54,"context_line":"    ( \u0027vitrage\u0027, enable_vitrage ),"},{"line_number":55,"context_line":"    ( \u0027watcher\u0027, enable_watcher ),"},{"line_number":56,"context_line":"    ( \u0027zookeeper\u0027, enable_zookeeper ),"},{"line_number":57,"context_line":"    ( \u0027zun\u0027, enable_zun )"},{"line_number":58,"context_line":"] %}"},{"line_number":59,"context_line":"{"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_e3695425","line":56,"updated":"2018-03-08 16:55:30.000000000","message":"Do we also need an entries in these?\n\nansible/roles/common/templates/conf/input/00-global.conf.j2\nansible/roles/common/templates/conf/filter/01-rewrite-0.12.conf.j2\nansible/roles/common/templates/conf/filter/01-rewrite-0.14.conf.j2","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6a33a347c568107bf6035b83c038bd9b206621b8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    ( \u0027trove\u0027, enable_trove ),"},{"line_number":54,"context_line":"    ( \u0027vitrage\u0027, enable_vitrage ),"},{"line_number":55,"context_line":"    ( \u0027watcher\u0027, enable_watcher ),"},{"line_number":56,"context_line":"    ( \u0027zookeeper\u0027, enable_zookeeper ),"},{"line_number":57,"context_line":"    ( \u0027zun\u0027, enable_zun )"},{"line_number":58,"context_line":"] %}"},{"line_number":59,"context_line":"{"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_cd2e3791","line":56,"in_reply_to":"df7087c5_e3695425","updated":"2018-03-14 14:43:58.000000000","message":"Good point. I\u0027ve added some rules and checked that they parse the logs.","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"}],"ansible/roles/zookeeper/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"####################"},{"line_number":23,"context_line":"# Docker"},{"line_number":24,"context_line":"####################"},{"line_number":25,"context_line":"zookeeper_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-zookeeper\""},{"line_number":26,"context_line":"zookeeper_tag: \"{{ openstack_release }}\""},{"line_number":27,"context_line":"zookeeper_image_full: \"{{ zookeeper_image }}:{{ zookeeper_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_e3ae342d","line":24,"updated":"2018-03-08 16:55:30.000000000","message":"It\u0027s now common to add a \u003cservice\u003e_install_type, e.g.\n\nzookeeper_install_type: \"{{ kolla_install_type }}\"","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"ed0f0ea60c55e8983ce7b98a1a77ca14ec7f9964","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"####################"},{"line_number":23,"context_line":"# Docker"},{"line_number":24,"context_line":"####################"},{"line_number":25,"context_line":"zookeeper_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-zookeeper\""},{"line_number":26,"context_line":"zookeeper_tag: \"{{ openstack_release }}\""},{"line_number":27,"context_line":"zookeeper_image_full: \"{{ zookeeper_image }}:{{ zookeeper_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_d03402fe","line":24,"in_reply_to":"df7087c5_e3ae342d","updated":"2018-03-09 11:59:21.000000000","message":"agree","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"16aa0951f4235bb17246b6b73807c400290c9aa7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# Docker"},{"line_number":24,"context_line":"####################"},{"line_number":25,"context_line":"zookeeper_install_type: \"{{ kolla_install_type }}\""},{"line_number":26,"context_line":"zookeeper_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-zookeeper\""},{"line_number":27,"context_line":"zookeeper_tag: \"{{ openstack_release }}\""},{"line_number":28,"context_line":"zookeeper_image_full: \"{{ zookeeper_image }}:{{ zookeeper_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df7087c5_c252863b","line":26,"updated":"2018-03-14 14:39:31.000000000","message":"Need to use zookeeper_install_type here.","commit_id":"9dfe283b4556cc79312f9ba5bca216474ab8e2d9"}],"ansible/roles/zookeeper/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensuring config directories exist"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item.key }}\""},{"line_number":5,"context_line":"    state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_068336ce","line":2,"updated":"2018-03-08 16:55:30.000000000","message":"become: true","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"ed0f0ea60c55e8983ce7b98a1a77ca14ec7f9964","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensuring config directories exist"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item.key }}\""},{"line_number":5,"context_line":"    state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_b04cee9e","line":2,"in_reply_to":"df7087c5_068336ce","updated":"2018-03-09 11:59:21.000000000","message":"agree","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item.key }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  when:"},{"line_number":8,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":9,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_46792efa","line":6,"updated":"2018-03-08 16:55:30.000000000","message":"owner: \"{{ config_owner_user }}\"\n     group: \"{{ config_owner_group }}\"\n     mode: \"0770\"","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - item.value.enabled | bool"},{"line_number":10,"context_line":"  with_dict: \"{{ zookeeper_services }}\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Copying over config.json files for services"},{"line_number":13,"context_line":"  template:"},{"line_number":14,"context_line":"    src: \"{{ item.key }}.json.j2\""},{"line_number":15,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/config.json\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_66cc7235","line":12,"updated":"2018-03-08 16:55:30.000000000","message":"become: true","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  notify:"},{"line_number":22,"context_line":"    - Restart zookeeper container"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Copying over zookeeper configuration"},{"line_number":25,"context_line":"  merge_configs:"},{"line_number":26,"context_line":"    sources:"},{"line_number":27,"context_line":"      - \"{{ role_path }}/templates/{{ item.key }}.cfg.j2\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_26d67ac7","line":24,"updated":"2018-03-08 16:55:30.000000000","message":"become: true","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  merge_configs:"},{"line_number":26,"context_line":"    sources:"},{"line_number":27,"context_line":"      - \"{{ role_path }}/templates/{{ item.key }}.cfg.j2\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":29,"context_line":"      - \"{{ node_custom_config }}/{{ item.key }}.cfg\""},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/{{ item.key }}/{{ item.key }}.cfg\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/{{ item.key }}/{{ inventory_hostname }}/{{ item.key }}.cfg\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_e65c024d","line":28,"updated":"2018-03-08 16:55:30.000000000","message":"This is openstack config, probably doesn\u0027t make sense for zk.","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  notify:"},{"line_number":39,"context_line":"    - Restart zookeeper container"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Copying over zookeeper instance id"},{"line_number":42,"context_line":"  template:"},{"line_number":43,"context_line":"    src: \"myid.j2\""},{"line_number":44,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/myid\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_c6da1ee8","line":41,"updated":"2018-03-08 16:55:30.000000000","message":"become: true","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"1df87765179afd63036c550daf5106382e068c79","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - Restart zookeeper container"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Copying over zookeeper configuration"},{"line_number":31,"context_line":"  merge_configs:"},{"line_number":32,"context_line":"    sources:"},{"line_number":33,"context_line":"      - \"{{ role_path }}/templates/{{ item.key }}.cfg.j2\""},{"line_number":34,"context_line":"      - \"{{ node_custom_config }}/{{ item.key }}.cfg\""},{"line_number":35,"context_line":"      - \"{{ node_custom_config }}/{{ item.key }}/{{ inventory_hostname }}/{{ item.key }}.cfg\""},{"line_number":36,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/{{ item.key }}.cfg\""},{"line_number":37,"context_line":"    mode: \"0660\""},{"line_number":38,"context_line":"  become: true"},{"line_number":39,"context_line":"  register: zookeeper_confs"},{"line_number":40,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf659307_23fadc74","line":37,"range":{"start_line":31,"start_character":0,"end_line":37,"end_character":16},"updated":"2018-03-27 02:35:23.000000000","message":"res \u003d self._execute(variables\u003dtask_vars)\n  File \"/usr/lib/python2.7/site-packages/ansible/executor/task_executor.py\", line 528, in _execute\n    result \u003d self._handler.run(task_vars\u003dvariables)\n  File \"/usr/share/kolla-ansible/ansible/action_plugins/merge_configs.py\", line 122, in run\n    self.read_config(source, config)\n  File \"/usr/share/kolla-ansible/ansible/action_plugins/merge_configs.py\", line 96, in read_config\n    config.parse(fakefile)\n  File \"/usr/share/kolla-ansible/ansible/action_plugins/merge_configs.py\", line 47, in parse\n    super(OverrideConfigParser, self).parse(lineiter)\n  File \"/usr/lib/python2.7/site-packages/oslo_config/iniparser.py\", line 81, in parse\n    key, value \u003d self._assignment(key, value)\n  File \"/usr/lib/python2.7/site-packages/oslo_config/iniparser.py\", line 31, in _assignment\n    self.assignment(key, value)\n  File \"/usr/share/kolla-ansible/ansible/action_plugins/merge_configs.py\", line 37, in assignment\n    cur_value \u003d self._cur_section.get(key)\nAttributeError: \u0027NoneType\u0027 object has no attribute \u0027get\u0027\n\nfatal: [poc12-02]: FAILED! \u003d\u003e {\n    \"msg\": \"Unexpected failure during module execution.\",\n    \"stdout\": \"\"\n}\n\n\nhere, you can refer to haproxy https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/haproxy/tasks/config.yml#L41","commit_id":"f87b238db52353884dffd60b86dea78c5139ebd4"}],"ansible/roles/zookeeper/tasks/precheck.yml":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"ed0f0ea60c55e8983ce7b98a1a77ca14ec7f9964","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - \"{{ zookeeper_peer_port }}\""},{"line_number":18,"context_line":"    - \"{{ zookeeper_quorum_port }}\""},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - container_facts[\u0027zookeeper\u0027] is not defined"},{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027zookeeper\u0027]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_f080268e","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":42},"updated":"2018-03-09 11:59:21.000000000","message":"- enabled | bool is needed","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a2b183a44afbd865adbbe13441c58764f4ab65ef","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - \"{{ zookeeper_peer_port }}\""},{"line_number":18,"context_line":"    - \"{{ zookeeper_quorum_port }}\""},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - container_facts[\u0027zookeeper\u0027] is not defined"},{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027zookeeper\u0027]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_2dd1f323","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":42},"in_reply_to":"df7087c5_ed477b4b","updated":"2018-03-14 14:50:37.000000000","message":"I guess strictly it ought to be checking zookeeper_services.zookeeper.enabled.","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6a33a347c568107bf6035b83c038bd9b206621b8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - \"{{ zookeeper_peer_port }}\""},{"line_number":18,"context_line":"    - \"{{ zookeeper_quorum_port }}\""},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - container_facts[\u0027zookeeper\u0027] is not defined"},{"line_number":21,"context_line":"    - inventory_hostname in groups[\u0027zookeeper\u0027]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_ed477b4b","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":42},"in_reply_to":"df7087c5_f080268e","updated":"2018-03-14 14:43:58.000000000","message":"I think this is covered by line 84 of ansible/site.yml","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"}],"ansible/roles/zookeeper/tasks/pull.yml":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"ed0f0ea60c55e8983ce7b98a1a77ca14ec7f9964","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pulling zookeeper image"},{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"pull_image\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_f0e4a6ae","line":2,"range":{"start_line":2,"start_character":26,"end_line":2,"end_character":31},"updated":"2018-03-09 11:59:21.000000000","message":"images","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6a33a347c568107bf6035b83c038bd9b206621b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pulling zookeeper image"},{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"pull_image\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_e2d78aed","line":2,"range":{"start_line":2,"start_character":26,"end_line":2,"end_character":31},"in_reply_to":"df7087c5_f0e4a6ae","updated":"2018-03-14 14:43:58.000000000","message":"There\u0027s only one, but since we\u0027re iterating over a dict..","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"}],"ansible/roles/zookeeper/templates/zookeeper.cfg.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05bcbca75a9e0f11f522e5720433325cefd6a5ea","unresolved":false,"context_lines":[{"line_number":5,"context_line":"dataDir\u003d/var/lib/zookeeper/data"},{"line_number":6,"context_line":"clientPort\u003d{{ zookeeper_client_port }}"},{"line_number":7,"context_line":"{% for host in groups[\u0027zookeeper\u0027] -%}"},{"line_number":8,"context_line":"server.{{ loop.index }}\u003d{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ zookeeper_peer_port }}:{{ zookeeper_quorum_port }}"},{"line_number":9,"context_line":"{%- endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df7087c5_09a58704","line":8,"updated":"2018-03-08 16:55:30.000000000","message":"How about:\n\n{{ hostvars[host][\u0027api_interface_address\u0027] }}","commit_id":"fb85fd5919207fe8c2d31672f3b07f77dd20e0c4"}],"ansible/site.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ba47d016b8483f1fc0ae44701bdce14605671572","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        tags: collectd,"},{"line_number":76,"context_line":"        when: enable_collectd | bool }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: Apply role zookeeper"},{"line_number":79,"context_line":"  hosts: zookeeper"},{"line_number":80,"context_line":"  serial: \u0027{{ serial|default(\"0\") }}\u0027"},{"line_number":81,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df7087c5_10303ae8","line":78,"updated":"2018-03-20 15:51:23.000000000","message":"Needs gather_facts: false","commit_id":"ac171f0cae566954ffdddca4a5fc92dabc8c7fec"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d0f1d6bbf53003329fb114ac7140afe86c068ee7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        tags: collectd,"},{"line_number":76,"context_line":"        when: enable_collectd | bool }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: Apply role zookeeper"},{"line_number":79,"context_line":"  hosts: zookeeper"},{"line_number":80,"context_line":"  serial: \u0027{{ serial|default(\"0\") }}\u0027"},{"line_number":81,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df7087c5_b0c62e16","line":78,"in_reply_to":"df7087c5_10303ae8","updated":"2018-03-20 16:09:39.000000000","message":"Fixed - I think that snuck in from cherry-picking this change from stable/pike.","commit_id":"ac171f0cae566954ffdddca4a5fc92dabc8c7fec"}]}