)]}'
{"tools/init-runonce":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d71f586b270a542514c28010b13149aec15da7e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    --property os_type\u003d${IMAGE_TYPE} ${EXTRA_PROPERTIES} --file ${IMAGE_PATH}/${IMAGE} ${IMAGE_NAME}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Test for \u0027cirros\u0027 image created"},{"line_number":72,"context_line":"if [[ -z \"$(openstack image list | grep -q cirros)\" ]]; then"},{"line_number":73,"context_line":"    echo \"Creating glance image failed, check the above output. Fix it and run this script again.\""},{"line_number":74,"context_line":"    exit"},{"line_number":75,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_1a6db497","line":72,"updated":"2018-05-21 13:34:30.000000000","message":"doesnt ensure the image is properly created and in active state. It may be just stored in the registry but not stored in the backend.\n\nsomething like openstack image list --property status","commit_id":"0a30828fb9671309b356ee8a1ac85fbed63bf49e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b59519969b3b8d8e3323994e08e0772eacda8446","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    --property os_type\u003d${IMAGE_TYPE} ${EXTRA_PROPERTIES} --file ${IMAGE_PATH}/${IMAGE} ${IMAGE_NAME}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Test for \u0027cirros\u0027 image created"},{"line_number":72,"context_line":"if [[ -z \"$(openstack image list | grep -q cirros)\" ]]; then"},{"line_number":73,"context_line":"    echo \"Creating glance image failed, check the above output. Fix it and run this script again.\""},{"line_number":74,"context_line":"    exit"},{"line_number":75,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_5ae6cc18","line":72,"in_reply_to":"5f7c97a3_1a6db497","updated":"2018-05-21 13:36:40.000000000","message":"Or:\n\n openstack image list --name cirros --status active","commit_id":"0a30828fb9671309b356ee8a1ac85fbed63bf49e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f8fcab32d5b3ba2e6badbd4476e2e5c2376bfa57","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    --property os_type\u003d${IMAGE_TYPE} ${EXTRA_PROPERTIES} --file ${IMAGE_PATH}/${IMAGE} ${IMAGE_NAME}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Test for \u0027cirros\u0027 image created"},{"line_number":72,"context_line":"if [[ -z \"$(openstack image list | grep -q cirros)\" ]]; then"},{"line_number":73,"context_line":"    echo \"Creating glance image failed, check the above output. Fix it and run this script again.\""},{"line_number":74,"context_line":"    exit"},{"line_number":75,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_7a8f082e","line":72,"in_reply_to":"5f7c97a3_5ae6cc18","updated":"2018-05-21 13:40:37.000000000","message":"If the image is in a different state, then can we wait for it to become active?","commit_id":"0a30828fb9671309b356ee8a1ac85fbed63bf49e"},{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"38314ec2a6c4a15ababa852766a7a223862c779d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    --property os_type\u003d${IMAGE_TYPE} ${EXTRA_PROPERTIES} --file ${IMAGE_PATH}/${IMAGE} ${IMAGE_NAME}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Test for \u0027cirros\u0027 image created"},{"line_number":72,"context_line":"if [[ -z \"$(openstack image list | grep -q cirros)\" ]]; then"},{"line_number":73,"context_line":"    echo \"Creating glance image failed, check the above output. Fix it and run this script again.\""},{"line_number":74,"context_line":"    exit"},{"line_number":75,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_3530c3e8","line":72,"in_reply_to":"5f7c97a3_5ae6cc18","updated":"2018-05-21 14:25:54.000000000","message":"agree, the image may in process but not failed, I need to ensure the status is active.","commit_id":"0a30828fb9671309b356ee8a1ac85fbed63bf49e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"954523d3f88853fb8fd32c60d276931afffa4499","unresolved":false,"context_lines":[{"line_number":72,"context_line":"if [[ -z \"$(openstack image list | grep -q cirros)\" ]]; then"},{"line_number":73,"context_line":"    echo \"Creating glance image failed, check the above output. Fix it and run this script again.\""},{"line_number":74,"context_line":"    exit"},{"line_number":75,"context_line":"fi"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"echo Configuring neutron."},{"line_number":78,"context_line":"openstack network create --external --provider-physical-network physnet1 \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_a6d34fd5","line":75,"updated":"2018-05-21 08:59:41.000000000","message":"Could we catch this and other errors by adding \u0027set -e\u0027 at the top of this script?","commit_id":"0a30828fb9671309b356ee8a1ac85fbed63bf49e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b3c282d4287526b4ac5a35d14591f23cdc7c3435","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    --property os_type\u003d${IMAGE_TYPE} ${EXTRA_PROPERTIES} --file ${IMAGE_PATH}/${IMAGE} ${IMAGE_NAME}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Test for \u0027cirros\u0027 image created"},{"line_number":72,"context_line":"if [[ -z \"$(openstack image list | grep cirros)\" ]]; then"},{"line_number":73,"context_line":"    echo \"Creating glance image failed, check the above output. Fix it and run this script again.\""},{"line_number":74,"context_line":"    exit"},{"line_number":75,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f7c97a3_d762a9d8","line":72,"updated":"2018-05-22 10:44:22.000000000","message":"--name cirros\n\nActually, we should be using ${IMAGE_NAME} here, and below.","commit_id":"a65654dbf64a2289075f55d6c7555fed58c5a916"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b3c282d4287526b4ac5a35d14591f23cdc7c3435","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    echo \"Creating glance image failed, check the above output. Fix it and run this script again.\""},{"line_number":74,"context_line":"    exit"},{"line_number":75,"context_line":"else"},{"line_number":76,"context_line":"    while true; do"},{"line_number":77,"context_line":"        if [[ \"$(openstack image list --name cirros --status active)\" \u003d\u003d \"\" ]]; then"},{"line_number":78,"context_line":"            echo \"Waiting for cirros image being active...\""},{"line_number":79,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f7c97a3_d7906998","line":76,"updated":"2018-05-22 10:44:22.000000000","message":"How about:\n\n while [[ -z \"$(openstack image list --name ${IMAGE_NAME} --status active)\" ]];  do\n     echo \"Waiting for ${IMAGE_NAME} image to become active...\"\n     sleep 10\n done","commit_id":"a65654dbf64a2289075f55d6c7555fed58c5a916"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"c91f3e84e19b40252e3173a11ce378f691cb04c7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    echo \"Creating glance image failed, check the above output. Fix it and run this script again.\""},{"line_number":74,"context_line":"    exit"},{"line_number":75,"context_line":"else"},{"line_number":76,"context_line":"    while true; do"},{"line_number":77,"context_line":"        if [[ \"$(openstack image list --name cirros --status active)\" \u003d\u003d \"\" ]]; then"},{"line_number":78,"context_line":"            echo \"Waiting for cirros image being active...\""},{"line_number":79,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f7c97a3_776f15fc","line":76,"in_reply_to":"5f7c97a3_d7906998","updated":"2018-05-22 11:41:34.000000000","message":"Obviously, this is a better way. Thanks, Mark! :P","commit_id":"a65654dbf64a2289075f55d6c7555fed58c5a916"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b3c282d4287526b4ac5a35d14591f23cdc7c3435","unresolved":false,"context_lines":[{"line_number":75,"context_line":"else"},{"line_number":76,"context_line":"    while true; do"},{"line_number":77,"context_line":"        if [[ \"$(openstack image list --name cirros --status active)\" \u003d\u003d \"\" ]]; then"},{"line_number":78,"context_line":"            echo \"Waiting for cirros image being active...\""},{"line_number":79,"context_line":"        else"},{"line_number":80,"context_line":"            break"},{"line_number":81,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f7c97a3_77a7150d","line":78,"updated":"2018-05-22 10:44:22.000000000","message":"Need a sleep here to prevent spinning.","commit_id":"a65654dbf64a2289075f55d6c7555fed58c5a916"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"68974aa95beb2bdeda0ac3a17f01b283946c546c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"else"},{"line_number":76,"context_line":"    while [[ -z \"$(openstack image list --name ${IMAGE_NAME} --status active)\" ]]; do"},{"line_number":77,"context_line":"    echo \"Waiting for ${IMAGE_NAME} image to become active...\""},{"line_number":78,"context_line":"    sleep 10"},{"line_number":79,"context_line":"    done"},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_aa91c048","line":78,"updated":"2018-05-22 12:43:35.000000000","message":"nit: needs more indentation","commit_id":"1e0f3b22fffc3bdb6935a4e96966229719df39c3"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"2505a8f52adba8195b6c8c7f18728090ea29157a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    echo \"Creating glance image failed, check the above output. Fix it and run this script again.\""},{"line_number":74,"context_line":"    exit"},{"line_number":75,"context_line":"else"},{"line_number":76,"context_line":"    while [[ -z \"$(openstack image list --name ${IMAGE_NAME} --status active)\" ]]; do"},{"line_number":77,"context_line":"        echo \"Waiting for ${IMAGE_NAME} image to become active...\""},{"line_number":78,"context_line":"        sleep 10"},{"line_number":79,"context_line":"    done"},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f7c97a3_4d404608","line":78,"range":{"start_line":76,"start_character":4,"end_line":78,"end_character":16},"updated":"2018-05-22 13:41:00.000000000","message":"need to check whether the status is error or not,  because if status is error, it can\u0027t be catched, and it won\u0027t exit.","commit_id":"96d232d0f44d48e8497f482b86157d16352d41ea"}]}