)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"c792498b30cbf6c7d144d7312943786f54f4e73a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"one by one."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"please refer to the documentation for details:"},{"line_number":23,"context_line":"doc/source/reference/ceph-guide.rst"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ia4cd15d64aef8d05d33b8a76c8d951d424dfe069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_f3e3d0d5","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":35},"updated":"2018-07-19 03:14:07.000000000","message":"please provide full path of the link","commit_id":"1a77f5d38075b64b9249f42f4736f9825a1396c6"}],"ansible/roles/ceph/tasks/check_ceph_health.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0501b14091345d90515eabb2d51da0f4b53c6468","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Sleep some time waiting for ceph state change"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  shell: sleep {{ ceph_state_change_time }}"},{"line_number":5,"context_line":"  changed_when: False"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Run ceph health check and wait HEALTH_OK"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_ebddf112","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":43},"updated":"2018-07-20 08:35:49.000000000","message":"what we\u0027re waiting for here? could we better check for the status to change actively against the service?","commit_id":"0fb7ae928e97e89f3155e21ae1bf776fbe649ef5"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"23013eb54d8836349bfc8d72f5478f5de69fdff4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Sleep some time waiting for ceph state change"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  shell: sleep {{ ceph_state_change_time }}"},{"line_number":5,"context_line":"  changed_when: False"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Run ceph health check and wait HEALTH_OK"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_1ac99858","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":43},"in_reply_to":"5f7c97a3_ebddf112","updated":"2018-07-20 10:18:41.000000000","message":"When upgrading osd, it will set \"ceph osd set noout \u0026\u0026 ceph osd set norebalance\". When the osd container is upgraded, it will be released. Because the program is executed very fast, I am worried that the state of ceph is not updated in time, for example, some warning messages are not updated in time, which causes the next task to obtain \"HEALTH_OK\" to upgrade directly, so this sleep time is added. I will continue to test, if I confirm the ceph update status is timely, I will remove this task.\n\nThe following task is to get the status of ceph,it has a certain number of retries and intervals, which will better get the state of ceph.","commit_id":"0fb7ae928e97e89f3155e21ae1bf776fbe649ef5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0501b14091345d90515eabb2d51da0f4b53c6468","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  until: ceph_health.stdout.find(\"HEALTH_OK\") !\u003d -1"},{"line_number":13,"context_line":"  retries: \"{{ ceph_health_check_retries }}\""},{"line_number":14,"context_line":"  delay: \"{{ ceph_health_check_delay }}\""},{"line_number":15,"context_line":"  changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_4bce655b","line":15,"updated":"2018-07-20 08:35:49.000000000","message":"can we add an failure when something gets wrong, except for passing an OK for every status?","commit_id":"0fb7ae928e97e89f3155e21ae1bf776fbe649ef5"},{"author":{"_account_id":24250,"name":"wangwei","email":"wangw88916@126.com","username":"Dream_x"},"change_message_id":"23013eb54d8836349bfc8d72f5478f5de69fdff4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  until: ceph_health.stdout.find(\"HEALTH_OK\") !\u003d -1"},{"line_number":13,"context_line":"  retries: \"{{ ceph_health_check_retries }}\""},{"line_number":14,"context_line":"  delay: \"{{ ceph_health_check_delay }}\""},{"line_number":15,"context_line":"  changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_9a76080c","line":15,"in_reply_to":"5f7c97a3_4bce655b","updated":"2018-07-20 10:18:41.000000000","message":"hi, this is just not prompted to change, not ignoring errors \"failed_when: False\". If the ceph state is not \"HEALTH_OK\" after the number of retries arrives, then the task will fail and the deployment will be interrupted.","commit_id":"0fb7ae928e97e89f3155e21ae1bf776fbe649ef5"}]}