)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"10a45824e26fa87bedced58106f28ee03e4a9c3b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"1dc47e17_002a14d7","updated":"2024-05-22 13:41:11.000000000","message":"Do we have some docs around it?","commit_id":"f0a99a4502ba70f6e94712f89d3944ca1c59e216"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"353228cb90ed3d061490354cb51c1c836366108b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"6ef8dcf3_cd70b02f","updated":"2024-05-08 20:03:22.000000000","message":"I am still thinking if reintroducing the \"check\" command is a good idea. My reasoning is following:\n\n1. there used to be a check command before which did something different, so by reintroducing it now it might create some confusion\n2. this is checking *containers* - which sounds awfully close to a different task we have - check-containers.yml\n\nPossible solutions:\n- make the command \"check-containers\"\n- I think this would make it a little more obvious as to what exactly it is doing\n- makes sense since we have \"deploy-containers\" command already\n- however it would create a clash with aforementioned \"check-containers.yml\"\n  - maybe we can move that under \"deploy-containers.yml\" because this tasks just \n    imports \"check-container.yml\" for almost all roles\n  - maybe we can make different name for check-container like start-containers or \n    restart-containers, etc.\n\nWhat are your thoughts? I think this approach would make it a little nicer, but let me know what you think. :)\n\nPS: That change of check-containers could be part of refactoring I took over from Radek https://review.opendev.org/c/openstack/kolla-ansible/+/773243","commit_id":"f0a99a4502ba70f6e94712f89d3944ca1c59e216"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c55dd199c98a02d2e196210eda6db83daacfbe70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"fbb674e2_a82609d4","updated":"2024-05-22 13:44:26.000000000","message":"Okay, i know that this is  useful feature, but in what it is better than ansible -m shell -a \u0027docker ps -a | grep -i unhealthy\u0027 all ? \n\nMoreover, kolla-ansible should config, deploy, upgrade, destroy, precheck (check for all before specified actions) ....but why check ? \n\nWe have monitoring documented, right ?","commit_id":"f0a99a4502ba70f6e94712f89d3944ca1c59e216"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"959149f53da49fb2fe0c58e326bb4aa90bd144f9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"40ed88c7_c06220ee","in_reply_to":"1dc47e17_002a14d7","updated":"2024-05-23 06:25:30.000000000","message":"Would you like me to make a section somewhere is the docs or just explain the mechanism?","commit_id":"f0a99a4502ba70f6e94712f89d3944ca1c59e216"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8e42238ab05cd63d2246247209a7905bd7c1e9db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3c2f93f1_f015fc73","in_reply_to":"407dcc0a_98455729","updated":"2025-01-28 10:27:03.000000000","message":"Acknowledged","commit_id":"f0a99a4502ba70f6e94712f89d3944ca1c59e216"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"87f459c55125c0d1852e2a3a7dfa424eeda83c96","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"cb9d2913_5a33328a","in_reply_to":"40ed88c7_c06220ee","updated":"2024-08-01 07:57:09.000000000","message":"I\u0027ve updated reno, so that should hopefully shine some light on how it is working.","commit_id":"f0a99a4502ba70f6e94712f89d3944ca1c59e216"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5d578b4c81dda9e28f633953e96f8d74ab95defa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"407dcc0a_98455729","in_reply_to":"6ef8dcf3_cd70b02f","updated":"2025-01-24 09:34:56.000000000","message":"I think it\u0027s fine as it is, we can rename that later if required.","commit_id":"f0a99a4502ba70f6e94712f89d3944ca1c59e216"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fb06d50de3c8e25523dad7c8e76c70b6c9658090","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"37072b10_b519aa30","in_reply_to":"cb9d2913_5a33328a","updated":"2025-01-24 09:31:37.000000000","message":"Done","commit_id":"f0a99a4502ba70f6e94712f89d3944ca1c59e216"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"959149f53da49fb2fe0c58e326bb4aa90bd144f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"92a01e06_74e20ec6","in_reply_to":"fbb674e2_a82609d4","updated":"2024-05-23 06:25:30.000000000","message":"This does little more then that. It also checks if all the containers that are suppoused to be running are actually running. You cant do that with shell command.\n\nIt could be one of the post post deploy commands you run to verify that everything ran successfully.","commit_id":"f0a99a4502ba70f6e94712f89d3944ca1c59e216"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2b09c0747a7ee86481105ccc626808686d4aa658","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7c3c1f49_5f69bfc4","updated":"2024-08-28 13:15:37.000000000","message":"Can you add this to be run in one of the CI jobs just to have coverage?","commit_id":"1536e2999b9f400f8f994456d8b9adc3bbf1ae17"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"5d4f9b36043e297b130407a0578630e7114a3356","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"ad9dc764_63b2aa21","in_reply_to":"7c3c1f49_5f69bfc4","updated":"2024-09-05 07:04:41.000000000","message":"The CI checks are in. I\u0027ve added it to the `if` statement of deploy.sh since the tests were failing on upgrade tests, because the latest stable release checked out by the upgrade tests don\u0027t have the `check` command implemented.\n\nAnd for those in IRC asking about the time it takes to check -\u003e it takes Zuul around 25 seconds.","commit_id":"1536e2999b9f400f8f994456d8b9adc3bbf1ae17"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fb06d50de3c8e25523dad7c8e76c70b6c9658090","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"ad37fb21_9d09301b","in_reply_to":"ad9dc764_63b2aa21","updated":"2025-01-24 09:31:37.000000000","message":"Done","commit_id":"1536e2999b9f400f8f994456d8b9adc3bbf1ae17"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"de11879a8d44d835fff9d5ea59c8b8d0f6ed0389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"9971e7a0_105fb5ac","updated":"2024-11-01 13:31:25.000000000","message":"rebased to new CLI","commit_id":"c60207d898152985cf6dbced2b5930aa554f417a"}],"ansible/roles/ceph-rgw/tasks/check.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"80ab3a101dd4631a5eec92d4132c19b3c7541ec5","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  import_role:"},{"line_number":4,"context_line":"    role: service-check"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    service_check_services: \"{{ sahara_services }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"8cc68ee8_209d38f8","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":47},"updated":"2024-05-08 13:20:11.000000000","message":"sahara? ;)","commit_id":"8570e9065e3e081d0c812accbefd622615b5fe17"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"959149f53da49fb2fe0c58e326bb4aa90bd144f9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  import_role:"},{"line_number":4,"context_line":"    role: service-check"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    service_check_services: \"{{ sahara_services }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"c11d4ea7_69d5ab89","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":47},"in_reply_to":"83548d89_83c9366d","updated":"2024-05-23 06:25:30.000000000","message":"Done","commit_id":"8570e9065e3e081d0c812accbefd622615b5fe17"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"353228cb90ed3d061490354cb51c1c836366108b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  import_role:"},{"line_number":4,"context_line":"    role: service-check"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    service_check_services: \"{{ sahara_services }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"83548d89_83c9366d","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":47},"in_reply_to":"8cc68ee8_209d38f8","updated":"2024-05-08 20:03:22.000000000","message":"I wanted to avoid exactly this by automatic lookup of services, but I guess I  messed that one up :) \n\nDone.","commit_id":"8570e9065e3e081d0c812accbefd622615b5fe17"}],"ansible/roles/glance/tasks/check.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"cc60073480804c6e130ec60667886d4e6a5d77dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f79a3b5_d5a4c8ba","updated":"2018-11-05 12:11:26.000000000","message":"Works well for me. Just this check needs to take into account if we\u0027re using the file backend, as only one glance-api will be started in that case (https://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L663)","commit_id":"d44fbdfed14e1001c3400703ece015b2eaaecc6e"}],"tests/deploy.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2879651ca82fb43620d542a7998bfdba8c6a6e59","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if [[ $HAS_UPGRADE \u003d\u003d \u0027no\u0027 ]]; then"},{"line_number":73,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv validate-config \u0026\u003e /tmp/logs/ansible/validate-config"},{"line_number":74,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv check \u0026\u003e /tmp/logs/ansible/check"},{"line_number":75,"context_line":"    fi"},{"line_number":76,"context_line":"}"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"bea7d945_6ad32ca2","line":74,"updated":"2024-09-25 13:43:33.000000000","message":"add a TODO note that this can be moved to regular/non-upgrade section in Epoxy cycle","commit_id":"ef4430c6ec2fa3b9ddd74a92012894173b2c5e8a"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"6af3bb8ed18c6c66748c1d3d13bf11f722a0baf9","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if [[ $HAS_UPGRADE \u003d\u003d \u0027no\u0027 ]]; then"},{"line_number":73,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv validate-config \u0026\u003e /tmp/logs/ansible/validate-config"},{"line_number":74,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv check \u0026\u003e /tmp/logs/ansible/check"},{"line_number":75,"context_line":"    fi"},{"line_number":76,"context_line":"}"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"c319152b_8fe398a7","line":74,"in_reply_to":"bea7d945_6ad32ca2","updated":"2024-09-27 07:23:45.000000000","message":"Done","commit_id":"ef4430c6ec2fa3b9ddd74a92012894173b2c5e8a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fb06d50de3c8e25523dad7c8e76c70b6c9658090","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if [[ $HAS_UPGRADE \u003d\u003d \u0027no\u0027 ]]; then"},{"line_number":73,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv validate-config \u0026\u003e /tmp/logs/ansible/validate-config"},{"line_number":74,"context_line":"        kolla-ansible -i ${RAW_INVENTORY} -vvv check \u0026\u003e /tmp/logs/ansible/check"},{"line_number":75,"context_line":"    fi"},{"line_number":76,"context_line":"}"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"7cfbfae3_c5b9dfde","line":74,"in_reply_to":"c319152b_8fe398a7","updated":"2025-01-24 09:31:37.000000000","message":"Done","commit_id":"ef4430c6ec2fa3b9ddd74a92012894173b2c5e8a"}]}