)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"ec5ad2b6bb61f13ef7ecafe2e5c4b9ed850f94bb","unresolved":false,"context_lines":[{"line_number":744,"context_line":"octavia_spare_amphora_pool_size:"},{"line_number":745,"context_line":"# Heartbeat key is a passphrase that secures health messages from tampering."},{"line_number":746,"context_line":"# You should change it to something random. It is used for HMAC encrypting."},{"line_number":747,"context_line":"octavia_heartbeat_key: \"please_change_this\""},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"###################"},{"line_number":750,"context_line":"# Ceph options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_c14fb167","line":747,"range":{"start_line":747,"start_character":0,"end_line":747,"end_character":43},"updated":"2018-09-21 07:08:42.000000000","message":"can this be a password generated instead if a sample hardcode of a string?\n\nWill it be backwards compatible when upgrading? If not, please add a release note notifying the value of this should match their value","commit_id":"1f6148ecf659be17bb64a90dd24e07b245b81681"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"370b21f8bd2bc2469f394bb8863e05ba03341a84","unresolved":false,"context_lines":[{"line_number":744,"context_line":"octavia_spare_amphora_pool_size:"},{"line_number":745,"context_line":"# Heartbeat key is a passphrase that secures health messages from tampering."},{"line_number":746,"context_line":"# You should change it to something random. It is used for HMAC encrypting."},{"line_number":747,"context_line":"octavia_heartbeat_key: \"please_change_this\""},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"###################"},{"line_number":750,"context_line":"# Ceph options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_3b00c200","line":747,"range":{"start_line":747,"start_character":0,"end_line":747,"end_character":43},"in_reply_to":"3f79a3b5_c14fb167","updated":"2018-09-26 00:14:16.000000000","message":"It is *not* backwards compatible when upgrading. It must always match the value for whatever cloud is being deployed.\nSo, for any given deployment, it needs to *never change*. I don\u0027t know how to generate it *once* in a safe way. If there\u0027s a good way to do that, then yes, that would be ideal. Is there?","commit_id":"1f6148ecf659be17bb64a90dd24e07b245b81681"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"86ce225f07432a0e1144b45140d96b58d5b43379","unresolved":true,"context_lines":[{"line_number":956,"context_line":"octavia_amp_boot_network_list:"},{"line_number":957,"context_line":"octavia_amp_secgroup_list:"},{"line_number":958,"context_line":"octavia_amp_flavor_id:"},{"line_number":959,"context_line":"octavia_spare_amphora_pool_size:"},{"line_number":960,"context_line":"# Heartbeat key is a passphrase that secures health messages from tampering."},{"line_number":961,"context_line":"# You should change it to something random. It is used for HMAC encrypting."},{"line_number":962,"context_line":"octavia_heartbeat_key: \"insecure\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d07ed6bd_72384da2","line":959,"updated":"2021-08-30 09:55:28.000000000","message":"Check line 59-60","commit_id":"79962ab5c33c8da7cc070df691f4b3494f005cee"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"86ce225f07432a0e1144b45140d96b58d5b43379","unresolved":true,"context_lines":[{"line_number":959,"context_line":"octavia_spare_amphora_pool_size:"},{"line_number":960,"context_line":"# Heartbeat key is a passphrase that secures health messages from tampering."},{"line_number":961,"context_line":"# You should change it to something random. It is used for HMAC encrypting."},{"line_number":962,"context_line":"octavia_heartbeat_key: \"insecure\""},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"#################"},{"line_number":965,"context_line":"# Qinling options"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b5a15672_5a11812a","line":962,"updated":"2021-08-30 09:55:28.000000000","message":"This should go to passwords.yml - you can inspire here https://review.opendev.org/c/openstack/kolla-ansible/+/455628.\n\n1. You can find there usage of variable {{ osprofiler_secret }} in services templates.\n2. Define it in etc/kolla/passwords.yml\n3. Include it in kolla_ansible/cmd/genpwd.py \n\nAlso, from my perspective of view this behavious should be configurable - so config will be rendered based on some variable - something as \"enable_amphora_secure\" which should be \"no\" by default as it is now.","commit_id":"79962ab5c33c8da7cc070df691f4b3494f005cee"}],"ansible/roles/octavia/templates/octavia.conf.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"86ce225f07432a0e1144b45140d96b58d5b43379","unresolved":true,"context_lines":[{"line_number":57,"context_line":"controller_ip_port_list \u003d {% for host in groups[\u0027octavia-health-manager\u0027] %}{{ \u0027octavia_network\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ octavia_health_manager_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[house_keeping]"},{"line_number":60,"context_line":"spare_amphora_pool_size \u003d {{ octavia_spare_amphora_pool_size | default(0) }}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[controller_worker]"},{"line_number":63,"context_line":"amp_boot_network_list \u003d {{ octavia_amp_boot_network_list }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e1eaa50a_99063d03","line":60,"updated":"2021-08-30 09:55:28.000000000","message":"This option is already removed in Xena cycle - https://review.opendev.org/c/openstack/octavia/+/787722","commit_id":"79962ab5c33c8da7cc070df691f4b3494f005cee"}]}