)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3698b95695daa23a03e2e615fbbc277884007516","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The fluentd user needs to be able to read all log files in order to"},{"line_number":10,"context_line":"process them. This change adds a check to the common role to check that"},{"line_number":11,"context_line":"all log files under /var/log/kolla/ are readable by the fluetnd user."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2d0a6cde4c35c0c98aab9e688c584f24ac1dd229"},{"line_number":14,"context_line":"Related-Bug: #1794472"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b1106aad","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":63},"updated":"2018-09-26 10:01:51.000000000","message":"femtonit: s/fluetnd/fluentd","commit_id":"89940672c0dad0b79a339cb829637f0a3bde3fde"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8998d004e12f422eda193e1f7415d4c4fa2dd0a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"820b2893_b2ded93b","updated":"2023-03-29 10:01:14.000000000","message":"This check fails for me once OVN has created log files, which are mode 0x640 and owned by root:root.","commit_id":"89ae5c486cac0af20e3e0e726828e380e7bb291f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e19eee56b4be383290bcdb06794c5cc183d02c4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"82d1901c_d224415e","in_reply_to":"820b2893_b2ded93b","updated":"2023-03-29 11:27:04.000000000","message":"and isn\u0027t that exactly what this check is supposed to do? :)","commit_id":"89ae5c486cac0af20e3e0e726828e380e7bb291f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"96f5427fe0d2231ab351710f80c77207ef5d47f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9a31d3d4_439c91cb","in_reply_to":"82d1901c_d224415e","updated":"2023-03-29 11:46:10.000000000","message":"yes, but having a check that fails in a default deploment isn\u0027t helpful. so IMO we need a) a job that runs the check so late that it actually does fail and b) a fix for that issue before merging this.","commit_id":"89ae5c486cac0af20e3e0e726828e380e7bb291f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"569b23d0202fe770fdf4bc1a0b18a1d41ad15ce8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3c01a17b_03d24b8f","in_reply_to":"9a31d3d4_439c91cb","updated":"2023-08-26 20:42:58.000000000","message":"agree, we could change this to the warning message and fail CI on it. this would be useful for CI to find issues like https://bugs.launchpad.net/kolla-ansible/+bug/1794472.","commit_id":"89ae5c486cac0af20e3e0e726828e380e7bb291f"}],"ansible/roles/common/tasks/check.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b07cfd95a0a1264bf2deb832bbeb2ef6351907f7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  command: \u003e-"},{"line_number":5,"context_line":"    docker exec fluentd"},{"line_number":6,"context_line":"    bash -c \u0027"},{"line_number":7,"context_line":"        rc\u003d0"},{"line_number":8,"context_line":"        for f in $(find /var/log/kolla/ -type f); do"},{"line_number":9,"context_line":"            if [[ ! -r $f ]]; then"},{"line_number":10,"context_line":"                echo \"Cannot read $f\""},{"line_number":11,"context_line":"                rc\u003d1"},{"line_number":12,"context_line":"            fi"},{"line_number":13,"context_line":"        done"},{"line_number":14,"context_line":"        exit $rc"},{"line_number":15,"context_line":"    \u0027"},{"line_number":16,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fcd96f7c_bb1de185","line":14,"range":{"start_line":7,"start_character":8,"end_line":14,"end_character":16},"updated":"2023-12-15 10:41:36.000000000","message":"ymmv of course, but a faster variant which doesn\u0027t need to read in each log file twice (once during find and a second time checking it with the builtin conditional expression from bash) would be:\n\n```bash\nrc\u003d0\nfind /var/log/kolla/ -not -readable -type f -exec echo \"Cannot read: \" \"{}\" \u003e\u003e /tmp/fluentd_unreadable_logs \\;\ncat /tmp/fluentd_unreadable_logs \u0026\u0026 rc\u003d1\nexit $rc\n```","commit_id":"89ae5c486cac0af20e3e0e726828e380e7bb291f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"add51b7cb9bdb496db61f124e326a111258b09c8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  command: \u003e-"},{"line_number":5,"context_line":"    docker exec fluentd"},{"line_number":6,"context_line":"    bash -c \u0027"},{"line_number":7,"context_line":"        rc\u003d0"},{"line_number":8,"context_line":"        for f in $(find /var/log/kolla/ -type f); do"},{"line_number":9,"context_line":"            if [[ ! -r $f ]]; then"},{"line_number":10,"context_line":"                echo \"Cannot read $f\""},{"line_number":11,"context_line":"                rc\u003d1"},{"line_number":12,"context_line":"            fi"},{"line_number":13,"context_line":"        done"},{"line_number":14,"context_line":"        exit $rc"},{"line_number":15,"context_line":"    \u0027"},{"line_number":16,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f3a5de7b_5257a785","line":14,"range":{"start_line":7,"start_character":8,"end_line":14,"end_character":16},"in_reply_to":"fcd96f7c_bb1de185","updated":"2024-07-09 10:21:19.000000000","message":"```suggestion\nrc\u003d0\nfind /var/log/kolla/ -not -readable -type f -exec echo \"Cannot read: \" \"{}\" \u003e\u003e /tmp/fluentd_unreadable_logs \\;\ncat /tmp/fluentd_unreadable_logs \u0026\u0026 rc\u003d1\nexit $rc\n```","commit_id":"89ae5c486cac0af20e3e0e726828e380e7bb291f"}]}