)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0ed9efe2209d212e4c7bea5425ea196ab6adc069","unresolved":false,"context_lines":[{"line_number":136,"context_line":"om_rpc_password: \"{{ rabbitmq_password }}\""},{"line_number":137,"context_line":"om_rpc_port: \"{{ rabbitmq_port }}\""},{"line_number":138,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":139,"context_line":"om_rpc_vhost: \"/\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":142,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_4ee6d415","line":139,"updated":"2018-10-11 08:16:46.000000000","message":"If we\u0027re going to make this configurable, do we need to ensure it exists using rabbitmq_vhost? If it\u0027s not configurable, let\u0027s just hard code it into the URL.","commit_id":"5bfcb58427519f6a9ae36d76fba5135358c89962"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"91c43b3976a42ee66095848353104fd10a0ec292","unresolved":false,"context_lines":[{"line_number":136,"context_line":"om_rpc_password: \"{{ rabbitmq_password }}\""},{"line_number":137,"context_line":"om_rpc_port: \"{{ rabbitmq_port }}\""},{"line_number":138,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":139,"context_line":"om_rpc_vhost: \"/\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":142,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_70e36507","line":139,"in_reply_to":"3f79a3b5_1086b166","updated":"2018-10-11 12:48:55.000000000","message":"For backward compatible need to be / vhost(was the default value in oslo)\n\nThis part really ends formatted as your suggested url.\n\nThe configurable part need to be added also at rabbitmq definitions.json, i missed this part","commit_id":"5bfcb58427519f6a9ae36d76fba5135358c89962"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"66bc9d810de78089bacf1bbeb2409e51bcc265f9","unresolved":false,"context_lines":[{"line_number":136,"context_line":"om_rpc_password: \"{{ rabbitmq_password }}\""},{"line_number":137,"context_line":"om_rpc_port: \"{{ rabbitmq_port }}\""},{"line_number":138,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":139,"context_line":"om_rpc_vhost: \"/\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":142,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_1086b166","line":139,"in_reply_to":"3f79a3b5_4ee6d415","updated":"2018-10-11 12:40:45.000000000","message":"I\u0027d also just make it the empty string, and put the / in the URL. AFAIK something like \"amqp://user:pass@host:port//\" is valid here.","commit_id":"5bfcb58427519f6a9ae36d76fba5135358c89962"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f8bf8d0d7505492292e826b6ce7ad46f4af08490","unresolved":false,"context_lines":[{"line_number":136,"context_line":"om_rpc_password: \"{{ rabbitmq_password }}\""},{"line_number":137,"context_line":"om_rpc_port: \"{{ rabbitmq_port }}\""},{"line_number":138,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":139,"context_line":"om_rpc_vhost: \"/\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":142,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_90c5e13f","line":139,"in_reply_to":"3f79a3b5_70e36507","updated":"2018-10-11 12:55:53.000000000","message":"I think Jim is suggesting that we assume a leading /, whatever is configured here. What is done elsewhere?","commit_id":"5bfcb58427519f6a9ae36d76fba5135358c89962"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a9491bac96a122519b1ede4f4f10f4af33c24a0a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"om_rpc_password: \"{{ rabbitmq_password }}\""},{"line_number":137,"context_line":"om_rpc_port: \"{{ rabbitmq_port }}\""},{"line_number":138,"context_line":"om_rpc_group: \"rabbitmq\""},{"line_number":139,"context_line":"om_rpc_vhost: \"/\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"rpc_transport_url: \"{{ om_rpc_transport }}://{% for host in groups[om_rpc_group] %}{{ om_rpc_user }}:{{ om_rpc_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ om_rpc_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ om_rpc_vhost }}\""},{"line_number":142,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_c0c86157","line":139,"in_reply_to":"3f79a3b5_90c5e13f","updated":"2018-10-11 19:15:56.000000000","message":"Right, that was my suggestion.\n\nLooks like openstack-ansible does what we\u0027re doing here, so I\u0027m fine with it. :)\n\nhttps://github.com/openstack/openstack-ansible-os_nova/blob/45e424e63075de4a8ba51f78ced9e6bac6c99c37/defaults/main.yml#L133","commit_id":"5bfcb58427519f6a9ae36d76fba5135358c89962"}]}
