)]}'
{"ansible/roles/masakari/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari/masakari:/var/lib/kolla/venv/lib/python2.7/site-packages/masakari\u0027 if masakari_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":38,"context_line":"    dimensions: \"{{ masakari_engine_dimensions }}\""},{"line_number":39,"context_line":"  masakari-hostmonitor:"},{"line_number":40,"context_line":"    container_name: masakari_hostmonitor"},{"line_number":41,"context_line":"    group: masakari-monitors"},{"line_number":42,"context_line":"    enabled: true"},{"line_number":43,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_2b6d8a2f","line":40,"range":{"start_line":40,"start_character":29,"end_line":40,"end_character":40},"updated":"2018-11-06 09:16:01.000000000","message":"host_monitor?\n\nI guess we should use whatever is standard here, but that seems more consistent to me.","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"5a82ba71b8afbde5c2a2c1dd1fdc2d3cad9a7a5a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari/masakari:/var/lib/kolla/venv/lib/python2.7/site-packages/masakari\u0027 if masakari_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":38,"context_line":"    dimensions: \"{{ masakari_engine_dimensions }}\""},{"line_number":39,"context_line":"  masakari-hostmonitor:"},{"line_number":40,"context_line":"    container_name: masakari_hostmonitor"},{"line_number":41,"context_line":"    group: masakari-monitors"},{"line_number":42,"context_line":"    enabled: true"},{"line_number":43,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_a7fe9736","line":40,"range":{"start_line":40,"start_character":29,"end_line":40,"end_character":40},"in_reply_to":"3f79a3b5_2b6d8a2f","updated":"2018-11-07 01:51:36.000000000","message":"I use masakari_hostmonitor to match container_name with internal running commands [1]: masakari_hostmonitor \u0026 masakari_instancemonitor.\n\n[1] https://github.com/openstack/masakari-monitors","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari/masakari:/var/lib/kolla/venv/lib/python2.7/site-packages/masakarimonitors\u0027 if masakari_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":49,"context_line":"    dimensions: \"{{ masakari_monitors_dimensions }}\""},{"line_number":50,"context_line":"  masakari-instancemonitor:"},{"line_number":51,"context_line":"    container_name: masakari_instance_monitors"},{"line_number":52,"context_line":"    group: masakari-monitors"},{"line_number":53,"context_line":"    enabled: true"},{"line_number":54,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_6b22a204","line":51,"range":{"start_line":51,"start_character":38,"end_line":51,"end_character":46},"updated":"2018-11-06 09:16:01.000000000","message":"monitor?","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"5a82ba71b8afbde5c2a2c1dd1fdc2d3cad9a7a5a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari/masakari:/var/lib/kolla/venv/lib/python2.7/site-packages/masakarimonitors\u0027 if masakari_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":49,"context_line":"    dimensions: \"{{ masakari_monitors_dimensions }}\""},{"line_number":50,"context_line":"  masakari-instancemonitor:"},{"line_number":51,"context_line":"    container_name: masakari_instance_monitors"},{"line_number":52,"context_line":"    group: masakari-monitors"},{"line_number":53,"context_line":"    enabled: true"},{"line_number":54,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_47c78312","line":51,"range":{"start_line":51,"start_character":38,"end_line":51,"end_character":46},"in_reply_to":"3f79a3b5_6b22a204","updated":"2018-11-07 01:51:36.000000000","message":"it should be masakari_instancemonitor.","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":75,"context_line":"####################"},{"line_number":76,"context_line":"# Docker"},{"line_number":77,"context_line":"####################"},{"line_number":78,"context_line":"masakari_install_type: \"source\""},{"line_number":79,"context_line":"masakari_tag: \"{{ openstack_release }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"masakari_api_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ masakari_install_type }}-masakari-api\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_ab799afa","line":78,"range":{"start_line":78,"start_character":24,"end_line":78,"end_character":30},"updated":"2018-11-06 09:16:01.000000000","message":"{{ kolla_install_type }}","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"aa85af5be989e0223b8bfc45d42aa753ad592dff","unresolved":false,"context_lines":[{"line_number":75,"context_line":"####################"},{"line_number":76,"context_line":"# Docker"},{"line_number":77,"context_line":"####################"},{"line_number":78,"context_line":"masakari_install_type: \"source\""},{"line_number":79,"context_line":"masakari_tag: \"{{ openstack_release }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"masakari_api_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ masakari_install_type }}-masakari-api\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_e2423693","line":78,"range":{"start_line":78,"start_character":24,"end_line":78,"end_character":30},"in_reply_to":"3f79a3b5_8786fbb6","updated":"2018-11-07 10:51:59.000000000","message":"Yeah, the same is true for some other images (e.g. monasca, bifrost) but we still tend to use kolla_install_type, in case we add binary images in future.","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"5a82ba71b8afbde5c2a2c1dd1fdc2d3cad9a7a5a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"####################"},{"line_number":76,"context_line":"# Docker"},{"line_number":77,"context_line":"####################"},{"line_number":78,"context_line":"masakari_install_type: \"source\""},{"line_number":79,"context_line":"masakari_tag: \"{{ openstack_release }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"masakari_api_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ masakari_install_type }}-masakari-api\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_8786fbb6","line":78,"range":{"start_line":78,"start_character":24,"end_line":78,"end_character":30},"in_reply_to":"3f79a3b5_ab799afa","updated":"2018-11-07 01:51:36.000000000","message":"I use \"source\" directly instead of kolla_install_type var because we don\u0027t have Masakari binary images [1].\n\n[1] https://review.openstack.org/#/c/615469/6/kolla/image/build.py","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      - \"{{ node_config_directory }}/masakari-hostmonitor/:{{ container_config_directory }}/:ro\""},{"line_number":46,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":47,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":48,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari/masakari:/var/lib/kolla/venv/lib/python2.7/site-packages/masakarimonitors\u0027 if masakari_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":49,"context_line":"    dimensions: \"{{ masakari_monitors_dimensions }}\""},{"line_number":50,"context_line":"  masakari-instancemonitor:"},{"line_number":51,"context_line":"    container_name: masakari_instancemonitor"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_df71bee0","line":48,"updated":"2018-11-12 13:47:12.000000000","message":"missing masakarimonitors","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      - \"{{ node_config_directory }}/masakari-hostmonitor/:{{ container_config_directory }}/:ro\""},{"line_number":46,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":47,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":48,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari/masakari:/var/lib/kolla/venv/lib/python2.7/site-packages/masakarimonitors\u0027 if masakari_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":49,"context_line":"    dimensions: \"{{ masakari_monitors_dimensions }}\""},{"line_number":50,"context_line":"  masakari-instancemonitor:"},{"line_number":51,"context_line":"    container_name: masakari_instancemonitor"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_fa7cc1c8","line":48,"in_reply_to":"3f79a3b5_df71bee0","updated":"2018-11-13 02:08:47.000000000","message":"Done, thank you.","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      - \"{{ node_config_directory }}/masakari-instancemonitor/:{{ container_config_directory }}/:ro\""},{"line_number":57,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":58,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":59,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari/masakari:/var/lib/kolla/venv/lib/python2.7/site-packages/masakarimonitors\u0027 if masakari_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":60,"context_line":"    dimensions: \"{{ masakari_monitors_dimensions }}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_1f64161f","line":59,"updated":"2018-11-12 13:47:12.000000000","message":"missing monitors","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      - \"{{ node_config_directory }}/masakari-instancemonitor/:{{ container_config_directory }}/:ro\""},{"line_number":57,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":58,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":59,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari/masakari:/var/lib/kolla/venv/lib/python2.7/site-packages/masakarimonitors\u0027 if masakari_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":60,"context_line":"    dimensions: \"{{ masakari_monitors_dimensions }}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_9a890dca","line":59,"in_reply_to":"3f79a3b5_1f64161f","updated":"2018-11-13 02:08:47.000000000","message":"Done","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":28614,"name":"jacky06","email":"zhang.min@99cloud.net","username":"jacky06"},"change_message_id":"c5c56a538ab210540338c467a3816765a9166076","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari-monitors/masakarimonitors:/var/lib/kolla/venv/lib/python2.7/site-packages/masakarimonitors\u0027 if masakarimonitors_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":50,"context_line":"    dimensions: \"{{ masakari_monitors_dimensions }}\""},{"line_number":51,"context_line":"  masakari-instancemonitor:"},{"line_number":52,"context_line":"    container_name: masakari_instancemonitor"},{"line_number":53,"context_line":"    group: masakari-monitors"},{"line_number":54,"context_line":"    enabled: true"},{"line_number":55,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f79a3b5_932ad6e2","line":52,"range":{"start_line":52,"start_character":20,"end_line":52,"end_character":44},"updated":"2018-11-21 14:04:33.000000000","message":"I perfer to masakari_instancemonitor to use masakari_instancemonitor image rather than to use others image","commit_id":"a1188b74ade167d6951f39db78cd43b4bf1d544c"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"d5c2ead7084406ac0907b27f21efdd86c346e388","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/masakari-monitors/masakarimonitors:/var/lib/kolla/venv/lib/python2.7/site-packages/masakarimonitors\u0027 if masakarimonitors_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":50,"context_line":"    dimensions: \"{{ masakari_monitors_dimensions }}\""},{"line_number":51,"context_line":"  masakari-instancemonitor:"},{"line_number":52,"context_line":"    container_name: masakari_instancemonitor"},{"line_number":53,"context_line":"    group: masakari-monitors"},{"line_number":54,"context_line":"    enabled: true"},{"line_number":55,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3f79a3b5_19d7bdf6","line":52,"range":{"start_line":52,"start_character":20,"end_line":52,"end_character":44},"in_reply_to":"3f79a3b5_932ad6e2","updated":"2018-11-22 03:51:59.000000000","message":"masakari_instancemonitor \u0026 masakari_hostmonitor are two executable commands of masakari-monitors agent [1]. Because there should be one process/cmd per container, so I define 2 containers for each command, same image but different cmd.\n\n[1] https://github.com/openstack/masakari-monitors","commit_id":"a1188b74ade167d6951f39db78cd43b4bf1d544c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5e4a6c105edd96091d41e7e682fddc84d7593067","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    dimensions: \"{{ masakari_engine_dimensions }}\""},{"line_number":30,"context_line":"  masakari-instancemonitor:"},{"line_number":31,"context_line":"    container_name: masakari_instancemonitor"},{"line_number":32,"context_line":"    group: masakari-monitors"},{"line_number":33,"context_line":"    enabled: true"},{"line_number":34,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""},{"line_number":35,"context_line":"    volumes: \"{{ masakari_instancemonitor_default_volumes + masakari_instancemonitor_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_dcfcfcb6","line":32,"range":{"start_line":32,"start_character":11,"end_line":32,"end_character":28},"updated":"2019-07-26 16:28:27.000000000","message":"Don\u0027t we want it to agree with the key \u0027masakari-instancemonitor\u0027?","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"ee7eafc796cfc7a99ac58f1efa78c2dccf0bccb1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    dimensions: \"{{ masakari_engine_dimensions }}\""},{"line_number":30,"context_line":"  masakari-instancemonitor:"},{"line_number":31,"context_line":"    container_name: masakari_instancemonitor"},{"line_number":32,"context_line":"    group: masakari-monitors"},{"line_number":33,"context_line":"    enabled: true"},{"line_number":34,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""},{"line_number":35,"context_line":"    volumes: \"{{ masakari_instancemonitor_default_volumes + masakari_instancemonitor_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_fca1b896","line":32,"range":{"start_line":32,"start_character":11,"end_line":32,"end_character":28},"in_reply_to":"7faddb67_dcfcfcb6","updated":"2019-07-26 16:38:13.000000000","message":"masakari-monitors group will host masakari-instancemonitor, masakari-hostmonitor and masakari-processmonitor","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"485a2c4a47ec7eafa27c9b92cb16710986cef618","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    dimensions: \"{{ masakari_engine_dimensions }}\""},{"line_number":30,"context_line":"  masakari-instancemonitor:"},{"line_number":31,"context_line":"    container_name: masakari_instancemonitor"},{"line_number":32,"context_line":"    group: masakari-monitors"},{"line_number":33,"context_line":"    enabled: true"},{"line_number":34,"context_line":"    image: \"{{ masakari_monitors_image_full }}\""},{"line_number":35,"context_line":"    volumes: \"{{ masakari_instancemonitor_default_volumes + masakari_instancemonitor_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_bc2020f9","line":32,"range":{"start_line":32,"start_character":11,"end_line":32,"end_character":28},"in_reply_to":"7faddb67_fca1b896","updated":"2019-07-26 16:45:42.000000000","message":"I see. Makes sense.","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"}],"ansible/roles/masakari/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    service: \"{{ masakari_services[service_name] }}\""},{"line_number":57,"context_line":"    config_json: \"{{ masakari_config_jsons.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":58,"context_line":"    masakarimonitors_conf: \"{{ masakarimonitors_confs.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":59,"context_line":"    masakari_instancemonitor_container: \"{{ check_masakari_containers.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":60,"context_line":"  become: true"},{"line_number":61,"context_line":"  kolla_docker:"},{"line_number":62,"context_line":"    action: \"recreate_or_restart_container\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_4b86c6b9","line":59,"range":{"start_line":59,"start_character":13,"end_line":59,"end_character":28},"updated":"2018-11-06 09:16:01.000000000","message":"This is instance_monitor in defaults/main.yml","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3e458ceb6625b0377b21eae2282b3d14428bfcb5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":87,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":88,"context_line":"    image: \"{{ service.image }}\""},{"line_number":89,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":90,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":91,"context_line":"  when:"},{"line_number":92,"context_line":"    - kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3f79a3b5_047a5026","line":89,"updated":"2018-12-13 18:35:24.000000000","message":"privileged is missing here, while is defined at defaults","commit_id":"965da0ee4ccf114a4c35cbcc8b7ea10d3a5bf25b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"masakari-api\""},{"line_number":5,"context_line":"    service: \"{{ masakari_services[service_name] }}\""},{"line_number":6,"context_line":"    config_json: \"{{ masakari_config_jsons.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":7,"context_line":"    masakari_conf: \"{{ masakari_confs.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":8,"context_line":"    policy_overwriting: \"{{ masakari_policy_overwriting.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":9,"context_line":"    masakari_api_container: \"{{ check_masakari_containers.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  kolla_docker:"},{"line_number":12,"context_line":"    action: \"recreate_or_restart_container\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_902c2ead","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":123},"updated":"2019-08-12 16:31:58.000000000","message":"We no longer use these variables. See I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd.","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service_name: \"masakari-api\""},{"line_number":5,"context_line":"    service: \"{{ masakari_services[service_name] }}\""},{"line_number":6,"context_line":"    config_json: \"{{ masakari_config_jsons.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":7,"context_line":"    masakari_conf: \"{{ masakari_confs.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":8,"context_line":"    policy_overwriting: \"{{ masakari_policy_overwriting.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":9,"context_line":"    masakari_api_container: \"{{ check_masakari_containers.results|selectattr(\u0027item.key\u0027, \u0027equalto\u0027, service_name)|first }}\""},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  kolla_docker:"},{"line_number":12,"context_line":"    action: \"recreate_or_restart_container\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_7947f31e","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":123},"in_reply_to":"7faddb67_902c2ead","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":21,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":22,"context_line":"    - service.enabled | bool"},{"line_number":23,"context_line":"    - config_json.changed | bool"},{"line_number":24,"context_line":"      or masakari_conf.changed | bool"},{"line_number":25,"context_line":"      or masakari_conf_wsgi.changed | bool"},{"line_number":26,"context_line":"      or masakari_api_paste_ini.changed | bool"},{"line_number":27,"context_line":"      or masakari_api_container.changed | bool"},{"line_number":28,"context_line":"      or policy_overwriting.changed | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Restart masakari-engine container"},{"line_number":31,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_b027eac7","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":42},"updated":"2019-08-12 16:31:58.000000000","message":"We no longer use these variables. See I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd.","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":21,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":22,"context_line":"    - service.enabled | bool"},{"line_number":23,"context_line":"    - config_json.changed | bool"},{"line_number":24,"context_line":"      or masakari_conf.changed | bool"},{"line_number":25,"context_line":"      or masakari_conf_wsgi.changed | bool"},{"line_number":26,"context_line":"      or masakari_api_paste_ini.changed | bool"},{"line_number":27,"context_line":"      or masakari_api_container.changed | bool"},{"line_number":28,"context_line":"      or policy_overwriting.changed | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Restart masakari-engine container"},{"line_number":31,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_19503fd5","line":28,"range":{"start_line":21,"start_character":0,"end_line":28,"end_character":42},"in_reply_to":"7faddb67_b027eac7","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"}],"ansible/roles/masakari/tasks/bootstrap.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"937b85c9751d19c0d7e1829e667d3b9c01acef9c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":10,"context_line":"      login_password: \"{{ database_password }}\""},{"line_number":11,"context_line":"      name: \"{{ masakari_database_name }}\""},{"line_number":12,"context_line":"  register: database"},{"line_number":13,"context_line":"  run_once: True"},{"line_number":14,"context_line":"  delegate_to: \"{{ groups[\u0027masakari-api\u0027][0] }}\""},{"line_number":15,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"7faddb67_1b62c8d9","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":20},"updated":"2019-07-24 09:00:11.000000000","message":"v continued","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"040cbd4142293f18b1b8e7eac95aacc23c3e000a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      login_user: \"{{ database_user }}\""},{"line_number":10,"context_line":"      login_password: \"{{ database_password }}\""},{"line_number":11,"context_line":"      name: \"{{ masakari_database_name }}\""},{"line_number":12,"context_line":"  register: database"},{"line_number":13,"context_line":"  run_once: True"},{"line_number":14,"context_line":"  delegate_to: \"{{ groups[\u0027masakari-api\u0027][0] }}\""},{"line_number":15,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"7faddb67_ed20479e","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":20},"in_reply_to":"7faddb67_1b62c8d9","updated":"2019-07-24 15:44:02.000000000","message":"Done","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"937b85c9751d19c0d7e1829e667d3b9c01acef9c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    - not use_preconfigured_databases | bool"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- include_tasks: bootstrap_service.yml"},{"line_number":38,"context_line":"  when: database.changed or use_preconfigured_databases | bool"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"7faddb67_db9990d0","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":62},"updated":"2019-07-24 09:00:11.000000000","message":"we changed to bootstrap always: https://review.opendev.org/650962","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"040cbd4142293f18b1b8e7eac95aacc23c3e000a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    - not use_preconfigured_databases | bool"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- include_tasks: bootstrap_service.yml"},{"line_number":38,"context_line":"  when: database.changed or use_preconfigured_databases | bool"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"7faddb67_0d2603b9","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":62},"in_reply_to":"7faddb67_db9990d0","updated":"2019-07-24 15:44:02.000000000","message":"Done","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"}],"ansible/roles/masakari/tasks/check.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"937b85c9751d19c0d7e1829e667d3b9c01acef9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"7faddb67_bba854db","line":2,"updated":"2019-07-24 09:00:11.000000000","message":"can we check anything?","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"040cbd4142293f18b1b8e7eac95aacc23c3e000a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"7faddb67_ed55a7fb","line":2,"in_reply_to":"7faddb67_bba854db","updated":"2019-07-24 15:44:02.000000000","message":"Nothing in mind.","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e4f018e4560fc0801b9a5e67288fa311937614d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"7faddb67_4d32bba9","line":2,"in_reply_to":"7faddb67_ed55a7fb","updated":"2019-07-24 16:01:44.000000000","message":"OK","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"}],"ansible/roles/masakari/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      - \"{{ role_path }}/templates/masakarimonitors.conf.j2\""},{"line_number":96,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":97,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors.conf\""},{"line_number":98,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors/{{ item }}.conf\""},{"line_number":99,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors/{{ inventory_hostname }}/masakarimonitors.conf\""},{"line_number":100,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/masakarimonitors.conf\""},{"line_number":101,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_cb365602","line":98,"range":{"start_line":98,"start_character":34,"end_line":98,"end_character":50},"updated":"2018-11-06 09:16:01.000000000","message":"I think the normal pattern is to put masakari here.","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"5a82ba71b8afbde5c2a2c1dd1fdc2d3cad9a7a5a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      - \"{{ role_path }}/templates/masakarimonitors.conf.j2\""},{"line_number":96,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":97,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors.conf\""},{"line_number":98,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors/{{ item }}.conf\""},{"line_number":99,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors/{{ inventory_hostname }}/masakarimonitors.conf\""},{"line_number":100,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/masakarimonitors.conf\""},{"line_number":101,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_8774bbce","line":98,"range":{"start_line":98,"start_character":34,"end_line":98,"end_character":50},"in_reply_to":"3f79a3b5_cb365602","updated":"2018-11-07 01:51:36.000000000","message":"Good point, thank you.","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":97,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors.conf\""},{"line_number":98,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors/{{ item }}.conf\""},{"line_number":99,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors/{{ inventory_hostname }}/masakarimonitors.conf\""},{"line_number":100,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/masakarimonitors.conf\""},{"line_number":101,"context_line":"    mode: \"0660\""},{"line_number":102,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_8b1cde7b","line":99,"range":{"start_line":99,"start_character":34,"end_line":99,"end_character":50},"updated":"2018-11-06 09:16:01.000000000","message":"and here","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"aa85af5be989e0223b8bfc45d42aa753ad592dff","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":97,"context_line":"      - \"{{ node_custom_config }}/masakarimonitors.conf\""},{"line_number":98,"context_line":"      - \"{{ node_custom_config }}/masakari/{{ item }}.conf\""},{"line_number":99,"context_line":"      - \"{{ node_custom_config }}/masakari/masakarimonitors.conf\""},{"line_number":100,"context_line":"      - \"{{ node_custom_config }}/masakari/{{ inventory_hostname }}/masakarimonitors.conf\""},{"line_number":101,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/masakarimonitors.conf\""},{"line_number":102,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_0208922b","line":99,"range":{"start_line":99,"start_character":8,"end_line":99,"end_character":65},"updated":"2018-11-07 10:51:59.000000000","message":"This one is basically the same as \"{{ node_custom_config }}/masakarimonitors.conf\". We only need one of these two.","commit_id":"6d70c97b84bf839f58009b4a4265c18d701a8631"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":13,"context_line":"  with_dict: \"{{ masakari_services }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# NOTE(kiennt): masakari-monitors doesn\u0027t create /etc/masakarimonitors"},{"line_number":16,"context_line":"# directory. Therefore, kolla-ansible has to copy the whole"},{"line_number":17,"context_line":"# masakarimonitors directory instead of masakarimonitor.conf."},{"line_number":18,"context_line":"- name: Ensuring masakarimonitors directories exist"},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    service: \"{{ masakari_services[item] }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_1f3df6e4","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":61},"updated":"2018-11-12 13:47:12.000000000","message":"this could be done during image build, is done in other services so here we just change the files we need to change,and not maintain","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# NOTE(kiennt): masakari-monitors doesn\u0027t create /etc/masakarimonitors"},{"line_number":16,"context_line":"# directory. Therefore, kolla-ansible has to copy the whole"},{"line_number":17,"context_line":"# masakarimonitors directory instead of masakarimonitor.conf."},{"line_number":18,"context_line":"- name: Ensuring masakarimonitors directories exist"},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    service: \"{{ masakari_services[item] }}\""},{"line_number":21,"context_line":"  file:"},{"line_number":22,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}/masakarimonitors\""},{"line_number":23,"context_line":"    state: \"directory\""},{"line_number":24,"context_line":"    owner: \"{{ config_owner_user }}\""},{"line_number":25,"context_line":"    group: \"{{ config_owner_group }}\""},{"line_number":26,"context_line":"    mode: \"0770\""},{"line_number":27,"context_line":"  become: true"},{"line_number":28,"context_line":"  when:"},{"line_number":29,"context_line":"    - service.enabled | bool"},{"line_number":30,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":31,"context_line":"  with_items:"},{"line_number":32,"context_line":"    - \"masakari-instancemonitor\""},{"line_number":33,"context_line":"    - \"masakari-hostmonitor\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Check if policies shall be overwritten"},{"line_number":36,"context_line":"  local_action: stat path\u003d\"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_ff559a1f","line":33,"range":{"start_line":18,"start_character":0,"end_line":33,"end_character":28},"updated":"2018-11-12 13:47:12.000000000","message":"i dont fully understand what is trying to acchieve here. Why create a local folder why all the content, you can define paths at the corresponding config.json file","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# NOTE(kiennt): masakari-monitors doesn\u0027t create /etc/masakarimonitors"},{"line_number":16,"context_line":"# directory. Therefore, kolla-ansible has to copy the whole"},{"line_number":17,"context_line":"# masakarimonitors directory instead of masakarimonitor.conf."},{"line_number":18,"context_line":"- name: Ensuring masakarimonitors directories exist"},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    service: \"{{ masakari_services[item] }}\""},{"line_number":21,"context_line":"  file:"},{"line_number":22,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}/masakarimonitors\""},{"line_number":23,"context_line":"    state: \"directory\""},{"line_number":24,"context_line":"    owner: \"{{ config_owner_user }}\""},{"line_number":25,"context_line":"    group: \"{{ config_owner_group }}\""},{"line_number":26,"context_line":"    mode: \"0770\""},{"line_number":27,"context_line":"  become: true"},{"line_number":28,"context_line":"  when:"},{"line_number":29,"context_line":"    - service.enabled | bool"},{"line_number":30,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":31,"context_line":"  with_items:"},{"line_number":32,"context_line":"    - \"masakari-instancemonitor\""},{"line_number":33,"context_line":"    - \"masakari-hostmonitor\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Check if policies shall be overwritten"},{"line_number":36,"context_line":"  local_action: stat path\u003d\"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_3ab47981","line":33,"range":{"start_line":18,"start_character":0,"end_line":33,"end_character":28},"in_reply_to":"3f79a3b5_ff559a1f","updated":"2018-11-13 02:08:47.000000000","message":"Because masakarimonitors does not create etc/masakarimonitors, that\u0027s why Kolla-ansible has to create it first. But according to your previous comment, I think that moving the directory creation to Kolla image build is a better approach. Thank you.","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"19fc6e0419fcec651b8d3ba7f514142a0ded0925","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    - masakari_policy_file is defined"},{"line_number":63,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":64,"context_line":"    - service.enabled | bool"},{"line_number":65,"context_line":"  with_items:"},{"line_number":66,"context_line":"    - \"masakari-api\""},{"line_number":67,"context_line":"    - \"masakari-engine\""},{"line_number":68,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_3d99da1b","line":65,"range":{"start_line":65,"start_character":2,"end_line":65,"end_character":12},"updated":"2018-11-12 15:41:34.000000000","message":"with_dict","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    - masakari_policy_file is defined"},{"line_number":63,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":64,"context_line":"    - service.enabled | bool"},{"line_number":65,"context_line":"  with_items:"},{"line_number":66,"context_line":"    - \"masakari-api\""},{"line_number":67,"context_line":"    - \"masakari-engine\""},{"line_number":68,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_9a502d30","line":65,"range":{"start_line":65,"start_character":2,"end_line":65,"end_character":12},"in_reply_to":"3f79a3b5_3d99da1b","updated":"2018-11-13 02:08:47.000000000","message":"No, it has to be with_items, there is no dict here. It differs with other services because just a sub-services (masakari-api \u0026 masakari-engine in this task) need a config not all masakari_services.","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"19fc6e0419fcec651b8d3ba7f514142a0ded0925","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  when:"},{"line_number":102,"context_line":"    - service.enabled | bool"},{"line_number":103,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":104,"context_line":"  with_items:"},{"line_number":105,"context_line":"    - \"masakari-api\""},{"line_number":106,"context_line":"    - \"masakari-engine\""},{"line_number":107,"context_line":"  notify:"},{"line_number":108,"context_line":"    - \"Restart {{ item }} container\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Copying over masakarimonitors.conf"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_1d965eef","line":107,"range":{"start_line":104,"start_character":0,"end_line":107,"end_character":9},"updated":"2018-11-12 15:41:34.000000000","message":"here should be with_dict","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  when:"},{"line_number":102,"context_line":"    - service.enabled | bool"},{"line_number":103,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":104,"context_line":"  with_items:"},{"line_number":105,"context_line":"    - \"masakari-api\""},{"line_number":106,"context_line":"    - \"masakari-engine\""},{"line_number":107,"context_line":"  notify:"},{"line_number":108,"context_line":"    - \"Restart {{ item }} container\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Copying over masakarimonitors.conf"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_ba4de994","line":107,"range":{"start_line":104,"start_character":0,"end_line":107,"end_character":9},"in_reply_to":"3f79a3b5_1d965eef","updated":"2018-11-13 02:08:47.000000000","message":"Same as the previous comment.","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"42654c92c33675428c2e2505f3928cc88e3290eb","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Copying over config.json files for services"},{"line_number":52,"context_line":"  vars:"},{"line_number":53,"context_line":"    service: \"{{ item.key }}\""},{"line_number":54,"context_line":"  template:"},{"line_number":55,"context_line":"    src: \"{{ item.key }}.json.j2\""},{"line_number":56,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/config.json\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_14c0692c","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":29},"updated":"2018-11-13 14:08:56.000000000","message":"why defined the service, it not used in this task","commit_id":"dec847533b27dda559736f69d0d2b3af19c5c949"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"13aa5ec352ab4dcd1dcf95468f8b51a3c3596158","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Copying over config.json files for services"},{"line_number":52,"context_line":"  vars:"},{"line_number":53,"context_line":"    service: \"{{ item.key }}\""},{"line_number":54,"context_line":"  template:"},{"line_number":55,"context_line":"    src: \"{{ item.key }}.json.j2\""},{"line_number":56,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/config.json\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_e05ac01d","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":29},"in_reply_to":"3f79a3b5_14c0692c","updated":"2018-11-14 00:57:57.000000000","message":"removed, thank you.","commit_id":"dec847533b27dda559736f69d0d2b3af19c5c949"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b120a943c7685048618975baf2975aac4b6ac91f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":131,"context_line":"    name: \"{{ item.value.container_name }}\""},{"line_number":132,"context_line":"    image: \"{{ item.value.image }}\""},{"line_number":133,"context_line":"    volumes: \"{{ item.value.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":134,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":135,"context_line":"  register: check_masakari_containers"},{"line_number":136,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3f79a3b5_846d006a","line":133,"updated":"2018-12-13 18:35:49.000000000","message":"also here","commit_id":"965da0ee4ccf114a4c35cbcc8b7ea10d3a5bf25b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5e4a6c105edd96091d41e7e682fddc84d7593067","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  notify:"},{"line_number":80,"context_line":"    - Restart {{ item.key }} container"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: Copying over masakari-monitors.conf"},{"line_number":83,"context_line":"  vars:"},{"line_number":84,"context_line":"    service: \"{{ item.key }}\""},{"line_number":85,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_fc20d84b","line":82,"range":{"start_line":82,"start_character":21,"end_line":82,"end_character":38},"updated":"2019-07-26 16:28:27.000000000","message":"ditto","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"485a2c4a47ec7eafa27c9b92cb16710986cef618","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  notify:"},{"line_number":80,"context_line":"    - Restart {{ item.key }} container"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: Copying over masakari-monitors.conf"},{"line_number":83,"context_line":"  vars:"},{"line_number":84,"context_line":"    service: \"{{ item.key }}\""},{"line_number":85,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_fc6bf81b","line":82,"range":{"start_line":82,"start_character":21,"end_line":82,"end_character":38},"in_reply_to":"7faddb67_9cdf640b","updated":"2019-07-26 16:45:42.000000000","message":"I wonder whether that is correct. Other monitors should not need libvirt access I guess?","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"ee7eafc796cfc7a99ac58f1efa78c2dccf0bccb1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  notify:"},{"line_number":80,"context_line":"    - Restart {{ item.key }} container"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: Copying over masakari-monitors.conf"},{"line_number":83,"context_line":"  vars:"},{"line_number":84,"context_line":"    service: \"{{ item.key }}\""},{"line_number":85,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_9cdf640b","line":82,"range":{"start_line":82,"start_character":21,"end_line":82,"end_character":38},"in_reply_to":"7faddb67_fc20d84b","updated":"2019-07-26 16:38:13.000000000","message":"From masakari-monitors repository, the default config file name is masakarimonitors.conf. I just added a - to be clearer.","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"07b722c33eab0ac198f4ddde21bef130c97b322c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  notify:"},{"line_number":80,"context_line":"    - Restart {{ item.key }} container"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: Copying over masakari-monitors.conf"},{"line_number":83,"context_line":"  vars:"},{"line_number":84,"context_line":"    service: \"{{ item.key }}\""},{"line_number":85,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_dc8cfcd8","line":82,"range":{"start_line":82,"start_character":21,"end_line":82,"end_character":38},"in_reply_to":"7faddb67_fc6bf81b","updated":"2019-07-26 16:56:03.000000000","message":"Technically for the host monitor, no. For the process monitor I have a doubt because it\u0027s done via QEMU guest agent.","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5e4a6c105edd96091d41e7e682fddc84d7593067","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    service: \"{{ item.key }}\""},{"line_number":85,"context_line":"  merge_configs:"},{"line_number":86,"context_line":"    sources:"},{"line_number":87,"context_line":"      - \"{{ role_path }}/templates/masakari-monitors.conf.j2\""},{"line_number":88,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":89,"context_line":"      - \"{{ node_custom_config }}/masakari/{{ item.key }}.conf\""},{"line_number":90,"context_line":"      - \"{{ node_custom_config }}/masakari/masakari-monitors.conf\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_1c1cd411","line":87,"range":{"start_line":87,"start_character":35,"end_line":87,"end_character":52},"updated":"2019-07-26 16:28:27.000000000","message":"ditto (+ filename)","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5e4a6c105edd96091d41e7e682fddc84d7593067","unresolved":false,"context_lines":[{"line_number":87,"context_line":"      - \"{{ role_path }}/templates/masakari-monitors.conf.j2\""},{"line_number":88,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":89,"context_line":"      - \"{{ node_custom_config }}/masakari/{{ item.key }}.conf\""},{"line_number":90,"context_line":"      - \"{{ node_custom_config }}/masakari/masakari-monitors.conf\""},{"line_number":91,"context_line":"      - \"{{ node_custom_config }}/masakari/{{ inventory_hostname }}/masakari-monitors.conf\""},{"line_number":92,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/masakari-monitors.conf\""},{"line_number":93,"context_line":"    mode: \"0660\""},{"line_number":94,"context_line":"  become: true"},{"line_number":95,"context_line":"  register: masakari_monitors_confs"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_7cd2a836","line":92,"range":{"start_line":90,"start_character":0,"end_line":92,"end_character":77},"updated":"2019-07-26 16:28:27.000000000","message":"3 dittos?","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/{{ masakari_policy_file }}\""},{"line_number":36,"context_line":"    mode: \"0660\""},{"line_number":37,"context_line":"  become: true"},{"line_number":38,"context_line":"  register: masakari_policy_overwriting"},{"line_number":39,"context_line":"  when:"},{"line_number":40,"context_line":"    - masakari_policy_file is defined"},{"line_number":41,"context_line":"    - inventory_hostname in groups[item.value.group]"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_6b298387","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":39},"updated":"2019-08-12 16:31:58.000000000","message":"Not required","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/{{ masakari_policy_file }}\""},{"line_number":36,"context_line":"    mode: \"0660\""},{"line_number":37,"context_line":"  become: true"},{"line_number":38,"context_line":"  register: masakari_policy_overwriting"},{"line_number":39,"context_line":"  when:"},{"line_number":40,"context_line":"    - masakari_policy_file is defined"},{"line_number":41,"context_line":"    - inventory_hostname in groups[item.value.group]"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_59731781","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":39},"in_reply_to":"7faddb67_6b298387","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/config.json\""},{"line_number":51,"context_line":"    mode: \"0660\""},{"line_number":52,"context_line":"  become: true"},{"line_number":53,"context_line":"  register: masakari_config_jsons"},{"line_number":54,"context_line":"  when:"},{"line_number":55,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":56,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_cb3997d8","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":33},"updated":"2019-08-12 16:31:58.000000000","message":"Not required","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/config.json\""},{"line_number":51,"context_line":"    mode: \"0660\""},{"line_number":52,"context_line":"  become: true"},{"line_number":53,"context_line":"  register: masakari_config_jsons"},{"line_number":54,"context_line":"  when:"},{"line_number":55,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":56,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_79705373","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":33},"in_reply_to":"7faddb67_cb3997d8","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/masakari.conf\""},{"line_number":72,"context_line":"    mode: \"0660\""},{"line_number":73,"context_line":"  become: true"},{"line_number":74,"context_line":"  register: masakari_confs"},{"line_number":75,"context_line":"  when:"},{"line_number":76,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":77,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_8b339ff6","line":74,"range":{"start_line":74,"start_character":2,"end_line":74,"end_character":26},"updated":"2019-08-12 16:31:58.000000000","message":"Not required","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/masakari.conf\""},{"line_number":72,"context_line":"    mode: \"0660\""},{"line_number":73,"context_line":"  become: true"},{"line_number":74,"context_line":"  register: masakari_confs"},{"line_number":75,"context_line":"  when:"},{"line_number":76,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":77,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_19691f8b","line":74,"range":{"start_line":74,"start_character":2,"end_line":74,"end_character":26},"in_reply_to":"7faddb67_8b339ff6","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/masakari-monitors.conf\""},{"line_number":93,"context_line":"    mode: \"0660\""},{"line_number":94,"context_line":"  become: true"},{"line_number":95,"context_line":"  register: masakari_monitors_confs"},{"line_number":96,"context_line":"  when:"},{"line_number":97,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":98,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_4b4b675e","line":95,"range":{"start_line":95,"start_character":2,"end_line":95,"end_character":35},"updated":"2019-08-12 16:31:58.000000000","message":"Not required","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/masakari-monitors.conf\""},{"line_number":93,"context_line":"    mode: \"0660\""},{"line_number":94,"context_line":"  become: true"},{"line_number":95,"context_line":"  register: masakari_monitors_confs"},{"line_number":96,"context_line":"  when:"},{"line_number":97,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":98,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_d904e7c8","line":95,"range":{"start_line":95,"start_character":2,"end_line":95,"end_character":35},"in_reply_to":"7faddb67_4b4b675e","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    dest: \"{{ node_config_directory }}/masakari-api/wsgi-masakari.conf\""},{"line_number":109,"context_line":"    mode: \"0660\""},{"line_number":110,"context_line":"  become: true"},{"line_number":111,"context_line":"  register: masakari_conf_wsgi"},{"line_number":112,"context_line":"  when:"},{"line_number":113,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":114,"context_line":"    - service.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_6b4e636f","line":111,"range":{"start_line":111,"start_character":2,"end_line":111,"end_character":30},"updated":"2019-08-12 16:31:58.000000000","message":"Not required","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    dest: \"{{ node_config_directory }}/masakari-api/wsgi-masakari.conf\""},{"line_number":109,"context_line":"    mode: \"0660\""},{"line_number":110,"context_line":"  become: true"},{"line_number":111,"context_line":"  register: masakari_conf_wsgi"},{"line_number":112,"context_line":"  when:"},{"line_number":113,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":114,"context_line":"    - service.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_f909a3dc","line":111,"range":{"start_line":111,"start_character":2,"end_line":111,"end_character":30},"in_reply_to":"7faddb67_6b4e636f","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    dest: \"{{ node_config_directory }}/masakari-api/masakari-api-paste.ini\""},{"line_number":126,"context_line":"    mode: \"0660\""},{"line_number":127,"context_line":"  become: true"},{"line_number":128,"context_line":"  register: masakari_api_paste_ini"},{"line_number":129,"context_line":"  when:"},{"line_number":130,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":131,"context_line":"    - service.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_0b556ffa","line":128,"range":{"start_line":128,"start_character":2,"end_line":128,"end_character":34},"updated":"2019-08-12 16:31:58.000000000","message":"Not required","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    dest: \"{{ node_config_directory }}/masakari-api/masakari-api-paste.ini\""},{"line_number":126,"context_line":"    mode: \"0660\""},{"line_number":127,"context_line":"  become: true"},{"line_number":128,"context_line":"  register: masakari_api_paste_ini"},{"line_number":129,"context_line":"  when:"},{"line_number":130,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":131,"context_line":"    - service.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_990aefce","line":128,"range":{"start_line":128,"start_character":2,"end_line":128,"end_character":34},"in_reply_to":"7faddb67_0b556ffa","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    privileged: \"{{ item.value.privileged | default(False) }}\""},{"line_number":143,"context_line":"    volumes: \"{{ item.value.volumes | reject(\u0027equalto\u0027, \u0027\u0027) | list }}\""},{"line_number":144,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":145,"context_line":"  register: check_masakari_containers"},{"line_number":146,"context_line":"  when:"},{"line_number":147,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":148,"context_line":"    - inventory_hostname in groups[item.value.group]"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_cb3e77b8","line":145,"range":{"start_line":145,"start_character":3,"end_line":145,"end_character":37},"updated":"2019-08-12 16:31:58.000000000","message":"Not required","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    privileged: \"{{ item.value.privileged | default(False) }}\""},{"line_number":143,"context_line":"    volumes: \"{{ item.value.volumes | reject(\u0027equalto\u0027, \u0027\u0027) | list }}\""},{"line_number":144,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":145,"context_line":"  register: check_masakari_containers"},{"line_number":146,"context_line":"  when:"},{"line_number":147,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":148,"context_line":"    - inventory_hostname in groups[item.value.group]"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_b90fabde","line":145,"range":{"start_line":145,"start_character":3,"end_line":145,"end_character":37},"in_reply_to":"7faddb67_cb3e77b8","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"}],"ansible/roles/masakari/templates/masakari-monitors.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"937b85c9751d19c0d7e1829e667d3b9c01acef9c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"username \u003d {{ masakari_keystone_user }}"},{"line_number":12,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[libvirt]"},{"line_number":15,"context_line":"connection_uri \u003d \"qemu+tcp://{{ migration_interface_address }}/system\""}],"source_content_type":"text/x-jinja2","patch_set":43,"id":"7faddb67_9b823800","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":70},"updated":"2019-07-24 09:00:11.000000000","message":"we should probably coordinate this with nova-compute (e.g. there is more than libvirt with qemu to handle, let\u0027s slap a todo for now and prepare the docs saying only libvirt with qemu[+kvm] is supported for now)","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"2669585fd023cbdcf45a481069becc3ec8327d3d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"username \u003d {{ masakari_keystone_user }}"},{"line_number":12,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[libvirt]"},{"line_number":15,"context_line":"connection_uri \u003d \"qemu+tcp://{{ migration_interface_address }}/system\""}],"source_content_type":"text/x-jinja2","patch_set":43,"id":"7faddb67_3599c51e","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":70},"in_reply_to":"7faddb67_0dafe394","updated":"2019-07-24 19:17:48.000000000","message":"Masakari will just connect to libvirtd to get the events. Should not be an issue whether xen:/// or qemu:/// but I could  add documentation.","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ee01029f31e6bc308ac53622bbe9dcdacfb806f0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"username \u003d {{ masakari_keystone_user }}"},{"line_number":12,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[libvirt]"},{"line_number":15,"context_line":"connection_uri \u003d \"qemu+tcp://{{ migration_interface_address }}/system\""}],"source_content_type":"text/x-jinja2","patch_set":43,"id":"7faddb67_36a1b247","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":70},"in_reply_to":"7faddb67_3599c51e","updated":"2019-07-26 11:24:17.000000000","message":"I see qemu here. Let\u0027s get this just documented for now.","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e4f018e4560fc0801b9a5e67288fa311937614d1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"username \u003d {{ masakari_keystone_user }}"},{"line_number":12,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[libvirt]"},{"line_number":15,"context_line":"connection_uri \u003d \"qemu+tcp://{{ migration_interface_address }}/system\""}],"source_content_type":"text/x-jinja2","patch_set":43,"id":"7faddb67_0dafe394","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":70},"in_reply_to":"7faddb67_4d7abb88","updated":"2019-07-24 16:01:44.000000000","message":"There is no doc about it. The question is whether we can support something else that we support with nova but not with masakari? Anyways, we will need docs for masakari deployment (can be separate change).","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"040cbd4142293f18b1b8e7eac95aacc23c3e000a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"username \u003d {{ masakari_keystone_user }}"},{"line_number":12,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[libvirt]"},{"line_number":15,"context_line":"connection_uri \u003d \"qemu+tcp://{{ migration_interface_address }}/system\""}],"source_content_type":"text/x-jinja2","patch_set":43,"id":"7faddb67_4d7abb88","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":70},"in_reply_to":"7faddb67_9b823800","updated":"2019-07-24 15:44:02.000000000","message":"I guess I could check if there is a doc about roles/nova/templates/nova.conf.d/libvirt.conf.j2","commit_id":"14bd5b80d8565586e637a4c8219cbfa780ec181a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[api]"},{"line_number":6,"context_line":"region \u003d {{ openstack_region_name }}"},{"line_number":7,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":8,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":9,"context_line":"project_name \u003d service"},{"line_number":10,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_6b850359","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":85},"updated":"2019-08-12 16:31:58.000000000","message":"We switched to keystone_admin_url","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[api]"},{"line_number":6,"context_line":"region \u003d {{ openstack_region_name }}"},{"line_number":7,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":8,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":9,"context_line":"project_name \u003d service"},{"line_number":10,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_19feffae","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":85},"in_reply_to":"7faddb67_6b850359","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":9,"context_line":"project_name \u003d service"},{"line_number":10,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":11,"context_line":"username \u003d {{ masakari_keystone_user }}"},{"line_number":12,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[libvirt]"},{"line_number":15,"context_line":"connection_uri \u003d \"qemu+tcp://{{ migration_interface_address }}/system\""}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_8be4ff3d","line":12,"range":{"start_line":11,"start_character":1,"end_line":12,"end_character":43},"updated":"2019-08-12 16:31:58.000000000","message":"Is it normal to use the same user for the monitors and control services?","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":9,"context_line":"project_name \u003d service"},{"line_number":10,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":11,"context_line":"username \u003d {{ masakari_keystone_user }}"},{"line_number":12,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[libvirt]"},{"line_number":15,"context_line":"connection_uri \u003d \"qemu+tcp://{{ migration_interface_address }}/system\""}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_99c74f99","line":12,"range":{"start_line":11,"start_character":1,"end_line":12,"end_character":43},"in_reply_to":"7faddb67_8be4ff3d","updated":"2019-08-14 16:25:23.000000000","message":"I can create a new user/password for masakari-monitor but I don\u0027t it is really needed.","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"}],"ansible/roles/masakari/templates/masakari.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":29,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":30,"context_line":"service_token_roles_required \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":33,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":34,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"[oslo_messaging_notifications]"},{"line_number":37,"context_line":"transport_url \u003d {{ notify_transport_url }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f79a3b5_2e88386a","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":207},"updated":"2018-11-06 09:16:01.000000000","message":"Wrap this in:\n\n{% if enable_memcached | bool %}\n{% endif %}","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"5a82ba71b8afbde5c2a2c1dd1fdc2d3cad9a7a5a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":30,"context_line":"service_token_roles_required \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":33,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":34,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"[oslo_messaging_notifications]"},{"line_number":37,"context_line":"transport_url \u003d {{ notify_transport_url }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f79a3b5_a75a174e","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":207},"in_reply_to":"3f79a3b5_2e88386a","updated":"2018-11-07 01:51:36.000000000","message":"Done","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":13,"context_line":"engine_manager \u003d masakari.engine.manager.MasakariManager"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[database]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"connection \u003d mysql+pymysql://{{ masakari_database_user }}:{{ masakari_database_password }}@{{ masakari_database_address }}/{{ masakari_database_name }}"},{"line_number":18,"context_line":"max_retries \u003d -1"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_5f15ae4a","line":16,"updated":"2018-11-12 13:47:12.000000000","message":"please remove the space, other files doesnt have it, just to keep consitency","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"engine_manager \u003d masakari.engine.manager.MasakariManager"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[database]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"connection \u003d mysql+pymysql://{{ masakari_database_user }}:{{ masakari_database_password }}@{{ masakari_database_address }}/{{ masakari_database_name }}"},{"line_number":18,"context_line":"max_retries \u003d -1"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_9aa26d40","line":16,"in_reply_to":"3f79a3b5_5f15ae4a","updated":"2018-11-13 02:08:47.000000000","message":"Done","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":18,"context_line":"max_retries \u003d -1"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[keystone_authtoken]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"www_authenticate_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"},{"line_number":23,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":24,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_7f18aa81","line":21,"updated":"2018-11-12 13:47:12.000000000","message":"ditto","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"max_retries \u003d -1"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[keystone_authtoken]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"www_authenticate_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"},{"line_number":23,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":24,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_ba9f29f5","line":21,"in_reply_to":"3f79a3b5_7f18aa81","updated":"2018-11-13 02:08:47.000000000","message":"Done","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":47,"context_line":"policy_file \u003d {{ masakari_policy_file }}"},{"line_number":48,"context_line":"{% endif %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[wsgi]"},{"line_number":51,"context_line":"api_paste_config \u003d /etc/masakari/api-paste.ini"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_3f0eb23b","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":46},"updated":"2018-11-12 13:47:12.000000000","message":"does it really need it? isnt the default value? https://github.com/openstack/masakari/blob/ccc3f930262602a384dd6b4579a3b86bf58ee878/masakari/conf/wsgi.py#L22","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"policy_file \u003d {{ masakari_policy_file }}"},{"line_number":48,"context_line":"{% endif %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[wsgi]"},{"line_number":51,"context_line":"api_paste_config \u003d /etc/masakari/api-paste.ini"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_1a641d20","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":46},"in_reply_to":"3f79a3b5_3f0eb23b","updated":"2018-11-13 02:08:47.000000000","message":"Done","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"enabled_apis \u003d masakari_api"},{"line_number":7,"context_line":"state_path \u003d /var/lib/masakari"},{"line_number":8,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":9,"context_line":"os_user_domain_name \u003d default"},{"line_number":10,"context_line":"os_project_domain_name \u003d default"},{"line_number":11,"context_line":"os_privileged_user_tenant \u003d service"},{"line_number":12,"context_line":"os_privileged_user_auth_url \u003d {{ keystone_internal_url }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_2b7f0b67","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":29},"updated":"2019-08-12 16:31:58.000000000","message":"default_user_domain_id?","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"enabled_apis \u003d masakari_api"},{"line_number":7,"context_line":"state_path \u003d /var/lib/masakari"},{"line_number":8,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":9,"context_line":"os_user_domain_name \u003d default"},{"line_number":10,"context_line":"os_project_domain_name \u003d default"},{"line_number":11,"context_line":"os_privileged_user_tenant \u003d service"},{"line_number":12,"context_line":"os_privileged_user_auth_url \u003d {{ keystone_internal_url }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_993c2f93","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":29},"in_reply_to":"7faddb67_2b7f0b67","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"state_path \u003d /var/lib/masakari"},{"line_number":8,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":9,"context_line":"os_user_domain_name \u003d default"},{"line_number":10,"context_line":"os_project_domain_name \u003d default"},{"line_number":11,"context_line":"os_privileged_user_tenant \u003d service"},{"line_number":12,"context_line":"os_privileged_user_auth_url \u003d {{ keystone_internal_url }}/v3"},{"line_number":13,"context_line":"os_privileged_user_name \u003d {{ nova_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_ab8a1b61","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":32},"updated":"2019-08-12 16:31:58.000000000","message":"default_project_domain_id","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"state_path \u003d /var/lib/masakari"},{"line_number":8,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":9,"context_line":"os_user_domain_name \u003d default"},{"line_number":10,"context_line":"os_project_domain_name \u003d default"},{"line_number":11,"context_line":"os_privileged_user_tenant \u003d service"},{"line_number":12,"context_line":"os_privileged_user_auth_url \u003d {{ keystone_internal_url }}/v3"},{"line_number":13,"context_line":"os_privileged_user_name \u003d {{ nova_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_b941eb0c","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":32},"in_reply_to":"7faddb67_ab8a1b61","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"os_project_domain_name \u003d default"},{"line_number":11,"context_line":"os_privileged_user_tenant \u003d service"},{"line_number":12,"context_line":"os_privileged_user_auth_url \u003d {{ keystone_internal_url }}/v3"},{"line_number":13,"context_line":"os_privileged_user_name \u003d {{ nova_keystone_user }}"},{"line_number":14,"context_line":"os_privileged_user_password \u003d {{ nova_keystone_password }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[database]"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_4be7e747","line":13,"range":{"start_line":13,"start_character":29,"end_line":13,"end_character":47},"updated":"2019-08-12 16:31:58.000000000","message":"masakari user?","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e59da01d9ef75974cb2bbc3338f66298efafa0f8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"os_project_domain_name \u003d default"},{"line_number":11,"context_line":"os_privileged_user_tenant \u003d service"},{"line_number":12,"context_line":"os_privileged_user_auth_url \u003d {{ keystone_internal_url }}/v3"},{"line_number":13,"context_line":"os_privileged_user_name \u003d {{ nova_keystone_user }}"},{"line_number":14,"context_line":"os_privileged_user_password \u003d {{ nova_keystone_password }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[database]"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_677c1ab6","line":13,"range":{"start_line":13,"start_character":29,"end_line":13,"end_character":47},"in_reply_to":"7faddb67_19e27f31","updated":"2019-08-15 12:40:34.000000000","message":"But the client is masakari, not nova right?","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"os_project_domain_name \u003d default"},{"line_number":11,"context_line":"os_privileged_user_tenant \u003d service"},{"line_number":12,"context_line":"os_privileged_user_auth_url \u003d {{ keystone_internal_url }}/v3"},{"line_number":13,"context_line":"os_privileged_user_name \u003d {{ nova_keystone_user }}"},{"line_number":14,"context_line":"os_privileged_user_password \u003d {{ nova_keystone_password }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[database]"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_19e27f31","line":13,"range":{"start_line":13,"start_character":29,"end_line":13,"end_character":47},"in_reply_to":"7faddb67_4be7e747","updated":"2019-08-14 16:25:23.000000000","message":"This is how masakari speaks to nova to ask an instance to start.\n\nhttps://github.com/openstack/masakari/blob/master/masakari/conf/nova.py#L34-L37","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"}],"ansible/roles/masakari/templates/masakarimonitors.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":17,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":18,"context_line":"domain_id \u003d {{ default_user_domain_id }}"},{"line_number":19,"context_line":"domain_name \u003d {{ default_user_domain_name }}"},{"line_number":20,"context_line":"project_name \u003d service\u003e"},{"line_number":21,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":22,"context_line":"project_domain_name \u003d {{ default_project_domain_name }}"},{"line_number":23,"context_line":"username \u003d {{ masakari_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f79a3b5_ceee641f","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":23},"updated":"2018-11-06 09:16:01.000000000","message":"delete me","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"5a82ba71b8afbde5c2a2c1dd1fdc2d3cad9a7a5a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":18,"context_line":"domain_id \u003d {{ default_user_domain_id }}"},{"line_number":19,"context_line":"domain_name \u003d {{ default_user_domain_name }}"},{"line_number":20,"context_line":"project_name \u003d service\u003e"},{"line_number":21,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":22,"context_line":"project_domain_name \u003d {{ default_project_domain_name }}"},{"line_number":23,"context_line":"username \u003d {{ masakari_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f79a3b5_874d9b94","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":23},"in_reply_to":"3f79a3b5_ceee641f","updated":"2018-11-07 01:51:36.000000000","message":"Done","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":24,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[callback]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"retry_max \u003d 12"},{"line_number":29,"context_line":"retry_interval \u003d 10"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_82fd2d08","line":27,"updated":"2018-11-12 13:47:12.000000000","message":"same for the empty line","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"password \u003d {{ masakari_keystone_password }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[callback]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"retry_max \u003d 12"},{"line_number":29,"context_line":"retry_interval \u003d 10"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_fa6a81e8","line":27,"in_reply_to":"3f79a3b5_82fd2d08","updated":"2018-11-13 02:08:47.000000000","message":"Done","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":29,"context_line":"retry_interval \u003d 10"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[host]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"monitoring_driver \u003d default"},{"line_number":34,"context_line":"monitoring_interval \u003d 60"},{"line_number":35,"context_line":"api_retry_max \u003d 12"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_e20d0136","line":32,"updated":"2018-11-12 13:47:12.000000000","message":"ditto","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"retry_interval \u003d 10"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[host]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"monitoring_driver \u003d default"},{"line_number":34,"context_line":"monitoring_interval \u003d 60"},{"line_number":35,"context_line":"api_retry_max \u003d 12"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_9a77cdd3","line":32,"in_reply_to":"3f79a3b5_e20d0136","updated":"2018-11-13 02:08:47.000000000","message":"Done","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67b8906592b572ee5a111a1c47ebeb09527d9410","unresolved":false,"context_lines":[{"line_number":36,"context_line":"api_retry_interval \u003d 10"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[libvirt]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"connection_uri \u003d \"qemu+tcp://{{ migration_interface_address }}/system\""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_2200d9fe","line":39,"updated":"2018-11-12 13:47:12.000000000","message":"ditto","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"2468107f6472fa9386eab0a4828f79b7b8d2805f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"api_retry_interval \u003d 10"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[libvirt]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"connection_uri \u003d \"qemu+tcp://{{ migration_interface_address }}/system\""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3f79a3b5_ba7409cf","line":39,"in_reply_to":"3f79a3b5_2200d9fe","updated":"2018-11-13 02:08:47.000000000","message":"Done","commit_id":"e91878ec2ed1f28ec34cf7e87efdf0b3368c968a"}],"ansible/roles/masakari/templates/wsgi-masakari.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if kolla_base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":2,"context_line":"    {% set python_path \u003d \u0027/usr/lib/python3/dist-packages\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/lib/python3.6/site-packages\u0027 %}"},{"line_number":3,"context_line":"{% else %}"},{"line_number":4,"context_line":"    {% set python_path \u003d \u0027/usr/lib/python2.7/site-packages\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/lib/python2.7/site-packages\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_6b38a39e","line":1,"range":{"start_line":1,"start_character":28,"end_line":1,"end_character":34},"updated":"2019-08-12 16:31:58.000000000","message":"or debian","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if kolla_base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":2,"context_line":"    {% set python_path \u003d \u0027/usr/lib/python3/dist-packages\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/lib/python3.6/site-packages\u0027 %}"},{"line_number":3,"context_line":"{% else %}"},{"line_number":4,"context_line":"    {% set python_path \u003d \u0027/usr/lib/python2.7/site-packages\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/lib/python2.7/site-packages\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_f92f63f3","line":1,"range":{"start_line":1,"start_character":28,"end_line":1,"end_character":34},"in_reply_to":"7faddb67_6b38a39e","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if kolla_base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":2,"context_line":"    {% set python_path \u003d \u0027/usr/lib/python3/dist-packages\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/lib/python3.6/site-packages\u0027 %}"},{"line_number":3,"context_line":"{% else %}"},{"line_number":4,"context_line":"    {% set python_path \u003d \u0027/usr/lib/python2.7/site-packages\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/lib/python2.7/site-packages\u0027 %}"},{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":"{% set binary_path \u003d \u0027/usr/bin\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/bin\u0027 %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_8bbddf03","line":4,"updated":"2019-08-12 16:31:58.000000000","message":"We should use distro_python_version here, see https://review.opendev.org/675822.","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if kolla_base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":2,"context_line":"    {% set python_path \u003d \u0027/usr/lib/python3/dist-packages\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/lib/python3.6/site-packages\u0027 %}"},{"line_number":3,"context_line":"{% else %}"},{"line_number":4,"context_line":"    {% set python_path \u003d \u0027/usr/lib/python2.7/site-packages\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/lib/python2.7/site-packages\u0027 %}"},{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":"{% set binary_path \u003d \u0027/usr/bin\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/bin\u0027 %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"7faddb67_9930af57","line":4,"in_reply_to":"7faddb67_8bbddf03","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4a63211197b2cac10c45e53b9263c24c3411db65","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":"{% set binary_path \u003d \u0027/usr/bin\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/bin\u0027 %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Listen {{ api_interface_address }}:{{ masakari_api_port }}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"ServerSignature Off"}],"source_content_type":"text/x-jinja2","patch_set":53,"id":"7faddb67_ca7395e6","line":8,"updated":"2019-08-15 13:55:17.000000000","message":"nit: extra line? :D","commit_id":"332aad334b7531e171bd3bfbdad6b9595b9dca7a"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"0623c14112367b51e6953ec3a891d8a01a371f13","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":"{% set binary_path \u003d \u0027/usr/bin\u0027 if masakari_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/bin\u0027 %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Listen {{ api_interface_address }}:{{ masakari_api_port }}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"ServerSignature Off"}],"source_content_type":"text/x-jinja2","patch_set":53,"id":"7faddb67_6a038111","line":8,"in_reply_to":"7faddb67_ca7395e6","updated":"2019-08-15 13:59:09.000000000","message":"Done","commit_id":"332aad334b7531e171bd3bfbdad6b9595b9dca7a"}],"ansible/site.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        tags: chrony,"},{"line_number":68,"context_line":"        when: enable_chrony | bool }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Apply role haproxy"},{"line_number":71,"context_line":"  gather_facts: false"},{"line_number":72,"context_line":"  hosts:"},{"line_number":73,"context_line":"    - haproxy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_ae3768ae","line":70,"updated":"2018-11-06 09:16:01.000000000","message":"This play also needs a task for masakari to configure haproxy.","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"aa85af5be989e0223b8bfc45d42aa753ad592dff","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        tags: chrony,"},{"line_number":68,"context_line":"        when: enable_chrony | bool }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Apply role haproxy"},{"line_number":71,"context_line":"  gather_facts: false"},{"line_number":72,"context_line":"  hosts:"},{"line_number":73,"context_line":"    - haproxy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_82b82278","line":70,"in_reply_to":"3f79a3b5_87fb5b14","updated":"2018-11-07 10:51:59.000000000","message":"No, you need a task in this play to execute the tasks in the masakari role\u0027s loadbalancer.yml file. e.g. L80 in this file for aodh.","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"5a82ba71b8afbde5c2a2c1dd1fdc2d3cad9a7a5a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        tags: chrony,"},{"line_number":68,"context_line":"        when: enable_chrony | bool }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Apply role haproxy"},{"line_number":71,"context_line":"  gather_facts: false"},{"line_number":72,"context_line":"  hosts:"},{"line_number":73,"context_line":"    - haproxy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_87fb5b14","line":70,"in_reply_to":"3f79a3b5_ae3768ae","updated":"2018-11-07 01:51:36.000000000","message":"Do you mean this task? [1]\n\n[1] https://review.openstack.org/#/c/615715/3/ansible/roles/masakari/tasks/loadbalancer.yml","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f54e18a32ac0978fe7a85fe35b38a55bf2433677","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"  roles:"},{"line_number":1062,"context_line":"    - { role: masakari,"},{"line_number":1063,"context_line":"        tags: masakari,"},{"line_number":1064,"context_line":"        when: enable_masakari| bool }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_ce3c2493","line":1064,"range":{"start_line":1064,"start_character":28,"end_line":1064,"end_character":30},"updated":"2018-11-06 09:16:01.000000000","message":"micronit: space","commit_id":"66f3c5cf19cab7692c73789e83ce4570fab04bc7"}],"doc/source/reference/compute/masakari-guide.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"948e04e69efc0a9abe07986a7b4afd28823d17e8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"provides an API service to manage and control the automated rescue mechanism."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Kolla deploys Masakari API, Masakari Engine and Masakari Instance Monitor"},{"line_number":17,"context_line":"containers which are the main Masakari components."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Connection URI to libvirtd"}],"source_content_type":"text/x-rst","patch_set":52,"id":"7faddb67_cb719779","line":17,"updated":"2019-08-12 16:31:58.000000000","message":"nit: Only if enable_masakari is set.","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"4f81637515d86a53ff13955dd9fa17e695e165f9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"provides an API service to manage and control the automated rescue mechanism."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Kolla deploys Masakari API, Masakari Engine and Masakari Instance Monitor"},{"line_number":17,"context_line":"containers which are the main Masakari components."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Connection URI to libvirtd"}],"source_content_type":"text/x-rst","patch_set":52,"id":"7faddb67_191d9fbd","line":17,"in_reply_to":"7faddb67_cb719779","updated":"2019-08-14 16:25:23.000000000","message":"Done","commit_id":"1656dd7691c3715f242119736f1adb50e03f6e35"}],"doc/source/reference/compute/masakari-quide.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5e4a6c105edd96091d41e7e682fddc84d7593067","unresolved":false,"context_lines":[{"line_number":24,"context_line":"``qemu+tcp://`` connection URI to get events of KVM-based virtual machines."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The setting is overridable using custom config, put the content in"},{"line_number":27,"context_line":"``/etc/kolla/config/masakari/masakari.conf``."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. code-block:: ini"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":48,"id":"7faddb67_3cdc3045","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":37},"updated":"2019-07-26 16:28:27.000000000","message":"masakari-instancemonitor","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"ee7eafc796cfc7a99ac58f1efa78c2dccf0bccb1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"``qemu+tcp://`` connection URI to get events of KVM-based virtual machines."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The setting is overridable using custom config, put the content in"},{"line_number":27,"context_line":"``/etc/kolla/config/masakari/masakari.conf``."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. code-block:: ini"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":48,"id":"7faddb67_bcd90023","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":37},"in_reply_to":"7faddb67_3cdc3045","updated":"2019-07-26 16:38:13.000000000","message":"masakari-monitors.conf","commit_id":"68e269c08b563221e96fe8bc9e9d1de54be96326"}]}