)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6c777aaf0d83075d047c57cfcc58ea4776f8a1f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a1581540_7a90b45b","updated":"2022-01-05 09:18:03.000000000","message":"\u003e Patch Set 6: Code-Review-1\n\u003e \n\u003e Agree with Pierre, socket mounting part needs re-working. Ideally rolling out exporters should not be disruptive for Nova libvirt\n\nthe setup for the nova-libvirt container is really confusing.\nthere is a bindmount /var/lib/docker/volumes/nova_libvirt_run/_data:/var/run/libvirt\nbut then there is also one for /run:/run. and since /var/run is a symlink to /run, \nthe libvirt data end up in all of these locations.\n\nthe good news about this is that the prometheus exporter can work without having \nto change anything about the libvirt container","commit_id":"a2c7414955f2efe9bf5fa02467611cc767c104e2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"834a179571736502138a6ab18c8e0e4663095879","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"927faa58_ad3e71b1","updated":"2022-01-06 08:03:28.000000000","message":"recheck job timeout","commit_id":"491d4184765dd58e5c6bb023127d4d66ebe90ba2"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9864a229a2af59e92d33044095ad9dc8080aeac","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"enable_prometheus_openstack_exporter: \"{{ enable_prometheus | bool }}\""},{"line_number":1005,"context_line":"enable_prometheus_elasticsearch_exporter: \"{{ enable_prometheus | bool and enable_elasticsearch | bool }}\""},{"line_number":1006,"context_line":"enable_prometheus_mtail: \"{{ enable_prometheus | bool }}\""},{"line_number":1007,"context_line":"enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool }}\""},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"prometheus_alertmanager_user: \"admin\""},{"line_number":1010,"context_line":"prometheus_openstack_exporter_interval: \"60s\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_31fb5fc1","line":1007,"updated":"2019-03-18 11:24:33.000000000","message":"and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027]","commit_id":"f626a06b60d1894d7fe45baed4cf24bc873c9385"}],"ansible/roles/prometheus/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9864a229a2af59e92d33044095ad9dc8080aeac","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    volumes:"},{"line_number":146,"context_line":"      - \"{{ node_config_directory }}/prometheus-libvirt-exporter/:{{ container_config_directory }}/:ro\""},{"line_number":147,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":148,"context_line":"      - \"libvirtd_run:/var/run/libvirt:ro\""},{"line_number":149,"context_line":"    dimensions: \"{{ prometheus_libvirt_exporter_dimensions }}\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_9129f337","line":148,"updated":"2019-03-18 11:24:33.000000000","message":"Does this thing generate logs?","commit_id":"f626a06b60d1894d7fe45baed4cf24bc873c9385"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4e9ce3b5cc244a0965b28295eb35c10df7813342","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    volumes:"},{"line_number":146,"context_line":"      - \"{{ node_config_directory }}/prometheus-libvirt-exporter/:{{ container_config_directory }}/:ro\""},{"line_number":147,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":148,"context_line":"      - \"libvirtd_run:/var/run/libvirt:ro\""},{"line_number":149,"context_line":"    dimensions: \"{{ prometheus_libvirt_exporter_dimensions }}\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_4753c96b","line":148,"in_reply_to":"5fc1f717_9129f337","updated":"2019-03-18 13:31:00.000000000","message":"Only to stdout, I think at lot of these follow the \u002712 factor\u0027 style. We could use the Docker Fluentd output driver for these.","commit_id":"f626a06b60d1894d7fe45baed4cf24bc873c9385"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9864a229a2af59e92d33044095ad9dc8080aeac","unresolved":false,"context_lines":[{"line_number":207,"context_line":"prometheus_mtail_tag: \"{{ prometheus_tag }}\""},{"line_number":208,"context_line":"prometheus_mtail_image_full: \"{{ prometheus_mtail_image }}:{{ prometheus_mtail_tag }}\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"prometheus_libvirt_exporter_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-prometheus-libvirt-exporter\""},{"line_number":211,"context_line":"prometheus_libvirt_exporter_tag: \"{{ prometheus_tag }}\""},{"line_number":212,"context_line":"prometheus_libvirt_exporter_image_full: \"{{ prometheus_libvirt_exporter_image }}:{{ prometheus_libvirt_exporter_tag }}\""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_3124bf5d","line":210,"range":{"start_line":210,"start_character":140,"end_line":210,"end_character":145},"updated":"2019-03-18 11:24:33.000000000","message":"prometheus","commit_id":"f626a06b60d1894d7fe45baed4cf24bc873c9385"}],"etc/kolla/globals.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9864a229a2af59e92d33044095ad9dc8080aeac","unresolved":false,"context_lines":[{"line_number":562,"context_line":"#enable_prometheus_openstack_exporter: \"{{ enable_prometheus | bool }}\""},{"line_number":563,"context_line":"#enable_prometheus_elasticsearch_exporter: \"{{ enable_prometheus | bool and enable_elasticsearch | bool }}\""},{"line_number":564,"context_line":"#enable_prometheus_mtail: \"{{ enable_prometheus | bool }}\""},{"line_number":565,"context_line":"#enable_prometheus_libvirt_exporter: \"{{ enable_prometheus | bool and enable_nova | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_91ded33b","line":565,"updated":"2019-03-18 11:24:33.000000000","message":"and nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027]","commit_id":"f626a06b60d1894d7fe45baed4cf24bc873c9385"}]}