)]}'
{"ansible/roles/aodh/tasks/check-containers.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3c5b952030cf82a09fad4c039b57d21b03e8b283","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - item.value.enabled | bool"},{"line_number":15,"context_line":"  with_dict: \"{{ aodh_services }}\""},{"line_number":16,"context_line":"  notify:"},{"line_number":17,"context_line":"    - Restart aodh-api container"},{"line_number":18,"context_line":"    - Restart aodh-evaluator container"},{"line_number":19,"context_line":"    - Restart aodh-listener container"},{"line_number":20,"context_line":"    - Restart aodh-notifier container"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_12c22035","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":37},"updated":"2019-03-26 11:00:04.000000000","message":"remove these","commit_id":"4fb3fada28f07f1fb77aa2a06394e4181ce042bf"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"5aabca38256e5706d7f3f9ee7e42dc22c1452cae","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - item.value.enabled | bool"},{"line_number":15,"context_line":"  with_dict: \"{{ aodh_services }}\""},{"line_number":16,"context_line":"  notify:"},{"line_number":17,"context_line":"    - Restart aodh-api container"},{"line_number":18,"context_line":"    - Restart aodh-evaluator container"},{"line_number":19,"context_line":"    - Restart aodh-listener container"},{"line_number":20,"context_line":"    - Restart aodh-notifier container"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_5d42ec69","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":37},"in_reply_to":"5fc1f717_12c22035","updated":"2019-03-26 20:19:43.000000000","message":"Done","commit_id":"4fb3fada28f07f1fb77aa2a06394e4181ce042bf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3c5b952030cf82a09fad4c039b57d21b03e8b283","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - Restart aodh-api container"},{"line_number":18,"context_line":"    - Restart aodh-evaluator container"},{"line_number":19,"context_line":"    - Restart aodh-listener container"},{"line_number":20,"context_line":"    - Restart aodh-notifier container"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_72c92457","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":27},"updated":"2019-03-26 11:00:04.000000000","message":"{{ item.key }}","commit_id":"4fb3fada28f07f1fb77aa2a06394e4181ce042bf"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"5aabca38256e5706d7f3f9ee7e42dc22c1452cae","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - Restart aodh-api container"},{"line_number":18,"context_line":"    - Restart aodh-evaluator container"},{"line_number":19,"context_line":"    - Restart aodh-listener container"},{"line_number":20,"context_line":"    - Restart aodh-notifier container"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_1d60e400","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":27},"in_reply_to":"5fc1f717_72c92457","updated":"2019-03-26 20:19:43.000000000","message":"Done","commit_id":"4fb3fada28f07f1fb77aa2a06394e4181ce042bf"}],"ansible/roles/aodh/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3c5b952030cf82a09fad4c039b57d21b03e8b283","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  notify:"},{"line_number":104,"context_line":"    - Restart aodh-api container"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- include_tasks: check-containers.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_d28a5819","line":106,"range":{"start_line":106,"start_character":2,"end_line":106,"end_character":37},"updated":"2019-03-26 11:00:04.000000000","message":"nice. I think we need to add when: kolla_action !\u003d \"config\"","commit_id":"4fb3fada28f07f1fb77aa2a06394e4181ce042bf"}],"ansible/roles/aodh/tasks/deploy-containers.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3b27ba2ce90a5d6dd9c7516fecadc97b3ed030c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Set file changed facts so handlers run"},{"line_number":2,"context_line":"  set_fact:"},{"line_number":3,"context_line":"    aodh_api_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":4,"context_line":"    aodh_conf: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":5,"context_line":"    aodh_conf_wsgi: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":6,"context_line":"    aodh_evaluator_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_3485e85a","line":3,"range":{"start_line":3,"start_character":33,"end_line":3,"end_character":40},"updated":"2019-03-25 11:15:52.000000000","message":"nit: you don\u0027t need the combine here.","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"120ed4ec641efdb897841620275c984ef327cd38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Set file changed facts so handlers run"},{"line_number":2,"context_line":"  set_fact:"},{"line_number":3,"context_line":"    aodh_api_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":4,"context_line":"    aodh_conf: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":5,"context_line":"    aodh_conf_wsgi: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":6,"context_line":"    aodh_evaluator_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_55b42082","line":3,"range":{"start_line":3,"start_character":33,"end_line":3,"end_character":40},"in_reply_to":"5fc1f717_3485e85a","updated":"2019-03-25 19:49:47.000000000","message":"Done.","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3b27ba2ce90a5d6dd9c7516fecadc97b3ed030c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Set file changed facts so handlers run"},{"line_number":2,"context_line":"  set_fact:"},{"line_number":3,"context_line":"    aodh_api_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":4,"context_line":"    aodh_conf: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":5,"context_line":"    aodh_conf_wsgi: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":6,"context_line":"    aodh_evaluator_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":7,"context_line":"    aodh_listener_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":8,"context_line":"    aodh_notifier_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":9,"context_line":"    config_json: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":10,"context_line":"    policy_overwriting: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Deploy aodh containers"},{"line_number":13,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_5120c6ac","line":10,"range":{"start_line":1,"start_character":0,"end_line":10,"end_character":63},"updated":"2019-03-25 11:15:52.000000000","message":"Hmm, this is the inevitable flaw in the original plan :)\n\nIf we mark all of these as changed, then we\u0027ll always deploy new containers, even if the images haven\u0027t changed.\n\nI have been slowly removing these conditionals from roles as I touch them, since we can actually rely on the ansible notify/handler mechanism. That would add a significant dependency to this patch, but feels like the right solution.\n\nAlternatively, just set \u0027changed\u0027: false.","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"071dfc8ca9d984ee948c137c995e5876010ea4ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Set file changed facts so handlers run"},{"line_number":2,"context_line":"  set_fact:"},{"line_number":3,"context_line":"    aodh_api_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":4,"context_line":"    aodh_conf: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":5,"context_line":"    aodh_conf_wsgi: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":6,"context_line":"    aodh_evaluator_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":7,"context_line":"    aodh_listener_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":8,"context_line":"    aodh_notifier_container: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":9,"context_line":"    config_json: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":10,"context_line":"    policy_overwriting: \"{{ {} | combine({\u0027changed\u0027: true}) }}\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Deploy aodh containers"},{"line_number":13,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_8a8a6318","line":10,"range":{"start_line":1,"start_character":0,"end_line":10,"end_character":63},"in_reply_to":"5fc1f717_5120c6ac","updated":"2019-03-25 18:40:18.000000000","message":"As Kris pointed out on IRC, we only trigger the handler if the compare_container check notifies it, so it doesn\u0027t matter that these all show as changed. This does make it more important to ensure that we trigger the correct handler.","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3b27ba2ce90a5d6dd9c7516fecadc97b3ed030c5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - item.value.enabled | bool"},{"line_number":25,"context_line":"  with_dict: \"{{ aodh_services }}\""},{"line_number":26,"context_line":"  notify:"},{"line_number":27,"context_line":"    - Restart aodh-api container"},{"line_number":28,"context_line":"    - Restart aodh-evaluator container"},{"line_number":29,"context_line":"    - Restart aodh-listener container"},{"line_number":30,"context_line":"    - Restart aodh-notifier container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_d10b5627","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":22},"updated":"2019-03-25 11:15:52.000000000","message":"Should be {{ item.key }} to ensure we only trigger one handler, then remove the next 3 lines.","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"5aabca38256e5706d7f3f9ee7e42dc22c1452cae","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - item.value.enabled | bool"},{"line_number":25,"context_line":"  with_dict: \"{{ aodh_services }}\""},{"line_number":26,"context_line":"  notify:"},{"line_number":27,"context_line":"    - Restart aodh-api container"},{"line_number":28,"context_line":"    - Restart aodh-evaluator container"},{"line_number":29,"context_line":"    - Restart aodh-listener container"},{"line_number":30,"context_line":"    - Restart aodh-notifier container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_fd52b834","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":22},"in_reply_to":"5fc1f717_52d188fa","updated":"2019-03-26 20:19:43.000000000","message":"Done","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3c5b952030cf82a09fad4c039b57d21b03e8b283","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - item.value.enabled | bool"},{"line_number":25,"context_line":"  with_dict: \"{{ aodh_services }}\""},{"line_number":26,"context_line":"  notify:"},{"line_number":27,"context_line":"    - Restart aodh-api container"},{"line_number":28,"context_line":"    - Restart aodh-evaluator container"},{"line_number":29,"context_line":"    - Restart aodh-listener container"},{"line_number":30,"context_line":"    - Restart aodh-notifier container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_52d188fa","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":22},"in_reply_to":"5fc1f717_9563681a","updated":"2019-03-26 11:00:04.000000000","message":"Yes, let\u0027s make the change here seeing as we\u0027re touching this code.","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"120ed4ec641efdb897841620275c984ef327cd38","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - item.value.enabled | bool"},{"line_number":25,"context_line":"  with_dict: \"{{ aodh_services }}\""},{"line_number":26,"context_line":"  notify:"},{"line_number":27,"context_line":"    - Restart aodh-api container"},{"line_number":28,"context_line":"    - Restart aodh-evaluator container"},{"line_number":29,"context_line":"    - Restart aodh-listener container"},{"line_number":30,"context_line":"    - Restart aodh-notifier container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_9563681a","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":22},"in_reply_to":"5fc1f717_d10b5627","updated":"2019-03-25 19:49:47.000000000","message":"Do you want this to be done across all the projects?  It seems like almost all of them just call a restart container action, which has conditionals to prevent a restart/create if the container shouldn\u0027t be enabled or a config option was changed.","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"}],"ansible/roles/glance/tasks/check-containers.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c8e9ff7c200f6bcc3828e44f98dab7f45d3a9582","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    volumes: \"{{ item.value.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":11,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":14,"context_line":"    - item.value.enabled | bool"},{"line_number":15,"context_line":"  with_dict: \"{{ glance_services }}\""},{"line_number":16,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_98cc62bc","line":13,"range":{"start_line":13,"start_character":6,"end_line":13,"end_character":52},"updated":"2019-08-27 10:49:41.000000000","message":"item.value.host_in_groups | bool\n\nThis is causing the failures.","commit_id":"ecc41aa8f8ff49bf93db9d92a9600b4d1dd9debf"}],"ansible/roles/qinling/tasks/check-containers.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c8e9ff7c200f6bcc3828e44f98dab7f45d3a9582","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":11,"context_line":"    environment: \"{{ item.value.environment }}\""},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":14,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":15,"context_line":"    - item.value.enabled | bool"},{"line_number":16,"context_line":"  with_dict: \"{{ qinling_services }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_58902a97","line":13,"range":{"start_line":13,"start_character":6,"end_line":13,"end_character":30},"updated":"2019-08-27 10:49:41.000000000","message":"not necessary","commit_id":"ecc41aa8f8ff49bf93db9d92a9600b4d1dd9debf"}],"ansible/roles/tacker/tasks/check-containers.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c8e9ff7c200f6bcc3828e44f98dab7f45d3a9582","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    volumes: \"{{ item.value.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":9,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":10,"context_line":"  when:"},{"line_number":11,"context_line":"    - kolla_action !\u003d \u0027config\u0027"},{"line_number":12,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":13,"context_line":"    - item.value.enabled | bool"},{"line_number":14,"context_line":"  with_dict: \"{{ tacker_services }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_d8841a60","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":30},"updated":"2019-08-27 10:49:41.000000000","message":"not necessary","commit_id":"ecc41aa8f8ff49bf93db9d92a9600b4d1dd9debf"}],"ansible/roles/watcher/tasks/check-containers.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c8e9ff7c200f6bcc3828e44f98dab7f45d3a9582","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    - item.value.enabled | bool"},{"line_number":14,"context_line":"  with_dict: \"{{ watcher_services }}\""},{"line_number":15,"context_line":"  notify:"},{"line_number":16,"context_line":"    - Restart watcher-api container"},{"line_number":17,"context_line":"    - Restart watcher-applier container"},{"line_number":18,"context_line":"    - Restart watcher-engine container"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_b8811e50","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":25},"updated":"2019-08-27 10:49:41.000000000","message":"item.key","commit_id":"ecc41aa8f8ff49bf93db9d92a9600b4d1dd9debf"}],"ansible/roles/zun/tasks/check-containers.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4dbc9832763150c6696f4e6104835e97abb7813b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":12,"context_line":"  register: check_zun_containers"},{"line_number":13,"context_line":"  when:"},{"line_number":14,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":15,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":16,"context_line":"    - item.value.enabled | bool"},{"line_number":17,"context_line":"  with_dict: \"{{ zun_services }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_6c97bced","line":14,"updated":"2019-06-15 14:07:48.000000000","message":"Is such a check required here? Sometimes it was removed, sometimes not. I think we are losing consistency.","commit_id":"b09486d3c4991482b884a348a4b92d5fc75eb068"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5d29c55fd30abf7f7f5a4aa07784661fb56d3e66","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":12,"context_line":"  register: check_zun_containers"},{"line_number":13,"context_line":"  when:"},{"line_number":14,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":15,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":16,"context_line":"    - item.value.enabled | bool"},{"line_number":17,"context_line":"  with_dict: \"{{ zun_services }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_6fd48e48","line":14,"in_reply_to":"9fb8cfa7_0f6712eb","updated":"2019-06-15 15:53:58.000000000","message":"E.g. aodh, barbican, common. It\u0027s unwieldy to list them all, not to mention I would probably miss some...","commit_id":"b09486d3c4991482b884a348a4b92d5fc75eb068"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"cd7c8079b83908f27c08e71f0a2f2543f89dbbe3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":12,"context_line":"  register: check_zun_containers"},{"line_number":13,"context_line":"  when:"},{"line_number":14,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":15,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":16,"context_line":"    - item.value.enabled | bool"},{"line_number":17,"context_line":"  with_dict: \"{{ zun_services }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_0f6712eb","line":14,"in_reply_to":"9fb8cfa7_6c97bced","updated":"2019-06-15 15:34:28.000000000","message":"I literally copied and pasted this from the config.yml section to here, and made an update to config.yaml to include this task.  I didn\u0027t change anything with the conditionals.   The only thing I changed was the notify section, here because I was asked to make them consistent in a previous review.  So if some have and some don\u0027t, its because afaik, they never had the check to begin with.  Can you point to me to one that had it in config.yml and now doesn\u0027t in check-containers.yml?","commit_id":"b09486d3c4991482b884a348a4b92d5fc75eb068"}],"tools/kolla-ansible":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3b27ba2ce90a5d6dd9c7516fecadc97b3ed030c5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    deploy              Deploy and start all kolla containers"},{"line_number":65,"context_line":"    deploy-bifrost      Deploy and start bifrost container"},{"line_number":66,"context_line":"    deploy-servers      Enroll and deploy servers with bifrost"},{"line_number":67,"context_line":"    deploy-containers    Only deploy and start containers (no config updates or boot straping)"},{"line_number":68,"context_line":"    post-deploy         Do post deploy on deploy node"},{"line_number":69,"context_line":"    pull                Pull all images for containers (only pulls, no running container changes)"},{"line_number":70,"context_line":"    reconfigure         Reconfigure OpenStack service"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_d1c91659","line":67,"range":{"start_line":67,"start_character":89,"end_line":67,"end_character":90},"updated":"2019-03-25 11:15:52.000000000","message":"micronit: bootstrapping","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3b27ba2ce90a5d6dd9c7516fecadc97b3ed030c5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    deploy              Deploy and start all kolla containers"},{"line_number":65,"context_line":"    deploy-bifrost      Deploy and start bifrost container"},{"line_number":66,"context_line":"    deploy-servers      Enroll and deploy servers with bifrost"},{"line_number":67,"context_line":"    deploy-containers    Only deploy and start containers (no config updates or boot straping)"},{"line_number":68,"context_line":"    post-deploy         Do post deploy on deploy node"},{"line_number":69,"context_line":"    pull                Pull all images for containers (only pulls, no running container changes)"},{"line_number":70,"context_line":"    reconfigure         Reconfigure OpenStack service"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_51be86b4","line":67,"range":{"start_line":67,"start_character":24,"end_line":67,"end_character":25},"updated":"2019-03-25 11:15:52.000000000","message":"micronit: extra space","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"120ed4ec641efdb897841620275c984ef327cd38","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    deploy              Deploy and start all kolla containers"},{"line_number":65,"context_line":"    deploy-bifrost      Deploy and start bifrost container"},{"line_number":66,"context_line":"    deploy-servers      Enroll and deploy servers with bifrost"},{"line_number":67,"context_line":"    deploy-containers    Only deploy and start containers (no config updates or boot straping)"},{"line_number":68,"context_line":"    post-deploy         Do post deploy on deploy node"},{"line_number":69,"context_line":"    pull                Pull all images for containers (only pulls, no running container changes)"},{"line_number":70,"context_line":"    reconfigure         Reconfigure OpenStack service"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_55950031","line":67,"range":{"start_line":67,"start_character":24,"end_line":67,"end_character":25},"in_reply_to":"5fc1f717_51be86b4","updated":"2019-03-25 19:49:47.000000000","message":"Done","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"},{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"120ed4ec641efdb897841620275c984ef327cd38","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    deploy              Deploy and start all kolla containers"},{"line_number":65,"context_line":"    deploy-bifrost      Deploy and start bifrost container"},{"line_number":66,"context_line":"    deploy-servers      Enroll and deploy servers with bifrost"},{"line_number":67,"context_line":"    deploy-containers    Only deploy and start containers (no config updates or boot straping)"},{"line_number":68,"context_line":"    post-deploy         Do post deploy on deploy node"},{"line_number":69,"context_line":"    pull                Pull all images for containers (only pulls, no running container changes)"},{"line_number":70,"context_line":"    reconfigure         Reconfigure OpenStack service"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_15a3f89f","line":67,"range":{"start_line":67,"start_character":89,"end_line":67,"end_character":90},"in_reply_to":"5fc1f717_d1c91659","updated":"2019-03-25 19:49:47.000000000","message":"Done","commit_id":"03695e36a2b7aff80d9e62491aaf2fa5ff6f5596"}]}