)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"bcaaea8734b925faa31a1a935ed87e386154d8b5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When integrating 3rd party component into openstack with kolla-ansible,"},{"line_number":10,"context_line":"maybe have to mount some extra volumes to container."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I69108209320edad4c4ffa37dabadff62d7340939"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_a205ed7b","line":12,"updated":"2019-04-09 15:06:10.000000000","message":"Implements: blueprint support-extra-volumes","commit_id":"ad75d33a3f0377c75562b423b66c122e308f2eab"}],"ansible/roles/nova/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"78e0bf2095bfacbec79e4ed70958b6b1686df9cc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    pid_mode: \"host\""},{"line_number":11,"context_line":"    privileged: True"},{"line_number":12,"context_line":"    volumes:"},{"line_number":13,"context_line":"      - \"{{ node_config_directory }}/nova-libvirt/:{{ container_config_directory }}/:ro\""},{"line_number":14,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":15,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":16,"context_line":"      - \"/run/:/run/:shared\""},{"line_number":17,"context_line":"      - \"/dev:/dev\""},{"line_number":18,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":19,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":20,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":21,"context_line":"      - \"{{ nova_instance_datadir_volume }}:/var/lib/nova/\""},{"line_number":22,"context_line":"      - \"{% if enable_shared_var_lib_nova_mnt | bool %}/var/lib/nova/mnt:/var/lib/nova/mnt:shared{% endif %}\""},{"line_number":23,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":24,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/nova/nova:/var/lib/kolla/venv/lib/python2.7/site-packages/nova\u0027 if nova_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":25,"context_line":"    extra_volumes: \"{{ nova_libvirt_extra_volumes }}\""},{"line_number":26,"context_line":"    dimensions: \"{{ nova_libvirt_dimensions }}\""},{"line_number":27,"context_line":"  nova-ssh:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5fc1f717_29156b3d","line":24,"range":{"start_line":13,"start_character":0,"end_line":24,"end_character":141},"updated":"2019-04-09 09:17:05.000000000","message":"How about if we add a new variable, nova_libvirt_default_volumes, set to these volumes?\n\nThen here we can have:\n\nvolumes: \"{{ nova_libvirt_default_volumes + nova_libvirt_extra_volumes }}\"","commit_id":"0e06e8727ea766ef178b6e517e22e9c8868d280f"},{"author":{"_account_id":24687,"name":"Lucas.hua","email":"huabinhong@kingsoft.com","username":"huabinhong"},"change_message_id":"0eecadfbb124fc2b355fd98641788f6dc2de8ea8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    pid_mode: \"host\""},{"line_number":11,"context_line":"    privileged: True"},{"line_number":12,"context_line":"    volumes:"},{"line_number":13,"context_line":"      - \"{{ node_config_directory }}/nova-libvirt/:{{ container_config_directory }}/:ro\""},{"line_number":14,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":15,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":16,"context_line":"      - \"/run/:/run/:shared\""},{"line_number":17,"context_line":"      - \"/dev:/dev\""},{"line_number":18,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":19,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":20,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":21,"context_line":"      - \"{{ nova_instance_datadir_volume }}:/var/lib/nova/\""},{"line_number":22,"context_line":"      - \"{% if enable_shared_var_lib_nova_mnt | bool %}/var/lib/nova/mnt:/var/lib/nova/mnt:shared{% endif %}\""},{"line_number":23,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":24,"context_line":"      - \"{{ kolla_dev_repos_directory ~ \u0027/nova/nova:/var/lib/kolla/venv/lib/python2.7/site-packages/nova\u0027 if nova_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":25,"context_line":"    extra_volumes: \"{{ nova_libvirt_extra_volumes }}\""},{"line_number":26,"context_line":"    dimensions: \"{{ nova_libvirt_dimensions }}\""},{"line_number":27,"context_line":"  nova-ssh:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5fc1f717_1141b5a6","line":24,"range":{"start_line":13,"start_character":0,"end_line":24,"end_character":141},"in_reply_to":"5fc1f717_29156b3d","updated":"2019-04-09 14:05:39.000000000","message":"right, it seems better.","commit_id":"0e06e8727ea766ef178b6e517e22e9c8868d280f"}]}