)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"ec267f38ab524138e507e0466e4ad40dc16d619a","unresolved":false,"context_lines":[{"line_number":783,"context_line":"glance_enable_rolling_upgrade: \"no\""},{"line_number":784,"context_line":"glance_api_hosts: \"{{ [groups[\u0027glance-api\u0027]|first] if glance_backend_file | bool and glance_file_datadir_volume \u003d\u003d \u0027glance\u0027 else groups[\u0027glance-api\u0027] }}\""},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"glance_admin_endpoint: \"{{ admin_protocol }}://{{ glance_internal_fqdn }}:{{ glance_api_port }}\""},{"line_number":787,"context_line":"glance_internal_endpoint: \"{{ internal_protocol }}://{{ glance_internal_fqdn }}:{{ glance_api_port }}\""},{"line_number":788,"context_line":"glance_public_endpoint: \"{{ public_protocol }}://{{ glance_external_fqdn }}:{{ glance_api_port }}\""},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"#######################"},{"line_number":791,"context_line":"# Barbican options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_ae4c2942","line":788,"range":{"start_line":786,"start_character":0,"end_line":788,"end_character":98},"updated":"2019-04-18 12:55:56.000000000","message":"I perfer to keep this in their own defaults/main.yml, no other roles use glance\u0027s endpoint, no need to move into all.yml","commit_id":"2d35c4dd96df1ce8fa307c7cb4224577c74fc2d7"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"21f90143ddd13a0ba2a126c57c7e521b7252711c","unresolved":false,"context_lines":[{"line_number":783,"context_line":"glance_enable_rolling_upgrade: \"no\""},{"line_number":784,"context_line":"glance_api_hosts: \"{{ [groups[\u0027glance-api\u0027]|first] if glance_backend_file | bool and glance_file_datadir_volume \u003d\u003d \u0027glance\u0027 else groups[\u0027glance-api\u0027] }}\""},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"glance_admin_endpoint: \"{{ admin_protocol }}://{{ glance_internal_fqdn }}:{{ glance_api_port }}\""},{"line_number":787,"context_line":"glance_internal_endpoint: \"{{ internal_protocol }}://{{ glance_internal_fqdn }}:{{ glance_api_port }}\""},{"line_number":788,"context_line":"glance_public_endpoint: \"{{ public_protocol }}://{{ glance_external_fqdn }}:{{ glance_api_port }}\""},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"#######################"},{"line_number":791,"context_line":"# Barbican options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_4eda654c","line":788,"range":{"start_line":786,"start_character":0,"end_line":788,"end_character":98},"in_reply_to":"3fce034c_ae4c2942","updated":"2019-04-18 13:07:18.000000000","message":"I do see your point. I did use it here though because of \"glance_internal_endpoint\". It is used in the following files:\n\n```\nrafael@rafael-Inspiron-5437:~/git/kolla-ansible$ grep  -R \"glance_internal_endpoint\" .\n./ansible/roles/cinder/templates/cinder.conf.j2:glance_api_servers \u003d {{ glance_internal_endpoint }}\n./ansible/roles/nova-hyperv/templates/nova_hyperv.conf.j2:api_servers \u003d {{ glance_internal_endpoint }}\n./ansible/roles/ironic/templates/ironic.conf.j2:glance_api_servers \u003d {{ glance_internal_endpoint }}\n./ansible/roles/glance/tasks/register.yml:    - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ glance_internal_endpoint }}\u0027}\n./ansible/roles/nova/templates/nova.conf.j2:api_servers \u003d {{glance_internal_endpoint }}\n./ansible/group_vars/all.yml:glance_internal_endpoint: \"{{ internal_protocol }}://{{ glance_internal_fqdn }}:{{ glance_api_port }}\"\n```\n\nTherefore, I did not want to re-create the same variable in different projects; and, I tried to keep all of them in the same place.\n\nDid you understand why I put these variables here?\n\nWould you like me to change? Or, can I keep this as is?","commit_id":"2d35c4dd96df1ce8fa307c7cb4224577c74fc2d7"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"ec267f38ab524138e507e0466e4ad40dc16d619a","unresolved":false,"context_lines":[{"line_number":845,"context_line":"designate_backend_external_bind9_nameservers: \"\""},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"# base endpoints"},{"line_number":848,"context_line":"designate_admin_endpoint: \"{{ admin_protocol }}://{{ designate_internal_fqdn }}:{{ designate_api_port }}\""},{"line_number":849,"context_line":"designate_internal_endpoint: \"{{ internal_protocol }}://{{ designate_internal_fqdn }}:{{ designate_api_port }}\""},{"line_number":850,"context_line":"designate_public_endpoint: \"{{ public_protocol }}://{{ designate_external_fqdn }}:{{ designate_api_port }}\""},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"#######################"},{"line_number":853,"context_line":"# Neutron options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_ce497531","line":850,"range":{"start_line":848,"start_character":0,"end_line":850,"end_character":63},"updated":"2019-04-18 12:55:56.000000000","message":"ditto","commit_id":"2d35c4dd96df1ce8fa307c7cb4224577c74fc2d7"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c57279a3e642d0864476cf38144c8f2a630af217","unresolved":false,"context_lines":[{"line_number":845,"context_line":"designate_backend_external_bind9_nameservers: \"\""},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"# base endpoints"},{"line_number":848,"context_line":"designate_admin_endpoint: \"{{ admin_protocol }}://{{ designate_internal_fqdn }}:{{ designate_api_port }}\""},{"line_number":849,"context_line":"designate_internal_endpoint: \"{{ internal_protocol }}://{{ designate_internal_fqdn }}:{{ designate_api_port }}\""},{"line_number":850,"context_line":"designate_public_endpoint: \"{{ public_protocol }}://{{ designate_external_fqdn }}:{{ designate_api_port }}\""},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"#######################"},{"line_number":853,"context_line":"# Neutron options"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fce034c_8ea7eda7","line":850,"range":{"start_line":848,"start_character":0,"end_line":850,"end_character":63},"in_reply_to":"3fce034c_ce497531","updated":"2019-04-18 13:10:06.000000000","message":"It is the same reason that I presented with the glance endpoint URL variable. The internal one is used in another file (outside designated role), and I tried not to replicate the same construction.\n\n./ansible/roles/neutron/templates/neutron.conf.j2:url \u003d {{ designate_internal_endpoint }}/v2","commit_id":"2d35c4dd96df1ce8fa307c7cb4224577c74fc2d7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"barbican_internal_fqdn: \"{{ kolla_internal_fqdn }}\""},{"line_number":204,"context_line":"barbican_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":205,"context_line":"barbican_api_port: \"9311\""},{"line_number":206,"context_line":"barbican_api_listen_port: \"{{ barbican_api_port }}\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"blazar_api_port: \"1234\""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_8972f9e2","line":206,"updated":"2019-06-18 14:40:58.000000000","message":"Generally, I think it makes sense to add these endpoints with the fqdn and port config for each service, e.g. here for barbican.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":203,"context_line":"barbican_internal_fqdn: \"{{ kolla_internal_fqdn }}\""},{"line_number":204,"context_line":"barbican_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":205,"context_line":"barbican_api_port: \"9311\""},{"line_number":206,"context_line":"barbican_api_listen_port: \"{{ barbican_api_port }}\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"blazar_api_port: \"1234\""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_7463a1dd","line":206,"in_reply_to":"9fb8cfa7_8972f9e2","updated":"2020-06-16 19:45:56.000000000","message":"Done. I added them into the Barbican section","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":666,"context_line":"####################"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"# Base endpoints"},{"line_number":669,"context_line":"monasca_api_base_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":670,"context_line":"monasca_api_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":671,"context_line":"monasca_api_base_public_endpoint: \"{{ public_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":672,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_46039010","line":669,"range":{"start_line":669,"start_character":60,"end_line":669,"end_character":86},"updated":"2019-06-18 14:40:58.000000000","message":"These should be fqdn.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":666,"context_line":"####################"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"# Base endpoints"},{"line_number":669,"context_line":"monasca_api_base_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":670,"context_line":"monasca_api_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":671,"context_line":"monasca_api_base_public_endpoint: \"{{ public_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":672,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_d4a9cddf","line":669,"range":{"start_line":669,"start_character":60,"end_line":669,"end_character":86},"in_reply_to":"9fb8cfa7_46039010","updated":"2020-06-16 19:45:56.000000000","message":"Done.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":670,"context_line":"monasca_api_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":671,"context_line":"monasca_api_base_public_endpoint: \"{{ public_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"monasca_log_api_base_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":674,"context_line":"monasca_log_api_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":675,"context_line":"monasca_log_api_base_external_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":676,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_e9fdb508","line":673,"range":{"start_line":673,"start_character":64,"end_line":673,"end_character":83},"updated":"2019-06-18 14:40:58.000000000","message":"and these","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":670,"context_line":"monasca_api_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":671,"context_line":"monasca_api_base_public_endpoint: \"{{ public_protocol }}://{{ kolla_internal_vip_address }}:{{ monasca_api_port }}\""},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"monasca_log_api_base_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":674,"context_line":"monasca_log_api_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":675,"context_line":"monasca_log_api_base_external_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":676,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_34ae49e7","line":673,"range":{"start_line":673,"start_character":64,"end_line":673,"end_character":83},"in_reply_to":"9fb8cfa7_e9fdb508","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":672,"context_line":""},{"line_number":673,"context_line":"monasca_log_api_base_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":674,"context_line":"monasca_log_api_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":675,"context_line":"monasca_log_api_base_external_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"# The OpenStack username used by the Monasca Agent and the Fluentd Monasca"},{"line_number":678,"context_line":"# plugin to post logs and metrics from the control plane to Monasca."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_c981d14c","line":675,"range":{"start_line":675,"start_character":21,"end_line":675,"end_character":29},"updated":"2019-06-18 14:40:58.000000000","message":"public?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":672,"context_line":""},{"line_number":673,"context_line":"monasca_log_api_base_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":674,"context_line":"monasca_log_api_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":675,"context_line":"monasca_log_api_base_external_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ monasca_log_api_port }}\""},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"# The OpenStack username used by the Monasca Agent and the Fluentd Monasca"},{"line_number":678,"context_line":"# plugin to post logs and metrics from the control plane to Monasca."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_f40e91e3","line":675,"range":{"start_line":675,"start_character":21,"end_line":675,"end_character":29},"in_reply_to":"9fb8cfa7_c981d14c","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":923,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"horizon_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}\""},{"line_number":926,"context_line":"horizon_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}\""},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"#################"},{"line_number":929,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_0951290f","line":926,"updated":"2019-06-18 14:40:58.000000000","message":"Should these include horizon_port?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":923,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"horizon_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}\""},{"line_number":926,"context_line":"horizon_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}\""},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"#################"},{"line_number":929,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_94d75524","line":926,"in_reply_to":"9fb8cfa7_0951290f","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"####################"},{"line_number":1074,"context_line":"# InfluxDB"},{"line_number":1075,"context_line":"####################"},{"line_number":1076,"context_line":"infuxdb_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ influxdb_http_port }}\""},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"####################"},{"line_number":1079,"context_line":"# Grafana"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_e974d59e","line":1076,"range":{"start_line":1076,"start_character":72,"end_line":1076,"end_character":83},"updated":"2019-06-18 14:40:58.000000000","message":"fqdn?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"####################"},{"line_number":1074,"context_line":"# InfluxDB"},{"line_number":1075,"context_line":"####################"},{"line_number":1076,"context_line":"infuxdb_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ influxdb_http_port }}\""},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"####################"},{"line_number":1079,"context_line":"# Grafana"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_b4bb79e3","line":1076,"range":{"start_line":1076,"start_character":72,"end_line":1076,"end_character":83},"in_reply_to":"9fb8cfa7_e974d59e","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"####################"},{"line_number":1079,"context_line":"# Grafana"},{"line_number":1080,"context_line":"####################"},{"line_number":1081,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ grafana_server_port }}\""},{"line_number":1082,"context_line":"grafana_external_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ grafana_server_port }}\""},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"#############"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_c97311b1","line":1081,"range":{"start_line":1081,"start_character":81,"end_line":1081,"end_character":88},"updated":"2019-06-18 14:40:58.000000000","message":"fqdn?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"####################"},{"line_number":1079,"context_line":"# Grafana"},{"line_number":1080,"context_line":"####################"},{"line_number":1081,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ grafana_server_port }}\""},{"line_number":1082,"context_line":"grafana_external_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ grafana_server_port }}\""},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"#############"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_f4b5f1ef","line":1081,"range":{"start_line":1081,"start_character":81,"end_line":1081,"end_character":88},"in_reply_to":"9fb8cfa7_c97311b1","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"# Grafana"},{"line_number":1080,"context_line":"####################"},{"line_number":1081,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ grafana_server_port }}\""},{"line_number":1082,"context_line":"grafana_external_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ grafana_server_port }}\""},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"#############"},{"line_number":1085,"context_line":"# Ironic"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_498de179","line":1082,"range":{"start_line":1082,"start_character":8,"end_line":1082,"end_character":16},"updated":"2019-06-18 14:40:58.000000000","message":"public?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"# Grafana"},{"line_number":1080,"context_line":"####################"},{"line_number":1081,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ grafana_server_port }}\""},{"line_number":1082,"context_line":"grafana_external_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ grafana_server_port }}\""},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"#############"},{"line_number":1085,"context_line":"# Ironic"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_74c9e176","line":1082,"range":{"start_line":1082,"start_character":8,"end_line":1082,"end_character":16},"in_reply_to":"9fb8cfa7_498de179","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":900,"context_line":"# Valid options are [ \u0027\u0027, redis ]"},{"line_number":901,"context_line":"designate_coordination_backend: \"{{ \u0027redis\u0027 if enable_redis|bool else \u0027\u0027 }}\""},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"# base endpoints"},{"line_number":904,"context_line":"designate_admin_endpoint: \"{{ admin_protocol }}://{{ designate_internal_fqdn }}:{{ designate_api_port }}\""},{"line_number":905,"context_line":"designate_internal_endpoint: \"{{ internal_protocol }}://{{ designate_internal_fqdn }}:{{ designate_api_port }}\""},{"line_number":906,"context_line":"designate_public_endpoint: \"{{ public_protocol }}://{{ designate_external_fqdn }}:{{ designate_api_port }}\""},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"#######################"},{"line_number":909,"context_line":"# Neutron options"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_4751ca35","line":906,"range":{"start_line":903,"start_character":0,"end_line":906,"end_character":107},"updated":"2020-06-29 09:28:30.000000000","message":"Missing put_address_in_context?","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":900,"context_line":"# Valid options are [ \u0027\u0027, redis ]"},{"line_number":901,"context_line":"designate_coordination_backend: \"{{ \u0027redis\u0027 if enable_redis|bool else \u0027\u0027 }}\""},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"# base endpoints"},{"line_number":904,"context_line":"designate_admin_endpoint: \"{{ admin_protocol }}://{{ designate_internal_fqdn }}:{{ designate_api_port }}\""},{"line_number":905,"context_line":"designate_internal_endpoint: \"{{ internal_protocol }}://{{ designate_internal_fqdn }}:{{ designate_api_port }}\""},{"line_number":906,"context_line":"designate_public_endpoint: \"{{ public_protocol }}://{{ designate_external_fqdn }}:{{ designate_api_port }}\""},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"#######################"},{"line_number":909,"context_line":"# Neutron options"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_382dd394","line":906,"range":{"start_line":903,"start_character":0,"end_line":906,"end_character":107},"in_reply_to":"bf51134e_4751ca35","updated":"2020-06-29 11:52:31.000000000","message":"Yes, sorry. Missed on conflict resolution.\n\nDone.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":971,"context_line":"enable_neutron_horizon_policy_file: \"{{ enable_neutron }}\""},{"line_number":972,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"horizon_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ horizon_port }}\""},{"line_number":975,"context_line":"horizon_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{horizon_public_port}}\""},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"#################"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_e70f3e34","line":974,"range":{"start_line":974,"start_character":62,"end_line":974,"end_character":81},"updated":"2020-06-29 09:28:30.000000000","message":"put_address_in_context?\n\nAlso, does horizon need base?","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d34d6ccda45079bc431830ceae1b85a52065a1c5","unresolved":false,"context_lines":[{"line_number":971,"context_line":"enable_neutron_horizon_policy_file: \"{{ enable_neutron }}\""},{"line_number":972,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"horizon_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ horizon_port }}\""},{"line_number":975,"context_line":"horizon_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{horizon_public_port}}\""},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"#################"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_c97bf3bb","line":974,"range":{"start_line":974,"start_character":62,"end_line":974,"end_character":81},"in_reply_to":"bf51134e_986e9fc6","updated":"2020-07-21 09:29:51.000000000","message":"What I meant is that there is no variable without base, so why not just call it horizon_internal_endpoint?","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":971,"context_line":"enable_neutron_horizon_policy_file: \"{{ enable_neutron }}\""},{"line_number":972,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"horizon_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ horizon_port }}\""},{"line_number":975,"context_line":"horizon_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{horizon_public_port}}\""},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"#################"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_986e9fc6","line":974,"range":{"start_line":974,"start_character":62,"end_line":974,"end_character":81},"in_reply_to":"bf51134e_e70f3e34","updated":"2020-06-29 11:52:31.000000000","message":"Done \"| put_address_in_context(\u0027url\u0027) \".\n\nYes it does:\n```\nansible/roles/tempest/templates/tempest.conf.j2:dashboard_url \u003d {{ horizon_internal_base_endpoint }}\nansible/roles/tempest/templates/tempest.conf.j2:login_url \u003d {{ horizon_internal_base_endpoint }}/auth/login/\n```","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":972,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"horizon_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ horizon_port }}\""},{"line_number":975,"context_line":"horizon_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{horizon_public_port}}\""},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"#################"},{"line_number":978,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_a739c6f2","line":975,"range":{"start_line":975,"start_character":83,"end_line":975,"end_character":102},"updated":"2020-06-29 09:28:30.000000000","message":"nit: spaces","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":972,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"horizon_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ horizon_port }}\""},{"line_number":975,"context_line":"horizon_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{horizon_public_port}}\""},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"#################"},{"line_number":978,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_d86bf7b3","line":975,"range":{"start_line":975,"start_character":83,"end_line":975,"end_character":102},"in_reply_to":"bf51134e_a739c6f2","updated":"2020-06-29 11:52:31.000000000","message":"Done","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"vitrage_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ vitrage_api_port }}\""},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"####################"},{"line_number":1102,"context_line":"# InfluxDB"},{"line_number":1103,"context_line":"####################"},{"line_number":1104,"context_line":"infuxdb_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ influxdb_http_port }}\""},{"line_number":1105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_07287294","line":1102,"range":{"start_line":1102,"start_character":2,"end_line":1102,"end_character":10},"updated":"2020-06-29 09:28:30.000000000","message":"we already have an influx section","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"vitrage_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ vitrage_api_port }}\""},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"####################"},{"line_number":1102,"context_line":"# InfluxDB"},{"line_number":1103,"context_line":"####################"},{"line_number":1104,"context_line":"infuxdb_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ influxdb_http_port }}\""},{"line_number":1105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_f85cfb19","line":1102,"range":{"start_line":1102,"start_character":2,"end_line":1102,"end_character":10},"in_reply_to":"bf51134e_07287294","updated":"2020-06-29 11:52:31.000000000","message":"Done. Thanks. Probably when I created the PR, it did not exist, but was created in the meantime.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"# Grafana"},{"line_number":1108,"context_line":"####################"},{"line_number":1109,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1110,"context_line":"grafana_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"#############"},{"line_number":1113,"context_line":"# Ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_12b70e3c","line":1110,"range":{"start_line":1110,"start_character":15,"end_line":1110,"end_character":20},"updated":"2020-06-29 09:28:30.000000000","message":"Do we need base for grafana?","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"# Grafana"},{"line_number":1108,"context_line":"####################"},{"line_number":1109,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1110,"context_line":"grafana_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"#############"},{"line_number":1113,"context_line":"# Ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_b8aba3d3","line":1110,"range":{"start_line":1110,"start_character":15,"end_line":1110,"end_character":20},"in_reply_to":"bf51134e_12b70e3c","updated":"2020-06-29 11:52:31.000000000","message":"Yes, it looks like we need it:\n```\nansible/roles/gnocchi/templates/gnocchi.conf.j2:allowed_origin \u003d {{ grafana_public_base_endpoint }}\nansible/roles/keystone/templates/keystone.conf.j2:allowed_origin \u003d {{ grafana_public_base_endpoint }}\n```","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"57c438406160c1f64c3de9e951ef88a4a13ca30e","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"# Grafana"},{"line_number":1108,"context_line":"####################"},{"line_number":1109,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1110,"context_line":"grafana_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"#############"},{"line_number":1113,"context_line":"# Ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_a3ba1307","line":1110,"range":{"start_line":1110,"start_character":15,"end_line":1110,"end_character":20},"in_reply_to":"bf51134e_7aa9c3db","updated":"2020-07-21 16:03:21.000000000","message":"It is used to construct URLs, but it is not used as the base for another variable.\n\nIn my opinion, this base endpoint pattern is a bit inconsistent with how we currently do things, so I would suggest we only use it when necessary, i.e. when there is a non-base endpoint variable.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"34132b180cd1888b8a7184edc33cc4c8613957a9","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"# Grafana"},{"line_number":1108,"context_line":"####################"},{"line_number":1109,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1110,"context_line":"grafana_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"#############"},{"line_number":1113,"context_line":"# Ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_7aa9c3db","line":1110,"range":{"start_line":1110,"start_character":15,"end_line":1110,"end_character":20},"in_reply_to":"bf51134e_895a9b4d","updated":"2020-07-21 14:11:37.000000000","message":"For public Grafana, yes, it is not used as a base to construct other URLs. On the other hand, for the internal one, it is used.\n\nI removed the base only for the public URL then.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"bac536289958134dac9a5e422ef554adae94c2ce","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"# Grafana"},{"line_number":1108,"context_line":"####################"},{"line_number":1109,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1110,"context_line":"grafana_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"#############"},{"line_number":1113,"context_line":"# Ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_83e42f10","line":1110,"range":{"start_line":1110,"start_character":15,"end_line":1110,"end_character":20},"in_reply_to":"bf51134e_a3ba1307","updated":"2020-07-21 16:12:00.000000000","message":"To me, the ``base`` word here is indicating a variable that is used to construct any other URLs that depend or have in common that base string.\n\nIf that is important for you, I will remove the word base in the \"grafana_internal_base_endpoint\" then.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d34d6ccda45079bc431830ceae1b85a52065a1c5","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"# Grafana"},{"line_number":1108,"context_line":"####################"},{"line_number":1109,"context_line":"grafana_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1110,"context_line":"grafana_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ grafana_server_port }}\""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"#############"},{"line_number":1113,"context_line":"# Ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_895a9b4d","line":1110,"range":{"start_line":1110,"start_character":15,"end_line":1110,"end_character":20},"in_reply_to":"bf51134e_b8aba3d3","updated":"2020-07-21 09:29:51.000000000","message":"Again, I mean there is no non-base variable","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"########"},{"line_number":1120,"context_line":"# Swift"},{"line_number":1121,"context_line":"########"},{"line_number":1122,"context_line":"swift_base_internal_endpoint: \"{{ internal_protocol }}://{{ swift_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}\""},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"swift_admin_endpoint: \"{{ admin_protocol }}://{{ swift_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}/v1\""},{"line_number":1125,"context_line":"swift_internal_endpoint: \"{{ swift_base_internal_endpoint | put_address_in_context(\u0027url\u0027) }}/v1/AUTH_%(tenant_id)s\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_52eb4611","line":1122,"range":{"start_line":1122,"start_character":0,"end_line":1122,"end_character":28},"updated":"2020-06-29 09:28:30.000000000","message":"Need to be more consistent about base_{internal,admin,public} vs {internal,admin,public}_base.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d34d6ccda45079bc431830ceae1b85a52065a1c5","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"########"},{"line_number":1120,"context_line":"# Swift"},{"line_number":1121,"context_line":"########"},{"line_number":1122,"context_line":"swift_base_internal_endpoint: \"{{ internal_protocol }}://{{ swift_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}\""},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"swift_admin_endpoint: \"{{ admin_protocol }}://{{ swift_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}/v1\""},{"line_number":1125,"context_line":"swift_internal_endpoint: \"{{ swift_base_internal_endpoint | put_address_in_context(\u0027url\u0027) }}/v1/AUTH_%(tenant_id)s\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_e9051716","line":1122,"range":{"start_line":1122,"start_character":0,"end_line":1122,"end_character":28},"in_reply_to":"bf51134e_1890cf94","updated":"2020-07-21 09:29:51.000000000","message":"There are still a few inconsistencies. See git grep _endpoint | grep base","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"########"},{"line_number":1120,"context_line":"# Swift"},{"line_number":1121,"context_line":"########"},{"line_number":1122,"context_line":"swift_base_internal_endpoint: \"{{ internal_protocol }}://{{ swift_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}\""},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"swift_admin_endpoint: \"{{ admin_protocol }}://{{ swift_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}/v1\""},{"line_number":1125,"context_line":"swift_internal_endpoint: \"{{ swift_base_internal_endpoint | put_address_in_context(\u0027url\u0027) }}/v1/AUTH_%(tenant_id)s\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_1890cf94","line":1122,"range":{"start_line":1122,"start_character":0,"end_line":1122,"end_character":28},"in_reply_to":"bf51134e_52eb4611","updated":"2020-06-29 11:52:31.000000000","message":"Sorry. fixed.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"34132b180cd1888b8a7184edc33cc4c8613957a9","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"########"},{"line_number":1120,"context_line":"# Swift"},{"line_number":1121,"context_line":"########"},{"line_number":1122,"context_line":"swift_base_internal_endpoint: \"{{ internal_protocol }}://{{ swift_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}\""},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"swift_admin_endpoint: \"{{ admin_protocol }}://{{ swift_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}/v1\""},{"line_number":1125,"context_line":"swift_internal_endpoint: \"{{ swift_base_internal_endpoint | put_address_in_context(\u0027url\u0027) }}/v1/AUTH_%(tenant_id)s\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_fb9dd5bb","line":1122,"range":{"start_line":1122,"start_character":0,"end_line":1122,"end_character":28},"in_reply_to":"bf51134e_e9051716","updated":"2020-07-21 14:11:37.000000000","message":"Ok, so you wanted me to re-recheck all of them.\n\nI changed everything to [internal|admin|public]_base_endpoint","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"swift_public_endpoint: \"{{ public_protocol }}://{{ swift_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}/v1/AUTH_%(tenant_id)s\""},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"########"},{"line_number":1129,"context_line":"# Octavia"},{"line_number":1130,"context_line":"########"},{"line_number":1131,"context_line":"octavia_admin_endpoint: \"{{ admin_protocol }}://{{ octavia_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ octavia_api_port }}\""},{"line_number":1132,"context_line":"octavia_internal_endpoint: \"{{ internal_protocol }}://{{ octavia_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ octavia_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_a7126660","line":1129,"range":{"start_line":1129,"start_character":2,"end_line":1129,"end_character":9},"updated":"2020-06-29 09:28:30.000000000","message":"ditto","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"swift_public_endpoint: \"{{ public_protocol }}://{{ swift_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ swift_proxy_server_port }}/v1/AUTH_%(tenant_id)s\""},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"########"},{"line_number":1129,"context_line":"# Octavia"},{"line_number":1130,"context_line":"########"},{"line_number":1131,"context_line":"octavia_admin_endpoint: \"{{ admin_protocol }}://{{ octavia_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ octavia_api_port }}\""},{"line_number":1132,"context_line":"octavia_internal_endpoint: \"{{ internal_protocol }}://{{ octavia_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ octavia_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_18e56f38","line":1129,"range":{"start_line":1129,"start_character":2,"end_line":1129,"end_character":9},"in_reply_to":"bf51134e_a7126660","updated":"2020-06-29 11:52:31.000000000","message":"Sorry, but I did not understand what you mean here.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d34d6ccda45079bc431830ceae1b85a52065a1c5","unresolved":false,"context_lines":[{"line_number":973,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"horizon_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ horizon_port }}\""},{"line_number":976,"context_line":"horizon_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ horizon_public_port }}\""},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"#################"},{"line_number":979,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bf51134e_8971fbe1","line":976,"range":{"start_line":976,"start_character":0,"end_line":976,"end_character":28},"updated":"2020-07-21 09:29:51.000000000","message":"This isn\u0027t used (and therefore neither is horizon_public_port)","commit_id":"da30b60800734b6954db3dc15f1a96e4ac311508"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"34132b180cd1888b8a7184edc33cc4c8613957a9","unresolved":false,"context_lines":[{"line_number":973,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"horizon_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ horizon_port }}\""},{"line_number":976,"context_line":"horizon_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ horizon_public_port }}\""},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"#################"},{"line_number":979,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bf51134e_af0b1f29","line":976,"range":{"start_line":976,"start_character":0,"end_line":976,"end_character":28},"in_reply_to":"bf51134e_8971fbe1","updated":"2020-07-21 14:11:37.000000000","message":"Deleted. I am so sorry. It seems that this was used at some point in time, and then, it was not used anymore. Therefore, I will remove this one.\n\nThis was probably delete/changed while this PR has been in review. The Horizon public port I will maintain, as it should be used, instead of a hardcoded port number that was added in a template file.","commit_id":"da30b60800734b6954db3dc15f1a96e4ac311508"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0f2391a680d900f9ce89eeaa37fe831e0b95e5a","unresolved":false,"context_lines":[{"line_number":303,"context_line":"heat_api_cfn_listen_port: \"{{ heat_api_cfn_port }}\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"horizon_port: \"80\""},{"line_number":306,"context_line":"horizon_public_port: \"443\""},{"line_number":307,"context_line":"horizon_listen_port: \"{{ horizon_port }}\""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"influxdb_http_port: \"8086\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_3e02880c","line":306,"range":{"start_line":306,"start_character":0,"end_line":306,"end_character":19},"updated":"2020-08-17 16:56:43.000000000","message":"horizon_tls_port","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d1cf6d923c874226ec802204a4596a19099b9aaf","unresolved":false,"context_lines":[{"line_number":303,"context_line":"heat_api_cfn_listen_port: \"{{ heat_api_cfn_port }}\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"horizon_port: \"80\""},{"line_number":306,"context_line":"horizon_public_port: \"443\""},{"line_number":307,"context_line":"horizon_listen_port: \"{{ horizon_port }}\""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"influxdb_http_port: \"8086\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_c1e9f1b7","line":306,"range":{"start_line":306,"start_character":0,"end_line":306,"end_character":19},"in_reply_to":"9f560f44_3e02880c","updated":"2020-08-17 17:27:23.000000000","message":"I see. Fixed","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0f2391a680d900f9ce89eeaa37fe831e0b95e5a","unresolved":false,"context_lines":[{"line_number":693,"context_line":"# Monasca options"},{"line_number":694,"context_line":"####################"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"# Base endpoints"},{"line_number":697,"context_line":"monasca_api_admin_base_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn  | put_address_in_context(\u0027url\u0027) }}:{{ monasca_api_port }}\""},{"line_number":698,"context_line":"monasca_api_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn  | put_address_in_context(\u0027url\u0027) }}:{{ monasca_api_port }}\""},{"line_number":699,"context_line":"monasca_api_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn  | put_address_in_context(\u0027url\u0027) }}:{{ monasca_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_21126d59","line":696,"range":{"start_line":696,"start_character":0,"end_line":696,"end_character":16},"updated":"2020-08-17 16:56:43.000000000","message":"this looks added randomly","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d1cf6d923c874226ec802204a4596a19099b9aaf","unresolved":false,"context_lines":[{"line_number":693,"context_line":"# Monasca options"},{"line_number":694,"context_line":"####################"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"# Base endpoints"},{"line_number":697,"context_line":"monasca_api_admin_base_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn  | put_address_in_context(\u0027url\u0027) }}:{{ monasca_api_port }}\""},{"line_number":698,"context_line":"monasca_api_internal_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn  | put_address_in_context(\u0027url\u0027) }}:{{ monasca_api_port }}\""},{"line_number":699,"context_line":"monasca_api_public_base_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn  | put_address_in_context(\u0027url\u0027) }}:{{ monasca_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_21f9cd7f","line":696,"range":{"start_line":696,"start_character":0,"end_line":696,"end_character":16},"in_reply_to":"9f560f44_21126d59","updated":"2020-08-17 17:27:23.000000000","message":"yes, probably some rebasing issue.\nThanks for spotting that.","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0f2391a680d900f9ce89eeaa37fe831e0b95e5a","unresolved":false,"context_lines":[{"line_number":912,"context_line":"# Valid options are [ \u0027\u0027, redis ]"},{"line_number":913,"context_line":"designate_coordination_backend: \"{{ \u0027redis\u0027 if enable_redis|bool else \u0027\u0027 }}\""},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"# base endpoints"},{"line_number":916,"context_line":"designate_admin_endpoint: \"{{ admin_protocol }}://{{ designate_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""},{"line_number":917,"context_line":"designate_internal_endpoint: \"{{ internal_protocol }}://{{ designate_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""},{"line_number":918,"context_line":"designate_public_endpoint: \"{{ public_protocol }}://{{ designate_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_611c656a","line":915,"range":{"start_line":915,"start_character":0,"end_line":915,"end_character":16},"updated":"2020-08-17 16:56:43.000000000","message":"ditto this looks added randomly","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d1cf6d923c874226ec802204a4596a19099b9aaf","unresolved":false,"context_lines":[{"line_number":912,"context_line":"# Valid options are [ \u0027\u0027, redis ]"},{"line_number":913,"context_line":"designate_coordination_backend: \"{{ \u0027redis\u0027 if enable_redis|bool else \u0027\u0027 }}\""},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"# base endpoints"},{"line_number":916,"context_line":"designate_admin_endpoint: \"{{ admin_protocol }}://{{ designate_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""},{"line_number":917,"context_line":"designate_internal_endpoint: \"{{ internal_protocol }}://{{ designate_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""},{"line_number":918,"context_line":"designate_public_endpoint: \"{{ public_protocol }}://{{ designate_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_812d39ff","line":915,"range":{"start_line":915,"start_character":0,"end_line":915,"end_character":16},"in_reply_to":"9f560f44_611c656a","updated":"2020-08-17 17:27:23.000000000","message":"Done","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0f2391a680d900f9ce89eeaa37fe831e0b95e5a","unresolved":false,"context_lines":[{"line_number":983,"context_line":"enable_neutron_horizon_policy_file: \"{{ enable_neutron }}\""},{"line_number":984,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"horizon_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ horizon_port }}\""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"#################"},{"line_number":989,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_c12451b2","line":986,"range":{"start_line":986,"start_character":115,"end_line":986,"end_character":127},"updated":"2020-08-17 16:56:43.000000000","message":"it can be tls","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d1cf6d923c874226ec802204a4596a19099b9aaf","unresolved":false,"context_lines":[{"line_number":983,"context_line":"enable_neutron_horizon_policy_file: \"{{ enable_neutron }}\""},{"line_number":984,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"horizon_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ horizon_port }}\""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"#################"},{"line_number":989,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_414321b0","line":986,"range":{"start_line":986,"start_character":115,"end_line":986,"end_character":127},"in_reply_to":"9f560f44_c12451b2","updated":"2020-08-17 17:27:23.000000000","message":"I guess so. I will fix it.","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe4ed0c93ee01557dfdbfa19a18667423cc1bbcd","unresolved":false,"context_lines":[{"line_number":980,"context_line":"enable_neutron_horizon_policy_file: \"{{ enable_neutron }}\""},{"line_number":981,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"horizon_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ horizon_public_port if kolla_enable_tls_internal | bool else horizon_port }}\""},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"#################"},{"line_number":986,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9f560f44_9c2abc7b","line":983,"range":{"start_line":983,"start_character":123,"end_line":983,"end_character":129},"updated":"2020-08-17 17:36:00.000000000","message":"tls! :D","commit_id":"dce6603eebd828f1b68e7114185906dbd1db0808"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"6b59832939ec13805c6c5984c08b16671fdcca9c","unresolved":false,"context_lines":[{"line_number":980,"context_line":"enable_neutron_horizon_policy_file: \"{{ enable_neutron }}\""},{"line_number":981,"context_line":"enable_nova_horizon_policy_file: \"{{ enable_nova }}\""},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"horizon_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ horizon_public_port if kolla_enable_tls_internal | bool else horizon_port }}\""},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"#################"},{"line_number":986,"context_line":"# Octavia options"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9f560f44_1ca98cdc","line":983,"range":{"start_line":983,"start_character":123,"end_line":983,"end_character":129},"in_reply_to":"9f560f44_9c2abc7b","updated":"2020-08-17 17:42:13.000000000","message":"damm it ctrl+c and v..\nfixed.","commit_id":"dce6603eebd828f1b68e7114185906dbd1db0808"}],"ansible/roles/blazar/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"####################"},{"line_number":40,"context_line":"blazar_database_name: \"blazar\""},{"line_number":41,"context_line":"blazar_database_user: \"blazar\""},{"line_number":42,"context_line":"blazar_database_address: \"{{ database_address }}:{{ database_port }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_89aaf9cf","line":42,"range":{"start_line":42,"start_character":29,"end_line":42,"end_character":45},"updated":"2019-06-18 14:40:58.000000000","message":"This looks like a different issue.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":39,"context_line":"####################"},{"line_number":40,"context_line":"blazar_database_name: \"blazar\""},{"line_number":41,"context_line":"blazar_database_user: \"blazar\""},{"line_number":42,"context_line":"blazar_database_address: \"{{ database_address }}:{{ database_port }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_54c65d69","line":42,"range":{"start_line":42,"start_character":29,"end_line":42,"end_character":45},"in_reply_to":"9fb8cfa7_89aaf9cf","updated":"2020-06-16 19:45:56.000000000","message":"already fixed upstream.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"eef9f2b7866eedef94432a2efb44812e606efafc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"blazar_database_user: \"blazar\""},{"line_number":42,"context_line":"blazar_database_address: \"{{ database_address | put_address_in_context(\u0027url\u0027) }}:{{ database_port }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"####################"},{"line_number":46,"context_line":"# Docker"},{"line_number":47,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_0ebad1dc","side":"PARENT","line":44,"updated":"2020-06-19 14:04:55.000000000","message":"This change does not affect the commit, could you remove it? (keeping the new line here), so this file will leave the commit.","commit_id":"b74f3c879d7718d3039804b254c7a6a93dd02d38"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c9a7dfe41c2ce116d62621ae780e450479d89a69","unresolved":false,"context_lines":[{"line_number":41,"context_line":"blazar_database_user: \"blazar\""},{"line_number":42,"context_line":"blazar_database_address: \"{{ database_address | put_address_in_context(\u0027url\u0027) }}:{{ database_port }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"####################"},{"line_number":46,"context_line":"# Docker"},{"line_number":47,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_c3170aa3","side":"PARENT","line":44,"in_reply_to":"bf51134e_0ebad1dc","updated":"2020-06-19 17:38:43.000000000","message":"Done","commit_id":"b74f3c879d7718d3039804b254c7a6a93dd02d38"}],"ansible/roles/cinder/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"####################"},{"line_number":169,"context_line":"cinder_base_admin_endpoint: \"{{ admin_protocol }}://{{ cinder_internal_fqdn }}:{{ cinder_api_port }}\""},{"line_number":170,"context_line":"cinder_base_internal_endpoint: \"{{ internal_protocol }}://{{ cinder_internal_fqdn }}:{{ cinder_api_port }}\""},{"line_number":171,"context_line":"cinder_base_external_endpoint: \"{{ public_protocol }}://{{ cinder_external_fqdn }}:{{ cinder_api_port }}\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"cinder_v2_admin_endpoint: \"{{ cinder_base_admin_endpoint }}/v2/%(tenant_id)s\""},{"line_number":174,"context_line":"cinder_v2_internal_endpoint: \"{{ cinder_base_internal_endpoint }}/v2/%(tenant_id)s\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_0988496f","line":171,"range":{"start_line":171,"start_character":11,"end_line":171,"end_character":20},"updated":"2019-06-18 14:40:58.000000000","message":"public?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":168,"context_line":"####################"},{"line_number":169,"context_line":"cinder_base_admin_endpoint: \"{{ admin_protocol }}://{{ cinder_internal_fqdn }}:{{ cinder_api_port }}\""},{"line_number":170,"context_line":"cinder_base_internal_endpoint: \"{{ internal_protocol }}://{{ cinder_internal_fqdn }}:{{ cinder_api_port }}\""},{"line_number":171,"context_line":"cinder_base_external_endpoint: \"{{ public_protocol }}://{{ cinder_external_fqdn }}:{{ cinder_api_port }}\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"cinder_v2_admin_endpoint: \"{{ cinder_base_admin_endpoint }}/v2/%(tenant_id)s\""},{"line_number":174,"context_line":"cinder_v2_internal_endpoint: \"{{ cinder_base_internal_endpoint }}/v2/%(tenant_id)s\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_f4833103","line":171,"range":{"start_line":171,"start_character":11,"end_line":171,"end_character":20},"in_reply_to":"9fb8cfa7_0988496f","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"}],"ansible/roles/common/templates/conf/output/00-local.conf.j2":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"eef9f2b7866eedef94432a2efb44812e606efafc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u003cstore\u003e"},{"line_number":39,"context_line":"       @type monasca"},{"line_number":40,"context_line":"       keystone_url {{ keystone_internal_url }}"},{"line_number":41,"context_line":"       monasca_api {{ monasca_api_base_internal_endpoint }}"},{"line_number":42,"context_line":"       monasca_api_version v2.0"},{"line_number":43,"context_line":"       monasca_log_api {{ monasca_log_api_base_internal_endpoint }}"},{"line_number":44,"context_line":"       monasca_log_api_version v3.0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_d12b587f","line":41,"updated":"2020-06-19 14:04:55.000000000","message":"In the last version, the monasca_api was using the \"monasca_log_api_port\", with this change, it uses the \"monasca_api_port\" instead.\n\nThis version makes more sense to me, splitting the configuration into monasca_api and monasca_log_api, but the port configuration was changed, so, the old versions were wrong?","commit_id":"21e5417432d67ecf5dddc5efad474378e13bae78"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c9a7dfe41c2ce116d62621ae780e450479d89a69","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u003cstore\u003e"},{"line_number":39,"context_line":"       @type monasca"},{"line_number":40,"context_line":"       keystone_url {{ keystone_internal_url }}"},{"line_number":41,"context_line":"       monasca_api {{ monasca_api_base_internal_endpoint }}"},{"line_number":42,"context_line":"       monasca_api_version v2.0"},{"line_number":43,"context_line":"       monasca_log_api {{ monasca_log_api_base_internal_endpoint }}"},{"line_number":44,"context_line":"       monasca_log_api_version v3.0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_c3ca6a18","line":41,"in_reply_to":"bf51134e_d12b587f","updated":"2020-06-19 17:38:43.000000000","message":"Done","commit_id":"21e5417432d67ecf5dddc5efad474378e13bae78"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"eef9f2b7866eedef94432a2efb44812e606efafc","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    \u003cstore\u003e"},{"line_number":98,"context_line":"       @type monasca"},{"line_number":99,"context_line":"       keystone_url {{ keystone_internal_url }}"},{"line_number":100,"context_line":"       monasca_api {{ monasca_api_base_internal_endpoint }}"},{"line_number":101,"context_line":"       monasca_api_version v2.0"},{"line_number":102,"context_line":"       monasca_log_api {{ monasca_log_api_base_internal_endpoint }}"},{"line_number":103,"context_line":"       monasca_log_api_version v3.0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_9131e0ef","line":100,"updated":"2020-06-19 14:04:55.000000000","message":"The same here.","commit_id":"21e5417432d67ecf5dddc5efad474378e13bae78"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c9a7dfe41c2ce116d62621ae780e450479d89a69","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    \u003cstore\u003e"},{"line_number":98,"context_line":"       @type monasca"},{"line_number":99,"context_line":"       keystone_url {{ keystone_internal_url }}"},{"line_number":100,"context_line":"       monasca_api {{ monasca_api_base_internal_endpoint }}"},{"line_number":101,"context_line":"       monasca_api_version v2.0"},{"line_number":102,"context_line":"       monasca_log_api {{ monasca_log_api_base_internal_endpoint }}"},{"line_number":103,"context_line":"       monasca_log_api_version v3.0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_83e07298","line":100,"in_reply_to":"bf51134e_9131e0ef","updated":"2020-06-19 17:38:43.000000000","message":"Done","commit_id":"21e5417432d67ecf5dddc5efad474378e13bae78"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e925b8c57d4c29931221c388ce7776e1699e74e3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"  \u003cstore\u003e"},{"line_number":162,"context_line":"     @type monasca"},{"line_number":163,"context_line":"     keystone_url {{ keystone_internal_url }}"},{"line_number":164,"context_line":"     monasca_api {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ monasca_log_api_port }}"},{"line_number":165,"context_line":"     monasca_api_version v2.0"},{"line_number":166,"context_line":"     username {{ monasca_agent_user }}"},{"line_number":167,"context_line":"     password {{ monasca_agent_password }}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"bf51134e_66fd7b3a","line":164,"updated":"2020-07-23 11:33:02.000000000","message":"monasca_log_api_internal_endpoint","commit_id":"0e6dede0e6295efed0005ee42ff2f2d53b03c232"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"ce065ac80e1843b0525c34eab9ddf9d6a002409c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"  \u003cstore\u003e"},{"line_number":162,"context_line":"     @type monasca"},{"line_number":163,"context_line":"     keystone_url {{ keystone_internal_url }}"},{"line_number":164,"context_line":"     monasca_api {{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ monasca_log_api_port }}"},{"line_number":165,"context_line":"     monasca_api_version v2.0"},{"line_number":166,"context_line":"     username {{ monasca_agent_user }}"},{"line_number":167,"context_line":"     password {{ monasca_agent_password }}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"bf51134e_7c96aa96","line":164,"in_reply_to":"bf51134e_66fd7b3a","updated":"2020-07-23 13:08:06.000000000","message":"Fixed. I think this one came after I created the first commit, and it was missed during the rebase.","commit_id":"0e6dede0e6295efed0005ee42ff2f2d53b03c232"}],"ansible/roles/common/templates/conf/output/02-monasca.conf.j2":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"eef9f2b7866eedef94432a2efb44812e606efafc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    \u003cstore\u003e"},{"line_number":4,"context_line":"       @type monasca"},{"line_number":5,"context_line":"       keystone_url {{ keystone_internal_url }}"},{"line_number":6,"context_line":"       monasca_api {{ monasca_api_base_internal_endpoint }}"},{"line_number":7,"context_line":"       monasca_api_version v2.0"},{"line_number":8,"context_line":"       monasca_log_api {{ monasca_log_api_base_internal_endpoint }}"},{"line_number":9,"context_line":"       monasca_log_api_version v3.0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_115b102e","line":6,"updated":"2020-06-19 14:04:55.000000000","message":"The same here.","commit_id":"21e5417432d67ecf5dddc5efad474378e13bae78"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c9a7dfe41c2ce116d62621ae780e450479d89a69","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    \u003cstore\u003e"},{"line_number":4,"context_line":"       @type monasca"},{"line_number":5,"context_line":"       keystone_url {{ keystone_internal_url }}"},{"line_number":6,"context_line":"       monasca_api {{ monasca_api_base_internal_endpoint }}"},{"line_number":7,"context_line":"       monasca_api_version v2.0"},{"line_number":8,"context_line":"       monasca_log_api {{ monasca_log_api_base_internal_endpoint }}"},{"line_number":9,"context_line":"       monasca_log_api_version v3.0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"bf51134e_23eb6679","line":6,"in_reply_to":"bf51134e_115b102e","updated":"2020-06-19 17:38:43.000000000","message":"Done","commit_id":"21e5417432d67ecf5dddc5efad474378e13bae78"}],"ansible/roles/cyborg/templates/cyborg.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"policy_file \u003d {{ cyborg_policy_file }}"},{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[service_credentials]"},{"line_number":35,"context_line":"auth_url \u003d {{ keystone_public_url }}/v3"},{"line_number":36,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":37,"context_line":"password \u003d {{ cyborg_keystone_password }}"},{"line_number":38,"context_line":"username \u003d {{ cyborg_keystone_user }}"},{"line_number":39,"context_line":"project_name \u003d service"},{"line_number":40,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":41,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":42,"context_line":"auth_type \u003d password"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[oslo_messaging_notifications]"},{"line_number":45,"context_line":"transport_url \u003d {{ notify_transport_url }}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9fb8cfa7_09d60951","line":42,"range":{"start_line":34,"start_character":0,"end_line":42,"end_character":20},"updated":"2019-06-18 14:40:58.000000000","message":"This was removed.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":31,"context_line":"policy_file \u003d {{ cyborg_policy_file }}"},{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[service_credentials]"},{"line_number":35,"context_line":"auth_url \u003d {{ keystone_public_url }}/v3"},{"line_number":36,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":37,"context_line":"password \u003d {{ cyborg_keystone_password }}"},{"line_number":38,"context_line":"username \u003d {{ cyborg_keystone_user }}"},{"line_number":39,"context_line":"project_name \u003d service"},{"line_number":40,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":41,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":42,"context_line":"auth_type \u003d password"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[oslo_messaging_notifications]"},{"line_number":45,"context_line":"transport_url \u003d {{ notify_transport_url }}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"bf51134e_7477213c","line":42,"range":{"start_line":34,"start_character":0,"end_line":42,"end_character":20},"in_reply_to":"9fb8cfa7_09d60951","updated":"2020-06-16 19:45:56.000000000","message":"done.\nProbably some left over because the PR has been waiting for my attention for a long time.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"08efc9b40174b1363bdc32c4e907c8f776d9184a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":18,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":19,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":20,"context_line":"auth_uri \u003d {{ keystone_public_url }}"},{"line_number":21,"context_line":"project_domain_name \u003d {{ default_project_domain_name }}"},{"line_number":22,"context_line":"project_name \u003d service"},{"line_number":23,"context_line":"user_domain_name \u003d {{ default_user_domain_name }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_5d2cd998","line":20,"range":{"start_line":20,"start_character":23,"end_line":20,"end_character":29},"updated":"2020-07-27 11:25:51.000000000","message":"internal","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cac770ea6c68dd8910c3ad831a19580a45d78ed8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":18,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":19,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":20,"context_line":"auth_uri \u003d {{ keystone_public_url }}"},{"line_number":21,"context_line":"project_domain_name \u003d {{ default_project_domain_name }}"},{"line_number":22,"context_line":"project_name \u003d service"},{"line_number":23,"context_line":"user_domain_name \u003d {{ default_user_domain_name }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_feb0438e","line":20,"range":{"start_line":20,"start_character":23,"end_line":20,"end_character":29},"in_reply_to":"9f560f44_3ec59b3d","updated":"2020-07-27 13:26:07.000000000","message":"keystone is unusual in that it has two ports - 5000 and 35357. Public and internal API both use 5000","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"bdbdb967b1c087f4e0ff9fd1578ef62e150569c9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":18,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":19,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":20,"context_line":"auth_uri \u003d {{ keystone_public_url }}"},{"line_number":21,"context_line":"project_domain_name \u003d {{ default_project_domain_name }}"},{"line_number":22,"context_line":"project_name \u003d service"},{"line_number":23,"context_line":"user_domain_name \u003d {{ default_user_domain_name }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_3ec59b3d","line":20,"range":{"start_line":20,"start_character":23,"end_line":20,"end_character":29},"in_reply_to":"9f560f44_5d2cd998","updated":"2020-07-27 13:22:54.000000000","message":"but the port is the public one... So, it seems that we should be using the public, right?","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"af628852b23f7b52b437b5b99bdd823792740f3e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":18,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":19,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":20,"context_line":"auth_uri \u003d {{ keystone_public_url }}"},{"line_number":21,"context_line":"project_domain_name \u003d {{ default_project_domain_name }}"},{"line_number":22,"context_line":"project_name \u003d service"},{"line_number":23,"context_line":"user_domain_name \u003d {{ default_user_domain_name }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_7e19d386","line":20,"range":{"start_line":20,"start_character":23,"end_line":20,"end_character":29},"in_reply_to":"9f560f44_feb0438e","updated":"2020-07-27 13:29:12.000000000","message":"So, this should be the internal one then? \nWhen I saw public port there, I assumed that there was a misconfiguration here.","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"}],"ansible/roles/designate/templates/designate.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":13,"context_line":"[service:api]"},{"line_number":14,"context_line":"listen \u003d {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_listen_port }}"},{"line_number":15,"context_line":"api_base_uri \u003d {{ designate_internal_endpoint }}"},{"line_number":16,"context_line":"enabled_extensions_v2 \u003d \u0027quotas, reports\u0027"},{"line_number":17,"context_line":"workers \u003d {{ openstack_service_workers }}"},{"line_number":18,"context_line":"enable_api_admin \u003d True"},{"line_number":19,"context_line":"enable_host_header \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_b238e2d2","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":41},"updated":"2020-06-29 09:28:30.000000000","message":"unrelated","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"[service:api]"},{"line_number":14,"context_line":"listen \u003d {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ designate_api_listen_port }}"},{"line_number":15,"context_line":"api_base_uri \u003d {{ designate_internal_endpoint }}"},{"line_number":16,"context_line":"enabled_extensions_v2 \u003d \u0027quotas, reports\u0027"},{"line_number":17,"context_line":"workers \u003d {{ openstack_service_workers }}"},{"line_number":18,"context_line":"enable_api_admin \u003d True"},{"line_number":19,"context_line":"enable_host_header \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_78cd8bb5","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":41},"in_reply_to":"bf51134e_b238e2d2","updated":"2020-06-29 11:52:31.000000000","message":"This probably came with the conflict resolution. I will remove this then.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"}],"ansible/roles/freezer/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":37,"context_line":"freezer_database_address: \"{{ database_address | put_address_in_context(\u0027url\u0027) }}:{{ database_port }}\""},{"line_number":38,"context_line":"freezer_elasticsearch_replicas: \"1\""},{"line_number":39,"context_line":"freezer_es_protocol: \"{{ internal_protocol }}\""},{"line_number":40,"context_line":"freezer_es_address: \"{{ elasticsearch_address | put_address_in_context(\u0027url\u0027) }}\""},{"line_number":41,"context_line":"freezer_es_port: \"{{ elasticsearch_port }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_9255defc","line":40,"range":{"start_line":40,"start_character":48,"end_line":40,"end_character":77},"updated":"2020-06-29 09:28:30.000000000","message":"Probably better to do this in the config file?","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"freezer_database_address: \"{{ database_address | put_address_in_context(\u0027url\u0027) }}:{{ database_port }}\""},{"line_number":38,"context_line":"freezer_elasticsearch_replicas: \"1\""},{"line_number":39,"context_line":"freezer_es_protocol: \"{{ internal_protocol }}\""},{"line_number":40,"context_line":"freezer_es_address: \"{{ elasticsearch_address | put_address_in_context(\u0027url\u0027) }}\""},{"line_number":41,"context_line":"freezer_es_port: \"{{ elasticsearch_port }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_b8c28383","line":40,"range":{"start_line":40,"start_character":48,"end_line":40,"end_character":77},"in_reply_to":"bf51134e_9255defc","updated":"2020-06-29 11:52:31.000000000","message":"Done","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0f2391a680d900f9ce89eeaa37fe831e0b95e5a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"freezer_database_user: \"{% if use_preconfigured_databases | bool and use_common_mariadb_user | bool %}{{ database_user }}{% else %}freezer{% endif %}\""},{"line_number":37,"context_line":"freezer_database_address: \"{{ database_address | put_address_in_context(\u0027url\u0027) }}:{{ database_port }}\""},{"line_number":38,"context_line":"freezer_elasticsearch_replicas: \"1\""},{"line_number":39,"context_line":"freezer_es_protocol: \"{{ internal_protocol }}\""},{"line_number":40,"context_line":"freezer_es_address: \"{{ elasticsearch_address }}\""},{"line_number":41,"context_line":"freezer_es_port: \"{{ elasticsearch_port }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"####################"},{"line_number":44,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_c1ce11b3","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":43},"updated":"2020-08-17 16:56:43.000000000","message":"fixes freezer\u0027s es integration","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"757e482ed270a8ddb1ec8fd4b0a185621cf62d25","unresolved":false,"context_lines":[{"line_number":36,"context_line":"freezer_database_user: \"{% if use_preconfigured_databases | bool and use_common_mariadb_user | bool %}{{ database_user }}{% else %}freezer{% endif %}\""},{"line_number":37,"context_line":"freezer_database_address: \"{{ database_address | put_address_in_context(\u0027url\u0027) }}:{{ database_port }}\""},{"line_number":38,"context_line":"freezer_elasticsearch_replicas: \"1\""},{"line_number":39,"context_line":"freezer_es_protocol: \"{{ internal_protocol }}\""},{"line_number":40,"context_line":"freezer_es_address: \"{{ elasticsearch_address }}\""},{"line_number":41,"context_line":"freezer_es_port: \"{{ elasticsearch_port }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"####################"},{"line_number":44,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_bc4ce076","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":43},"in_reply_to":"9f560f44_418de1d1","updated":"2020-08-17 17:38:02.000000000","message":"It\u0027s ok/nice. I leave all kinds of comments. Sorry for being unclear.","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d1cf6d923c874226ec802204a4596a19099b9aaf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"freezer_database_user: \"{% if use_preconfigured_databases | bool and use_common_mariadb_user | bool %}{{ database_user }}{% else %}freezer{% endif %}\""},{"line_number":37,"context_line":"freezer_database_address: \"{{ database_address | put_address_in_context(\u0027url\u0027) }}:{{ database_port }}\""},{"line_number":38,"context_line":"freezer_elasticsearch_replicas: \"1\""},{"line_number":39,"context_line":"freezer_es_protocol: \"{{ internal_protocol }}\""},{"line_number":40,"context_line":"freezer_es_address: \"{{ elasticsearch_address }}\""},{"line_number":41,"context_line":"freezer_es_port: \"{{ elasticsearch_port }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"####################"},{"line_number":44,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_418de1d1","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":43},"in_reply_to":"9f560f44_c1ce11b3","updated":"2020-08-17 17:27:23.000000000","message":"Should I do something here? Or just leave as is?","commit_id":"8962614646d49ecd0d92505e9403a482736524de"}],"ansible/roles/glance/defaults/main.yml":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"eef9f2b7866eedef94432a2efb44812e606efafc","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"####################"},{"line_number":179,"context_line":"# OpenStack"},{"line_number":180,"context_line":"####################"},{"line_number":181,"context_line":"glance_admin_endpoint: \"{{ admin_protocol }}://{{ glance_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ glance_api_port }}\""},{"line_number":182,"context_line":"glance_internal_endpoint: \"{{ internal_protocol }}://{{ glance_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ glance_api_port }}\""},{"line_number":183,"context_line":"glance_public_endpoint: \"{{ public_protocol }}://{{ glance_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ glance_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_d1e078cf","line":180,"updated":"2020-06-19 14:04:55.000000000","message":"I think you can restore the new line here, so this file will be remove from the commit.","commit_id":"21e5417432d67ecf5dddc5efad474378e13bae78"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c9a7dfe41c2ce116d62621ae780e450479d89a69","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"####################"},{"line_number":179,"context_line":"# OpenStack"},{"line_number":180,"context_line":"####################"},{"line_number":181,"context_line":"glance_admin_endpoint: \"{{ admin_protocol }}://{{ glance_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ glance_api_port }}\""},{"line_number":182,"context_line":"glance_internal_endpoint: \"{{ internal_protocol }}://{{ glance_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ glance_api_port }}\""},{"line_number":183,"context_line":"glance_public_endpoint: \"{{ public_protocol }}://{{ glance_external_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ glance_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_6389dec8","line":180,"in_reply_to":"bf51134e_d1e078cf","updated":"2020-06-19 17:38:43.000000000","message":"Done","commit_id":"21e5417432d67ecf5dddc5efad474378e13bae78"}],"ansible/roles/grafana/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"############"},{"line_number":72,"context_line":"# Prometheus"},{"line_number":73,"context_line":"############"},{"line_number":74,"context_line":"grafana_prometheus_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ prometheus_port }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_a93fbd85","line":74,"range":{"start_line":74,"start_character":69,"end_line":74,"end_character":80},"updated":"2019-06-18 14:40:58.000000000","message":"fqdn?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":71,"context_line":"############"},{"line_number":72,"context_line":"# Prometheus"},{"line_number":73,"context_line":"############"},{"line_number":74,"context_line":"grafana_prometheus_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ prometheus_port }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_54749d35","line":74,"range":{"start_line":74,"start_character":69,"end_line":74,"end_character":80},"in_reply_to":"9fb8cfa7_a93fbd85","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"}],"ansible/roles/ironic/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"#########"},{"line_number":188,"context_line":"# Ironic"},{"line_number":189,"context_line":"#########"},{"line_number":190,"context_line":"ironic_ipxe_endpoint: \"{{ internal_protocol }}://{{ api_interface_address }}:{{ ironic_ipxe_port }}\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"ironic_dnsmasq_interface: \"{{ api_interface }}\""},{"line_number":193,"context_line":"ironic_dnsmasq_dhcp_range:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_896f5991","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":20},"updated":"2019-06-18 14:40:58.000000000","message":"How is this different from ironic_ipxe_url?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":187,"context_line":"#########"},{"line_number":188,"context_line":"# Ironic"},{"line_number":189,"context_line":"#########"},{"line_number":190,"context_line":"ironic_ipxe_endpoint: \"{{ internal_protocol }}://{{ api_interface_address }}:{{ ironic_ipxe_port }}\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"ironic_dnsmasq_interface: \"{{ api_interface }}\""},{"line_number":193,"context_line":"ironic_dnsmasq_dhcp_range:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_f4b171e3","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":20},"in_reply_to":"9fb8cfa7_896f5991","updated":"2020-06-16 19:45:56.000000000","message":"It was not being built using the schema variable before. I normalized to use the same variable now `ironic_ipxe_url`","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"ironic_inspector_admin_endpoint: \"{{ admin_protocol }}://{{ ironic_inspector_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ ironic_inspector_port }}\""},{"line_number":184,"context_line":"ironic_inspector_internal_endpoint: \"{{ internal_protocol }}://{{ ironic_inspector_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ ironic_inspector_port }}\""},{"line_number":185,"context_line":"ironic_inspector_public_endpoint: \"{{ public_protocol }}://{{ ironic_inspector_external_fqdn  | put_address_in_context(\u0027url\u0027) }}:{{ ironic_inspector_port }}\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"ironic_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":188,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_72712aa8","line":185,"range":{"start_line":185,"start_character":93,"end_line":185,"end_character":94},"updated":"2020-06-29 09:28:30.000000000","message":"nit: extra space","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"ironic_inspector_admin_endpoint: \"{{ admin_protocol }}://{{ ironic_inspector_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ ironic_inspector_port }}\""},{"line_number":184,"context_line":"ironic_inspector_internal_endpoint: \"{{ internal_protocol }}://{{ ironic_inspector_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ ironic_inspector_port }}\""},{"line_number":185,"context_line":"ironic_inspector_public_endpoint: \"{{ public_protocol }}://{{ ironic_inspector_external_fqdn  | put_address_in_context(\u0027url\u0027) }}:{{ ironic_inspector_port }}\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"ironic_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":188,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_3865d3b5","line":185,"range":{"start_line":185,"start_character":93,"end_line":185,"end_character":94},"in_reply_to":"bf51134e_72712aa8","updated":"2020-06-29 11:52:31.000000000","message":"Done","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":200,"context_line":"ironic_dnsmasq_boot_file: \"{% if enable_ironic_ipxe | bool %}undionly.kpxe{% else %}pxelinux.0{% endif %}\""},{"line_number":201,"context_line":"ironic_cleaning_network:"},{"line_number":202,"context_line":"ironic_console_serial_speed: \"115200n8\""},{"line_number":203,"context_line":"ironic_ipxe_url: \"{{ internal_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ ironic_ipxe_port }}\""},{"line_number":204,"context_line":"ironic_enable_rolling_upgrade: \"yes\""},{"line_number":205,"context_line":"ironic_inspector_kernel_cmdline_extras: []"},{"line_number":206,"context_line":"ironic_inspector_pxe_filter: \"{% if enable_neutron | bool %}dnsmasq{% else %}none{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_926e7ec6","line":203,"range":{"start_line":203,"start_character":18,"end_line":203,"end_character":41},"updated":"2020-06-29 09:28:30.000000000","message":"This is wrong","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":200,"context_line":"ironic_dnsmasq_boot_file: \"{% if enable_ironic_ipxe | bool %}undionly.kpxe{% else %}pxelinux.0{% endif %}\""},{"line_number":201,"context_line":"ironic_cleaning_network:"},{"line_number":202,"context_line":"ironic_console_serial_speed: \"115200n8\""},{"line_number":203,"context_line":"ironic_ipxe_url: \"{{ internal_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ ironic_ipxe_port }}\""},{"line_number":204,"context_line":"ironic_enable_rolling_upgrade: \"yes\""},{"line_number":205,"context_line":"ironic_inspector_kernel_cmdline_extras: []"},{"line_number":206,"context_line":"ironic_inspector_pxe_filter: \"{% if enable_neutron | bool %}dnsmasq{% else %}none{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_785bcbf4","line":203,"range":{"start_line":203,"start_character":18,"end_line":203,"end_character":41},"in_reply_to":"bf51134e_926e7ec6","updated":"2020-06-29 11:52:31.000000000","message":"Done","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0f2391a680d900f9ce89eeaa37fe831e0b95e5a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"ironic_dnsmasq_boot_file: \"{% if enable_ironic_ipxe | bool %}undionly.kpxe{% else %}pxelinux.0{% endif %}\""},{"line_number":201,"context_line":"ironic_cleaning_network:"},{"line_number":202,"context_line":"ironic_console_serial_speed: \"115200n8\""},{"line_number":203,"context_line":"ironic_ipxe_url: \"http://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ ironic_ipxe_port }}\""},{"line_number":204,"context_line":"ironic_enable_rolling_upgrade: \"yes\""},{"line_number":205,"context_line":"ironic_inspector_kernel_cmdline_extras: []"},{"line_number":206,"context_line":"ironic_inspector_pxe_filter: \"{% if enable_neutron | bool %}dnsmasq{% else %}none{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_21c54d8f","line":203,"range":{"start_line":203,"start_character":18,"end_line":203,"end_character":22},"updated":"2020-08-17 16:56:43.000000000","message":"is it always http only?","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0f2391a680d900f9ce89eeaa37fe831e0b95e5a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"ironic_dnsmasq_boot_file: \"{% if enable_ironic_ipxe | bool %}undionly.kpxe{% else %}pxelinux.0{% endif %}\""},{"line_number":201,"context_line":"ironic_cleaning_network:"},{"line_number":202,"context_line":"ironic_console_serial_speed: \"115200n8\""},{"line_number":203,"context_line":"ironic_ipxe_url: \"http://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ ironic_ipxe_port }}\""},{"line_number":204,"context_line":"ironic_enable_rolling_upgrade: \"yes\""},{"line_number":205,"context_line":"ironic_inspector_kernel_cmdline_extras: []"},{"line_number":206,"context_line":"ironic_inspector_pxe_filter: \"{% if enable_neutron | bool %}dnsmasq{% else %}none{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_21aeede6","line":203,"updated":"2020-08-17 16:56:43.000000000","message":"redundant change","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"757e482ed270a8ddb1ec8fd4b0a185621cf62d25","unresolved":false,"context_lines":[{"line_number":200,"context_line":"ironic_dnsmasq_boot_file: \"{% if enable_ironic_ipxe | bool %}undionly.kpxe{% else %}pxelinux.0{% endif %}\""},{"line_number":201,"context_line":"ironic_cleaning_network:"},{"line_number":202,"context_line":"ironic_console_serial_speed: \"115200n8\""},{"line_number":203,"context_line":"ironic_ipxe_url: \"http://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ ironic_ipxe_port }}\""},{"line_number":204,"context_line":"ironic_enable_rolling_upgrade: \"yes\""},{"line_number":205,"context_line":"ironic_inspector_kernel_cmdline_extras: []"},{"line_number":206,"context_line":"ironic_inspector_pxe_filter: \"{% if enable_neutron | bool %}dnsmasq{% else %}none{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_fc565806","line":203,"range":{"start_line":203,"start_character":18,"end_line":203,"end_character":22},"in_reply_to":"9f560f44_2176edd9","updated":"2020-08-17 17:38:02.000000000","message":"I think it was mostly to Mark as he\u0027s an ironic guru. :-)\nAs for \"redundancy\" - there is no need for quotes here so far but it\u0027s fine with them too.","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d1cf6d923c874226ec802204a4596a19099b9aaf","unresolved":false,"context_lines":[{"line_number":200,"context_line":"ironic_dnsmasq_boot_file: \"{% if enable_ironic_ipxe | bool %}undionly.kpxe{% else %}pxelinux.0{% endif %}\""},{"line_number":201,"context_line":"ironic_cleaning_network:"},{"line_number":202,"context_line":"ironic_console_serial_speed: \"115200n8\""},{"line_number":203,"context_line":"ironic_ipxe_url: \"http://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ ironic_ipxe_port }}\""},{"line_number":204,"context_line":"ironic_enable_rolling_upgrade: \"yes\""},{"line_number":205,"context_line":"ironic_inspector_kernel_cmdline_extras: []"},{"line_number":206,"context_line":"ironic_inspector_pxe_filter: \"{% if enable_neutron | bool %}dnsmasq{% else %}none{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9f560f44_2176edd9","line":203,"range":{"start_line":203,"start_character":18,"end_line":203,"end_character":22},"in_reply_to":"9f560f44_21c54d8f","updated":"2020-08-17 17:27:23.000000000","message":"should I externalize this schema configuration?","commit_id":"8962614646d49ecd0d92505e9403a482736524de"}],"ansible/roles/ironic/templates/inspector.ipxe.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e0f2391a680d900f9ce89eeaa37fe831e0b95e5a","unresolved":false,"context_lines":[{"line_number":13,"context_line":":inspector_ipa"},{"line_number":14,"context_line":":retry_boot"},{"line_number":15,"context_line":"imgfree"},{"line_number":16,"context_line":"kernel --timeout 30000 {{ ironic_ipxe_url }}/ironic-agent.kernel ipa-inspection-callback-url\u003d{{ironic_inspector_internal_endpoint }}/v1/continue systemd.journald.forward_to_console\u003dyes BOOTIF\u003d${mac} initrd\u003dironic-agent.initramfs {{ ironic_inspector_kernel_cmdline_extras | join(\u0027 \u0027) }} || goto retry_boot"},{"line_number":17,"context_line":"initrd --timeout 30000 {{ ironic_ipxe_url }}/ironic-agent.initramfs || goto retry_boot"},{"line_number":18,"context_line":"boot"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"9f560f44_e17d156f","line":16,"range":{"start_line":16,"start_character":94,"end_line":16,"end_character":96},"updated":"2020-08-17 16:56:43.000000000","message":"missing space","commit_id":"8962614646d49ecd0d92505e9403a482736524de"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d1cf6d923c874226ec802204a4596a19099b9aaf","unresolved":false,"context_lines":[{"line_number":13,"context_line":":inspector_ipa"},{"line_number":14,"context_line":":retry_boot"},{"line_number":15,"context_line":"imgfree"},{"line_number":16,"context_line":"kernel --timeout 30000 {{ ironic_ipxe_url }}/ironic-agent.kernel ipa-inspection-callback-url\u003d{{ironic_inspector_internal_endpoint }}/v1/continue systemd.journald.forward_to_console\u003dyes BOOTIF\u003d${mac} initrd\u003dironic-agent.initramfs {{ ironic_inspector_kernel_cmdline_extras | join(\u0027 \u0027) }} || goto retry_boot"},{"line_number":17,"context_line":"initrd --timeout 30000 {{ ironic_ipxe_url }}/ironic-agent.initramfs || goto retry_boot"},{"line_number":18,"context_line":"boot"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"9f560f44_017129df","line":16,"range":{"start_line":16,"start_character":94,"end_line":16,"end_character":96},"in_reply_to":"9f560f44_e17d156f","updated":"2020-08-17 17:27:23.000000000","message":"Done","commit_id":"8962614646d49ecd0d92505e9403a482736524de"}],"ansible/roles/kuryr/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"kuryr_source_version: \"{{ kolla_source_version }}\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"###########"},{"line_number":64,"context_line":"# Edpoints"},{"line_number":65,"context_line":"##########"},{"line_number":66,"context_line":"kuryr_internal_endpoint: \"{{ internal_protocol }}://{{ api_interface_address }}:{{ kuryr_port }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_e92cd54b","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":10},"updated":"2019-06-18 14:40:58.000000000","message":"Spelling","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":61,"context_line":"kuryr_source_version: \"{{ kolla_source_version }}\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"###########"},{"line_number":64,"context_line":"# Edpoints"},{"line_number":65,"context_line":"##########"},{"line_number":66,"context_line":"kuryr_internal_endpoint: \"{{ internal_protocol }}://{{ api_interface_address }}:{{ kuryr_port }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_b405397d","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":10},"in_reply_to":"9fb8cfa7_e92cd54b","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"}],"ansible/roles/kuryr/templates/kuryr.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"08efc9b40174b1363bdc32c4e907c8f776d9184a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"kuryr_uri \u003d {{ internal_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ kuryr_port }}"},{"line_number":3,"context_line":"debug \u003d {{ kuryr_logging_debug }}"},{"line_number":4,"context_line":"log_dir \u003d /var/log/kolla/kuryr"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_5dedf923","side":"PARENT","line":2,"updated":"2020-07-27 11:25:51.000000000","message":"This isn\u0027t using the VIP.","commit_id":"6bbc7138851e3517fdf20f06bf85b5a0c88b93c0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f256517894d6d2ff870a63b8c39e8e363b9734fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"kuryr_uri \u003d {{ internal_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ kuryr_port }}"},{"line_number":3,"context_line":"debug \u003d {{ kuryr_logging_debug }}"},{"line_number":4,"context_line":"log_dir \u003d /var/log/kolla/kuryr"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_f8cfbb54","side":"PARENT","line":2,"in_reply_to":"9f560f44_5dedf923","updated":"2020-07-27 11:27:36.000000000","message":"Ignore this","commit_id":"6bbc7138851e3517fdf20f06bf85b5a0c88b93c0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cac770ea6c68dd8910c3ad831a19580a45d78ed8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"kuryr_uri \u003d {{ internal_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ kuryr_port }}"},{"line_number":3,"context_line":"debug \u003d {{ kuryr_logging_debug }}"},{"line_number":4,"context_line":"log_dir \u003d /var/log/kolla/kuryr"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_1ea8971d","side":"PARENT","line":2,"in_reply_to":"9f560f44_bee6cbe7","updated":"2020-07-27 13:26:07.000000000","message":"It\u0027s fine, I was mistaken","commit_id":"6bbc7138851e3517fdf20f06bf85b5a0c88b93c0"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"bdbdb967b1c087f4e0ff9fd1578ef62e150569c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"kuryr_uri \u003d {{ internal_protocol }}://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ kuryr_port }}"},{"line_number":3,"context_line":"debug \u003d {{ kuryr_logging_debug }}"},{"line_number":4,"context_line":"log_dir \u003d /var/log/kolla/kuryr"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_bee6cbe7","side":"PARENT","line":2,"in_reply_to":"9f560f44_f8cfbb54","updated":"2020-07-27 13:22:54.000000000","message":"I did not get it. Should I maintain my change? Or should I leave as it was before?","commit_id":"6bbc7138851e3517fdf20f06bf85b5a0c88b93c0"}],"ansible/roles/kuryr/templates/kuryr.spec.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"08efc9b40174b1363bdc32c4e907c8f776d9184a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"http://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ kuryr_port }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_dd93c9a2","side":"PARENT","line":1,"updated":"2020-07-27 11:25:51.000000000","message":"This isn\u0027t using the VIP.","commit_id":"6bbc7138851e3517fdf20f06bf85b5a0c88b93c0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f256517894d6d2ff870a63b8c39e8e363b9734fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"http://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ kuryr_port }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9f560f44_d8cc7763","side":"PARENT","line":1,"in_reply_to":"9f560f44_dd93c9a2","updated":"2020-07-27 11:27:36.000000000","message":"Ignore this","commit_id":"6bbc7138851e3517fdf20f06bf85b5a0c88b93c0"}],"ansible/roles/manila/templates/manila-share.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[neutron]"},{"line_number":41,"context_line":"url \u003d {{ neutron_internal_endpoint }}"},{"line_number":42,"context_line":"uth_uri \u003d {{ keystone_internal_url }}"},{"line_number":43,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":44,"context_line":"auth_type \u003d password"},{"line_number":45,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9fb8cfa7_09a5a9b5","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":7},"updated":"2019-06-18 14:40:58.000000000","message":"Replace \u0027a\u0027","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[neutron]"},{"line_number":41,"context_line":"url \u003d {{ neutron_internal_endpoint }}"},{"line_number":42,"context_line":"uth_uri \u003d {{ keystone_internal_url }}"},{"line_number":43,"context_line":"auth_url \u003d {{ keystone_admin_url }}"},{"line_number":44,"context_line":"auth_type \u003d password"},{"line_number":45,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"bf51134e_74f3a19f","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":7},"in_reply_to":"9fb8cfa7_09a5a9b5","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"}],"ansible/roles/mistral/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4407a8320221f4b000eb30e0811620a6ab1862c5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"mistral_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ mistral_api_port }}\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"mistral_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ mistral_api_port }}/v2\""},{"line_number":104,"context_line":"mistral_internal_endpoint: \"{{ imistral_base_internal_endpoint }}/v2\""},{"line_number":105,"context_line":"mistral_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ mistral_api_port }}/v2\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"mistral_logging_debug: \"{{ openstack_logging_debug }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fce034c_93767ea4","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":32},"updated":"2019-04-15 12:52:34.000000000","message":"imistral?","commit_id":"244bc7842bd99bba648abb027b74c2fe60a0dc37"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"2a5ce089ab0780874fb2fdca291916d13e7c568b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"mistral_base_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ mistral_api_port }}\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"mistral_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ mistral_api_port }}/v2\""},{"line_number":104,"context_line":"mistral_internal_endpoint: \"{{ imistral_base_internal_endpoint }}/v2\""},{"line_number":105,"context_line":"mistral_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ mistral_api_port }}/v2\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"mistral_logging_debug: \"{{ openstack_logging_debug }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fce034c_537ed66b","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":32},"in_reply_to":"3fce034c_93767ea4","updated":"2019-04-15 13:08:29.000000000","message":"It was a typo.\nSorry for the trouble, I am fixing it right now.","commit_id":"244bc7842bd99bba648abb027b74c2fe60a0dc37"}],"ansible/roles/monasca/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"monasca\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"monasca_grafana_base_endpoint: \"{{ grafana_internal_base_endpoint }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"monasca_services:"},{"line_number":7,"context_line":"  monasca-api:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_697c6520","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":69},"updated":"2019-06-18 14:40:58.000000000","message":"This is not the same as the grafana URL - it uses a different port.\n\nAlso, should probably be moved lower in the file.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"monasca\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"monasca_grafana_base_endpoint: \"{{ grafana_internal_base_endpoint }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"monasca_services:"},{"line_number":7,"context_line":"  monasca-api:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_947d95e9","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":69},"in_reply_to":"9fb8cfa7_697c6520","updated":"2020-06-16 19:45:56.000000000","message":"I see. Good catch. Thanks for the huge help here.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"monasca_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"monasca_grafana_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ monasca_api_port }}\""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"####################"},{"line_number":329,"context_line":"# Keystone"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_f2b89a11","line":326,"range":{"start_line":326,"start_character":119,"end_line":326,"end_character":135},"updated":"2020-06-29 09:28:30.000000000","message":"monasca_grafana_server_port","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"monasca_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"monasca_grafana_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ monasca_api_port }}\""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"####################"},{"line_number":329,"context_line":"# Keystone"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf51134e_b8f563cd","line":326,"range":{"start_line":326,"start_character":119,"end_line":326,"end_character":135},"in_reply_to":"bf51134e_f2b89a11","updated":"2020-06-29 11:52:31.000000000","message":"Done. Good catch.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"08efc9b40174b1363bdc32c4e907c8f776d9184a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"      name: \"Monasca API\""},{"line_number":172,"context_line":"      type: \"monasca-datasource\""},{"line_number":173,"context_line":"      access: \"proxy\""},{"line_number":174,"context_line":"      url: \"{{ monasca_api_base_internal_endpoint }}\""},{"line_number":175,"context_line":"      isDefault: True"},{"line_number":176,"context_line":"      basicAuth: false"},{"line_number":177,"context_line":"      jsonData:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9f560f44_b8aa6382","line":174,"range":{"start_line":174,"start_character":15,"end_line":174,"end_character":49},"updated":"2020-07-27 11:25:51.000000000","message":"base_endpoint","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"bdbdb967b1c087f4e0ff9fd1578ef62e150569c9","unresolved":false,"context_lines":[{"line_number":171,"context_line":"      name: \"Monasca API\""},{"line_number":172,"context_line":"      type: \"monasca-datasource\""},{"line_number":173,"context_line":"      access: \"proxy\""},{"line_number":174,"context_line":"      url: \"{{ monasca_api_base_internal_endpoint }}\""},{"line_number":175,"context_line":"      isDefault: True"},{"line_number":176,"context_line":"      basicAuth: false"},{"line_number":177,"context_line":"      jsonData:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9f560f44_de23bf04","line":174,"range":{"start_line":174,"start_character":15,"end_line":174,"end_character":49},"in_reply_to":"9f560f44_b8aa6382","updated":"2020-07-27 13:22:54.000000000","message":"This was already fixed, right?","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cac770ea6c68dd8910c3ad831a19580a45d78ed8","unresolved":false,"context_lines":[{"line_number":171,"context_line":"      name: \"Monasca API\""},{"line_number":172,"context_line":"      type: \"monasca-datasource\""},{"line_number":173,"context_line":"      access: \"proxy\""},{"line_number":174,"context_line":"      url: \"{{ monasca_api_base_internal_endpoint }}\""},{"line_number":175,"context_line":"      isDefault: True"},{"line_number":176,"context_line":"      basicAuth: false"},{"line_number":177,"context_line":"      jsonData:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9f560f44_9e7147e4","line":174,"range":{"start_line":174,"start_character":15,"end_line":174,"end_character":49},"in_reply_to":"9f560f44_de23bf04","updated":"2020-07-27 13:26:07.000000000","message":"yes","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"08efc9b40174b1363bdc32c4e907c8f776d9184a","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"monasca_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"monasca_grafana_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ monasca_grafana_server_port }}\""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"####################"},{"line_number":328,"context_line":"# Keystone"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9f560f44_7889eb24","line":325,"range":{"start_line":325,"start_character":0,"end_line":325,"end_character":29},"updated":"2020-07-27 11:25:51.000000000","message":"internal","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"bdbdb967b1c087f4e0ff9fd1578ef62e150569c9","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"monasca_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"monasca_grafana_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ monasca_grafana_server_port }}\""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"####################"},{"line_number":328,"context_line":"# Keystone"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9f560f44_9e602735","line":325,"range":{"start_line":325,"start_character":0,"end_line":325,"end_character":29},"in_reply_to":"9f560f44_7889eb24","updated":"2020-07-27 13:22:54.000000000","message":"It was already fixed, right?","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cac770ea6c68dd8910c3ad831a19580a45d78ed8","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"monasca_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"monasca_grafana_base_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ monasca_grafana_server_port }}\""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"####################"},{"line_number":328,"context_line":"# Keystone"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9f560f44_fe75e3cd","line":325,"range":{"start_line":325,"start_character":0,"end_line":325,"end_character":29},"in_reply_to":"9f560f44_9e602735","updated":"2020-07-27 13:26:07.000000000","message":"yes","commit_id":"f819a01b699ab2b59051105e754f57ca58453dff"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":515,"context_line":"########################"},{"line_number":516,"context_line":"# Opendaylight endpoint"},{"line_number":517,"context_line":"########################"},{"line_number":518,"context_line":"opendaylight_base_endpoint_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ opendaylight_restconf_port }}\""},{"line_number":519,"context_line":"opendaylight_base_haproxy_endpoint_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ opendaylight_haproxy_restconf_port }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_29d98d21","line":518,"range":{"start_line":518,"start_character":76,"end_line":518,"end_character":88},"updated":"2019-06-18 14:40:58.000000000","message":"fqdn?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":515,"context_line":"########################"},{"line_number":516,"context_line":"# Opendaylight endpoint"},{"line_number":517,"context_line":"########################"},{"line_number":518,"context_line":"opendaylight_base_endpoint_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ opendaylight_restconf_port }}\""},{"line_number":519,"context_line":"opendaylight_base_haproxy_endpoint_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ opendaylight_haproxy_restconf_port }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_346c8935","line":518,"range":{"start_line":518,"start_character":76,"end_line":518,"end_character":88},"in_reply_to":"9fb8cfa7_29d98d21","updated":"2020-06-16 19:45:56.000000000","message":"We do not need them anymore.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":516,"context_line":"# Opendaylight endpoint"},{"line_number":517,"context_line":"########################"},{"line_number":518,"context_line":"opendaylight_base_endpoint_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ opendaylight_restconf_port }}\""},{"line_number":519,"context_line":"opendaylight_base_haproxy_endpoint_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ opendaylight_haproxy_restconf_port }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_e9db751e","line":519,"updated":"2019-06-18 14:40:58.000000000","message":"Shouldn\u0027t these go into group_vars/all.yml?","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":516,"context_line":"# Opendaylight endpoint"},{"line_number":517,"context_line":"########################"},{"line_number":518,"context_line":"opendaylight_base_endpoint_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ opendaylight_restconf_port }}\""},{"line_number":519,"context_line":"opendaylight_base_haproxy_endpoint_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ opendaylight_haproxy_restconf_port }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_14698524","line":519,"in_reply_to":"9fb8cfa7_e9db751e","updated":"2020-06-16 19:45:56.000000000","message":"We do not need them anymore.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"}],"ansible/roles/neutron/templates/ml2_conf.ini.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"fd98b18e081b5680e02c2d16b3b8f8f988d44d50","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% if enable_haproxy | bool %}"},{"line_number":30,"context_line":"url \u003d {{ opendaylight_base_haproxy_endpoint_url }}/controller/nb/v2/neutron"},{"line_number":31,"context_line":"{% else %}"},{"line_number":32,"context_line":"url \u003d {{ opendaylight_base_haproxy_endpoint_url }}/controller/nb/v2/neutron"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":"username \u003d admin"},{"line_number":35,"context_line":"password \u003d {{ opendaylight_password }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fce034c_914f4191","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":34},"updated":"2019-04-16 12:11:07.000000000","message":"not the haproxy endpoint","commit_id":"4875a8b3a1225c4a3f1e33d765efe1a325bafbcf"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"8f2d1a93da69743fd3a560e83e9fd488e1b7d9bd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% if enable_haproxy | bool %}"},{"line_number":30,"context_line":"url \u003d {{ opendaylight_base_haproxy_endpoint_url }}/controller/nb/v2/neutron"},{"line_number":31,"context_line":"{% else %}"},{"line_number":32,"context_line":"url \u003d {{ opendaylight_base_haproxy_endpoint_url }}/controller/nb/v2/neutron"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":"username \u003d admin"},{"line_number":35,"context_line":"password \u003d {{ opendaylight_password }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fce034c_2c571605","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":34},"in_reply_to":"3fce034c_914f4191","updated":"2019-04-16 12:19:37.000000000","message":"copy and paste error.\nThanks for spotting that","commit_id":"4875a8b3a1225c4a3f1e33d765efe1a325bafbcf"}],"ansible/roles/nova-hyperv/templates/nova_hyperv.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"html5_proxy_base_url \u003d {{ public_protocol }}://{{ kolla_internal_vip_address }}:{{ rdp_port }}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[neutron]"},{"line_number":51,"context_line":"url \u003d {{ nova_hyperv_rdp_public_endpoint }}"},{"line_number":52,"context_line":"auth_strategy \u003d keystone"},{"line_number":53,"context_line":"project_domain_name \u003d default"},{"line_number":54,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9fb8cfa7_a90c9d94","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":40},"updated":"2019-06-18 14:40:58.000000000","message":"This should be neutron.","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":48,"context_line":"html5_proxy_base_url \u003d {{ public_protocol }}://{{ kolla_internal_vip_address }}:{{ rdp_port }}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[neutron]"},{"line_number":51,"context_line":"url \u003d {{ nova_hyperv_rdp_public_endpoint }}"},{"line_number":52,"context_line":"auth_strategy \u003d keystone"},{"line_number":53,"context_line":"project_domain_name \u003d default"},{"line_number":54,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"bf51134e_94cbd51c","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":40},"in_reply_to":"9fb8cfa7_a90c9d94","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"}],"ansible/roles/nova/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"979a96f6cb6e6666be7d7af6da737c113c53ec1c","unresolved":false,"context_lines":[{"line_number":365,"context_line":"####################"},{"line_number":366,"context_line":"nova_base_admin_endpoint: \"{{ admin_protocol }}://{{ nova_internal_fqdn }}:{{ nova_api_port }}\""},{"line_number":367,"context_line":"nova_base_internal_endpoint: \"{{ internal_protocol }}://{{ nova_internal_fqdn }}:{{ nova_api_port }}\""},{"line_number":368,"context_line":"nova_base_external_endpoint: \"{{ public_protocol }}://{{ nova_external_fqdn }}:{{ nova_api_port }}\""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"nova_legacy_admin_endpoint: \"{{ nova_base_admin_endpoint }}/v2/%(tenant_id)s\""},{"line_number":371,"context_line":"nova_legacy_internal_endpoint: \"{{ nova_base_internal_endpoint }}/v2/%(tenant_id)s\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9fb8cfa7_8968b921","line":368,"range":{"start_line":368,"start_character":10,"end_line":368,"end_character":18},"updated":"2019-06-18 14:40:58.000000000","message":"public","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"b683bd4e32d0f1387edc0a1002c41744a8ae3bba","unresolved":false,"context_lines":[{"line_number":365,"context_line":"####################"},{"line_number":366,"context_line":"nova_base_admin_endpoint: \"{{ admin_protocol }}://{{ nova_internal_fqdn }}:{{ nova_api_port }}\""},{"line_number":367,"context_line":"nova_base_internal_endpoint: \"{{ internal_protocol }}://{{ nova_internal_fqdn }}:{{ nova_api_port }}\""},{"line_number":368,"context_line":"nova_base_external_endpoint: \"{{ public_protocol }}://{{ nova_external_fqdn }}:{{ nova_api_port }}\""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"nova_legacy_admin_endpoint: \"{{ nova_base_admin_endpoint }}/v2/%(tenant_id)s\""},{"line_number":371,"context_line":"nova_legacy_internal_endpoint: \"{{ nova_base_internal_endpoint }}/v2/%(tenant_id)s\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_74e441ad","line":368,"range":{"start_line":368,"start_character":10,"end_line":368,"end_character":18},"in_reply_to":"9fb8cfa7_8968b921","updated":"2020-06-16 19:45:56.000000000","message":"Done","commit_id":"96a6cfc7201a243e75f24115e4c06cbb80353ef2"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[glance]"},{"line_number":61,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":62,"context_line":"api_servers \u003d {{glance_internal_endpoint }}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":65,"context_line":"debug \u003d {{ nova_logging_debug }}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_f24d3a3b","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":40},"updated":"2020-06-29 09:28:30.000000000","message":"nit: space\n\nYou probably also want to set this in the nova-cell role.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[glance]"},{"line_number":61,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":62,"context_line":"api_servers \u003d {{glance_internal_endpoint }}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":65,"context_line":"debug \u003d {{ nova_logging_debug }}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_78290b35","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":40},"in_reply_to":"bf51134e_f24d3a3b","updated":"2020-06-29 11:52:31.000000000","message":"Done. Thanks for the pointers.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"}],"ansible/roles/prometheus/templates/prometheus-alertmanager.yml.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"fd98b18e081b5680e02c2d16b3b8f8f988d44d50","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      - send_resolved: true"},{"line_number":14,"context_line":"        url: \u0027{{ vitrage_public_endpoint }}/v1/event\u0027"},{"line_number":15,"context_line":"        http_config:"},{"line_number":16,"context_line":"          basic_authdsdf            username: \u0027{{ keystone_admin_user }}\u0027"},{"line_number":17,"context_line":"            password: \u0027{{ keystone_admin_password }}\u0027"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"templates: []"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fce034c_b12efda2","line":16,"range":{"start_line":16,"start_character":20,"end_line":16,"end_character":24},"updated":"2019-04-16 12:11:07.000000000","message":"mistake guess","commit_id":"4875a8b3a1225c4a3f1e33d765efe1a325bafbcf"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"8f2d1a93da69743fd3a560e83e9fd488e1b7d9bd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      - send_resolved: true"},{"line_number":14,"context_line":"        url: \u0027{{ vitrage_public_endpoint }}/v1/event\u0027"},{"line_number":15,"context_line":"        http_config:"},{"line_number":16,"context_line":"          basic_authdsdf            username: \u0027{{ keystone_admin_user }}\u0027"},{"line_number":17,"context_line":"            password: \u0027{{ keystone_admin_password }}\u0027"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"templates: []"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fce034c_0c3c9abd","line":16,"range":{"start_line":16,"start_character":20,"end_line":16,"end_character":24},"in_reply_to":"3fce034c_b12efda2","updated":"2019-04-16 12:19:37.000000000","message":"Yes, totally.","commit_id":"4875a8b3a1225c4a3f1e33d765efe1a325bafbcf"}],"ansible/roles/prometheus/templates/prometheus-elasticsearch-exporter.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b23c99f0f2685bd779a92ba9d6e556144295301","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/elasticsearch_exporter/elasticsearch_exporter --es.uri http://{{ elasticsearch_internal_endpoint }} --web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_elasticsearch_exporter_port }}\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"permissions\": ["},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_725beaf4","line":2,"range":{"start_line":2,"start_character":76,"end_line":2,"end_character":120},"updated":"2020-06-29 09:28:30.000000000","message":"Please revert to previous - this is the local backend rather than the endpoint.","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"acf0927aef58f3bf65bae8a722495d2a728f12fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/elasticsearch_exporter/elasticsearch_exporter --es.uri http://{{ elasticsearch_internal_endpoint }} --web.listen-address {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_elasticsearch_exporter_port }}\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"permissions\": ["},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"bf51134e_181a8f15","line":2,"range":{"start_line":2,"start_character":76,"end_line":2,"end_character":120},"in_reply_to":"bf51134e_725beaf4","updated":"2020-06-29 11:52:31.000000000","message":"Done","commit_id":"7723bb75a5d280d7e4e7397f16304fc0bf96a4c9"}],"ansible/roles/telegraf/defaults/main.yml":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"eef9f2b7866eedef94432a2efb44812e606efafc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"####################"},{"line_number":35,"context_line":"# Protocols"},{"line_number":36,"context_line":"####################"},{"line_number":37,"context_line":"elasticsearch_proto: \"http\""},{"line_number":38,"context_line":"haproxy_proto: \"http\""},{"line_number":39,"context_line":"influxdb_proto: \"http\""},{"line_number":40,"context_line":"rabbitmq_proto: \"http\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_14049e7a","side":"PARENT","line":37,"updated":"2020-06-19 14:04:55.000000000","message":"Why did you remove it? Is there another place where it is defined? ansible/roles/telegraf/templates/telegraf.conf.j2 still uses that.","commit_id":"b74f3c879d7718d3039804b254c7a6a93dd02d38"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"c9a7dfe41c2ce116d62621ae780e450479d89a69","unresolved":false,"context_lines":[{"line_number":34,"context_line":"####################"},{"line_number":35,"context_line":"# Protocols"},{"line_number":36,"context_line":"####################"},{"line_number":37,"context_line":"elasticsearch_proto: \"http\""},{"line_number":38,"context_line":"haproxy_proto: \"http\""},{"line_number":39,"context_line":"influxdb_proto: \"http\""},{"line_number":40,"context_line":"rabbitmq_proto: \"http\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_63b27e96","side":"PARENT","line":37,"in_reply_to":"bf51134e_14049e7a","updated":"2020-06-19 17:38:43.000000000","message":"Done","commit_id":"b74f3c879d7718d3039804b254c7a6a93dd02d38"}]}