)]}'
{"ansible/roles/cloudkitty/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dc22f1cca564837a6dd815c6c897ccb3d12cca17","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - cloudkitty_policy.results"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Check if custom custom_metrics.yml exists"},{"line_number":33,"context_line":"  local_action: stat path\u003d\"{{ node_custom_config }}/cloudkitty/custom_metrics.yml\""},{"line_number":34,"context_line":"  register: cloudkitty_custom_metrics_file"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Copying custom_metrics.yml if it exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_89d35560","line":33,"range":{"start_line":33,"start_character":63,"end_line":33,"end_character":77},"updated":"2019-05-13 17:55:08.000000000","message":"Why call it custom_metrics.yml? Why not just metrics.yml, given that we\u0027re replacing the existing metrics.yml by setting metrics_conf (I assume).","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"8a61cb463015c729236732c5f067b903e95aa6fc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - cloudkitty_policy.results"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Check if custom custom_metrics.yml exists"},{"line_number":33,"context_line":"  local_action: stat path\u003d\"{{ node_custom_config }}/cloudkitty/custom_metrics.yml\""},{"line_number":34,"context_line":"  register: cloudkitty_custom_metrics_file"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Copying custom_metrics.yml if it exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_a43760ff","line":33,"range":{"start_line":33,"start_character":63,"end_line":33,"end_character":77},"in_reply_to":"dfbec78f_89d35560","updated":"2019-05-13 19:59:16.000000000","message":"I normally prefer to leave the default file when I have the option to use a custom one. That is why I am not overwriting the default file there. Instead, I am introducing a custom file, and then using the variable in Cloudkitty that allows me to use a custom metric yaml file.\n\nDo you prefer/\"want me\" to overwrite the default file?","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"294244d1c359e44c7a14937db82241d5b9b7e1fc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - cloudkitty_policy.results"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Check if custom custom_metrics.yml exists"},{"line_number":33,"context_line":"  local_action: stat path\u003d\"{{ node_custom_config }}/cloudkitty/custom_metrics.yml\""},{"line_number":34,"context_line":"  register: cloudkitty_custom_metrics_file"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Copying custom_metrics.yml if it exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_062c26aa","line":33,"range":{"start_line":33,"start_character":63,"end_line":33,"end_character":77},"in_reply_to":"dfbec78f_a43760ff","updated":"2019-05-14 11:39:35.000000000","message":"I don\u0027t feel that strongly about it :)","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dc22f1cca564837a6dd815c6c897ccb3d12cca17","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  copy:"},{"line_number":38,"context_line":"    src: \"{{ node_custom_config }}/cloudkitty/custom_metrics.yml\""},{"line_number":39,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/custom_metrics.yml\""},{"line_number":40,"context_line":"    force: True"},{"line_number":41,"context_line":"    mode: \"0600\""},{"line_number":42,"context_line":"  become: true"},{"line_number":43,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_2996e994","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":15},"updated":"2019-05-13 17:55:08.000000000","message":"nit: this is the default","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"8a61cb463015c729236732c5f067b903e95aa6fc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  copy:"},{"line_number":38,"context_line":"    src: \"{{ node_custom_config }}/cloudkitty/custom_metrics.yml\""},{"line_number":39,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/custom_metrics.yml\""},{"line_number":40,"context_line":"    force: True"},{"line_number":41,"context_line":"    mode: \"0600\""},{"line_number":42,"context_line":"  become: true"},{"line_number":43,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_4f0b1d7c","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":15},"in_reply_to":"dfbec78f_2996e994","updated":"2019-05-13 19:59:16.000000000","message":"I was just being verbose :P\nI removed it then.","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dc22f1cca564837a6dd815c6c897ccb3d12cca17","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    src: \"{{ node_custom_config }}/cloudkitty/custom_metrics.yml\""},{"line_number":39,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/custom_metrics.yml\""},{"line_number":40,"context_line":"    force: True"},{"line_number":41,"context_line":"    mode: \"0600\""},{"line_number":42,"context_line":"  become: true"},{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - cloudkitty_custom_metrics_file is defined and cloudkitty_custom_metrics_file.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_c98e2d78","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":15},"updated":"2019-05-13 17:55:08.000000000","message":"0660","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"8a61cb463015c729236732c5f067b903e95aa6fc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    src: \"{{ node_custom_config }}/cloudkitty/custom_metrics.yml\""},{"line_number":39,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/custom_metrics.yml\""},{"line_number":40,"context_line":"    force: True"},{"line_number":41,"context_line":"    mode: \"0600\""},{"line_number":42,"context_line":"  become: true"},{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - cloudkitty_custom_metrics_file is defined and cloudkitty_custom_metrics_file.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_0f29a5e4","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":15},"in_reply_to":"dfbec78f_c98e2d78","updated":"2019-05-13 19:59:16.000000000","message":"fixed","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dc22f1cca564837a6dd815c6c897ccb3d12cca17","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    mode: \"0600\""},{"line_number":42,"context_line":"  become: true"},{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - cloudkitty_custom_metrics_file is defined and cloudkitty_custom_metrics_file.stat.exists"},{"line_number":45,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":46,"context_line":"    - item.value.enabled | bool"},{"line_number":47,"context_line":"  with_dict: \"{{ cloudkitty_services }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_69806147","line":44,"range":{"start_line":44,"start_character":6,"end_line":44,"end_character":47},"updated":"2019-05-13 17:55:08.000000000","message":"This should always be true","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"8a61cb463015c729236732c5f067b903e95aa6fc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    mode: \"0600\""},{"line_number":42,"context_line":"  become: true"},{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - cloudkitty_custom_metrics_file is defined and cloudkitty_custom_metrics_file.stat.exists"},{"line_number":45,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":46,"context_line":"    - item.value.enabled | bool"},{"line_number":47,"context_line":"  with_dict: \"{{ cloudkitty_services }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_ef1bf1c6","line":44,"range":{"start_line":44,"start_character":6,"end_line":44,"end_character":47},"in_reply_to":"dfbec78f_69806147","updated":"2019-05-13 19:59:16.000000000","message":"I was being verbose. Sorry for that, I have this habit ;)","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dc22f1cca564837a6dd815c6c897ccb3d12cca17","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Are we using custom_metrics.yml?"},{"line_number":52,"context_line":"  set_fact:"},{"line_number":53,"context_line":"    cloudkitty_custom_metrics_used: \"{{ cloudkitty_custom_metrics_file is defined and cloudkitty_custom_metrics_file.stat.exists }}\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Copying over config.json files for services"},{"line_number":56,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_e9b21149","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":81},"updated":"2019-05-13 17:55:08.000000000","message":"This should always be true.","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"8a61cb463015c729236732c5f067b903e95aa6fc","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Are we using custom_metrics.yml?"},{"line_number":52,"context_line":"  set_fact:"},{"line_number":53,"context_line":"    cloudkitty_custom_metrics_used: \"{{ cloudkitty_custom_metrics_file is defined and cloudkitty_custom_metrics_file.stat.exists }}\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Copying over config.json files for services"},{"line_number":56,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_af7f39de","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":81},"in_reply_to":"dfbec78f_e9b21149","updated":"2019-05-13 19:59:16.000000000","message":"Fixed","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"}],"ansible/roles/cloudkitty/templates/cloudkitty-api.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dc22f1cca564837a6dd815c6c897ccb3d12cca17","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \"dest\": \"/etc/cloudkitty/{{ cloudkitty_policy_file }}\","},{"line_number":21,"context_line":"            \"owner\": \"cloudkitty\","},{"line_number":22,"context_line":"            \"perm\": \"0600\""},{"line_number":23,"context_line":"        }{% endif %}{% if cloudkitty_custom_metrics_used is defined and cloudkitty_custom_metrics_used %},"},{"line_number":24,"context_line":"        {"},{"line_number":25,"context_line":"            \"source\": \"{{ container_config_directory }}/custom_metrics.yml\","},{"line_number":26,"context_line":"            \"dest\": \"/etc/cloudkitty/custom_metrics.yml\","}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dfbec78f_a9ef391c","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":67},"updated":"2019-05-13 17:55:08.000000000","message":"This should always be true.","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"8a61cb463015c729236732c5f067b903e95aa6fc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \"dest\": \"/etc/cloudkitty/{{ cloudkitty_policy_file }}\","},{"line_number":21,"context_line":"            \"owner\": \"cloudkitty\","},{"line_number":22,"context_line":"            \"perm\": \"0600\""},{"line_number":23,"context_line":"        }{% endif %}{% if cloudkitty_custom_metrics_used is defined and cloudkitty_custom_metrics_used %},"},{"line_number":24,"context_line":"        {"},{"line_number":25,"context_line":"            \"source\": \"{{ container_config_directory }}/custom_metrics.yml\","},{"line_number":26,"context_line":"            \"dest\": \"/etc/cloudkitty/custom_metrics.yml\","}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dfbec78f_ef70d10a","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":67},"in_reply_to":"dfbec78f_a9ef391c","updated":"2019-05-13 19:59:16.000000000","message":"Fixed","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"}],"ansible/roles/cloudkitty/templates/cloudkitty.conf.j2":[{"author":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"change_message_id":"bdba66962fa82937b0367b3c9345209fd0cb9f85","unresolved":false,"context_lines":[{"line_number":40,"context_line":"collector \u003d {{ cloudkitty_collector_backend }}"},{"line_number":41,"context_line":"services \u003d compute,image{% if enable_cinder | bool %},volume{% endif %},network.bw.out,network.bw.in,network.floating"},{"line_number":42,"context_line":"{% if cloudkitty_custom_metrics_used is defined and cloudkitty_custom_metrics_used %}"},{"line_number":43,"context_line":"metrics_conf \u003d /etc/cloudkitty/custom_metrics.yml"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[keystone_fetcher]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dfbec78f_7277e5a1","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":49},"updated":"2019-05-14 04:08:48.000000000","message":"I don\u0027t think we need a separated custom_metrics in container. If someone makes sure I need to use a custom_metrics, why do we need to preserve the original metrics.yml?\n\nalso, if we want to rollback the configurations, just set the cloudkitty_metrics_file_path empty and it will automatically revert to the original!","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e3ef354784d434cb1e4a80c14c880a31457e8160","unresolved":false,"context_lines":[{"line_number":40,"context_line":"collector \u003d {{ cloudkitty_collector_backend }}"},{"line_number":41,"context_line":"services \u003d compute,image{% if enable_cinder | bool %},volume{% endif %},network.bw.out,network.bw.in,network.floating"},{"line_number":42,"context_line":"{% if cloudkitty_custom_metrics_used is defined and cloudkitty_custom_metrics_used %}"},{"line_number":43,"context_line":"metrics_conf \u003d /etc/cloudkitty/custom_metrics.yml"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[keystone_fetcher]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dfbec78f_064666c1","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":49},"in_reply_to":"dfbec78f_7277e5a1","updated":"2019-05-14 11:25:34.000000000","message":"I see your point. But in case of rolling back the configs, I have to restart the container to troubleshoot, which I normally prefer to avoid. To satisfy everybody, what if I externalize this file name to a variable? And then, I can use the default as `metrics.yml`. What do you think?","commit_id":"592a958ca9a6e6e17669d722da9f9a357316309a"}]}