)]}'
{"ansible/roles/nova/tasks/discover_computes.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dbc7ebc0ece689fc7e74056875163e29b022fbbe","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - nova_compute_services is success"},{"line_number":24,"context_line":"    - nova_compute_services.stdout | from_json | length !\u003d 0"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# TODO(yoctozepto): no need to do --by-service if ironic not used"},{"line_number":27,"context_line":"- name: Discover nova hosts"},{"line_number":28,"context_line":"  become: true"},{"line_number":29,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_b98ddd32","line":26,"updated":"2019-06-17 18:13:50.000000000","message":"Does it cause a problem?","commit_id":"ce680bcfe2208f19a23630ee3feff4b9bd40c595"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c758192a7e5b9b2aa47121d3ad2c599e141d1346","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - nova_compute_services is success"},{"line_number":24,"context_line":"    - nova_compute_services.stdout | from_json | length !\u003d 0"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# TODO(yoctozepto): no need to do --by-service if ironic not used"},{"line_number":27,"context_line":"- name: Discover nova hosts"},{"line_number":28,"context_line":"  become: true"},{"line_number":29,"context_line":"  command: \u003e"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_f9eef5b2","line":26,"in_reply_to":"9fb8cfa7_b98ddd32","updated":"2019-06-17 18:20:09.000000000","message":"It\u0027s not recommended if not required due to being less efficient than normal, see https://docs.openstack.org/nova/stein/cli/nova-manage.html\nThough I never experienced the slowness myself with my humble setup. ;-)","commit_id":"ce680bcfe2208f19a23630ee3feff4b9bd40c595"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dbc7ebc0ece689fc7e74056875163e29b022fbbe","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# NOTE(yoctozepto): SIGHUP is probably unnecessary"},{"line_number":36,"context_line":"- name: Refresh cell cache in nova scheduler"},{"line_number":37,"context_line":"  become: true"},{"line_number":38,"context_line":"  command: docker kill --signal HUP nova_scheduler"},{"line_number":39,"context_line":"  changed_when: False"},{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - inventory_hostname in groups[\u0027nova-scheduler\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_999fb964","line":38,"updated":"2019-06-17 18:13:50.000000000","message":"Interesting, this is actually broken: https://bugs.launchpad.net/oslo.service/+bug/1715374. And our fix in review: https://review.opendev.org/665660","commit_id":"ce680bcfe2208f19a23630ee3feff4b9bd40c595"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c758192a7e5b9b2aa47121d3ad2c599e141d1346","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# NOTE(yoctozepto): SIGHUP is probably unnecessary"},{"line_number":36,"context_line":"- name: Refresh cell cache in nova scheduler"},{"line_number":37,"context_line":"  become: true"},{"line_number":38,"context_line":"  command: docker kill --signal HUP nova_scheduler"},{"line_number":39,"context_line":"  changed_when: False"},{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - inventory_hostname in groups[\u0027nova-scheduler\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_d94691c1","line":38,"in_reply_to":"9fb8cfa7_999fb964","updated":"2019-06-17 18:20:09.000000000","message":"Yup, though this is not upgrade. There is (IMHO) no reason to HUP or restart the services after discovering the hosts (in the normal case).","commit_id":"ce680bcfe2208f19a23630ee3feff4b9bd40c595"}]}